December 2023 - Wine-GitLab

[PATCH v3 0/1] MR4566: ntdll/unix: Add an option to inherit the Unix console handle.
by Aida Jonikienė Dec. 8, 2023

Dec. 8, 2023

I know this breaks Windows behavior but having apps print out special debug messages to the terminal provides a good look into the applications' development (for example I know that NFS Underground has some "done" messages likely used for debugging). I also don't want to keep another revert in my Wine tree just for this one feature either so that's why I'm MR'ing this. I considered adding a registry/winecfg entry for this behavior but it would make this change much larger (and there's no good place in winecfg to put this behavior in). To enable this behavior, you can set WINEDEBUG=+unixcon variable before launching an application. Xkcd-Entry: https://xkcd.com/1172/ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55435 -- v3: ntdll/unix: Add an option to inherit the Unix console handle. https://gitlab.winehq.org/wine/wine/-/merge_requests/4566

1 3

[PATCH v3 0/15] MR895: msxml3/tests: Filter attributes tests by version.
by Daniel Lehman (＠dlehman25) Dec. 8, 2023

Dec. 8, 2023

Based on patch from Damjan Jovanovic <damjan.jov(a)gmail.com> https://bugs.winehq.org/show_bug.cgi?id=53531 -- v3: msxml3: Handle default namespace in get_namespaceURI. msxml3: Handle default namespace in get_prefix. msxml3: Handle default namespace in get_nodeName. msxml3: Handle default namespace in get_baseName. msxml3: Handle null prefix in get_item. msxml6/tests: Add tests for default namespace. msxml4/tests: Add tests for default namespace. msxml3/tests: Add tests for default namespace. msxml6/tests: Copy create namespace tests. msxml4/tests: Copy create namespace tests. msxml6/tests: Copy namespaces as attributes tests. msxml4/tests: Copy namespaces as attributes tests. msmxl3/tests: Add tests for get_xml. msxml3/tests: Remove msxml6 tests. msxml3/tests: Fix failure messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/895

2 18

[PATCH 0/7] MR4637: bcrypt DH improvements
by Hans Leidekker (＠hans) Dec. 8, 2023

Dec. 8, 2023

Support for generating keys from known DH parameters is not included unfortunately because even the latest stable GnuTLS release doesn't have the necessary support. I have a patch that implements it using _gnutls_dh_generate_key() but that requires a special GnuTLS 3.8.2 build (--enable-fips140-mode). With that patch all included tests pass here. Paul, can you take a look? I included your tests so please approve this MR if you think it's okay. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4637

3 14

Re: [PATCH v4 0/1] MR4393: gdiplus: Boost performance of GdipDrawImagePointsRect.
by Fabian Maurer (＠DarkShadow44) Dec. 8, 2023

Dec. 8, 2023

Now that https://gitlab.winehq.org/wine/wine/-/commit/4b458775bb8c9492ac859cfd167c5f… is merged, is this still needed? IMHO this MR doesn't add any more performance now that the stack issue is solved. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4393#note_55509

1 0

[PATCH v3 0/13] MR490: Draft: vkd3d-shader: Int64 support.
by Conor McCarthy (＠cmccarthy) Dec. 8, 2023

Dec. 8, 2023

Goes atop !489. The last 7 commits belong to this MR. Many of these patches are small, but the series can be split further if necessary. -- v3: vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction(). vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast(). vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div(). vkd3d-shader/spirv: Introduce a UINT64 component type. vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function. vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg(). vkd3d: Pass int64 capability info to vkd3d-shader. vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce an 'int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490

2 13

[PATCH v6 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 8, 2023

Dec. 8, 2023

-- v6: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

2 6

[PATCH v5 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 8, 2023

Dec. 8, 2023

This is ready for review, but may not go upstream until after the release. -- v5: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader/dxil: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

2 6

Re: [PATCH 0/15] MR4650: Translation - closed
by joan-lucì Labòrda Dec. 7, 2023

Dec. 7, 2023

This merge request was closed by joan-lucì Labòrda. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4650

1 0

Re: [PATCH 0/15] MR4650: Translation
by joan-lucì Labòrda Dec. 7, 2023

Dec. 7, 2023

Update oc.po -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4650#note_55498

1 0

[PATCH 0/2] MR4649: user32/tests: Add tests for word breaks before punctuation
by Brendan McGrath (＠redmcg) Dec. 7, 2023

Dec. 7, 2023

Whilst uniscribe won't break on the space here (see LB13 of the Unicode line breaking algorith), DrawText does -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4649

2 2

[PATCH 0/1] MR4648: po: Update Lithuanian translation.
by Aurimas Fišeras Dec. 7, 2023

Dec. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4648

2 2

[PATCH v3 0/4] MR4645: quartz: Partially implement the VMR7 presenter.
by Zebediah Figura (＠zfigura) Dec. 7, 2023

Dec. 7, 2023

-- v3: quartz: Implement sample allocation in the VMR7 presenter. https://gitlab.winehq.org/wine/wine/-/merge_requests/4645

3 6

[PATCH 0/1] MR4646: kernel32: Export RtlIsEcCode().
by Billy Laws (＠bylaws) Dec. 7, 2023

Dec. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4646

3 2

Re: [PATCH v4 0/1] MR4577: user32: remove unneeded spec entry - closed
by Vijay Kiran Kamuju (＠infyquest) Dec. 7, 2023

Dec. 7, 2023

This merge request was closed by Vijay Kiran Kamuju. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4577

1 0

Re: [PATCH v3 0/3] MR4609: winegstreamer: Some tiny fixes - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4609

1 0

Re: [PATCH v2 0/1] MR4600: winegstreamer: Set streamheader field for h264 caps. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4600

1 0

Re: [PATCH v4 0/4] MR4645: quartz: Partially implement the VMR7 presenter. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4645

1 0

Re: [PATCH v2 0/1] MR4646: kernel32: Export RtlIsEcCode(). - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4646

1 0

Re: [PATCH v4 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

1 0

Re: [PATCH v4 0/1] MR4618: dsound: Set position past the end of the buffer is invalid. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4618

1 0

Re: [PATCH v2 0/1] MR4644: winedump: Sync demangling code with msvcrt. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4644

1 0

Re: [PATCH v5 0/1] MR4615: vbscript: For for loop coerce right bound string to real. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4615

1 0

Re: [PATCH v2 0/1] MR4632: winecoreaudio: Use UID as device string. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4632

1 0

Re: [PATCH v3 0/3] MR4639: wineps: Pattern brush improvements - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4639

1 0

Re: [PATCH v6 0/5] MR4593: winewayland.drv: part 11: Mouselook support - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

1 0

Re: [PATCH v2 0/1] MR4631: msxml3: Handle default namespace in get_namespaceURI. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4631

1 0

Re: [PATCH v5 0/2] MR4629: user32: Correct capitalization of SetDeskWallpaper. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4629

1 0

Re: [PATCH v4 0/1] MR4300: net: Accept yes/no switches - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4300

1 0

Re: [PATCH v3 0/1] MR4562: dwmapi: Implement DwmGetWindowAttribute(DWMWA_EXTENDED_FRAME_BOUNDS). - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4562

1 0

Re: [PATCH v3 0/1] MR4030: configure: Use -mpreferred-stack-boundary=2 on i386. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4030

1 0

Re: [PATCH v4 0/5] MR4619: mshtml: EventObj improvements. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4619

1 0

Re: [PATCH v2 0/1] MR4627: ntdll: Remove unused valgrind_make_readable function. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4627

1 0

Re: [PATCH v2 0/1] MR515: vkd3d-shader/ir: Pass a local copy of location to control_point_normaliser_emit_hs_input(). - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/515

1 0

Re: [PATCH v2 0/4] MR507: Various tests for creating identical objects - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/507

1 0

Re: [PATCH v2 0/8] MR506: configure: Enable -Wshadow. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/506

1 0

Re: [PATCH v2 0/1] MR501: vkd3d-shader/dxil: Set the result register data type for nop casts. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/501

1 0

Re: [PATCH v8 0/2] MR497: vkd3d-shader/dxil: Implement DX intrinsic Unary. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/497

1 0

Re: [PATCH v7 0/6] MR477: vkd3d-shader: Finish global variable and GEP support. - approved
by Alexandre Julliard (＠julliard) Dec. 7, 2023

Dec. 7, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/477

1 0

[PATCH 0/8] MR4647: (WIP) Win32u SNI systray internal
by Cherser-s (＠Cherser-s) Dec. 7, 2023

Dec. 7, 2023

Doesn't add new driver interface enums for tray management. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4647

2 9

[PATCH 0/4] MR4645: quartz: Partially implement the VMR7 presenter.
by Zebediah Figura (＠zfigura) Dec. 7, 2023

Dec. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4645

3 5

[PATCH v2 0/3] MR4609: winegstreamer: Some tiny fixes
by Alfred Agrell (＠Alcaro) Dec. 7, 2023

Dec. 7, 2023

Just some tiny fixes I found while creating !4449. No functional changes intended. Wine's code review process, and commit history, is a lot more comprehensive than anything else I've seen. This means I can't just write code, submit patch, and call it a day; but it also means the codebase is clean and easy to work with, so fixing bugs and missing pieces is relatively straightforward. While this does increase the total time needed on my side (especially splitting commits), it's easy (though somewhat boring) work, so in total, it's a win. And splitting makes it easier for the maintainers - you have more to do than me, so if it saves your time at the expense of mine, I have no right to complain. Thank you for your patience with my prior MRs. 8.2/10 would contribute again (I've seen a few other games with broken videos that I suspect have still-unfixed causes) -- v2: winegstreamer: Delete duplicate WMT_ON check. winegstreamer: Fix a memory leak in stream_props_GetMediaType. https://gitlab.winehq.org/wine/wine/-/merge_requests/4609

3 5

[PATCH 0/1] MR4600: winegstreamer: Set streamheader field for h264 caps.
by Ziqing Hui (＠zhui) Dec. 7, 2023

Dec. 7, 2023

For h264 byte-stream format, we should set "streamheader". "codec_data" is for avc. We also set timestamp of the buffer to 0 because mp4mux will be error if the PTS is none. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4600

4 8

[PATCH v3 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272.
by Georg Lehmann (＠DadSchoorse) Dec. 7, 2023

Dec. 7, 2023

-- v3: winevulkan: Update to VK spec version 1.3.272. https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

3 3

[PATCH 0/5] MR4624: wined3d: More old-GL fixes.
by Matteo Bruni (＠Mystral) Dec. 7, 2023

Dec. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4624

4 12

[PATCH v3 0/1] MR4618: dsound: Set position past the end of the buffer is invalid.
by Yuxuan Shui (＠yshui) Dec. 7, 2023

Dec. 7, 2023

-- v3: dsound: Set position past the end of the buffer is invalid. https://gitlab.winehq.org/wine/wine/-/merge_requests/4618

3 2

[PATCH v2 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272.
by Georg Lehmann (＠DadSchoorse) Dec. 7, 2023

Dec. 7, 2023

-- v2: winevulkan: Update to VK spec version 1.3.272. https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

3 3

[PATCH 0/1] MR4643: winevulkan: Update to VK spec version 1.3.272.
by Georg Lehmann (＠DadSchoorse) Dec. 7, 2023

Dec. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4643

3 3

[PATCH 0/1] MR4644: winedump: Sync demangling code with msvcrt.
by Piotr Caban (＠piotr) Dec. 7, 2023

Dec. 7, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4644

2 1

[PATCH 0/1] MR515: vkd3d-shader/ir: Pass a local copy of location to control_point_normaliser_emit_hs_input().
by Conor McCarthy (＠cmccarthy) Dec. 7, 2023

Dec. 7, 2023

Fixes invalid reads in valgrind. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/515

3 2

[PATCH 0/4] MR507: Various tests for creating identical objects
by Stefan Dösinger Dec. 7, 2023

Dec. 7, 2023

These tests are a side product of my shader cache work. We don't need them right now, but we want them as documentation at some point. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/507

2 5