December 2023 - Wine-GitLab

Re: [PATCH v2 0/4] MR4591: amstream, winegstreamer: Quality control improvements. - approved
by Alexandre Julliard (＠julliard) Dec. 5, 2023

Dec. 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4591

1 0

Re: [PATCH v3 0/2] MR4592: mscoree: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) Dec. 5, 2023

Dec. 5, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4592

1 0

[PATCH v2 0/4] MR4587: kernelbase: Implement flag validation in `LoadLibraryEx()` to work like in Win10
by Dāvis Mosāns Dec. 5, 2023

Dec. 5, 2023

While debugging League of Legends I noticed that `LoadLibraryEx()` is invoked with binary filename (non-text) and non-NULL `hFile`. In Windows such call would return `NULL` with LastError set as `ERROR_INVALID_PARAMETER` but current Wine implementation would try to proceed ahead. I don't know if this is intentional trick to mess up debugging/reversing tools or if we have some memory corruption before that overwrites filename buffer. But then I can't imagine how `hFile` could have gotten corrupted since shouldn't that be simple static value in register... Having this MR causes very noticeable difference in LoL: * without it - process deadlocks * with it - no deadlock Also while looking at this, I tried a lot of different flag combinations on Windows 10 and here I implemented so it works exactly like that. I also implemented test case for non-NULL `hFile` but I didn't bother for other flags since I don't know if we even care about those. -- v2: kernelbase: LoadLibraryEx validate flags like Win10 kernelbase: LoadLibraryEx support LOAD_PACKAGED_LIBRARY kernelbase: LoadLibraryEx enforce valid flag combinations kernelbase: Add test case for LoadLibraryEx() when hFile is non-NULL https://gitlab.winehq.org/wine/wine/-/merge_requests/4587

3 11

[PATCH v2 0/2] MR4605: ntdll: Use public type for SystemSupportedProcessorArchitectures returned data.
by Nikolay Sivov (＠nsivov) Dec. 5, 2023

Dec. 5, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: ntdll: Use public type for SystemSupportedProcessorArchitectures returned data. include: Add missing enum to wdm.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/4605

2 3

[PATCH v11 0/7] MR4449: winegstreamer: WMReader compressed output
by Alfred Agrell (＠Alcaro) Dec. 5, 2023

Dec. 5, 2023

Along with !4450, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v11: wmvcore/tests: Add tests for compressed output. winegstreamer: Implement compressed output support in WMSyncReader. https://gitlab.winehq.org/wine/wine/-/merge_requests/4449

3 9

[PATCH v10 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) Dec. 5, 2023

Dec. 5, 2023

- Make it present some frames - Make it check that the frames are from the new device, instead of checking TerminateDevice count; fixes https://bugs.winehq.org/show_bug.cgi?id=55649 - ~~Make it check for and avoid some absurd crash on Windows~~ ~~I tried everything I could think of, but Windows absolutely refuses to present a frame after changing the D3D device, instead choosing to return various absurd errors (segfaults, deadlocks, out of memory, etc). I suspect the VMR9 is haunted.~~ edit: Works on Windows now -- v10: quartz/tests: Improve VMR9 ChangeD3DDevice test. https://gitlab.winehq.org/wine/wine/-/merge_requests/3970

3 3

[PATCH v6 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) Dec. 5, 2023

Dec. 5, 2023

Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions This will help some applications not crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Next part will be moving this code to msvcp and to make sure Cin, other related classes are implemented for msvcmxx.dlls -- v6: msvcm80: Add stub for ThrowNestedLoadModuleException function. msvcm80: Add stub for ThrowModuleLoadException(String, Exception) function. msvcm80: Add stub for ThrowModuleLoadException(String) function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4596

3 4

Re: [PATCH v5 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) Dec. 5, 2023

Dec. 5, 2023

On Tue Dec 5 19:35:28 2023 +0000, Piotr Caban wrote: > This generally looks good for me. How about changing > `CrtImplementationDetails_ThrowModuleLoadException_Inner` function name? > I'm not familiar with the function so it's hard to suggest a better name > (maybe `CrtImplementationDetails_ThrowModuleLoadException_inner` or > `CrtImplementationDetails_ThrowModuleLoadException_exc`). In other > functions we're using lowercase suffix if needed. > This MR is marked as draft. Please mark it as ready when appropriate. I will rename to CrtImplementationDetails_ThrowModuleLoadException_inner and What I found that from extensive searching on google and the error messages is that the it trys to rethrow the inner exception as ModuleLoadException. eg: https://forum.unity.com/threads/c-wrapper-for-unity.265398/ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4596#note_55104

1 0

Re: [PATCH v5 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Piotr Caban (＠piotr) Dec. 5, 2023

Dec. 5, 2023

This generally looks good for me. How about changing `CrtImplementationDetails_ThrowModuleLoadException_Inner` function name? I'm not familiar with the function so it's hard to suggest a better name (maybe `CrtImplementationDetails_ThrowModuleLoadException_inner` or `CrtImplementationDetails_ThrowModuleLoadException_exc`). In other functions we're using lowercase suffix if needed. This MR is marked as draft. Please mark it as ready when appropriate. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4596#note_55103

1 0

[PATCH 0/2] MR4608: msvcrt: Demangler C++/CLI related improvements
by Piotr Caban (＠piotr) Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4608

2 2

[PATCH 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) Dec. 5, 2023

Dec. 5, 2023

This MR implements mouselook, which requires support for ClipCursor and relative motion events. The latter we can implement directly without using `SetCursorPos` for which no Wayland protocol exists at the moment. 1. Implement setting the foreground window, as this is required for clipping to work properly (i.e., for the ClipCursor driver callback to be called in the proper process/thread, see commit (2)). We can't unconditionally set the foreground window on keyboard focus, since compositors are eager to give the focus and some windows strongly dislike that (see https://gitlab.winehq.org/wine/wine/-/merge_requests/4102#note_51733) This MR borrows the "managed" window concept from WineX11 to detect windows that we shouldn't allow the compositor to manage, and avoids setting such windows as the foreground on keyboard focus. 2. Implement cursor clipping using the pointer-constraints protocol. 3. Switch to emitting relative motion events using the relative-pointer protocol when the cursor is not visible. --- 4. Finally, a potential fix for an issue I have been seeing where apps may transiently lose the active status (see commit message for more) as a result of the foreground state changes in this MR, which has undesirable side-effects. I have included this here for MR completeness/correctness, but it can be moved to a subsequent MR if preferred. Note: the velocity of relative motion events when scaling is involved is somewhat inconsistent among Wayland compositors. Thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

8 33

[PATCH 0/1] MR4607: apisetschema: Add api-ms-win-core-com-l2-1-1
by Fabian Maurer (＠DarkShadow44) Dec. 5, 2023

Dec. 5, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55075 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4607

2 1

[PATCH v6 0/7] MR3106: Draft: apisetschema: Add api-ms-win-core-com-l2-1-1
by Fabian Maurer (＠DarkShadow44) Dec. 5, 2023

Dec. 5, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55075 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v6: apisetschema: Add api-ms-win-core-com-l2-1-1 https://gitlab.winehq.org/wine/wine/-/merge_requests/3106

3 9

[PATCH 0/10] MR4604: mshtml: Get rid of outer_window member in HTMLDocumentNode.
by Gabriel Ivăncescu Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4604

2 13

[PATCH 0/1] MR4605: ntdll: Use public type for SystemSupportedProcessorArchitectures returned data.
by Nikolay Sivov (＠nsivov) Dec. 5, 2023

Dec. 5, 2023

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4605

3 2

[PATCH v4 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4572 When there's driver wrappers the handles are always unwrapped to driver handles, including for functions which don't have a driver entry point. This fixes that and unwrap to host / driver depending on the functions. Extension chains are still always unwrapped to host handles for now. I have pushed some sample change to wrap swapchain handles in https://gitlab.winehq.org/rbernon/wine/-/commit/3181c3adbb3abd5967e947dfd42… and https://gitlab.winehq.org/rbernon/wine/-/commit/00220d8b80d0d39ce003232f47a…, without the last change in this MR they would look like https://gitlab.winehq.org/rbernon/wine/-/commit/470b67c514028983b23d3118377… and https://gitlab.winehq.org/rbernon/wine/-/commit/122980f2b04a60661533599b513… respectively. -- v4: winevulkan: Unwrap to driver or host depending on the function. winevulkan: Use an enumeration for make_vulkan unwrapping kinds. winevulkan: Introduce a new convert_suffix make_vulkan helper. winevulkan: Remove redundant make_vulkan needs_unwrapping method. winevulkan: Use a dictionary for user driver entry points. winevulkan: Use a dictionary in make_vulkan for manual unix thunks. winevulkan: Replace "loader_thunk" with dedicated dictionaries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4602

2 9

[PATCH v3 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4572 When there's driver wrappers the handles are always unwrapped to driver handles, including for functions which don't have a driver entry point. This fixes that and unwrap to host / driver depending on the functions. Extension chains are still always unwrapped to host handles for now. I have pushed some sample change to wrap swapchain handles in https://gitlab.winehq.org/rbernon/wine/-/commit/3181c3adbb3abd5967e947dfd42… and https://gitlab.winehq.org/rbernon/wine/-/commit/00220d8b80d0d39ce003232f47a…, without the last change in this MR they would look like https://gitlab.winehq.org/rbernon/wine/-/commit/470b67c514028983b23d3118377… and https://gitlab.winehq.org/rbernon/wine/-/commit/122980f2b04a60661533599b513… respectively. -- v3: winevulkan: Unwrap to driver or host depending on the function. winevulkan: Use an enumeration for make_vulkan unwrapping kinds. winevulkan: Introduce a new convert_suffix make_vulkan helper. winevulkan: Remove redundant make_vulkan needs_unwrapping method. winevulkan: Use a dictionary for user driver entry points. winevulkan: Use a dictionary in make_vulkan for manual unix thunks. winevulkan: Replace "loader_thunk" with dedicated dictionaries. https://gitlab.winehq.org/wine/wine/-/merge_requests/4602

2 10

[PATCH v2 0/2] MR4592: mscoree: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 5, 2023

Dec. 5, 2023

-- v2: mscoree: Annotate WtoA with __WINE_(DEALLOC|MALLOC). mscoree: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4592

4 5

[PATCH v12 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Vijay Kiran Kamuju (＠infyquest) Dec. 5, 2023

Dec. 5, 2023

Add the stub function D3DXComputeTangent based on the staging patch. https://bugs.winehq.org/show_bug.cgi?id=41697 Since this will at least make the application go further. Even though the implementation is based on documentation https://learn.microsoft.com/en-us/windows/win32/direct3d9/d3dxcomputetangent -- v12: d3dx9: Stub D3DXComputeTangent https://gitlab.winehq.org/wine/wine/-/merge_requests/2795

3 4

Re: [PATCH v2 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Jacek Caban (＠jacek) Dec. 5, 2023

Dec. 5, 2023

Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan: > for e in self.struct_extensions: > if not e.required: > continue > - conversions.extend(e.get_conversions(True, parent_const)) > + # FIXME: This should follow the caller unwrapping instead of always unwrapping to host handles Let's leave the comment out. I'm not saying no, but let's not make it sound like it's decided. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55078

1 0

Re: [PATCH v2 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Jacek Caban (＠jacek) Dec. 5, 2023

Dec. 5, 2023

Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan: > > return self.host_handle(name) > > - def is_wrapped(self): > - return self.host_handle("test") is not None > + def is_wrapped(self, unwrap): `unwrap` argument seems redundant to me. Do you expect that there will be a case where driver handle will be wrapped, but not host handle (nor the other way around). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55077

1 0

[PATCH v2 0/13] MR490: Draft: vkd3d-shader: Int64 support.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

Goes atop !489. The last 8 commits belong to this MR. Many of these patches are small, but the series can be split further if necessary. -- v2: vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction(). vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast(). vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div(). vkd3d-shader/spirv: Introduce a UINT64 component type. vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function. vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg(). vkd3d: Pass int64 capability info to vkd3d-shader. vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader/dxil: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490

2 13

[PATCH v4 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

This is ready for review, but may not go upstream until after the release. -- v4: vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

2 6

[PATCH 0/1] MR4603: ntdll: Set main_(argc|argv|envp) as early as possible.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Fixes: 62a979347a4dc1bd68f79b86397de85c016ec588 There are some debug traces before init_environment, and calling init_options before main_argv is set will try to dereference a NULL pointer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4603

1 1

[PATCH 0/2] MR4597: d3d1*/tests: Mark a test as no longer todo.
by Zebediah Figura (＠zfigura) Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4597

3 3

[PATCH v3 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

This is ready for review, but may not go upstream until after the release. -- v3: vkd3d-shader/spirv: Add a parameter name for int64 capability. tests/shader-runner: Add 64-bit bitwise tests. tests/shader-runner: Add 64-bit arithmetic tests. tests/shader-runner: Introduce a 'shader int64' requirement directive. vkd3d-shader/spirv: Emit an error if 64-bit integers are used. vkd3d-shader/dxil: Introduce an instruction flag to suppress masking of bitwise shift counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

4 10

[PATCH 0/1] MR4595: dxgi: Avoid redundantly setting the present info wait semaphore fields in d3d12_swapchain_queue_present().
by Henri Verbeet (＠hverbeet) Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4595

4 3

[PATCH 0/1] MR4594: dxgi/tests: Release the swapchain after waiting for the window thread to finish in test_resize_target_wndproc().
by Henri Verbeet (＠hverbeet) Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4594

4 3

[PATCH v2 0/6] MR4573: More CreateProcess work.
by eric pouech (＠epo) Dec. 5, 2023

Dec. 5, 2023

This series mainly: - tests and implement fixes for GetStartupInfoW: + it should transform PEB's RTL_USER_PROCESS_PARAMETERS on the fly (instead of caching the results as GetStartupInfoA) + it doesn't set all the fields of returned in STARTUPINFOW (unlike GetStartupInfoA) - no longer allow console and console handles for non CUI apps: + forbid inheritance of console handles for non CUI apps + don't create a unix console for initial (non CUI) app -- v2: ntdll,start: Don't create Unix console for GUI apps. ntdll: Don't inherit std console handles for non CUI child process. kernelbase: GetStartupInfoW: set std handle only when USESTDHANDLES is set. kernelbase: No longer cache GetStartupInfoW() results. kernel32/tests: Add tests for GetStartupInfo(A|W). kernel32/tests: Identify untouched fields returned from GetStartupInfo. https://gitlab.winehq.org/wine/wine/-/merge_requests/4573

3 9

[PATCH 0/1] MR4599: msxml3: Handle default namespace in get_nodeName.
by Daniel Lehman (＠dlehman25) Dec. 5, 2023

Dec. 5, 2023

3rd of 5 request to remove the todos i added combined result of remaining requests: https://gitlab.winehq.org/dlehman25/wine/-/tree/msxml-nullpfx-combined -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4599

3 2

Re: [PATCH v2 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

v2: Remove unnecessary direction named parameter change, I initially replaced the unwrap parameter earlier and it was more readable with named parameters but later changed my mind. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55035

1 0

[PATCH 0/7] MR4602: winevulkan: Fix host / driver handle unwrapping.
by Rémi Bernon Dec. 5, 2023

Dec. 5, 2023

Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/4572 When there's driver wrappers the handles are always unwrapped to driver handles, including for functions which don't have a driver entry point. This fixes that and unwrap to host / driver depending on the functions. Extension chains are still always unwrapped to host handles for now. I have pushed some sample change to wrap swapchain handles in https://gitlab.winehq.org/rbernon/wine/-/commit/3181c3adbb3abd5967e947dfd42… and https://gitlab.winehq.org/rbernon/wine/-/commit/00220d8b80d0d39ce003232f47a…, without the last change in this MR they would look like https://gitlab.winehq.org/rbernon/wine/-/commit/470b67c514028983b23d3118377… and https://gitlab.winehq.org/rbernon/wine/-/commit/122980f2b04a60661533599b513… respectively. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4602

1 7

[PATCH 0/4] MR4591: amstream, winegstreamer: Quality control improvements.
by Anton Baskanov (＠baskanov) Dec. 5, 2023

Dec. 5, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4591

5 7

[PATCH v5 0/11] MR498: Draft: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

Goes atop !477. The last two commits belong to this MR. -- v5: tests/shader-runner: Add a non-const-indexing test for asfloat() result storage. vkd3d-shader/spirv: Bitcast if necessary in the spirv_compiler_emit_mov() general implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

2 11

[PATCH v4 0/9] MR498: Draft: vkd3d-shader/dxil: Implement the DXIL ALLOCA and STORE instructions.
by Conor McCarthy (＠cmccarthy) Dec. 5, 2023

Dec. 5, 2023

Goes atop !477. The last two commits belong to this MR. -- v4: vkd3d-shader/dxil: Implement the DXIL STORE instruction. vkd3d-shader/dxil: Implement the DXIL ALLOCA instruction. tests/shader-runner: Test an uninitialised indexable temp. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/498

2 9

Re: [PATCH v9 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) Dec. 5, 2023

Dec. 5, 2023

On Tue Dec 5 01:23:40 2023 +0000, Alfred Agrell wrote: > I don't know what Microsoft's intention is or what's officially > supported, but a quick WINEDEBUG=trace+quartz tells me that Kirikiri > does, in fact, call ChangeD3DDevice while the graph is connected but > stopped. It's the last thing it does before IMediaControl::Run(). > (Kirikiri doesn't pause the graph, it just goes directly to Run.) > Kirikiri's source code also shows that the function is called if > IDirect3DDevice9::Present returns D3DERR_DEVICELOST; Present() is only > plausible while paused or running, though I don't know if that code path > was ever tested. > (Also rebased this thing. No other changes.) Fair enough, I can only assume they avoid the race somehow else then, e.g. by always happening to wait the few ms necessary to ensure the asynchronous reconnect completes. It certainly wouldn't surprise me. In any case I think the best thing we can do for the tests is to not test that case. We want the tests to pass consistently, and experience has taught me that the only way to achieve that is to never rely on Sleep(). The stopped case should be interesting enough by itself anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_55004

1 0

Re: [PATCH v3 0/1] MR4578: include: Add Windows.Storage.Streams.InMemoryRandomAccessStream runtimeclass definition.
by Fabian Maurer (＠DarkShadow44) Dec. 5, 2023

Dec. 5, 2023

On Fri Dec 1 21:45:23 2023 +0000, Vijay Kiran Kamuju wrote: > According the idl its activatable, but I was not sure how to add the > activatable as its in hex > [activatable(0x06020000)] Probably just `activatable(Windows.Foundation.UniversalApiContract, 1.0)`. But I'm pretty sure you need that activatable if you want it to be usable later. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4578#note_54999

1 0

Re: [PATCH v8 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Alfred Agrell (＠Alcaro) Dec. 5, 2023

Dec. 5, 2023

On Tue Dec 5 01:21:52 2023 +0000, Zebediah Figura wrote: > I did some more digging on this one, and here is what my testing suggests: > * native ChangeD3DDevice() *just* reconnects the filter, i.e. it doesn't > directly call any of the same methods. > * This reconnection is done on a separate thread, for some reason. IPin > methods and IVMRSurfaceAllocator::TerminateDevice() are called from that thread. > * The filter graph documentation claims that IFilterGraph::Reconnect() > and IFilterGraph2::ReconnectEx() execute on a separate thread, but > according to my tests this is not true. > * ChangeD3DDevice() can be called while the filter is running, in which > case it will stop the graph, reconnnect, and then run. This is all done > on the same thread. Note that ReconnectEx() *cannot* be called while the > filter is running. > * ChangeD3DDevice() can be called while the filter is not connected. > * InitializeDevice() is not called immediately on connection. Rather, it > seems to be deferred until IMemAllocator::SetProperties(). > VFW_E_NOT_COMMITTED happens because reconnecting evidently decommits the > allocator, and we manage to race exactly such that the pins have been > disconnected but not yet reconnected when trying to send a frame. > As far as I can tell there is no actual way to synchronize this thread. > I suspect that in practice ChangeD3DDevice() is not expected to be > called while connected and stopped. I don't know if it's meant to be > called while disconnected or while running, or both. Either will avoid > this race, although ChangeD3DDevice() while running will definitely run > into other races surrounding state change (e.g. what happens if you > ChangeD3DDevice() and then decide to stop the graph?) > I think the only case we can really reliably test is the stopped case. I don't know what Microsoft's intention is or what's officially supported, but a quick WINEDEBUG=trace+quartz tells me that Kirikiri does, in fact, call ChangeD3DDevice while the graph is connected but stopped. It's the last thing it does before IMediaControl::Run(). (Kirikiri doesn't pause the graph, it just goes directly to Run.) Kirikiri's source code also shows that the function is called if IDirect3DDevice9::Present returns D3DERR_DEVICELOST, which only happens while paused or running, though I don't know if that code path was ever tested. (Also rebased this thing. No other changes.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_54997

1 0

[PATCH v10 0/7] MR4449: winegstreamer: WMReader compressed output
by Alfred Agrell (＠Alcaro) Dec. 5, 2023

Dec. 5, 2023

Along with !4450, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v10: wmvcore/tests: Add tests for compressed output. winegstreamer: Implement compressed output support in WMSyncReader. winegstreamer: Leave pts/duration unchanged if they're not set. winegstreamer: Introduce mutex for wm_reader read_thread_shutdown. winegstreamer: Move file size to struct wm_reader. winegstreamer: Fill in a few more pieces of WMV format handling. winegstreamer: Add codec_data to WMVs. https://gitlab.winehq.org/wine/wine/-/merge_requests/4449

2 7

[PATCH v9 0/7] MR4449: winegstreamer: WMReader compressed output
by Alfred Agrell (＠Alcaro) Dec. 5, 2023

Dec. 5, 2023

Along with !4450, this fixes WMV videos in microkiri (https://bugs.winehq.org/show_bug.cgi?id=9127#c102) and Wagamama High Spec Trial Edition (https://wagahigh.com/download_trial.php#normal ; ダウンロード means download). -- v9: wmvcore/tests: Add tests for compressed output. winegstreamer: Implement compressed output support in WMSyncReader. winegstreamer: Leave pts/duration unchanged if they're not set. winegstreamer: Introduce mutex for wm_reader read_thread_shutdown. winegstreamer: Move file size to struct wm_reader. winegstreamer: Fill in a few more pieces of WMV format handling. winegstreamer: Add codec_data to WMVs. https://gitlab.winehq.org/wine/wine/-/merge_requests/4449

4 18

Re: [PATCH v8 0/1] MR3970: quartz/tests: Improve VMR9 ChangeD3DDevice test
by Zebediah Figura (＠zfigura) Dec. 4, 2023

Dec. 4, 2023

I did some more digging on this one, and here is what my testing suggests: * native ChangeD3DDevice() *just* reconnects the filter, i.e. it doesn't directly call any of the same methods. * This reconnection is done on a separate thread, for some reason. IPin methods and IVMRSurfaceAllocator::TerminateDevice() are called from that thread. * The filter graph documentation claims that IFilterGraph::Reconnect() and IFilterGraph2::ReconnectEx() execute on a separate thread, but according to my tests this is not true. * ChangeD3DDevice() can be called while the filter is running, in which case it will stop the graph, reconnnect, and then run. This is all done on the same thread. Note that ReconnectEx() *cannot* be called while the filter is running. * ChangeD3DDevice() can be called while the filter is not connected. * InitializeDevice() is not called immediately on connection. Rather, it seems to be deferred until IMemAllocator::SetProperties(). VFW_E_NOT_COMMITTED happens because reconnecting evidently decommits the allocator, and we manage to race exactly such that the pins have been disconnected but not yet reconnected when trying to send a frame. As far as I can tell there is no actual way to synchronize this thread. I suspect that in practice ChangeD3DDevice() is not expected to be called while connected and stopped. I don't know if it's meant to be called while disconnected or while running, or both. Either will avoid this race, although ChangeD3DDevice() while running will definitely run into other races surrounding state change (e.g. what happens if you ChangeD3DDevice() and then decide to stop the graph?) I think the only case we can really reliably test is the stopped case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3970#note_54992

1 0

[PATCH 0/1] MR4598: po: Update Lithuanian translation.
by Aurimas Fišeras Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4598

2 2

Re: [PATCH v4 0/2] MR4585: dsdmo: Add stubs for distortion and gargle effects - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4585

1 0

Re: [PATCH v7 0/1] MR4466: win32u/winex11: Add the GPU device physical memory registry - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4466

1 0

Re: [PATCH v2 0/2] MR4467: rpcrt4: Support for explicit handle passing - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4467

1 0

Re: [PATCH v2 0/2] MR4588: winegstreamer: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4588

1 0

Re: [PATCH v3 0/2] MR4304: ole32/tests: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4304

1 0

Re: [PATCH v2 0/1] MR4589: gdiplus: Fix a memory leak (Coverity). - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4589

1 0

Re: [PATCH v8 0/4] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4380

1 0

Re: [PATCH v3 0/6] MR4572: winevulkan: Use "host" instead of "native" and improve driver handle unwrapping. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4572

1 0