December 2023 - Wine-GitLab

Re: [PATCH v2 0/1] MR4582: winhttp: Handle chunked requests. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4582

1 0

Re: [PATCH v3 0/5] MR4590: mciwave: Use matching memory allocator (Coverity). - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4590

1 0

Re: [PATCH v3 0/2] MR4580: d3d9: Upload mapped dynamic vertex and index buffers before every draw. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4580

1 0

Re: [PATCH v4 0/5] MR4581: wined3d: Miscellaneous FFP housekeeping. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4581

1 0

Re: [PATCH v16 0/1] MR4428: cfgmgr32: Add CM_Register_Notification stub. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4428

1 0

Re: [PATCH v4 0/1] MR4539: d3dx9_36: Use CRT allocation functions. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4539

1 0

Re: [PATCH v2 0/1] MR4583: msxml3: Handle default namespace in get_baseName. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4583

1 0

Re: [PATCH v2 0/4] MR4586: oleaut32/tests: Remove some of the function availability checks. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4586

1 0

Re: [PATCH v2 0/1] MR4576: wineps.drv: Add paper source selection support in printer properties. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4576

1 0

Re: [PATCH v3 0/1] MR4563: wineps.drv: Fix printing images from iexplore. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4563

1 0

Re: [PATCH v4 0/1] MR4374: win32u: Find the correct dib driver in windrv_CreateDC(). - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4374

1 0

Re: [PATCH v2 0/1] MR509: vkd3d-shader: Update the vkd3d_shader_scan() documentation. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/509

1 0

Re: [PATCH v2 0/1] MR510: readme: Document VKD3D_SHADER_CONFIG. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/510

1 0

Re: [PATCH v2 0/1] MR508: vkd3d-shader: Add a VKD3D_FORCE_32_BIT_ENUM element to enum vkd3d_shader_compile_option_fragment_coordinate_origin. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/508

1 0

Re: [PATCH v2 0/2] MR503: vkd3d-shader/spirv: Silence fixmes for SV_TARGET. - approved
by Alexandre Julliard (＠julliard) Dec. 4, 2023

Dec. 4, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/503

1 0

[PATCH v4 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) Dec. 4, 2023

Dec. 4, 2023

Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions This will help some applications not crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Next part will be moving this code to msvcp and to make sure Cin, other related classes are implemented for msvcmxx.dlls -- v4: msvcm80: Add stub for ThrowNestedLoadModuleException function. msvcm80: Add stub for ThrowModuleLoadException(String, Exception) function. msvcm80: Add stub for ThrowModuleLoadException(String) function. https://gitlab.winehq.org/wine/wine/-/merge_requests/4596

2 4

[PATCH 0/1] MR509: vkd3d-shader: Update the vkd3d_shader_scan() documentation.
by Henri Verbeet (＠hverbeet) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/509

3 3

[PATCH 0/1] MR510: readme: Document VKD3D_SHADER_CONFIG.
by Henri Verbeet (＠hverbeet) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/510

3 3

[PATCH 0/1] MR508: vkd3d-shader: Add a VKD3D_FORCE_32_BIT_ENUM element to enum vkd3d_shader_compile_option_fragment_coordinate_origin.
by Henri Verbeet (＠hverbeet) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/508

3 3

[PATCH v3 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) Dec. 4, 2023

Dec. 4, 2023

Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions This will help some applications not crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Next part will be moving this code to msvcp and to make sure Cin, other related classes are implemented for msvcmxx.dlls -- v3: msvcm80: Add stub for https://gitlab.winehq.org/wine/wine/-/merge_requests/4596

3 4

[PATCH v2 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) Dec. 4, 2023

Dec. 4, 2023

Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions This will help some applications not crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Next part will be moving this code to msvcp and to make sure Cin, other related classes are implemented for msvcmxx.dlls -- v2: msvcm80: Add stub for https://gitlab.winehq.org/wine/wine/-/merge_requests/4596

3 4

[PATCH v3 0/2] MR4585: Draft: dsdmo: Add stubs for distortion and gargle effects
by Vijay Kiran Kamuju (＠infyquest) Dec. 4, 2023

Dec. 4, 2023

Add stubs for distortion and gargle effects in dsdmo. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55978 Currently Distortion effect is used by games like Fallout 3 and Gargle effect AFAIK is only in the DXSDK 9 demos. -- v3: dsdmo: Add Gargle effect stub. dsdmo: Add Distortion effect stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/4585

3 4

[PATCH 0/3] MR4596: Draft: msvcm80: Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions
by Vijay Kiran Kamuju (＠infyquest) Dec. 4, 2023

Dec. 4, 2023

Add stubs for CrtImplementationDetails::Thow*ModuleLoadException functions This will help some applications not crashing. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=34537 Next part will be moving this code to msvcp and to make sure Cin, other related classes are implemented for msvcmxx.dlls -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4596

3 4

[PATCH 0/2] MR4588: winegstreamer: Fix a memory leak (Coverity).
by Zhiyi Zhang (＠zhiyi) Dec. 4, 2023

Dec. 4, 2023

video_format can be leaked when encountering an invalid WMV format. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4588

4 4

[PATCH v33 0/4] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) Dec. 4, 2023

Dec. 4, 2023

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v33: win32u: Add SNI driver for systray handling https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

4 12

Re: [PATCH v3 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Petrichor Park (＠petrathekat) Dec. 4, 2023

Dec. 4, 2023

On Mon Dec 4 11:24:24 2023 +0000, Giovanni Mascellani wrote: > Currently we push the debug context when entering a section and pop it > just before entering the following one. It would be enough to keep doing > this for all except for the `[test]` section, and push and pull at each > line inside a `[test]` section. Does this make sense for you? Yep, and I have a working sketch locally. Pushing ... -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499#note_54891

1 0

[PATCH 0/2] MR4592: mscoree: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4592

3 3

[PATCH 0/6] MR4573: More CreateProcess work.
by eric pouech (＠epo) Dec. 4, 2023

Dec. 4, 2023

This series mainly: - tests and implement fixes for GetStartupInfoW: + it should transform PEB's RTL_USER_PROCESS_PARAMETERS on the fly (instead of caching the results as GetStartupInfoA) + it doesn't set all the fields of returned in STARTUPINFOW (unlike GetStartupInfoA) - no longer allow console and console handles for non CUI apps: + forbid inheritance of console handles for non CUI apps + don't create a unix console for initial (non CUI) app -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4573

3 12

[PATCH v2 0/2] MR4304: ole32/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 4, 2023

Dec. 4, 2023

-- v2: ole32/tests: Use CRT allocation functions. ole32/tests: Free what get_stgdef returns in test_OleCreateStaticFromData. https://gitlab.winehq.org/wine/wine/-/merge_requests/4304

3 4

[PATCH 0/1] MR4589: gdiplus: Fix a memory leak (Coverity).
by Zhiyi Zhang (＠zhiyi) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4589

3 2

[PATCH v7 0/4] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu Dec. 4, 2023

Dec. 4, 2023

Here's a list of usages of `base.outer_window` that may be impacted by the change and my analysis/fixes. Note that I specifically did not look for `document->outer_window` since that one was already holding it forever, so it's out of scope for this MR (whether it's correct or not, the behavior is the same after this MR). I also didn't consider some cases that already **did not check** for it being NULL or not, because they would have crashed earlier before anyway (they'd still crash now if outer window gets killed, but it's out of scope of the MR as I said). For those that says "Handled" it means I've added checks so that the behavior is same as before, i.e. detached inner windows behave as if outer window is NULL. * `htmldoc.c/HTMLDocument_get_mimeType`: Changed so it doesn't rely on outer window. * `htmldoc.c/HTMLDocument7_get_defaultView`: This is actually fixed by these patches. * `htmlform.c/HTMLFormElement_submit`: Handled. * `htmlstorage.c/send_storage_event`: Fixed in a separate patch with tests, since it follows the outer window. * `htmlwindow.c/check_target_origin`: This (along with many other methods) can't have it NULL anymore or detached, since the caller must hold a ref to the outer window, and they're not called from our objects holding ref to inner window only. * `htmlwindow.c/HTMLWindowSP_QueryService`: This uses the outer window to obtain the browser and the doc obj, so it's fine. * `mutation.c/set_document_mode`: Handled. * `navigate.c/BindCallbackRedirect_Redirect`: Handled. * `navigate.c/nsAsyncVerifyRedirectCallback_OnRedirectVerifyCallback`: Handled. * `navigate.c/nsChannelBSC_init_bindinfo`: Uses the outer window to obtain the browser and doc obj to set a flag, so it's harmless and probably correct this way. * `navigate.c/handle_navigation_error`: Handled. * `navigate.c/handle_extern_mime_navigation`: Handled. * `omnavigator.c/OmHistory_get_length`: This is actually fixed by these patches. * `script.c/ActiveScriptSite_GetItemInfo`: Handled. * `script.c/ActiveScriptSiteWindow_GetWindow`: Handled. -- v7: mshtml/tests: Fix XHR leak in test_window_refs. mshtml: Don't check for NULL outer_window from within HTMLWindow* methods. mshtml: Don't attempt to send storage events after outer window is detached. mshtml: Don't rely on the outer_window in document.mimeType. https://gitlab.winehq.org/wine/wine/-/merge_requests/4380

2 6

[PATCH v2 0/6] MR4572: winevulkan: Use "host" instead of "native" and improve driver handle unwrapping.
by Rémi Bernon Dec. 4, 2023

Dec. 4, 2023

We often use "native" to talk about Windows "native" code, which is confusing here. The unwrapping is also broken and always unwraps client handles to driver handles in the thunks, if they are wrapped. This currently forces every function that may be needing unwrapping to be handled in the drivers to unwrap the handles, which will be an issue if we intend to wrap VkSwapchainKHR in the drivers (which might be useful), and which requires to implement a lot of pass-through VkSurfaceKHR entry points. -- v2: winevulkan: Remove unnecessary dispatch from make_vulkan. winevulkan: Omit defaults in make_vulkan FUNCTION_OVERRIDES. winewayland: Use "host" intead of "native" in vulkan wrappers. winemac: Use "host" instead of "native" in vulkan wrappers. winex11: Use "host" instead of "native" in vulkan wrappers. winevulkan: Use "host" more consistently instead of "native". https://gitlab.winehq.org/wine/wine/-/merge_requests/4572

2 8

[PATCH v6 0/7] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu Dec. 4, 2023

Dec. 4, 2023

Here's a list of usages of `base.outer_window` that may be impacted by the change and my analysis/fixes. Note that I specifically did not look for `document->outer_window` since that one was already holding it forever, so it's out of scope for this MR (whether it's correct or not, the behavior is the same after this MR). I also didn't consider some cases that already **did not check** for it being NULL or not, because they would have crashed earlier before anyway (they'd still crash now if outer window gets killed, but it's out of scope of the MR as I said). For those that says "Handled" it means I've added checks so that the behavior is same as before, i.e. detached inner windows behave as if outer window is NULL. * `htmldoc.c/HTMLDocument_get_mimeType`: Changed so it doesn't rely on outer window. * `htmldoc.c/HTMLDocument7_get_defaultView`: This is actually fixed by these patches. * `htmlform.c/HTMLFormElement_submit`: Handled. * `htmlstorage.c/send_storage_event`: Fixed in a separate patch with tests, since it follows the outer window. * `htmlwindow.c/check_target_origin`: This (along with many other methods) can't have it NULL anymore or detached, since the caller must hold a ref to the outer window, and they're not called from our objects holding ref to inner window only. * `htmlwindow.c/HTMLWindowSP_QueryService`: This uses the outer window to obtain the browser and the doc obj, so it's fine. * `mutation.c/set_document_mode`: Handled. * `navigate.c/BindCallbackRedirect_Redirect`: Handled. * `navigate.c/nsAsyncVerifyRedirectCallback_OnRedirectVerifyCallback`: Handled. * `navigate.c/nsChannelBSC_init_bindinfo`: Uses the outer window to obtain the browser and doc obj to set a flag, so it's harmless and probably correct this way. * `navigate.c/handle_navigation_error`: Handled. * `navigate.c/handle_extern_mime_navigation`: Handled. * `omnavigator.c/OmHistory_get_length`: This is actually fixed by these patches. * `script.c/ActiveScriptSite_GetItemInfo`: Handled. * `script.c/ActiveScriptSiteWindow_GetWindow`: Handled. -- v6: mshtml/tests: Fix XHR leak in test_window_refs. mshtml: Get rid of outer_window member in HTMLDocumentNode. mshtml: Remove the inner window ref from the doc only when it is actually mshtml: Don't check for NULL outer_window from within HTMLWindow* methods. mshtml: Don't attempt to send storage events after outer window is detached. mshtml/tests: Improve the iframe navigation test. mshtml: Don't rely on the outer_window in document.mimeType. https://gitlab.winehq.org/wine/wine/-/merge_requests/4380

2 16

[PATCH v32 0/4] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) Dec. 4, 2023

Dec. 4, 2023

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v32: win32u: Add SNI driver for systray handling win32u: Add a SystrayRunLoop driver interface win32u: Refactor NotifyIcon driver interface into separate calls. win32u: Add a ShowBalloon driver interface https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 5

[PATCH v31 0/4] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) Dec. 4, 2023

Dec. 4, 2023

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v31: win32u: add SNI driver for systray handling win32u: add a SystrayRunLoop driver interface win32u: Refactor NotifyIcon driver interface into separate calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 17

Re: [PATCH v3 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Henri Verbeet (＠hverbeet) Dec. 4, 2023

Dec. 4, 2023

Shouldn't this simply be a matter of adjusting the existing vkd3d_test_push_context() and vkd3d_test_pop_context() calls in run_shader_tests() to update the context for each line? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499#note_54856

1 0

[PATCH 0/2] MR503: vkd3d-shader/spirv: Silence fixmes for SV_TARGET.
by Conor McCarthy (＠cmccarthy) Dec. 4, 2023

Dec. 4, 2023

Tests produce many spurious fixmes since SV_TARGET used to map to SV_NONE. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/503

3 3

[PATCH 0/8] MR4572: winevulkan: Use "host" instead of "native" and improve driver handle unwrapping.
by Rémi Bernon Dec. 4, 2023

Dec. 4, 2023

We often use "native" to talk about Windows "native" code, which is confusing here. The unwrapping is also broken and always unwraps client handles to driver handles in the thunks, if they are wrapped. This currently forces every function that may be needing unwrapping to be handled in the drivers to unwrap the handles, which will be an issue if we intend to wrap VkSwapchainKHR in the drivers (which might be useful), and which requires to implement a lot of pass-through VkSurfaceKHR entry points. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4572

2 13

[PATCH v2 0/5] MR502: Draft: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper.
by Giovanni Mascellani (＠giomasce) Dec. 4, 2023

Dec. 4, 2023

-- v2: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/502

2 6

[PATCH 0/1] MR411: win32u: Don't load bitmap only TTF fonts without bitmap table.
by Paul Gofman (＠gofman) Dec. 4, 2023

Dec. 4, 2023

The offending font is NotoColorEmoji.ttf which is present in, e. g., google-noto-emoji-color-fonts or noto-fonts-emoji packages available in various distribution. Attempting to load this font on Windows 10 (with AddFontResourceA() or open it with default font viewer) fails while currently succeeds on Windows. fontforge also refuses to open this font. That is because the font is bitmap only but missing bitmap table. Some apps (Glyph launcher is an example) try to GetOutlineTextMetrics() on this font and do not expect that to have an error return (as we currenly do), which leads to crash on unhandled division by zero exception. I am attaching a bitmap-only ttf test font (with only one bitmap) which I created with fontforge to make sure that such font can still be loaded in Wine. This font also loads on Windows (both with AddFontResourceA() and with default font viewer). There are other font types which can be legitimately missing EBDT table, but FT_Load_Sfnt_Table() returns a different error for those and my patch doesn't reject those fonts. [test.ttf](/uploads/b41472180b80c2c53f9dcc06055990f0/test.ttf) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/411

5 12

[PATCH 0/2] MR505: vkd3d-shader/dxil: Fix two small issues.
by Conor McCarthy (＠cmccarthy) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/505

3 3

Re: [PATCH v3 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Giovanni Mascellani (＠giomasce) Dec. 4, 2023

Dec. 4, 2023

On Sat Dec 2 18:00:47 2023 +0000, Petrichor Park wrote: > (the change is to remove the `vkd3d_test_push_context` call on L1439, > and then I'd need to remove the matching `vkd3d_test_pop_context` call > that's somewhere) Currently we push the debug context when entering a section and pop it just before entering the following one. It would be enough to keep doing this for all except for the `[test]` section, and push and pull at each line inside a `[test]` section. Does this make sense for you? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499#note_54833

1 0

[PATCH 0/1] MR4582: winhttp: Handle chunked requests.
by Paul Gofman (＠gofman) Dec. 4, 2023

Dec. 4, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4582

3 2

[PATCH v2 0/5] MR4590: mciwave: Use matching memory allocator (Coverity).
by Zhiyi Zhang (＠zhiyi) Dec. 4, 2023

Dec. 4, 2023

*pszTmpFileName will be freed with free() but it's allocated with HeapAlloc(). -- v2: ntdll: Fix a memory leak (Coverity). shell32: Fix a memory leak (Coverity). wininet: Fix a use-after-free (Coverity). tasklist: Fix a possible buffer overrun (Coverity). https://gitlab.winehq.org/wine/wine/-/merge_requests/4590

2 5

[PATCH 0/5] MR4590: mciwave: Use matching memory allocator (Coverity).
by Zhiyi Zhang (＠zhiyi) Dec. 4, 2023

Dec. 4, 2023

*pszTmpFileName will be freed with free() but it's allocated with HeapAlloc(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4590

3 6

[PATCH v3 0/1] MR4539: d3dx9_36: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 4, 2023

Dec. 4, 2023

-- v3: d3dx9: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4539

3 2

[PATCH v2 0/1] MR4539: d3dx9_36: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) Dec. 4, 2023

Dec. 4, 2023

-- v2: d3dx9: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/4539

3 6

[PATCH v2 0/6] MR489: vkd3d-shader: Prepare for 64-bit integer support.
by Conor McCarthy (＠cmccarthy) Dec. 4, 2023

Dec. 4, 2023

This is ready for review, but may not go upstream until after the release. -- v2: vkd3d-shader/spirv: Add a parameter name for int64 capability. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/489

4 18

[PATCH 0/4] MR4587: kernelbase: Implement flag validation in `LoadLibraryEx()` to work like in Win10
by Dāvis Mosāns Dec. 4, 2023

Dec. 4, 2023

While debugging League of Legends I noticed that `LoadLibraryEx()` is invoked with binary filename (non-text) and non-NULL `hFile`. In Windows such call would return `NULL` with LastError set as `ERROR_INVALID_PARAMETER` but current Wine implementation would try to proceed ahead. I don't know if this is intentional trick to mess up debugging/reversing tools or if we have some memory corruption before that overwrites filename buffer. But then I can't imagine how `hFile` could have gotten corrupted since shouldn't that be simple static value in register... Having this MR causes very noticeable difference in LoL: * without it - process deadlocks * with it - no deadlock Also while looking at this, I tried a lot of different flag combinations on Windows 10 and here I implemented so it works exactly like that. I also implemented test case for non-NULL `hFile` but I didn't bother for other flags since I don't know if we even care about those. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4587

2 5

[PATCH v2 0/2] MR4468: ntdll: Use posix_spawn() to start the server.
by Brendan Shanks (＠bshanks) Dec. 4, 2023

Dec. 4, 2023

-- v2: ntdll: Use posix_spawn() to start the server. ntdll: Factor out generating possible paths to wineserver. https://gitlab.winehq.org/wine/wine/-/merge_requests/4468

2 2