December 2023 - Wine-GitLab

[PATCH v4 0/3] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) Dec. 26, 2023

Dec. 26, 2023

-- v4: vkd3d-shader/spirv: Specify behavior for bit field instructions. tests: Use a uint target for rendering uint data. vkd3d: Specify the aspect when creating NULL UAVs. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 3

[PATCH v3 0/3] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) Dec. 26, 2023

Dec. 26, 2023

-- v3: vkd3d-shader/spirv: Specify behavior for bit field instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 3

[PATCH v2 0/2] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) Dec. 26, 2023

Dec. 26, 2023

-- v2: tests: Use a uint target for rendering uint data. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 2

[PATCH 0/1] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) Dec. 26, 2023

Dec. 26, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 1

[PATCH 0/1] MR4742: server: Allow PROCESS_QUERY_INFORMATION on LIMITED handle.
by Bernhard Übelacker Dec. 26, 2023

Dec. 26, 2023

A handle created with just PROCESS_QUERY_LIMITED_INFORMATION should be returned when queried with PROCESS_QUERY_INFORMATION. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56093 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4742

2 2

[PATCH 0/1] MR4736: wineandroid: fix incorrect checking reason.
by Fan WenJie (＠fanwenjie) Dec. 25, 2023

Dec. 25, 2023

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4736

3 2

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls - approved
by Jinoh Kang (＠iamahuman) Dec. 25, 2023

Dec. 25, 2023

This merge request was approved by Jinoh Kang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655

1 0

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Jinoh Kang (＠iamahuman) Dec. 25, 2023

Dec. 25, 2023

You're correct that debuggers can be sensitive to the timing of the initial breakpoint. Adding a conformance test would let us confirm your observation, and ensure such regression won't happen in the future. For reference, see 2b40969c58a099f958c58909b666915991a42979. I'm still approving since the existing tests did not fail and I cannot find a particular reason `process_breakpoint();` must be placed exactly there in the commit history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655#note_56412

1 0

[PATCH v2 0/1] MR4703: dmime: Fix handling of curve PMSG.
by Yuxuan Shui (＠yshui) Dec. 24, 2023

Dec. 24, 2023

DMUS_PMSG::dwType is the type of the message, but we are comparing it to curve types. We should be using DMUS_CURVE_PMSG::bType instead. * * * (I tried to write some test cases for this. I created a IDirectMusicPort implementation that checks the generated midi commands, but instead I cannot get Windows to generate any midi commands for CCCURVEs. ) -- v2: dmime: Fix handling of curve PMSG. https://gitlab.winehq.org/wine/wine/-/merge_requests/4703

4 5

[PATCH 0/1] MR4739: ntdll: Don't hardcode page size
by Fabian Maurer (＠DarkShadow44) Dec. 24, 2023

Dec. 24, 2023

While this is not needed for 16k pages to work, it does seem sensible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4739

2 1

[PATCH 0/1] MR4734: gdiplus: Avoid use of temporary variable
by David Kahurani (＠kahurani) Dec. 23, 2023

Dec. 23, 2023

A temporary variable is used here to assist with assignment but this does not conform to the coding style in the rest of gdiplus and introduces an unnecessary variable. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4734

3 3

[PATCH v3 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) Dec. 23, 2023

Dec. 23, 2023

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- v3: advapi32/tests: Skip WoW64 tests on 32-bit in test_reg_create_key. https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

2 2

[PATCH v2 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) Dec. 23, 2023

Dec. 23, 2023

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- v2: advapi32/tests: Use has_wow64() in the test_reg_create_key test. advapi32/tests: Introduce a new has_wow64 helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) Dec. 23, 2023

Dec. 23, 2023

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH v2 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns Dec. 23, 2023

Dec. 23, 2023

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v2: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

3 10

Re: [PATCH v2 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

1 0

Re: [PATCH v2 0/1] MR4732: winedbg: Fix main module detection in 'info share' command. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4732

1 0

Re: [PATCH v3 0/5] MR4702: dmime/tests: Multiple fixes for various Windows test failures. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4702

1 0

Re: [PATCH v2 0/1] MR4731: include: Fix boolean return value definition in IIterator<T> methods. - approved
by Alexandre Julliard (＠julliard) Dec. 22, 2023

Dec. 22, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4731

1 0

[PATCH v17 0/7] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) Dec. 22, 2023

Dec. 22, 2023

-- v17: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten SWITCH/CASE/DEFAULT/ENDSWITCH control flow instructions. vkd3d-shader/ir: Flatten LOOP/BREAK/CONTINUE/ENDLOOP control flow instructions. vkd3d-shader/ir: Flatten IF/ELSE/ENDIF control flow instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 10

[PATCH 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK.
by Paul Gofman (＠gofman) Dec. 22, 2023

Dec. 22, 2023

CreateClassEnumerator() can return S_FALSE and NULL moniker if the specified category is empty or doesn't exist (and devenum implementation can do that), build_directshowfilters_tree() will crash in that case. That's not new and AFAIU should not be normally hit as the category should not be empty, but I managed to hit that on some prefix (maybe with messed up direct show registration) and the change looks simple and sure enough probably (currently it will always crash if gets S_FALSE). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

2 1

[PATCH 0/1] MR4731: include: Fix boolean return value definition in IIterator<T> methods.
by Paul Gofman (＠gofman) Dec. 22, 2023

Dec. 22, 2023

The practical effect of the change is that boolean is 1 byte while BOOL is 4 bytes, so we are wrongly filling more bytes in those methods and wrongly expect full 4 byte BOOL value to be filled from apps IIterator implemenation (and thus depend on uninitialized data in implementation). That fixes a hang on new game start in Phasmophobia (when it is configured to use windows.media.speech). That was originally attributed as a regression from commit 62173699c38453777c7d5638ed2e779790506b75 ("include: Don't align the stack for PE builds.") while before that commit it worked by chance only of course, the commit only changed stack data a bit so we were a bit more lucky in getting high bytes of BOOL as 0 in windows.media.speech/vector.c:vector_hstring_create_copy(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4731

5 4

[PATCH 0/1] MR4732: winedbg: Fix main module detection in 'info share' command.
by eric pouech (＠epo) Dec. 22, 2023

Dec. 22, 2023

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4732

3 2

[PATCH v6 0/5] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) Dec. 22, 2023

Dec. 22, 2023

-- v6: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 5

Re: [PATCH v2 0/1] MR4730: dbghelp/tests: Wait for child window to be up before testing. - approved
by Alexandre Julliard (＠julliard) Dec. 21, 2023

Dec. 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4730

1 0

Re: [PATCH v4 0/2] MR4676: server: Only update the global cursor if the pointer is inside the thread's windows. - approved
by Alexandre Julliard (＠julliard) Dec. 21, 2023

Dec. 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

1 0

Re: [PATCH v4 0/1] MR4726: server: Always release internal hardware messages - approved
by Alexandre Julliard (＠julliard) Dec. 21, 2023

Dec. 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

1 0

Re: [PATCH v2 0/2] MR4729: dnsapi: Update the array ptr in the insufficient buffer case. - approved
by Alexandre Julliard (＠julliard) Dec. 21, 2023

Dec. 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4729

1 0

Re: [PATCH v2 0/1] MR4728: winmm: Fill in pIOProc field in MMIOINFO. - approved
by Alexandre Julliard (＠julliard) Dec. 21, 2023

Dec. 21, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4728

1 0

[PATCH v4 0/4] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) Dec. 21, 2023

Dec. 21, 2023

-- v4: vkd3d-shader/ir: Validate destination write masks depending on the dimension. vkd3d-shader/ir: Validate source swizzles depending on the dimension. vkd3d-shader/ir: Validate SSA registers. vkd3d-shader/dxil: Create constant buffer registers with dimension vec4. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 4

[PATCH v3 0/3] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) Dec. 21, 2023

Dec. 21, 2023

-- v3: vkd3d-shader/ir: Validate destination write masks depending on the dimension. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 3

[PATCH v2 0/3] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) Dec. 21, 2023

Dec. 21, 2023

-- v2: vkd3d-shader/ir: Validate destination write masks depending on the dimension. vkd3d-shader/ir: Validate source swizzles depending on the dimension. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 3

[PATCH 0/1] MR511: vkd3d-shader/ir: Do not merge signature elements which have different interpolation modes.
by Conor McCarthy (＠cmccarthy) Dec. 21, 2023

Dec. 21, 2023

Regression in signature normalisation, however the old code was not correct either because it would apply the interpolation mode to all components. Found in an Assassin's Creed: Valhalla shader. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/511

4 5

[PATCH 0/1] MR4730: dbghelp/tests: Wait for child window to be up before testing.
by eric pouech (＠epo) Dec. 21, 2023

Dec. 21, 2023

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4730

2 2

[PATCH 0/3] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) Dec. 21, 2023

Dec. 21, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 3

[PATCH 0/2] MR4729: dnsapi: Update the array ptr in the insufficient buffer case.
by Huw Davies (＠huw) Dec. 21, 2023

Dec. 21, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4729

3 3

[PATCH 0/1] MR4728: winmm: Fill in pIOProc field in MMIOINFO.
by eric pouech (＠epo) Dec. 21, 2023

Dec. 21, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55942 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4728

3 2

[PATCH v3 0/2] MR4676: server: Only update the global cursor if the pointer is inside the thread's windows.
by Rémi Bernon Dec. 21, 2023

Dec. 21, 2023

We are preferring the thread input cursor over the global desktop cursor, but if the thread input has no cursor yet, for instance when thread is attached to another thread without a message queue yet, it will end up being invisible. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55961 -- v3: server: Change desktop cursor only when inside the thread's windows. server: Introduce a new get_desktop_cursor_thread_input helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

1 3

[PATCH v3 0/1] MR4726: server: Always release internal hardware messages
by Brendan McGrath (＠redmcg) Dec. 21, 2023

Dec. 21, 2023

This fixes an issue seen in Outlook 365 where the password prompt appears to lock up. Technically this fixes a regression introduced in 25906eedd8679fdb474976563f4a05a92e11bbd6, but I think Outlook had other issues that would have masked this one at the time. -- v3: server: Always release internal hardware messages https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

3 3

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon Dec. 21, 2023

Dec. 21, 2023

I'm not sure we need a test for that btw. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56344

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon Dec. 21, 2023

Dec. 21, 2023

Rémi Bernon (@rbernon) commented about server/queue.c: > > data->hw_id = msg->unique_id; > set_reply_data( msg->data, msg->data_size ); > - if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) > + if (get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && > + ((flags & PM_REMOVE) || is_internal_hardware_message( msg->msg ))) ```suggestion:-1+0 if ((get_hardware_msg_bit( msg->msg ) == QS_RAWINPUT && (flags & PM_REMOVE)) || is_internal_hardware_message( msg->msg ))) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56343

1 0

Re: [PATCH v2 0/2] MR4726: server: Always release internal hardware messages
by Rémi Bernon Dec. 21, 2023

Dec. 21, 2023

Rémi Bernon (@rbernon) commented about server/queue.c: > } > } > > +/* is this message an internal driver notification message */ > +static inline BOOL is_internal_hardware_message( unsigned int message ) > +{ > + return (message >= WM_WINE_CLIPCURSOR && message <= WM_WINE_LAST_DRIVER_MSG); I'd use the same range that's used for peeking the messages: ```suggestion:-0+0 return (message >= WM_WINE_FIRST_DRIVER_MSG && message <= WM_WINE_LAST_DRIVER_MSG); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726#note_56342

1 0

[PATCH 0/1] MR4727: advapi32: Add TreeSetNamedSecurityInfoW stub.
by Alex Henrie (＠alexhenrie) Dec. 21, 2023

Dec. 21, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56055 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4727

2 1

[PATCH 0/2] MR4726: server: Always release internal hardware messages
by Brendan McGrath (＠redmcg) Dec. 21, 2023

Dec. 21, 2023

This fixes an issue seen in Outlook 365 where the password prompt appears to lock up. Technically this fixes a regression introduced in 25906eedd8679fdb474976563f4a05a92e11bbd6, but I think Outlook had other issues that would have masked this one at the time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

3 3

[PATCH v5 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) Dec. 21, 2023

Dec. 21, 2023

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v5: tests: Use the vulkan runner to run SM1 compilation tests. tests/shader-runner: Call each runner only once. tests/shader-runner: Support reading multiple model range args for qualifiers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

2 5

Re: [PATCH v3 0/1] MR4725: qcap/audiorecord: Do not leak the sample when pausing or stopping. - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4725

1 0

Re: [PATCH v5 0/2] MR4699: wined3d: Store the resource heap memory pointer directly. - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4699

1 0

Re: [PATCH v5 0/1] MR4674: comctl32/listview: Ignore the lParam to WM_PRINTCLIENT and add tests. - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4674

1 0

Re: [PATCH v2 0/1] MR4722: msdasql/tests: Add missing carriage returns - approved
by Alexandre Julliard (＠julliard) Dec. 20, 2023

Dec. 20, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4722

1 0

[PATCH 0/1] MR4724: evr/dshow: Handle YUY2 sample copy.
by Nikolay Sivov (＠nsivov) Dec. 20, 2023

Dec. 20, 2023

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53810 This bug is marked as a regression, however I don't see it crashing on my system, with current wine. I do however get a black screen instead of the intro video. This fix helps. I think it's fine to wait for 9.0 without this MR, but also might be nice to get it working. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4724

3 4