- Wine-GitLab - list.winehq.org

Re: [PATCH v2 0/1] MR10316: d2d1: Do not reference layer objects when recording to the command list. - approved
by Alexandre Julliard (＠julliard) March 12, 2026

March 12, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10316

1 0

Re: [PATCH v2 0/1] MR10315: mfplay: Remove incorrect fixme for MFP_EVENT_TYPE_ERROR. - approved
by Alexandre Julliard (＠julliard) March 12, 2026

March 12, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10315

1 0

Re: [PATCH v8 0/2] MR10272: wbemprox: Correct IP address order when calling Win32_NetworkAdapterConfiguration. - approved
by Alexandre Julliard (＠julliard) March 12, 2026

March 12, 2026

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10272

1 0

[PATCH v2 0/1] MR10311: vbscript: Do not fail on colon-prefixed statements in If blocks.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

fixes https://bugs.winehq.org/show_bug.cgi?id=55037 -- v2: vbscript: Do not fail on colon-prefixed statements in If blocks. https://gitlab.winehq.org/wine/wine/-/merge_requests/10311

3 2

[PATCH 0/1] MR10318: vbscript: Allow End If on the same line as the preceding statement.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

Use BodyStatements instead of StatementsNl_opt for If, ElseIf, and Else blocks so the last statement before End If does not require a trailing newline, matching native behavior. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55196 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10318

3 4

[PATCH v2 0/1] MR10309: vbscript: Split() should return an empty array for empty strings.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58398 -- v2: vbscript: Split() should return an empty array for empty strings. https://gitlab.winehq.org/wine/wine/-/merge_requests/10309

3 4

[PATCH v7 0/2] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 12, 2026

March 12, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- v7: mfmediaengine: Implement looping behaviour. https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

2 3

[PATCH v6 0/2] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 12, 2026

March 12, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- v6: mfmediaengine: Implement looping behaviour. https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

2 3

[PATCH v17 0/4] MR8394: Fix Clip Studio Paint crash with Windows 10 compatibility mode
by Ignacy Kuchciński March 12, 2026

March 12, 2026

This fixes the crash when launching ClipStudioPaint.exe with Windows 10 compatiblity mode by adding the minimum required windows.ui and windows.storage definitions and stubs. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58254 -- v17: windows.storage: Add stubs for StorageFile class. include: Add Windows.Storage.StorageFile missing definitions. windows.ui: Add stubs for RadialController classes. include: Add Windows.UI.Input.RadialController definitions. https://gitlab.winehq.org/wine/wine/-/merge_requests/8394

1 5

[PATCH v5 0/2] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 12, 2026

March 12, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- v5: mfmediaengine: Implement looping behaviour. https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

2 4

[PATCH v2 0/2] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 12, 2026

March 12, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- v2: mfmediaengine: Implement looping behaviour. https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

4 7

Re: [PATCH v6 0/1] MR10206: comctl32/treeview: Fixed missing redraw of item being unfocused
by Nikolay Sivov (＠nsivov) March 12, 2026

March 12, 2026

I think keeping selection invalidation is still useful. For example when clicking on checkboxes, it's possible to have old selection not repainted, it's lost once you force whole repaint but it's not very nice. Checkbox behavior regarding selection is still incorrect, but that's another thing. P.S. please also keep existing style, with opening braces on a new line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10206#note_132071

1 0

[PATCH v3 0/2] MR10245: ole32: Relax COM initialization check in RegisterDragDrop.
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59084 -- v3: ole32: Relax COM initialization check in RegisterDragDrop. ole32/tests: Add more RegisterDragDrop tests after mismatched cleanup. https://gitlab.winehq.org/wine/wine/-/merge_requests/10245

3 3

[PATCH v5 0/1] MR9742: mf: Prevent invalid topologies from being started.
by Bernhard Kölbl March 12, 2026

March 12, 2026

Signed-off-by: Bernhard Kölbl <bkoelbl(a)codeweavers.com> -- v5: mf: Prevent invalid topologies from being started. https://gitlab.winehq.org/wine/wine/-/merge_requests/9742

2 3

[PATCH v3 0/4] MR10247: server, ntoskrnl.exe: Implement FsRtlGetFileSize().
by Nello De Gregoris (＠bluechxin) March 12, 2026

March 12, 2026

Needed by Persona 5: The Phantom X (SEA/KR/CN) in order to launch the game. -- v3: ntoskrnl.exe/tests: Add tests for FsRtlGetFileSize(). ntoskrnl.exe: Implement FsRtlGetFileSize(). ntoskrnl.exe/tests: Add tests for directory kernel objects. server: Allow creating directory kernel objects. https://gitlab.winehq.org/wine/wine/-/merge_requests/10247

2 4

[PATCH v2 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- v2: vbscript: Convert string to number for comparison operators. https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

2 3

[PATCH 0/2] MR10307: comctl32/tab: Use a clip region to protect the tab item background.
by Zhiyi Zhang (＠zhiyi) March 12, 2026

March 12, 2026

Use a clip region to protect the tab item background when drawing the text of an owner-draw tab control. This partially reverts 0d173d01. Tests show that the top edge of the rcItem in DRAWITEMSTRUCT shouldn't be added 2 pixels for a owner-draw tab, and the tab item background can't be overwritten when painting the text, which suggests the presence of a clip region. Fix the text position being off by 2 pixels for an application, which uses the rcItem in DRAWITEMSTRUCT to calculate text position. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10307

3 3

[PATCH 0/1] MR10314: vbscript: Convert string to number for comparison operators.
by Francis De Brabandere (＠francisdb) March 12, 2026

March 12, 2026

When one operand was a string and the other numeric, VBScript should have converted the string to a double before comparing. VarCmp did not do this automatically, resulting in incorrect string comparison. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56281 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10314

3 4

[PATCH v2 0/2] MR10305: mfmediaengine: Add IMFMediaEngineClassFactoryEx interface.
by Paul Gofman (＠gofman) March 12, 2026

March 12, 2026

-- v2: mfmediaengine: Add IMFMediaEngineClassFactoryEx interface. https://gitlab.winehq.org/wine/wine/-/merge_requests/10305

3 5

[PATCH 0/2] MR10306: mfmediaengine: Implement looping behaviour.
by Brendan McGrath (＠redmcg) March 12, 2026

March 12, 2026

When `IMFMediaEngine::SetLoop(TRUE)` is called, media engine will repeatedly loop the video. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10306

3 3

[PATCH 0/1] MR10316: d2d1: Do not reference layer objects when recording to the command list.
by Nikolay Sivov (＠nsivov) March 12, 2026

March 12, 2026

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10316

2 1

[PATCH 0/1] MR10315: mfplay: Remove incorrect fixme for MFP_EVENT_TYPE_ERROR.
by Nikolay Sivov (＠nsivov) March 12, 2026

March 12, 2026

This type is already handled, no need for such message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10315

2 1

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

I'm not the one responsible for this area, but I added my comments. If there are any applications or bug reports depending on the behavior you suggest, please let us know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132030

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > + > + nt_header.FileHeader.NumberOfSections = 1; > + nt_header.FileHeader.SizeOfOptionalHeader = sizeof(IMAGE_OPTIONAL_HEADER); > + > + nt_header.OptionalHeader.SectionAlignment = page_size; > + nt_header.OptionalHeader.DllCharacteristics = IMAGE_DLLCHARACTERISTICS_NX_COMPAT | IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE; > + nt_header.OptionalHeader.FileAlignment = page_size; > + nt_header.OptionalHeader.SizeOfHeaders = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER); > + nt_header.OptionalHeader.SizeOfImage = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + page_size; > + > + create_test_dll( &dos_header, sizeof(dos_header), &nt_header, dll_name_a ); > + mod = LoadLibraryA( dll_name_a ); > + ok(mod != NULL, "can't load test dll\n"); > + if (mod != NULL) > + { > + dll_name[0] = 0; Likewise below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132029

1 0

Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
by Akihiro Sagawa (＠sgwaki) March 12, 2026

March 12, 2026

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c: > DeleteFileA( long_path ); > } > > +static void test_getmodulefilename_string_termination(void) > +{ > + WCHAR dll_name[MAX_PATH]; > + int dll_name_len, i; > + > + dll_name[0] = 0; > + GetModuleFileNameW(NULL, dll_name, MAX_PATH); > + dll_name_len = wcslen(dll_name); > + ok(dll_name_len > 0, "can't get path for NULL module\n"); > + ok(dll_name_len < MAX_PATH, "unterminated path for NULL module\n"); > + > + memset(dll_name, 0x9, sizeof(dll_name)); It would be better to avoid using magic numbers and use `'\t'` instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132028

1 0