- Wine-GitLab - list.winehq.org

[PATCH 0/2] MR642: msvcp: Fix _Fiopen implementation
by Piotr Caban (＠piotr) Aug. 15, 2022

Aug. 15, 2022

Based on a patch by Yeshun Ye. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/642

2 2

[PATCH v2 0/1] MR8: vkd3d-shader/spirv: Fix the signature of vkd3d_spirv_build_op_type_image
by Martin Storsjö Aug. 15, 2022

Aug. 15, 2022

Don't assume that enums and uint32_t parameters are identical. Clang 16 changes the diagonstic for incompatible function pointer types from a warning into an error by default. This fixes the following error, when built (for aarch64, but probably also for other architectures) in MSVC mode: ``` ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:1083:13: error: incompatible function pointer types passing 'uint32_t (struct vkd3d_spirv_builder *, uint32_t, SpvDim, uint32_t, uint32_t, uint32_t, uint32_t, SpvImageFormat)' (aka 'unsigned int (struct vkd3d_spirv_builder *, unsigned int, enum SpvDim_, unsigned int, unsigned int, unsigned int, unsigned int, enum SpvImageFormat_)') to parameter of type 'vkd3d_spirv_build7_pfn' (aka 'unsigned int (*)(struct vkd3d_spirv_builder *, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)') [-Wincompatible-function-pointer-types] vkd3d_spirv_build_op_type_image); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:612:68: note: passing argument to parameter 'build_pfn' here SpvOp op, const uint32_t *operands, vkd3d_spirv_build7_pfn build_pfn) ^ ``` -- v2: vkd3d-shader/spirv: Fix the signature of vkd3d_spirv_build_op_type_image https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/8

2 2

[PATCH 0/1] MR8: vkd3d-shader/spirv: Fix the signature of vkd3d_spirv_build_op_type_image
by Martin Storsjö Aug. 15, 2022

Aug. 15, 2022

Don't assume that enums and uint32_t parameters are identical. Clang 16 changes the diagonstic for incompatible function pointer types from a warning into an error by default. This fixes the following error, when built (for aarch64, but probably also for other architectures) in MSVC mode: ``` ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:1083:13: error: incompatible function pointer types passing 'uint32_t (struct vkd3d_spirv_builder *, uint32_t, SpvDim, uint32_t, uint32_t, uint32_t, uint32_t, SpvImageFormat)' (aka 'unsigned int (struct vkd3d_spirv_builder *, unsigned int, enum SpvDim_, unsigned int, unsigned int, unsigned int, unsigned int, enum SpvImageFormat_)') to parameter of type 'vkd3d_spirv_build7_pfn' (aka 'unsigned int (*)(struct vkd3d_spirv_builder *, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int, unsigned int)') [-Wincompatible-function-pointer-types] vkd3d_spirv_build_op_type_image); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/libs/vkd3d/libs/vkd3d-shader/spirv.c:612:68: note: passing argument to parameter 'build_pfn' here SpvOp op, const uint32_t *operands, vkd3d_spirv_build7_pfn build_pfn) ^ ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/8

1 1

[PATCH 0/2] MR640: Hnetcfg fw rule
by Hans Leidekker (＠hans) Aug. 15, 2022

Aug. 15, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/640

2 2

[PATCH 0/1] MR639: bcrypt: Move symmetric flags check to symmetric section.
by Santino Mazza (＠tati1454) Aug. 15, 2022

Aug. 15, 2022

This conditional prevented BCryptEncrypt from executing when using asymmetric flags. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/639

3 2

[PATCH v4 0/6] MR581: d3d8, d3d9: More tests for dirty rects and UpdateTexture().
by Zebediah Figura (＠zfigura) Aug. 15, 2022

Aug. 15, 2022

-- v4: d3d9/tests: Add more tests for dirty rect handling. d3d8/tests: Add more tests for dirty rect handling. d3d8/tests: Read back directly from the specified surface if possible. d3d9/tests: Expand tests for valid pools in UpdateTexture(). d3d8/tests: Expand tests for valid pools in UpdateTexture(). wined3d: Use wined3d_array_reserve() in wined3d_adapter_create_output(). https://gitlab.winehq.org/wine/wine/-/merge_requests/581

2 6

[PATCH v3 0/2] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) Aug. 14, 2022

Aug. 14, 2022

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- v3: mf/samplegrabber: Request a sample when going from paused to running state. mf: Handle timer time behind clock time in present_clock_schedule_timer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/574

3 4

[PATCH 0/2] MR638: wshom: Use signed type for properties ProcessID and ExitCode in IWshExec.
by Robert Wilhelm (＠sloper42) Aug. 14, 2022

Aug. 14, 2022

Automation interfaces should use signed types, because VBScript does not support unsigned types like VT_UI4. See discussion under Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53542 Signed-off-by: Robert Wilhelm <robert.wilhelm(a)gmx.net> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/638

3 3

Re: [PATCH v5 0/5] MR625: qasf: Configure, start and stop the WMReader in the ASF Reader filter. - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/625

1 0

Re: [PATCH v2 0/2] MR582: winegstreamer: Prefer switch rather than misleading array indexes. - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/582

1 0

Re: [PATCH v3 0/1] MR618: d3d11: Validate layout description in d3d_input_layout_create(). - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/618

1 0

Re: [PATCH v2 0/1] MR620: ntdll: Remove redundant assignment in fixup_icmp_over_dgram(). - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/620

1 0

Re: [PATCH v3 0/5] MR632: mshtml: Hooks and misc improvements. - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/632

1 0

Re: [PATCH v2 0/3] MR636: ieframe: Allow STGM_WRITE in IPropertyStorage::Open. - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/636

1 0

Re: [PATCH v2 0/7] MR637: wow64win: more implementation - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/637

1 0

Re: [PATCH v2 0/1] MR634: wshom: Use signed type for ExitCode in IWshShell3::Run(). - approved
by Alexandre Julliard (＠julliard) Aug. 13, 2022

Aug. 13, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/634

1 0

[PATCH 0/2] MR582: winegstreamer: Prefer switch rather than misleading array indexes.
by Rémi Bernon Aug. 12, 2022

Aug. 12, 2022

Adding formats without updating the array gets unnoticed by the compiler otherwise. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/582

4 7

[PATCH v4 0/5] MR625: qasf: Configure, start and stop the WMReader in the ASF Reader filter.
by Rémi Bernon Aug. 12, 2022

Aug. 12, 2022

-- v4: qasf: Configure WMReader stream selection in asf_reader_init_stream. qasf: Configure WMReader stream format in asf_reader_init_stream. qasf: Start/stop the WM reader in asf_reader_init/cleanup_stream. qasf: Implement ASF Reader filter init_stream and cleanup_stream. qasf: Wait for IWMReader_Open to complete in ASF Reader Load. https://gitlab.winehq.org/wine/wine/-/merge_requests/625

1 5

[PATCH v2 0/1] MR618: d3d11: Validate layout description in d3d_input_layout_create().
by Paul Gofman (＠gofman) Aug. 12, 2022

Aug. 12, 2022

Fixes black screen in Sweet Transit game. The game depends on ID3D11Device_CreateInputLayout to fail properly when mandatory VS input is not filled. It is coming from MonoGame engine available as source, here is the place of interest: https://github.com/MonoGame/MonoGame/blob/158c0154ac18ed6102c65e24665c6a080… As far as my testing goes: - missing mandatory inputs cause failure, extra elements in input layout are fine; - shader type is not checked; - what is mandatory is unrelated to sysval semantics value in dxbc, it probably just checks for sv_ special names with position being a special case which is still mandatory; - there are more validation checks which are not implemented in this patch, e. g., for InputSlotClass validity. There is a single todo_wine test for that, but it doesn't cover all the specifics. -- v2: d3d11: Validate layout description in d3d_input_layout_create(). https://gitlab.winehq.org/wine/wine/-/merge_requests/618

3 3

[PATCH v3 0/5] MR625: qasf: Configure, start and stop the WMReader in the ASF Reader filter.
by Rémi Bernon Aug. 12, 2022

Aug. 12, 2022

-- v3: qasf: Configure WMReader stream selection in asf_reader_init_stream. qasf: Configure WMReader stream format in asf_reader_init_stream. qasf: Start/stop the WM reader in asf_reader_init/cleanup_stream. qasf: Implement ASF Reader filter init_stream and cleanup_stream. qasf: Wait for IWMReader_Open to complete in ASF Reader Load. https://gitlab.winehq.org/wine/wine/-/merge_requests/625

2 10

[PATCH 0/3] MR633: d3d11: Implement D3D11_FEATURE_FORMAT_SUPPORT.
by Zebediah Figura (＠zfigura) Aug. 12, 2022

Aug. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/633

4 5

[PATCH 0/1] MR620: ntdll: Remove redundant assignment in fixup_icmp_over_dgram().
by Paul Gofman (＠gofman) Aug. 12, 2022

Aug. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/620

3 2

[PATCH v2 0/5] MR632: mshtml: Hooks and misc improvements.
by Gabriel Ivăncescu Aug. 12, 2022

Aug. 12, 2022

The last patch will be useful later when we have to use the dispex itself. -- v2: mshtml: Return DISP_E_MEMBERNOTFOUND when not finding member by DISPID. mshtml: Implement document.location with a hook. mshtml: Implement window.setTimeout with a hook. mshtml: Implement window.location setter with a hook. mshtml: Forward Document's Invoke to InvokeEx. https://gitlab.winehq.org/wine/wine/-/merge_requests/632

2 7

[PATCH 0/3] MR636: ieframe: Allow STGM_WRITE in IPropertyStorage::Open.
by Akihiro Sagawa (＠sgwaki) Aug. 12, 2022

Aug. 12, 2022

Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/636

3 4

[PATCH 0/7] MR637: wow64win: more implementation
by Jacek Caban (＠jacek) Aug. 12, 2022

Aug. 12, 2022

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/637

3 8