October 2012 - Wine-commits

Daniel Lehman : msvcp90: Fix usage of fpos<>::off vs fpos<>::pos.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: 771cc7fdbd43550980c9250b9421cfe4621f3bbf URL: http://source.winehq.org/git/wine.git/?a=commit;h=771cc7fdbd43550980c9250b9… Author: Daniel Lehman <dlehman(a)esri.com> Date: Fri Sep 28 17:17:53 2012 -0700 msvcp90: Fix usage of fpos<>::off vs fpos<>::pos. --- dlls/msvcp90/ios.c | 74 ++++++++++++++++++++++++++-------------------------- 1 files changed, 37 insertions(+), 37 deletions(-) diff --git a/dlls/msvcp90/ios.c b/dlls/msvcp90/ios.c index 9435cb2..b1acb3f 100644 --- a/dlls/msvcp90/ios.c +++ b/dlls/msvcp90/ios.c @@ -1250,8 +1250,8 @@ fpos_int* __thiscall basic_streambuf_char_seekoff(basic_streambuf_char *this, fpos_int *ret, streamoff off, int way, int mode) { TRACE("(%p %ld %d %d)\n", this, off, way, mode); - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -1285,8 +1285,8 @@ fpos_int* __thiscall basic_streambuf_char_seekpos(basic_streambuf_char *this, fpos_int *ret, fpos_int pos, int mode) { TRACE("(%p %s %d)\n", this, debugstr_fpos_int(&pos), mode); - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -2020,8 +2020,8 @@ fpos_int* __thiscall basic_streambuf_wchar_seekoff(basic_streambuf_wchar *this, fpos_int *ret, streamoff off, int way, int mode) { TRACE("(%p %ld %d %d)\n", this, off, way, mode); - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -2061,8 +2061,8 @@ fpos_int* __thiscall basic_streambuf_wchar_seekpos(basic_streambuf_wchar *this, fpos_int *ret, fpos_int pos, int mode) { TRACE("(%p %s %d)\n", this, debugstr_fpos_int(&pos), mode); - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -2804,8 +2804,8 @@ fpos_int* __thiscall basic_filebuf_char_seekoff(basic_filebuf_char *this, if(!basic_filebuf_char_is_open(this) || !basic_filebuf_char__Endwrite(this) || fseek(this->file, off, way)) { - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -2830,8 +2830,8 @@ fpos_int* __thiscall basic_filebuf_char_seekpos(basic_filebuf_char *this, if(!basic_filebuf_char_is_open(this) || !basic_filebuf_char__Endwrite(this) || fseek(this->file, (LONG)pos.pos, SEEK_SET) || (pos.off && fseek(this->file, pos.off, SEEK_CUR))) { - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -3421,8 +3421,8 @@ fpos_int* __thiscall basic_filebuf_wchar_seekoff(basic_filebuf_wchar *this, if(!basic_filebuf_wchar_is_open(this) || !basic_filebuf_wchar__Endwrite(this) || fseek(this->file, off, way)) { - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -3449,8 +3449,8 @@ fpos_int* __thiscall basic_filebuf_wchar_seekpos(basic_filebuf_wchar *this, if(!basic_filebuf_wchar_is_open(this) || !basic_filebuf_wchar__Endwrite(this) || fseek(this->file, (LONG)pos.pos, SEEK_SET) || (pos.off && fseek(this->file, pos.off, SEEK_CUR))) { - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -3854,7 +3854,7 @@ fpos_int* __thiscall basic_stringbuf_char_seekpos(basic_stringbuf_char *this, { TRACE("(%p %p %s %d)\n", this, ret, debugstr_fpos_int(&pos), mode); - if(pos.off==0 && pos.pos==-1 && pos.state==0) { + if(pos.off==-1 && pos.pos==0 && pos.state==0) { *ret = pos; return ret; } @@ -4267,7 +4267,7 @@ fpos_int* __thiscall basic_stringbuf_wchar_seekpos(basic_stringbuf_wchar *this, { TRACE("(%p %p %s %d)\n", this, ret, debugstr_fpos_int(&pos), mode); - if(pos.off==0 && pos.pos==-1 && pos.state==0) { + if(pos.off==-1 && pos.pos==0 && pos.state==0) { *ret = pos; return ret; } @@ -5610,7 +5610,7 @@ basic_ostream_char* __thiscall basic_ostream_char_seekp(basic_ostream_char *this basic_streambuf_char_pubseekoff(basic_ios_char_rdbuf_get(base), &seek, off, way, OPENMODE_out); - if(seek.off==0 && seek.pos==-1 && seek.state==0) + if(seek.off==-1 && seek.pos==0 && seek.state==0) basic_ios_char_setstate(base, IOSTATE_failbit); } return this; @@ -5630,7 +5630,7 @@ basic_ostream_char* __thiscall basic_ostream_char_seekp_fpos(basic_ostream_char basic_streambuf_char_pubseekpos(basic_ios_char_rdbuf_get(base), &seek, pos, OPENMODE_out); - if(seek.off==0 && seek.pos==-1 && seek.state==0) + if(seek.off==-1 && seek.pos==0 && seek.state==0) basic_ios_char_setstate(base, IOSTATE_failbit); } return this; @@ -5649,8 +5649,8 @@ fpos_int* __thiscall basic_ostream_char_tellp(basic_ostream_char *this, fpos_int basic_streambuf_char_pubseekoff(basic_ios_char_rdbuf_get(base), ret, 0, SEEKDIR_cur, OPENMODE_out); }else { - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; } return ret; @@ -6419,7 +6419,7 @@ basic_ostream_wchar* __thiscall basic_ostream_wchar_seekp(basic_ostream_wchar *t basic_streambuf_wchar_pubseekoff(basic_ios_wchar_rdbuf_get(base), &seek, off, way, OPENMODE_out); - if(seek.off==0 && seek.pos==-1 && seek.state==0) + if(seek.off==-1 && seek.pos==0 && seek.state==0) basic_ios_wchar_setstate(base, IOSTATE_failbit); } return this; @@ -6441,7 +6441,7 @@ basic_ostream_wchar* __thiscall basic_ostream_wchar_seekp_fpos(basic_ostream_wch basic_streambuf_wchar_pubseekpos(basic_ios_wchar_rdbuf_get(base), &seek, pos, OPENMODE_out); - if(seek.off==0 && seek.pos==-1 && seek.state==0) + if(seek.off==-1 && seek.pos==0 && seek.state==0) basic_ios_wchar_setstate(base, IOSTATE_failbit); } return this; @@ -6462,8 +6462,8 @@ fpos_int* __thiscall basic_ostream_wchar_tellp(basic_ostream_wchar *this, fpos_i basic_streambuf_wchar_pubseekoff(basic_ios_wchar_rdbuf_get(base), ret, 0, SEEKDIR_cur, OPENMODE_out); }else { - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; } return ret; @@ -7746,15 +7746,15 @@ fpos_int* __thiscall basic_istream_char_tellg(basic_istream_char *this, fpos_int ret, 0, SEEKDIR_cur, OPENMODE_in); basic_istream_char_sentry_destroy(this); - if(ret->off==0 && ret->pos==-1 && ret->state==0) + if(ret->off==-1 && ret->pos==0 && ret->state==0) basic_ios_char_setstate(base, IOSTATE_failbit); return ret; } } basic_istream_char_sentry_destroy(this); - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -7774,7 +7774,7 @@ basic_istream_char* __thiscall basic_istream_char_seekg(basic_istream_char *this basic_streambuf_char_pubseekoff(strbuf, &ret, off, dir, OPENMODE_in); - if(ret.off==0 && ret.pos==-1 && ret.state==0) + if(ret.off==-1 && ret.pos==0 && ret.state==0) basic_ios_char_setstate(base, IOSTATE_failbit); else basic_ios_char_clear(base, IOSTATE_goodbit); @@ -7801,7 +7801,7 @@ basic_istream_char* __thiscall basic_istream_char_seekg_fpos(basic_istream_char basic_streambuf_char_pubseekpos(strbuf, &ret, pos, OPENMODE_in); basic_istream_char_sentry_destroy(this); - if(ret.off==0 && ret.pos==-1 && ret.state==0) + if(ret.off==-1 && ret.pos==0 && ret.state==0) basic_ios_char_setstate(base, IOSTATE_failbit); else basic_ios_char_clear(base, IOSTATE_goodbit); @@ -9028,15 +9028,15 @@ fpos_int* __thiscall basic_istream_wchar_tellg(basic_istream_wchar *this, fpos_i ret, 0, SEEKDIR_cur, OPENMODE_in); basic_istream_wchar_sentry_destroy(this); - if(ret->off==0 && ret->pos==-1 && ret->state==0) + if(ret->off==-1 && ret->pos==0 && ret->state==0) basic_ios_wchar_setstate(base, IOSTATE_failbit); return ret; } } basic_istream_wchar_sentry_destroy(this); - ret->off = 0; - ret->pos = -1; + ret->off = -1; + ret->pos = 0; ret->state = 0; return ret; } @@ -9059,7 +9059,7 @@ basic_istream_wchar* __thiscall basic_istream_wchar_seekg(basic_istream_wchar *t basic_streambuf_wchar_pubseekoff(strbuf, &ret, off, dir, OPENMODE_in); basic_istream_wchar_sentry_destroy(this); - if(ret.off==0 && ret.pos==-1 && ret.state==0) + if(ret.off==-1 && ret.pos==0 && ret.state==0) basic_ios_wchar_setstate(base, IOSTATE_failbit); else basic_ios_wchar_clear(base, IOSTATE_goodbit); @@ -9088,7 +9088,7 @@ basic_istream_wchar* __thiscall basic_istream_wchar_seekg_fpos(basic_istream_wch basic_streambuf_wchar_pubseekpos(strbuf, &ret, pos, OPENMODE_in); basic_istream_wchar_sentry_destroy(this); - if(ret.off==0 && ret.pos==-1 && ret.state==0) + if(ret.off==-1 && ret.pos==0 && ret.state==0) basic_ios_wchar_setstate(base, IOSTATE_failbit); else basic_ios_wchar_clear(base, IOSTATE_goodbit); @@ -12829,7 +12829,7 @@ fpos_int* __thiscall strstreambuf_seekpos(strstreambuf *this, fpos_int *ret, fpo { TRACE("(%p %p %s %d)\n", this, ret, debugstr_fpos_int(&pos), mode); - if(pos.off==0 && pos.pos==-1 && pos.state==0) { + if(pos.off==-1 && pos.pos==0 && pos.state==0) { *ret = pos; return ret; }

1 0

Daniel Lehman : msvcp90: In istream<>::tellg don't use sentry.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: 01c451703c3de5e029a20cc19b6fc77e382ee700 URL: http://source.winehq.org/git/wine.git/?a=commit;h=01c451703c3de5e029a20cc19… Author: Daniel Lehman <dlehman(a)esri.com> Date: Mon Oct 1 10:54:36 2012 -0700 msvcp90: In istream<>::tellg don't use sentry. --- dlls/msvcp90/ios.c | 55 +++++++++++------------- dlls/msvcp90/tests/ios.c | 104 ++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 129 insertions(+), 30 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=01c451703c3de5e029a20…

1 0

Daniel Lehman : msvcp: Sync fpos usage and istream<>::tellg.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: a49da3ca5d8bef49dc4ff7694690ca801e7811aa URL: http://source.winehq.org/git/wine.git/?a=commit;h=a49da3ca5d8bef49dc4ff7694… Author: Daniel Lehman <dlehman(a)esri.com> Date: Tue Oct 30 13:14:57 2012 -0700 msvcp: Sync fpos usage and istream<>::tellg. --- dlls/msvcp100/ios.c | 111 ++++++++++++++++++++++------------------------ dlls/msvcp60/ios.c | 119 ++++++++++++++++++++++++------------------------- dlls/msvcp71/ios.c | 123 +++++++++++++++++++++++++-------------------------- 3 files changed, 171 insertions(+), 182 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a49da3ca5d8bef49dc4ff…

1 0

Jacek Caban : advpack: Added ExtractFilesW implementation.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: 57b83719b7921c5af268fdfcff633012bf95c3b0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=57b83719b7921c5af268fdfcf… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 31 11:28:28 2012 +0100 advpack: Added ExtractFilesW implementation. --- dlls/advpack/advpack_private.h | 23 +++++++++++++++++++++++ dlls/advpack/files.c | 32 ++++++++++++++++++++++++++++++-- dlls/advpack/tests/files.c | 19 +++++++++++++++++++ 3 files changed, 72 insertions(+), 2 deletions(-) diff --git a/dlls/advpack/advpack_private.h b/dlls/advpack/advpack_private.h index cbbbf48..a1bcfe4 100644 --- a/dlls/advpack/advpack_private.h +++ b/dlls/advpack/advpack_private.h @@ -27,4 +27,27 @@ void set_ldids(HINF hInf, LPCWSTR pszInstallSection, LPCWSTR pszWorkingDir) DECL HRESULT launch_exe(LPCWSTR cmd, LPCWSTR dir, HANDLE *phEXE) DECLSPEC_HIDDEN; +static inline void *heap_alloc(size_t len) +{ + return HeapAlloc(GetProcessHeap(), 0, len); +} + +static inline BOOL heap_free(void *mem) +{ + return HeapFree(GetProcessHeap(), 0, mem); +} + +static inline char *heap_strdupWtoA(const WCHAR *str) +{ + char *ret = NULL; + + if(str) { + size_t size = WideCharToMultiByte(CP_ACP, 0, str, -1, NULL, 0, NULL, NULL); + ret = heap_alloc(size); + WideCharToMultiByte(CP_ACP, 0, str, -1, ret, size, NULL, NULL); + } + + return ret; +} + #endif /* __ADVPACK_PRIVATE_H */ diff --git a/dlls/advpack/files.c b/dlls/advpack/files.c index f6056f2..c34f6d5 100644 --- a/dlls/advpack/files.c +++ b/dlls/advpack/files.c @@ -779,11 +779,39 @@ done: HRESULT WINAPI ExtractFilesW(LPCWSTR CabName, LPCWSTR ExpandDir, DWORD Flags, LPCWSTR FileList, LPVOID LReserved, DWORD Reserved) { + char *cab_name = NULL, *expand_dir = NULL, *file_list = NULL; + HRESULT hres = S_OK; - FIXME("(%s, %s, %d, %s, %p, %d) stub!\n", debugstr_w(CabName), debugstr_w(ExpandDir), + TRACE("(%s, %s, %d, %s, %p, %d)\n", debugstr_w(CabName), debugstr_w(ExpandDir), Flags, debugstr_w(FileList), LReserved, Reserved); - return E_FAIL; + if(CabName) { + cab_name = heap_strdupWtoA(CabName); + if(!cab_name) + return E_OUTOFMEMORY; + } + + if(ExpandDir) { + expand_dir = heap_strdupWtoA(ExpandDir); + if(!expand_dir) + hres = E_OUTOFMEMORY; + } + + if(SUCCEEDED(hres) && FileList) { + file_list = heap_strdupWtoA(FileList); + if(!file_list) + hres = E_OUTOFMEMORY; + } + + /* cabinet.dll, which does the real job of extracting files, doesn't have UNICODE API, + so we need W->A conversion at some point anyway. */ + if(SUCCEEDED(hres)) + hres = ExtractFilesA(cab_name, expand_dir, Flags, file_list, LReserved, Reserved); + + heap_free(cab_name); + heap_free(expand_dir); + heap_free(file_list); + return hres; } /*********************************************************************** diff --git a/dlls/advpack/tests/files.c b/dlls/advpack/tests/files.c index 9bb8cde..4a985be 100644 --- a/dlls/advpack/tests/files.c +++ b/dlls/advpack/tests/files.c @@ -32,6 +32,7 @@ static HMODULE hAdvPack; static HRESULT (WINAPI *pAddDelBackupEntry)(LPCSTR, LPCSTR, LPCSTR, DWORD); static HRESULT (WINAPI *pExtractFiles)(LPCSTR, LPCSTR, DWORD, LPCSTR, LPVOID, DWORD); +static HRESULT (WINAPI *pExtractFilesW)(const WCHAR*,const WCHAR*,DWORD,const WCHAR*,void*,DWORD); static HRESULT (WINAPI *pAdvInstallFile)(HWND,LPCSTR,LPCSTR,LPCSTR,LPCSTR,DWORD,DWORD); static CHAR CURR_DIR[MAX_PATH]; @@ -44,6 +45,7 @@ static void init_function_pointers(void) { pAddDelBackupEntry = (void *)GetProcAddress(hAdvPack, "AddDelBackupEntry"); pExtractFiles = (void *)GetProcAddress(hAdvPack, "ExtractFiles"); + pExtractFilesW = (void *)GetProcAddress(hAdvPack, "ExtractFilesW"); pAdvInstallFile = (void*)GetProcAddress(hAdvPack, "AdvInstallFile"); } } @@ -468,6 +470,23 @@ static void test_ExtractFiles(void) ok(!DeleteFileA("dest\\a.txt"), "Expected dest\\a.txt to not exist\n"); ok(!DeleteFileA("dest\\testdir\\c.txt"), "Expected dest\\testdir\\c.txt to not exist\n"); ok(!RemoveDirectoryA("dest\\testdir"), "Expected dest\\testdir to not exist\n"); + + if(pExtractFilesW) { + static const WCHAR extract_cabW[] = {'e','x','t','r','a','c','t','.','c','a','b',0}; + static const WCHAR destW[] = {'d','e','s','t',0}; + static const WCHAR file_listW[] = + {'a','.','t','x','t',':','t','e','s','t','d','i','r','\\','c','.','t','x','t',0}; + + hr = pExtractFilesW(extract_cabW, destW, 0, file_listW, NULL, 0); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(DeleteFileA("dest\\a.txt"), "Expected dest\\a.txt to exist\n"); + ok(DeleteFileA("dest\\testdir\\c.txt"), "Expected dest\\testdir\\c.txt to exist\n"); + ok(RemoveDirectoryA("dest\\testdir"), "Expected dest\\testdir to exist\n"); + ok(!DeleteFileA("dest\\b.txt"), "Expected dest\\b.txt to not exist\n"); + ok(!DeleteFileA("dest\\testdir\\d.txt"), "Expected dest\\testdir\\d.txt to not exist\n"); + }else { + win_skip("ExtractFilesW not available\n"); + } } static void test_AdvInstallFile(void)

1 0

Michael Stefaniuc : usp10: Use FIELD_OFFSET to calculate the size of a struct with variable length array .
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: b4712d2e165979e8c77697a013d3e9c97eeb66ca URL: http://source.winehq.org/git/wine.git/?a=commit;h=b4712d2e165979e8c77697a01… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Oct 31 11:32:33 2012 +0100 usp10: Use FIELD_OFFSET to calculate the size of a struct with variable length array. --- dlls/usp10/opentype.c | 18 ++++++++++++------ 1 files changed, 12 insertions(+), 6 deletions(-) diff --git a/dlls/usp10/opentype.c b/dlls/usp10/opentype.c index 138890f..635b822 100644 --- a/dlls/usp10/opentype.c +++ b/dlls/usp10/opentype.c @@ -933,7 +933,8 @@ static INT GSUB_apply_ChainContextSubst(const OT_LookupList* lookup, const OT_Lo continue; TRACE("Matched Backtrack\n"); - ccsf3_2 = (const GSUB_ChainContextSubstFormat3_2 *)(((LPBYTE)ccsf1)+sizeof(GSUB_ChainContextSubstFormat3_1) + (sizeof(WORD) * (GET_BE_WORD(ccsf3_1->BacktrackGlyphCount)-1))); + ccsf3_2 = (const GSUB_ChainContextSubstFormat3_2 *)((BYTE *)ccsf1 + + FIELD_OFFSET(GSUB_ChainContextSubstFormat3_1, Coverage[GET_BE_WORD(ccsf3_1->BacktrackGlyphCount)])); indexGlyphs = GET_BE_WORD(ccsf3_2->InputGlyphCount); for (k = 0; k < indexGlyphs; k++) @@ -946,7 +947,8 @@ static INT GSUB_apply_ChainContextSubst(const OT_LookupList* lookup, const OT_Lo continue; TRACE("Matched IndexGlyphs\n"); - ccsf3_3 = (const GSUB_ChainContextSubstFormat3_3 *)(((LPBYTE)ccsf3_2)+sizeof(GSUB_ChainContextSubstFormat3_2) + (sizeof(WORD) * (GET_BE_WORD(ccsf3_2->InputGlyphCount)-1))); + ccsf3_3 = (const GSUB_ChainContextSubstFormat3_3 *)((BYTE *)ccsf3_2 + + FIELD_OFFSET(GSUB_ChainContextSubstFormat3_2, Coverage[GET_BE_WORD(ccsf3_2->InputGlyphCount)])); for (k = 0; k < GET_BE_WORD(ccsf3_3->LookaheadGlyphCount); k++) { @@ -958,7 +960,8 @@ static INT GSUB_apply_ChainContextSubst(const OT_LookupList* lookup, const OT_Lo continue; TRACE("Matched LookAhead\n"); - ccsf3_4 = (const GSUB_ChainContextSubstFormat3_4 *)(((LPBYTE)ccsf3_3)+sizeof(GSUB_ChainContextSubstFormat3_3) + (sizeof(WORD) * (GET_BE_WORD(ccsf3_3->LookaheadGlyphCount)-1))); + ccsf3_4 = (const GSUB_ChainContextSubstFormat3_4 *)((BYTE *)ccsf3_3 + + FIELD_OFFSET(GSUB_ChainContextSubstFormat3_3, Coverage[GET_BE_WORD(ccsf3_3->LookaheadGlyphCount)])); if (GET_BE_WORD(ccsf3_4->SubstCount)) { @@ -1421,7 +1424,8 @@ static INT GPOS_apply_ChainContextPos(LPOUTLINETEXTMETRICW lpotm, LPLOGFONTW lpl continue; TRACE("Matched Backtrack\n"); - ccpf3_2 = (const GPOS_ChainContextPosFormat3_2*)(((LPBYTE)ccpf3)+sizeof(GPOS_ChainContextPosFormat3_1) + (sizeof(WORD) * (GET_BE_WORD(ccpf3->BacktrackGlyphCount)-1))); + ccpf3_2 = (const GPOS_ChainContextPosFormat3_2*)((BYTE *)ccpf3 + + FIELD_OFFSET(GPOS_ChainContextPosFormat3_1, Coverage[GET_BE_WORD(ccpf3->BacktrackGlyphCount)])); indexGlyphs = GET_BE_WORD(ccpf3_2->InputGlyphCount); for (k = 0; k < indexGlyphs; k++) @@ -1434,7 +1438,8 @@ static INT GPOS_apply_ChainContextPos(LPOUTLINETEXTMETRICW lpotm, LPLOGFONTW lpl continue; TRACE("Matched IndexGlyphs\n"); - ccpf3_3 = (const GPOS_ChainContextPosFormat3_3*)(((LPBYTE)ccpf3_2)+sizeof(GPOS_ChainContextPosFormat3_2) + (sizeof(WORD) * (GET_BE_WORD(ccpf3_2->InputGlyphCount)-1))); + ccpf3_3 = (const GPOS_ChainContextPosFormat3_3*)((BYTE *)ccpf3_2 + + FIELD_OFFSET(GPOS_ChainContextPosFormat3_2, Coverage[GET_BE_WORD(ccpf3_2->InputGlyphCount)])); for (k = 0; k < GET_BE_WORD(ccpf3_3->LookaheadGlyphCount); k++) { @@ -1446,7 +1451,8 @@ static INT GPOS_apply_ChainContextPos(LPOUTLINETEXTMETRICW lpotm, LPLOGFONTW lpl continue; TRACE("Matched LookAhead\n"); - ccpf3_4 = (const GPOS_ChainContextPosFormat3_4*)(((LPBYTE)ccpf3_3)+sizeof(GPOS_ChainContextPosFormat3_3) + (sizeof(WORD) * (GET_BE_WORD(ccpf3_3->LookaheadGlyphCount)-1))); + ccpf3_4 = (const GPOS_ChainContextPosFormat3_4*)((BYTE *)ccpf3_3 + + FIELD_OFFSET(GPOS_ChainContextPosFormat3_3, Coverage[GET_BE_WORD(ccpf3_3->LookaheadGlyphCount)])); if (GET_BE_WORD(ccpf3_4->PosCount)) {

1 0

Michael Stefaniuc : user32: Avoid sizeof on structs with variable length array.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: 5f304e7000063f92c1e55c1def40640844179127 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5f304e7000063f92c1e55c1de… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Oct 31 11:34:10 2012 +0100 user32: Avoid sizeof on structs with variable length array. --- dlls/user32/exticon.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/dlls/user32/exticon.c b/dlls/user32/exticon.c index 840483c..5682c77 100644 --- a/dlls/user32/exticon.c +++ b/dlls/user32/exticon.c @@ -216,9 +216,6 @@ static BYTE * ICO_LoadIcon( LPBYTE peimage, LPicoICONDIRENTRY lpiIDE, ULONG *uSi * * Reads .ico file and build phony ICONDIR struct */ -#define HEADER_SIZE (sizeof(CURSORICONDIR) - sizeof (CURSORICONDIRENTRY)) -#define HEADER_SIZE_FILE (sizeof(icoICONDIR) - sizeof (icoICONDIRENTRY)) - static BYTE * ICO_GetIconDirectory( LPBYTE peimage, LPicoICONDIR* lplpiID, ULONG *uSize ) { CURSORICONDIR * lpcid; /* icon resource in resource-dir format */ @@ -233,7 +230,7 @@ static BYTE * ICO_GetIconDirectory( LPBYTE peimage, LPicoICONDIR* lplpiID, ULONG return 0; /* allocate the phony ICONDIR structure */ - *uSize = lpcid->idCount * sizeof(CURSORICONDIRENTRY) + HEADER_SIZE; + *uSize = FIELD_OFFSET(CURSORICONDIR, idEntries[lpcid->idCount]); if( (lpID = HeapAlloc(GetProcessHeap(),0, *uSize) )) { /* copy the header */

1 0

Jörg Höhle : winealsa: Fix capture overrun logging.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: c596ddffab5c41e4c5ab8afed63f1ae40627503d URL: http://source.winehq.org/git/wine.git/?a=commit;h=c596ddffab5c41e4c5ab8afed… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Wed Jan 25 22:53:21 2012 +0100 winealsa: Fix capture overrun logging. --- dlls/winealsa.drv/mmdevdrv.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c index 1c8b03a..9275fbc 100644 --- a/dlls/winealsa.drv/mmdevdrv.c +++ b/dlls/winealsa.drv/mmdevdrv.c @@ -2043,9 +2043,13 @@ static void alsa_read_data(ACImpl *This) nread = snd_pcm_readi(This->pcm_handle, This->local_buffer + pos * This->fmt->nBlockAlign, readable); + TRACE("read %ld from %u limit %lu\n", nread, This->held_frames + This->lcl_offs_frames, readable); if(nread < 0){ int ret; + if(nread == -EAGAIN) /* no data yet */ + return; + WARN("read failed, recovering: %ld (%s)\n", nread, snd_strerror(nread)); ret = snd_pcm_recover(This->pcm_handle, nread, 0);

1 0

Jörg Höhle : ntdll: Do not execute callbacks past DeleteTimer(INVALID_HANDLE_VALUE).
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: 602807c2a5afca3feba11b5f4d56f1c38cb48665 URL: http://source.winehq.org/git/wine.git/?a=commit;h=602807c2a5afca3feba11b5f4… Author: Jörg Höhle <hoehle(a)users.sourceforge.net> Date: Tue Mar 6 19:07:44 2012 +0100 ntdll: Do not execute callbacks past DeleteTimer(INVALID_HANDLE_VALUE). --- dlls/ntdll/threadpool.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/threadpool.c b/dlls/ntdll/threadpool.c index bd6e06b..81abac3 100644 --- a/dlls/ntdll/threadpool.c +++ b/dlls/ntdll/threadpool.c @@ -1015,7 +1015,11 @@ NTSTATUS WINAPI RtlDeleteTimer(HANDLE TimerQueue, HANDLE Timer, return STATUS_INVALID_PARAMETER_1; q = t->q; if (CompletionEvent == INVALID_HANDLE_VALUE) + { status = NtCreateEvent(&event, EVENT_ALL_ACCESS, NULL, SynchronizationEvent, FALSE); + if (status == STATUS_SUCCESS) + status = STATUS_PENDING; + } else if (CompletionEvent) event = CompletionEvent; @@ -1029,7 +1033,10 @@ NTSTATUS WINAPI RtlDeleteTimer(HANDLE TimerQueue, HANDLE Timer, if (CompletionEvent == INVALID_HANDLE_VALUE && event) { if (status == STATUS_PENDING) + { NtWaitForSingleObject(event, FALSE, NULL); + status = STATUS_SUCCESS; + } NtClose(event); }

1 0

Nikolay Sivov : dwrite: Support for Armenian, Hebrew and complete Arabic ranges.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: 368bc8aa5080a3bab338872bcea1983879d95cc1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=368bc8aa5080a3bab338872bc… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Oct 31 10:44:49 2012 -0400 dwrite: Support for Armenian, Hebrew and complete Arabic ranges. --- dlls/dwrite/analyzer.c | 8 +++++++- dlls/dwrite/tests/analyzer.c | 29 ++++++++++++++++++++++++++++- 2 files changed, 35 insertions(+), 2 deletions(-) diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c index 541914b..0a0642a 100644 --- a/dlls/dwrite/analyzer.c +++ b/dlls/dwrite/analyzer.c @@ -29,10 +29,12 @@ WINE_DEFAULT_DEBUG_CHANNEL(dwrite); enum scriptcode { Script_Arabic = 0, + Script_Armenian = 1, Script_C1Controls = 12, Script_Coptic = 13, Script_Cyrillic = 16, Script_Greek = 23, + Script_Hebrew = 29, Script_Latin = 38, Script_Symbol = 77, Script_Unknown = (UINT16)-1 @@ -79,8 +81,12 @@ static const struct script_range script_ranges[] = { /* Cyrillic Supplement range is incomplete cause it's based on Unicode 5.2 that doesn't define some Abkhaz and Azerbaijani letters, we support Unicode 6.0 range here */ { Script_Cyrillic, 0x400, 0x52f }, + /* Armenian: U+0530–U+058F */ + { Script_Armenian, 0x530, 0x58f }, + /* Hebrew: U+0590–U+05FF */ + { Script_Hebrew, 0x590, 0x5ff }, /* Arabic: U+0600–U+06FF */ - { Script_Arabic, 0x600, 0x6ef }, + { Script_Arabic, 0x600, 0x6ff }, /* unsupported range */ { Script_Unknown } }; diff --git a/dlls/dwrite/tests/analyzer.c b/dlls/dwrite/tests/analyzer.c index c610357..648759f 100644 --- a/dlls/dwrite/tests/analyzer.c +++ b/dlls/dwrite/tests/analyzer.c @@ -391,17 +391,19 @@ static IDWriteTextAnalysisSourceVtbl analysissourcevtbl = { static IDWriteTextAnalysisSource analysissource = { &analysissourcevtbl }; struct sa_test { - const WCHAR string[20]; + const WCHAR string[50]; int item_count; struct script_analysis sa[10]; }; enum scriptcode { Script_Arabic = 0, + Script_Armenian = 1, Script_C1Controls = 12, Script_Coptic = 13, Script_Cyrillic = 16, Script_Greek = 23, + Script_Hebrew = 29, Script_Latin = 38, Script_Symbol = 77 }; @@ -435,6 +437,14 @@ static struct sa_test sa_tests[] = { { { 0, 7, { Script_Arabic, DWRITE_SCRIPT_SHAPES_DEFAULT } }} }, { + /* Arabic */ + {0x0627,0x0644,0x0635,0x0651,0x0650,0x062d,0x0629,0x064f,' ',0x062a,0x064e, + 0x0627,0x062c,0x064c,' ',0x0639,0x064e,0x0644,0x0649,' ', + 0x0631,0x064f,0x0624,0x0648,0x0633,0x0650,' ',0x0627,0x0644, + 0x0623,0x0635,0x0650,0x062d,0x0651,0x064e,0x0627,0x0621,0x0650,0x06f0,0x06f5,0}, 1, + { { 0, 40, { Script_Arabic, DWRITE_SCRIPT_SHAPES_DEFAULT } }} + }, + { /* Arabic, Latin */ {'1','2','3','-','5','2',0x064a,0x064f,0x0633,0x0627,0x0648,0x0650,0x064a,'7','1','.',0}, 1, { { 0, 16, { Script_Arabic, DWRITE_SCRIPT_SHAPES_DEFAULT } }} @@ -505,6 +515,23 @@ static struct sa_test sa_tests[] = { {0x400,0x40f,0x410,0x44f,0x450,0x45f,0x460,0x481,0x48a,0x4f0,0x4fa,0x4ff,0x500,0x510,0x520,0}, 1, { { 0, 15, { Script_Cyrillic, DWRITE_SCRIPT_SHAPES_DEFAULT } }} }, + { + /* Armenian */ + {0x531,0x540,0x559,0x55f,0x570,0x589,0x58a,0}, 1, + { { 0, 7, { Script_Armenian, DWRITE_SCRIPT_SHAPES_DEFAULT } }} + }, + { + /* Hebrew */ + {0x5e9,0x5dc,0x5d5,0x5dd,0}, 1, + { { 0, 4, { Script_Hebrew, DWRITE_SCRIPT_SHAPES_DEFAULT } }} + }, + { + /* Hebrew */ + {'p','a','r','t',' ','o','n','e',' ',0x5d7,0x5dc,0x5e7,' ',0x5e9,0x5ea,0x5d9,0x5d9,0x5dd,' ','p','a','r','t',' ','t','h','r','e','e',0}, 3, + { { 0, 9, { Script_Latin, DWRITE_SCRIPT_SHAPES_DEFAULT } }, + { 9, 10, { Script_Hebrew, DWRITE_SCRIPT_SHAPES_DEFAULT } }, + { 19, 10, { Script_Latin, DWRITE_SCRIPT_SHAPES_DEFAULT } }} + }, /* keep this as end marker */ { {0} } };

1 0

Huw Davies : vbscript: The first day of the week should default to Sunday, not the system default.
by Alexandre Julliard 31 Oct '12

31 Oct '12

Module: wine Branch: master Commit: 908c2d44e1fdb2c3039e8505bd0269fedb3f0614 URL: http://source.winehq.org/git/wine.git/?a=commit;h=908c2d44e1fdb2c3039e8505b… Author: Huw Davies <huw(a)codeweavers.com> Date: Wed Oct 31 12:06:23 2012 +0000 vbscript: The first day of the week should default to Sunday, not the system default. --- dlls/vbscript/global.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c index 900242b..420a5a5 100644 --- a/dlls/vbscript/global.c +++ b/dlls/vbscript/global.c @@ -1426,7 +1426,7 @@ static HRESULT Global_FormatDateTime(vbdisp_t *This, VARIANT *arg, unsigned args static HRESULT Global_WeekdayName(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VARIANT *res) { - int weekday, first_day = 0, abbrev = 0; + int weekday, first_day = 1, abbrev = 0; BSTR ret; HRESULT hres;

1 0