- wine-devel - winehq.org

Re: gdiplus: When copying an image do not round pixel positions up.
by Vincent Povirk 28 Aug '12

28 Aug '12

I know this looks wrong, but it's there for a reason, and it matches the behavior of the other interpolations. In my tests, the center of a bitmap pixel is at an integral value, meaning that the pixel at (0,0) is a rectangle extending from (-0.5, -0.5) to (0.5, 0.5), and if you enlarge an image you do get out-of-bounds bits on the lower right. I'm pretty sure I also tested GdipDrawImageRect separately and got the same result.

2 7

re: xmllite: Store DTD processing mode in reader
by Dan Kegel 28 Aug '12

28 Aug '12

Alexandre Julliard wrote: > Explicit ok() calls are better than hiding them inside a macro. Uh-oh. Want me to get rid of this macro +#define CHECK_RET_ERRNO(ret, ex) \ + do { \ + ok(ret == ex, "ret is %d, expected %d\n", ret, ex); \ + ok(errno == ex, "errno is %d, expected %d\n", errno, ex); \ + } while (0) in http://source.winehq.org/patches/data/89349 ?

2 1

Re: [3/3] gdiplus: Make GdipMeasureCharacterRanges/GdipMeasureString/GdipDrawString add extra space around the text.
by Vincent Povirk 28 Aug '12

28 Aug '12

> These APIs use different logic for adding extra space, so at the moment > I don't see how gdip_format_string() can be used to do this in one place, > but if somebody has an idea how to do that - patches are welcome. That is highly unlikely, particularly given that MeasureCharacterRanges is the accepted practice for highlighting parts of a string. You should make sure you do your tests so the size in pixels is the em size of the font, or at least at a consistent size between them, as native may cut into the padding if hinting makes the characters proportionally larger (this is the point of having the padding, but for the record I think it is behavior that we shouldn't try to duplicate). Do you have a visual test program for this? I'd like to see something that draws a string overlayed with the measurements, to confirm that the functions are not consistent on Windows (or, if they are, confirm that they are consistent with your patch). If not, I'll write one and send you the source code. + /* FIXME: GenericTypographic format prevents extra margins */ Since no margins is the current behavior, won't that cause a regression? It should be fairly easy to include that exception. Then again, I think I've heard reports that GenericTypographic doesn't work.

2 10

Re: gdiplus: Use outside color from image attributes for an out of bounds pixel.
by Vincent Povirk 28 Aug '12

28 Aug '12

> if (src_pointf.X >= srcx && src_pointf.X < srcx + srcwidth && src_pointf.Y >= srcy && src_pointf.Y < srcy+srcheight) > *dst_color = resample_bitmap_pixel(&src_area, src_data, bitmap->width, bitmap->height, &src_pointf, imageAttributes, interpolation); > else > - *dst_color = 0; > + *dst_color = imageAttributes->outside_color; It's like this for a reason. This isn't out of the bounds of the source image, which is when imageAttributes would apply. This is out of the bounds of the parallelogram we're drawing, and we should be leaving that pixel alone.

1 0

Re: [PATCH 1/2] msvcrt: Detect UTF-8 mode
by Alexandre Julliard 27 Aug '12

27 Aug '12

Detlef Riekenberg <wine.dev(a)web.de> writes: > @@ -1286,6 +1288,17 @@ static int msvcrt_get_flags(const MSVCRT_wchar_t* mode, int *open_flags, int* st > case '+': > case ' ': > break; > + case ',': > + if (!memcmp(mode, encoding_utf8, sizeof(encoding_utf8)) ) > + { > + *open_flags |= MSVCRT__O_U8TEXT; > + *open_flags &= ~(MSVCRT__O_TEXT | MSVCRT__O_BINARY | MSVCRT__O_WTEXT | MSVCRT__O_U16TEXT); > + mode += (sizeof(encoding_utf8)/sizeof(MSVCRT_wchar_t)); > + } > + else > + FIXME("mode %s not supported\n", debugstr_w(mode -1)); Your string parsing needs more work. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: xmllite: Store DTD processing mode in reader
by Alexandre Julliard 27 Aug '12

27 Aug '12

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -350,34 +353,47 @@ static void test_reader_create(void) > HRESULT hr; > IXmlReader *reader; > IUnknown *input; > + DtdProcessing dtd; > > /* crashes native */ > if (0) > { > pCreateXmlReader(&IID_IXmlReader, NULL, NULL); > - pCreateXmlReader(NULL, (LPVOID*)&reader, NULL); > + pCreateXmlReader(NULL, (void**)&reader, NULL); > } > > - hr = pCreateXmlReader(&IID_IXmlReader, (LPVOID*)&reader, NULL); > - ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > + hr = pCreateXmlReader(&IID_IXmlReader, (void**)&reader, NULL); > + EXPECT_HR(hr, S_OK); > > test_read_state(reader, XmlReadState_Closed, -1, FALSE); > > + dtd = 2; > + hr = IXmlReader_GetProperty(reader, XmlReaderProperty_DtdProcessing, (LONG_PTR*)&dtd); > + EXPECT_HR(hr, S_OK); > + ok(dtd == DtdProcessing_Prohibit, "got %d\n", dtd); > + > + dtd = 2; > + hr = IXmlReader_SetProperty(reader, XmlReaderProperty_DtdProcessing, dtd); > + EXPECT_HR(hr, E_INVALIDARG); > + > + hr = IXmlReader_SetProperty(reader, XmlReaderProperty_DtdProcessing, -1); > + EXPECT_HR(hr, E_INVALIDARG); > + > /* Null input pointer, releases previous input */ > hr = IXmlReader_SetInput(reader, NULL); > - ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > + EXPECT_HR(hr, S_OK); Explicit ok() calls are better than hiding them inside a macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

Unused msvcp100 functions?
by Francois Gouget 27 Aug '12

27 Aug '12

There are a lot of msvcp100 functions that look like they are unused: * In string.c all of the MSVCP__String_base_*(), MSVCP_basic_string_*(), MSVCP_basic_string_wchar_*() and MSVCP_char_traits_*() functions, basic_string_w?char_replace_helper(). * In locale.c _Locinfo__Locinfo_ctor_bstr(), codecvt_{short,wchar}__Id_func(), collate_{char,short}__Getcat(), various ctype_*() functions, etc. * In ios.c, the basic_istream_*() and basic_ostream_*() functions, ios_base_Index_func() and ios_base_Sync_func(). * In math.c a lot of std_Ctraits_{double,float,long}_*() functions. Is it just that the spec file needs to catch up or that they will be used soon? I attached a more precise list of the suspects. I did not actually verify that all of them are unused but based on the ones I looked at it seems to be the case. If they are indeed unused and will remain so I can submit a patch to remove them. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: kernel32: Handle neutral locale names better in GetLocaleInfoEx
by Dmitry Timoshkov 27 Aug '12

27 Aug '12

Hi, Are you sure that GetLocaleInfo can't handle these cases on its own? -- Dmitry.

2 1

Re: [3/3] gdiplus: get_log_fontW helper requires a valid graphics object.
by Vincent Povirk 27 Aug '12

27 Aug '12

> + GdipFree(backup); I think you want GdipDeletePath. This seems very convoluted. Couldn't we just skip the size conversion in get_log_fontW when graphics is NULL? Any cases where the scaling would produce a size other than the em size need to be fixed in GdipAddPathString anyway.

2 2

Re: msxml3: Implement xmldecl-version property for a reader
by Marvin 27 Aug '12

27 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21252 Your paranoid android. === W2KPROSP4 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WXPPROSP3 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K3R2SESP2 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === WVISTAADM (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W2K8SE (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PRO (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === TEST64_W7SP1 (32 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 saxreader: unhandled exception c0000005 at 00443BC3 === W7PROX64 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout === TEST64_W7SP1 (64 bit saxreader) === saxreader.c:2365: Test failed: got 0x80040154, expected 0x00000000 Timeout

1 0

re: msvcr100: Add wmemmove_s and wmemcpy_s
by Dan Kegel 26 Aug '12

26 Aug '12

I asked Alexandre what http://source.winehq.org/patches/data/88732 needed before it could be reviewed. He said it needed to adapt to the recent parameter checking changes. I see that when he took my patch http://www.winehq.org/pipermail/wine-patches/attachments/20120728/bea2581d/… and committed it as http://source.winehq.org/git/wine.git/patch/49560458426cf25b6a36bbf9bad35aa… he could remove a few assignments to *MSVCRT__errno() because MSVCRT_CHECK_PMT now does that for you. But msvcr100's wmemmove_s/wmemcpy_s are different; they do not change errno. Tests in my patch confirm this. So changing msvcr100's CHECK_PMT macro to assign to errno doesn't seem appropriate. So, is there still anything that needs changing?

2 2

Re: About WineHQ Wiki
by Kyle Auble 26 Aug '12

26 Aug '12

Sorry if my replies come in large batches, I'm subscribed to the mailing list digest. Sun, 26 Aug 2012 10:08, Cheer Xiao wrote: > Hi all, > I'm a MoinMoin contributor, one of MoinMoin's participating students > in this year's Summer of Code. > 2012/8/26 Kyle Auble <randomidman48(a)yahoo.com>: >> Sat, 25 Aug 2012 14:44, Oleg Yarigin wrote: >>> When I edited pages in the WineHQ Wiki, I notised, its markup lankuage >>> isn`t so good as MediaWiki`s one. How do you think about moving the Wiki >>> into MediaWiki engine? Besides, moving each language section of the Wiki >>> into separated subdomain (like in Wikipedia) would be a good idea too. >> There are some pluggable parsers for Moinmoin, and there may be one >> that allows MediaWiki syntax. After going through and checking, >> categorizing, and editing so many pages, I definitely agree with your >> suggestion that each language be given a domain, instead of one flat >> namespace. Then maybe just add a single common "translation" menu to >> the side toolbar? > Indeed there is a MediaWiki parser[1]. > Also, take a look at MoinMoin 2.0[2]. It has multiple markups support > out of the box (including mediawiki of course). You can even mix them > in a single wiki instance - this is not necessarily a good idea, but > it helps when you have to migrate some content from another wiki by > hand. ... > Feature requests are welcome, but be noted that MoinMoin 2.0 is the > current development version (it's not a development "branch" since the > codebase is almost a total rewrite) and quite likely the feature you > want is already there (or a TODO). :) Hello, I'm glad to hear there's already a line of communication. Allowing people to use MediaWiki syntax will probably be a big plus. There have been performance problems, but I noticed both the Ubuntu and Moinmoin wikis are pretty snappy so I'm thinking it's due to a strained server and using an old version of Moinmoin (although the SystemInfo macro seems to be disabled, I ran across version info somewhere, and I think Wine Wiki is running Moinmoin 1.5 or 1.6). I'm not sure if other problems I've noticed have been fixed in v1.8 or 1.9 so I would have to try out those versions before checking against v2.0. One thing I have done is written up some python code to help convert HTML tables to Moinmoin ones. I checked in Moinmoin's script market, but could only find full-blown page converters, and their output was kind of messy. I probably got carried away, but I'll attach it to http://wiki.winehq.org/WineStatus because I'm using it to move WineHQ's static status pages to the wiki. I guess that would make it LGPL so if you want to salvage a few parts from it or have me submit it to your utility marketplace, just let me know. Sun, 26 Aug 2012 16:07, Andre Hentschel wrote: > Further it seems a bit more complicated with Wine, the moinmoin wiki is sponsored by http://lattica.com/ (whatever > sponsored means, didn't find further information) and the code > is not accessable via a wine git repo (maybe it should be in tools.git, website.git or its own). This also leads to the > fact that we still have no new wiki theme years after the > theme change on the website. > Now that we upgraded the Forum engine we (we as in laxdragon xD) could maybe do something about the wiki, it > needs love. > It seems Kyle is doing a good job at the content, but the content is not everything. Thank you for the compliment. I am actually planning on doing more coding soon, but besides ramping up, I though cleaning up the wiki some first would let me see where the different parts of the project are. Applying the theme from the rest of the WineHQ is on both the WikiToDo and my own list (no guarantees about how long I would take though). Sun, 26 Aug 2012 22:46, Cheer Xiao wrote: > And yes, as I noted in a previous post moin2 is *not* production-ready > yet and I don't suggest you jump ship now. :) > What I do strongly suggest, however, is that you upgrade to moin1.9 > first, since 1) there has been many security fixes[1] which are not > backported to old versions, and 2) upgrade to moin2 will only be > supported from moin1.9. Helping to upgrade the wiki is on my list somewhere between finishing a first round of polishing content and trying a couple of patches to Wine itself. Although the maintainer would actually have to deploy it, I could test and work some of the kinks out of the upgrade using a local install. Dimi Paun put a lot of work into setting up the wiki in the first place and is the maintainer at lattica. From the git logs and mail list, it seems like he has been really busy with other things for a while. At times, Jeremy Newman has raised the possibility of moving the wiki to WineHQ: http://www.winehq.org/pipermail/wine-devel/2006-June/048712.html I remember stumbling across another email too, but I can't find it right now. If it's still a possibilty, I think the first step would be somehow setting up datadumps so we could start on the upgrade. If there is already a feature for admins to do that, maybe Dimi could start putting a daily/weekly tarball on WineHQ's FTP site. If it requires a custom patch though, I could look into doing that too. -Kyle

1 0

Re: po: Update German translation
by Julian Rüger 26 Aug '12

26 Aug '12

Hi André, war ich zu langsam? ;) Das Komma ist an der Stelle grammatikalisch falsch, glaube ich. "Die verbundenen Controller" sollten auch Plural bleiben. Mein Vorschlag wäre irgendwie so etwas: "Nach dem De-/Aktivieren eines Gerätes wird die Liste der verbundenen Controller bis zum Neustart dieses Applets nicht [mehr] aktualisiert." Viele Grüsse, Julian Am Samstag, den 25.08.2012, 13:40 +0200 schrieb André Hentschel: > "After disabling or enabling a device, the connected joysticks won't be " > "updated here until you restart this applet." >-msgstr "" >+msgstr "Nach dem deaktivieren oder aktivieren eines Gerätes, wird der " >+"verbundene Controller hier bis zum Neustart des Applets nicht mehr " >+"aktualisiert."

1 1

Re: winhttp: disable TLSv1.1/1.2 by default
by Marcus Meissner 26 Aug '12

26 Aug '12

On Sun, Aug 26, 2012 at 11:50:15AM +0900, Hiroshi Miura wrote: > > Windows 7 disables TLSv1.1/1.2 by default. > This patch intend to behave same as Windows. Please do not... The newer TLSv1.x fix some shortcomings of the older TLS versions. Is there a specific problem you see? Otherwise, I object. Ciao, MArcus > Signed-off-by: Hiroshi Miura <miurahr(a)linux.com> > --- > dlls/winhttp/net.c | 74 > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > > > > diff --git a/dlls/winhttp/net.c b/dlls/winhttp/net.c > index 5ec4e1a..03cf9b7 100644 > --- a/dlls/winhttp/net.c > +++ b/dlls/winhttp/net.c > @@ -52,6 +52,7 @@ > #include "winbase.h" > #include "winhttp.h" > #include "wincrypt.h" > +#include "winreg.h" > > #include "winhttp_private.h" > > @@ -109,8 +110,10 @@ MAKE_FUNCPTR( SSL_load_error_strings ); > MAKE_FUNCPTR( SSLv23_method ); > MAKE_FUNCPTR( SSL_CTX_free ); > MAKE_FUNCPTR( SSL_CTX_new ); > +MAKE_FUNCPTR( SSL_CTX_ctrl ); > MAKE_FUNCPTR( SSL_new ); > MAKE_FUNCPTR( SSL_free ); > +MAKE_FUNCPTR( SSL_ctrl ); > MAKE_FUNCPTR( SSL_set_fd ); > MAKE_FUNCPTR( SSL_connect ); > MAKE_FUNCPTR( SSL_shutdown ); > @@ -408,12 +411,66 @@ static int netconn_secure_verify( int preverify_ok, X509_STORE_CTX *ctx ) > } > return ret; > } > + > +static long get_tls_option(void) { > + long tls_option; > + DWORD type, val, size; > + HKEY hkey,tls12_client,tls11_client; > + LONG res; > + const WCHAR Schannel_Prot[] = { /* SYSTEM\\CurrentControlSet\\Control\\SecurityProviders\\SCANNEL\\Protocols */ > + 'S','Y','S','T','E','M','\\', > + 'C','u','r','r','e','n','t','C','o','n','t','r','o','l','S','e','t','\\', > + 'C','o','n','t','r','o','l','\\', > + 'S','e','c','u','r','i','t','y','P','r','o','v','i','d','e','r','s','\\', > + 'S','C','H','A','N','N','E','L','\\', > + 'P','r','o','t','o','c','o','l','s',0 }; > + const WCHAR TLS12_Client[] = {'T','L','S',' ','1','.','2','\\','C','l','i','e','n','t',0}; > + const WCHAR TLS11_Client[] = {'T','L','S',' ','1','.','1','\\','C','l','i','e','n','t',0}; > + const WCHAR DisabledByDefault[] = {'D','i','s','a','b','l','e','d','B','y','D','e','f','a','u','l','t',0}; > + > + tls_option = SSL_OP_NO_SSLv2; /* disable SSLv2 for security reason, and secur32/Schannel(GnuTLS) don't support it */ > + res = RegOpenKeyExW(HKEY_LOCAL_MACHINE, > + Schannel_Prot, > + 0, KEY_READ, &hkey); > + if (res != ERROR_SUCCESS) { > + tls_option |= SSL_OP_NO_TLSv1_2; > + tls_option |= SSL_OP_NO_TLSv1_1; > + goto end; > + } > + if (RegOpenKeyExW(hkey, TLS12_Client, 0, KEY_READ, &tls12_client) == ERROR_SUCCESS) { > + size = sizeof(DWORD); > + if (RegQueryValueExW(tls12_client, DisabledByDefault, NULL, &type, (LPBYTE) &val, &size) || type != REG_DWORD) { > + tls_option |= SSL_OP_NO_TLSv1_2; > + } else { > + tls_option |= val?SSL_OP_NO_TLSv1_2:0; > + } > + RegCloseKey(tls12_client); > + } else { > + tls_option |= SSL_OP_NO_TLSv1_2; > + } > + if (RegOpenKeyExW(hkey, TLS11_Client, 0, KEY_READ, &tls11_client) == ERROR_SUCCESS) { > + size = sizeof(DWORD); > + if (RegQueryValueExW(tls11_client, DisabledByDefault, NULL, &type, (LPBYTE) &val, &size) || type != REG_DWORD) { > + tls_option |= SSL_OP_NO_TLSv1_1; > + } else { > + tls_option |= val?SSL_OP_NO_TLSv1_1:0; > + } > + RegCloseKey(tls11_client); > + } else { > + tls_option |= SSL_OP_NO_TLSv1_1; > + } > + RegCloseKey(hkey); > + > +end: > + return tls_option; > +} > #endif > > BOOL netconn_init( netconn_t *conn, BOOL secure ) > { > #if defined(SONAME_LIBSSL) && defined(SONAME_LIBCRYPTO) > int i; > + long tls_option; > #endif > > conn->socket = -1; > @@ -453,8 +510,10 @@ BOOL netconn_init( netconn_t *conn, BOOL secure ) > LOAD_FUNCPTR( SSLv23_method ); > LOAD_FUNCPTR( SSL_CTX_free ); > LOAD_FUNCPTR( SSL_CTX_new ); > + LOAD_FUNCPTR (SSL_CTX_ctrl); > LOAD_FUNCPTR( SSL_new ); > LOAD_FUNCPTR( SSL_free ); > + LOAD_FUNCPTR( SSL_ctrl ); > LOAD_FUNCPTR( SSL_set_fd ); > LOAD_FUNCPTR( SSL_connect ); > LOAD_FUNCPTR( SSL_shutdown ); > @@ -494,11 +553,20 @@ BOOL netconn_init( netconn_t *conn, BOOL secure ) > LOAD_FUNCPTR( sk_num ); > #undef LOAD_FUNCPTR > > +#define pSSL_CTX_set_options(ctx,op) \ > + pSSL_CTX_ctrl((ctx),SSL_CTRL_OPTIONS,(op),NULL) > +#define pSSL_set_options(ssl,op) \ > + pSSL_ctrl((ssl),SSL_CTRL_OPTIONS,(op),NULL) > + > pSSL_library_init(); > pSSL_load_error_strings(); > > method = pSSLv23_method(); > ctx = pSSL_CTX_new( method ); > + > + tls_option = get_tls_option(); > + pSSL_CTX_set_options(ctx, tls_option); > + > if (!pSSL_CTX_set_default_verify_paths( ctx )) > { > ERR("SSL_CTX_set_default_verify_paths failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > @@ -676,12 +744,18 @@ BOOL netconn_connect( netconn_t *conn, const struct sockaddr *sockaddr, unsigned > BOOL netconn_secure_connect( netconn_t *conn, WCHAR *hostname ) > { > #ifdef SONAME_LIBSSL > + long tls_option; > + > if (!(conn->ssl_conn = pSSL_new( ctx ))) > { > ERR("SSL_new failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > set_last_error( ERROR_OUTOFMEMORY ); > goto fail; > } > + > + tls_option = get_tls_option(); > + pSSL_set_options(conn->ssl_conn, tls_option); > + > if (!pSSL_set_ex_data( conn->ssl_conn, hostname_idx, hostname )) > { > ERR("SSL_set_ex_data failed: %s\n", pERR_error_string( pERR_get_error(), 0 )); > > >

1 0

Question about some Linux integration
by Oleg Yarigin 25 Aug '12

25 Aug '12

Hi! I have an idea to move some Wine parts into Linux subsystems. For instance, Wine apps windows and window content can be drawn with Desktop Manager via USER32.DLL opposite of using Wine Server. Similar thing can be with clipboard. I understand, it`s a big work, what is must to be started with an EXE loader. So I have a few questions before I can start: 1. Does Wine loader have any mechanism for loading .so files. 2. May I move all loader stuff from NTDLL to the loader. Is it rational? I asked, becouse there are a lot of stuff, that can be unloaded after program loading. And an off-top question: where is wine_server_call realisation defined? --- Oleg

2 2

About WineHQ Wiki
by Oleg Yarigin 25 Aug '12

25 Aug '12

Hi to all! When I edited pages in the WineHQ Wiki, I notised, its markup lankuage isn`t so good as MediaWiki`s one. How do you think about moving the Wiki into MediaWiki engine? Besides, moving each language section of the Wiki into separated subdomain (like in Wikipedia) would be a good idea too. --- Oleg

1 0

Re: [1/16] po: Update Russian translation
by Dmitry Timoshkov 24 Aug '12

24 Aug '12

These new translations look at least questionable to say the least. -- Dmitry.

2 1

Re: advapi32/tests: Skip a couple of registry tests on NT4 to avoid crashing it.
by Alexandre Julliard 24 Aug '12

24 Aug '12

Francois Gouget <fgouget(a)free.fr> writes: > I know it's bad form to test for the Windows version but I'm not sure > what other check would be relevant here. I think we can safely ignore such old versions at this point. -- Alexandre Julliard julliard(a)winehq.org

1 0

configure --with-osmesa fails to link
by Peter Urbanec 24 Aug '12

24 Aug '12

I just turned on --with-osmesa and configure fails for me: > checking for -lOSMesa... not found > configure: error: libOSMesa development files not found (or too old), > OpenGL rendering in bitmaps won't be supported. > This is an error since --with-osmesa was requested config.log output would suggest that perhaps the test is being treated as C code, but libOSMesa needs to link with C++ libs. > configure:9067: checking for -lOSMesa > configure:9092: gcc -o conftest -g3 -feliminate-unused-debug-symbols > -O0 -mtune=core2 conftest.c -lOSMesa -lSM -lICE -lXext -lX11 > -lm >&5 > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator delete[](void*)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator new(unsigned long)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_proc_address' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator delete(void*)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_dispatch_table_size' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `operator new[](unsigned long)' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `__cxa_pure_virtual' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `__gxx_personality_v0' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_get_context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__vmi_class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_add_dispatch' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_check_multithread' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_tls_Context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_set_context' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `vtable for __cxxabiv1::__si_class_type_info' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_set_dispatch' > /usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64/libOSMesa.so: > undefined reference to `_glapi_tls_Dispatch' > collect2: ld returned 1 exit status This is on Gentoo x64 with: media-libs/mesa-8.1_rc1_pre20120814 (classic egl g3dvl gallium llvm nptl osmesa shared-glapi vdpau xvmc -bindist -d3d -debug -gbm -gles1 -gles2 -kernel_FreeBSD -openvg -pax_kernel -pic -r600-llvm-compiler -selinux -video_cards_i915 -video_cards_i965 -video_cards_intel -video_cards_nouveau -video_cards_r100 -video_cards_r200 -video_cards_r300 -video_cards_r600 -video_cards_radeon -video_cards_radeonsi -video_cards_vmware -wayland -xa -xorg) sys-devel/gcc-4.6.3 (cxx fortran graphite mudflap multilib nls nptl openmp -altivec -bootstrap -build -doc -fixed-point -gcj -go -gtk -hardened -libssp -multislot -nocxx -nopie -nossp -objc -objc++ -objc-gc -test -vanilla) Any suggestions as to how this could be fixed? My autoconf skills are no match for this problem :-( Thanks.

3 3

Re: quartz/tests: Use proper method macros
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21196 Your paranoid android. === WNT4WSSP6 (32 bit memallocator) === memallocator.c:34: Test failed: Unable to create memory allocator 80040154

1 0

Re: wshom.ocx/tests: Use proper method macro
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21198 Your paranoid android. === WINEBUILD (build) === Can't determine base name

1 0

Re: [2/16] po: Update Russian translation
by Nikolay Sivov 24 Aug '12

24 Aug '12

On 8/24/2012 10:14, Oleg Yarigin wrote: > #: comctl32.rc:88 > msgid "&Add ->" > -msgstr "&Добавить ->" > +msgstr "&Добавить →" > #: comctl32.rc:89 > msgid "<- &Remove" > -msgstr "<- &Удалить" > +msgstr "← &Удалить" I don't think so. > #: comdlg32.rc:157 comdlg32.rc:179 > msgid "&Directories:" > -msgstr "&Каталоги:" > +msgstr "&Папки:" New translation is traditionally used for 'folders' mostly. I agree there's a mess in directory/folder/catalogue here though. > #: comdlg32.rc:223 > msgid "[none]" > -msgstr "[нет]" > +msgstr "(нет)" Why? > #: comdlg32.rc:282 > msgid "&Red:" > -msgstr "Крас&н:" > +msgstr "Крас&ный:" The reason was it doesn't fit a dialog template otherwise, did you check that? > #: comdlg32.rc:52 > msgid "Unreadable Entry" > -msgstr "Нечитаемый элемент" > +msgstr "Нераспознаваемый элемент" You translated 'unrecognised' instead of 'unreadable'. > #: comdlg32.rc:65 > msgid "Cannot find the printer." > -msgstr "Не удалось найти принтер." > +msgstr "Принтер не найден." However I like this kind of changes, it's a good example of keeping it short while it means the same. > #: comdlg32.rc:91 > msgid "Output tray is full; " > -msgstr "Лоток переполнен бумагой; " > +msgstr "Лоток для бумаги переполнен; " Could be "Лоток полон;" ... I can't comment on the rest of this series but there's a lot to fix already.

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21195 Your paranoid android. === WNT4WSSP6 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WXPPROSP3 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === WVISTAADM (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W2K8SE (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PRO (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (32 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === W7PROX64 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v === TEST64_W7SP1 (64 bit safearray) === safearray.c:564: Test failed: CTE VT_BSTR -> VT_UI1|VT_ARRAY failed with 80020008 safearray.c:565: Test failed: CTE BSTR -> VT_UI1|VT_ARRAY did not return VT_UI1|VT_ARRAY, but 8.v

1 0

Re: oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY
by Dmitry Timoshkov 24 Aug '12

24 Aug '12

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Changelog: > oleaut32: VaraintChangeType to support VT_BSTR to VT_UI2|VT_ARRAY Please resend the test separately, your fix conflicts with the patch sent by Roman Dadkov. -- Dmitry.

1 0

Re: dssenh/tests: Added key exchange tests for the DSSENH cryptographic service provider
by Marvin 24 Aug '12

24 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21186 Your paranoid android. === TEST64_W7SP1 (32 bit dssenh) === dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008 dssenh.c:1144: Test failed: Expected ERROR_INVALID_PARAMETER, got 80090008

1 0

Have there been any problems with Wine on GCC 4.7?
by Scott Ritchie 23 Aug '12

23 Aug '12

Wine is the last remaining package still depending on GCC 4.5 in the current Ubuntu alpha, it would be nice to drop GCC 4.5 and forward port Wine, however 4.6 is known to not work too well. But now we have 4.7 -- have there been any bugs attributed to its usage? Thanks, Scott Ritchie

4 15

Re: hhctrl.ocx: Make MergeChmProperties() static.
by Erich E. Hoover 23 Aug '12

23 Aug '12

I'm going to need MergeChmProperties() for HH_SET_WIN_TYPE. I've just been really busy lately and have not had a chance to cleanup my patches yet (from discussions with Jacek it looks like we need to redo storing HH_WINTYPE data a little bit). Erich

1 0

Re: [PATCH 1/3] dinput: Disable linuxinput or linux joysticks based on registry key (try 2)
by Alexandre Julliard 23 Aug '12

23 Aug '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "controllername(drivername)"="disabled" key > > Examples: > Disable the linux js driver for "Usb Controller" device > "Usb Controller(js)"="disabled" > > Disable the linux js and event drivers for "Other Controller" device > "OtherController(event)"="disabled" > "OtherController(js)"="disabled" That's better, thanks. You probably want to put them under a subkey though, to avoid mixing up the joystick names with the other configuration values. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 2/3] joy.cpl: Using joystick name suffixed with driver when in Linux (try 2)
by Alexandre Julliard 23 Aug '12

23 Aug '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > @@ -57,6 +57,34 @@ BOOL WINAPI DllMain(HINSTANCE hdll, DWORD reason, LPVOID reserved) > return TRUE; > } > > +static void get_joystick_name(struct Joystick *joy) > +{ > + /* Base product guids as Wine defines them in DirectInput */ > + /* 9e573ed9-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linux_guid = { 0x9e573ed9, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + /* 9e573eda-7734-11d2-8d4a-23903fb6bdf7 */ > + static const GUID linuxinput_guid = { 0x9e573eda, 0x7734, 0x11d2, {0x8d, 0x4a, 0x23, 0x90, 0x3f, 0xb6, 0xbd, 0xf7} }; > + static REFGUID wine_guids[] = { &linux_guid, &linuxinput_guid }; > + static const WCHAR wine_device_names[2][9] = { {'(','j','s',')','\0'}, {'(','e','v','e','n','t',')','\0'} }; I think dinput should be appending that to the returned name, joy.cpl shouldn't have to know about the specific naming scheme of the driver. -- Alexandre Julliard julliard(a)winehq.org

2 1

Testing Gdi+
by Stepa Nick 23 Aug '12

23 Aug '12

Hi! I`m new in WINE development. I have some tests cases, that works incorrect in current version of WINE and I want to fix this mistakes. So, I`m interesting are there some testing systems that compares bitmap(for example)? I look thru WINE tests, http://www.winehq.org/docs/winedev-guide/testing and had found only tests, that compare some variables to constant. I think, that WINE needs graphics test. Thanks.

2 1

Re: wine/server: removed obsolete one-iteration loop from request forming macro (try 2)
by Marcus Meissner 23 Aug '12

23 Aug '12

On Thu, Aug 23, 2012 at 11:14:23AM +0400, Oleg Yarigin wrote: > An original message was sent with wrong author`s name by mistake, so > I resend this patch with hope it was the only reason to reject it. It was not the only reason. A single loop is a common pattern in C to allow safe encapsulation and handling of blocks, or doing "break;"/"continue;" style things. One thing that it allows here in Wine is that the variable definitions are at the begin of a { } block and not in the middle of the code to allow old C standard builds to work still. There is no "break;" usage, although I spotted 1 "goto done;" which could be just a break; ;) The compiler will optimize everything of those loops away, so this change also brings no performance improvement. Ciao, Marcus > --- > include/wine/server.h | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) > > diff --git a/include/wine/server.h b/include/wine/server.h > index d573d1f..dcbc7fa 100644 > --- a/include/wine/server.h > +++ b/include/wine/server.h > @@ -124,19 +124,15 @@ static inline void *wine_server_get_ptr( client_ptr_t ptr ) > /* macros for server requests */ > > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ > - struct type##_request * const req = &__req.u.req.type##_request; \ > - const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > - memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > - __req.u.req.request_header.req = REQ_##type; \ > - __req.data_count = 0; \ > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ > + struct type##_request * const req = &__req.u.req.type##_request; \ > + const struct type##_reply * const reply = &__req.u.reply.type##_reply; \ > + memset( &__req.u.req, 0, sizeof(__req.u.req) ); \ > + __req.u.req.request_header.req = REQ_##type; \ > + __req.data_count = 0; \ > + (void)reply; > + > +#define SERVER_END_REQ > > > #endif /* __WINE_WINE_SERVER_H */ > -- 1.7.9.5 > > -- Open Linux Security Engineer Position at SUSE: http://bit.ly/Li4RbS

1 0

Re: configure.ac: provide a --disable-dwarf2 configure option
by Alexandre Julliard 22 Aug '12

22 Aug '12

Austin English <austinenglish(a)gmail.com> writes: > This should address the concerns from > http://bugs.winehq.org/show_bug.cgi?id=31501 I don't think that justifies adding a configure option, people shouldn't have to worry about that kind of detail. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wine/server: removed obsolete one-iteration loop from request forming macro
by Sergey Guralnik 22 Aug '12

22 Aug '12

On 2012-08-22 6:26, Архад wrote: > #define SERVER_START_REQ(type) \ > - do { \ > - struct __server_request_info __req; \ ... > - (void)reply; \ > - do > - > -#define SERVER_END_REQ \ > - while(0); \ > - } while(0) > + struct __server_request_info __req; \ ... > + (void)reply; > + > +#define SERVER_END_REQ Are you try at least to rebuild project with it? -- Sergey

1 0

Re: opengl32/test: do not pass NULL attrib list to wglCreatePBufferARB
by Marvin 22 Aug '12

22 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21127 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [3/3] gdiplus: GdipMeasureCharacterRanges should respect device units and transformations.
by Vincent Povirk 22 Aug '12

22 Aug '12

> GetTextExtentExPointW(hdc, string + index, range_start - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.X = bounds->X + range_size.cx; > + range_rect.X = bounds->X / args->rel_width + range_size.cx; > > GetTextExtentExPointW(hdc, string + index, range_end - index, > INT_MAX, NULL, NULL, &range_size); > - range_rect.Width = (bounds->X + range_size.cx) - range_rect.X; > + range_rect.Width = (bounds->X / args->rel_width + range_size.cx) - range_rect.X; Shouldn't you be scaling range_size.cx as well?

2 3

Re: user32: Don't limit time needed for WM_DDE_INITIATE processing.
by Alexandre Julliard 21 Aug '12

21 Aug '12

Piotr Caban <piotr(a)codeweavers.com> writes: > Current timeout is too small for Microsoft Office 2010 in some cases. > I've checked that DdeConnect succeeds on windows when it needs to wait > for 10 minutes. Are you sure that you want to remove the SMTO_ABORTIFHUNG flag? Does a hung process really prevent all DDE connections? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/3] dinput: Disable linuxinput or linux joysticks based on registry key
by Alexandre Julliard 21 Aug '12

21 Aug '12

Lucas Zawacki <lfzawacki(a)gmail.com> writes: > From: Lucas Fialho Zawacki <lfzawacki(a)gmail.com> > > In the form of "Disable Controllername"="driver" > > Examples: > Disable "Usb Controller"="js" disable linux js driver > Disable "OtherController"="event,js" disable linux js and event drivers That's a fairly complicated way to disable a given joystick. What you probably want is to give them a unique name and have a enable/disable value for each name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mountmgr.sys: For loop-mounted devices, use the backing file
by Alexandre Julliard 21 Aug '12

21 Aug '12

Alexandre Goujon <ale.goujon(a)gmail.com> writes: > As part of their copy protection, some games use some ioctl's to check some physical attributes. > Unfortunately, when using the loop device, some ioctl fail (like IOCTL_SCSI_GET_ADDRESS). > A simple fix is to use /path/to/the/file.ISO instead of /dev/loopX. Several places depend on this being a device. Besides, failing to get the SCSI address of a loop mount seems like correct behavior to me. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [PATCH] kernel32: add basic conditional variables support (try 2)
by Alexandre Julliard 21 Aug '12

21 Aug '12

Marcus Meissner <marcus(a)jet.franken.de> writes: > Hi, > > Started with patch from Austin, brought up to a point > where Adobe Lightroom 4.1 starts up. > > The synchronisation is probably not 100% correct and > not sufficiently atomic. Synchronization routines have to be 100% correct, half stubs are worse than no implementation at all. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] wined3d: Improve post-pixelshader blending test. (Try 2)
by Lucas Zawacki 20 Aug '12

20 Aug '12

Hello, this patch caused a regression with Rayman 2, all the text in the menus is rendered wrong now. Should I open a bug or is this email enough? A demo of the game can be downloaded here ftp://ftp.ubisoft.com/Rayman2/rayman2high.zip Screenshot: http://dl.dropbox.com/u/2701879/images/rayman2.png Regression test: a488e574497d674631b4036d4b179ce349ddb764 is the first bad commit commit a488e574497d674631b4036d4b179ce349ddb764 Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Wed Aug 15 00:38:26 2012 +0200 wined3d: Improve post-pixelshader blending test. :040000 040000 1a61c91a146de3e7a5206ccde1cc239fa0771e40 a9759ba603b3b52f2feccc716daff3d875a90b74 M dlls

2 1

Re: [6/7] d3dx9: Implement ID3DXConstantTable::SetMatrixPointerArray.
by Rico Schüller 20 Aug '12

20 Aug '12

On 20.08.2012 17:10, Józef Kucia wrote: > + if (desc.Class == D3DXPC_MATRIX_ROWS || desc.Class == D3DXPC_MATRIX_COLUMNS) > + { ... > + } > + else if (desc.Class == D3DXPC_SCALAR) Could you also set D3DXPC_VECTOR variables with this call? It should be easy to add a test for a scalar and a vector. But that may also be a separate patch. In general I think it would be fine to try to set all variable class and see which work / fail. That way you would also verify, that the non common way works too, which has no test, yet, but a implementation. This holds true for all the Set(Matrix/Vector/...) functions. That way you'd ensure that the setting is correct for the specific class. ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "c2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "r2x3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "vec3", matrix_pointer, 1); ID3DXConstantTable_SetMatrixPointerArray(ctable, device, "scalar", matrix_pointer, 1); Cheers Rico

1 0

Re: [3/7] d3dx9: ID3DXConstantTable::SetFloat shouldn't change the value of matrix and vector constants.
by Rico Schüller 20 Aug '12

20 Aug '12

On 20.08.2012 17:10, Józef Kucia wrote: > @@ -665,6 +666,31 @@ static void test_setting_basic_table(IDirect3DDevice9 *device) > out[8], out[9], out[10], out[11], > out[12], out[13], out[14], out[15]); > > + ID3DXConstantTable_SetFloat(ctable, device, "mvp", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable mvp: 0x%08x\n", res); You probably may save res (= ID3DXConstantTable_SetFloat) before checking it. Otherwise you are checking the same res value multiple times. > + ID3DXConstantTable_SetFloat(ctable, device, "f4", f); > + ok(res == D3D_OK, "ID3DXConstantTable_SetFloat failed on variable f4: 0x%08x\n", res); Cheers Rico

1 0

Re: [PATCH 1/2] oleaut32: Ensure that the right interface is passed to the callee in ITypeInfo::Invoke
by Alexandre Julliard 20 Aug '12

20 Aug '12

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -6509,6 +6510,38 @@ static HRESULT WINAPI ITypeInfo_fnInvoke( > { > prgpvarg[i] = src_arg; > } > + > + if((tdesc->vt == VT_USERDEFINED || (tdesc->vt == VT_PTR && tdesc->u.lptdesc->vt == VT_USERDEFINED)) > + && (V_VT(prgpvarg[i]) == VT_DISPATCH || V_VT(prgpvarg[i]) == VT_UNKNOWN)) { > + const TYPEDESC *userdefined_tdesc = tdesc; > + IUnknown *userdefined_iface; > + ITypeInfo *tinfo2; > + TYPEATTR *tattr; > + > + if(tdesc->vt == VT_PTR) > + userdefined_tdesc = tdesc->u.lptdesc; typelib.c: In function ‘ITypeInfo_fnInvoke’: typelib.c:6516:41: error: variable ‘userdefined_tdesc’ set but not used [-Werror=unused-but-set-variable] make[1]: *** [typelib.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Microsecond unit
by Francois Gouget 20 Aug '12

20 Aug '12

The microsecond unit is 'µs' and yet, in dlls/sane.ds/sane.rc, we define it as 'us' and then rely on the British and American English PO files to convert it to 'µs'. Why not put the right unit directly in the RC file? It's UTF-8 anyway... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ The software said it requires Win95 or better, so I installed Linux.

2 1

Re: kernel32: Add UTF-7 support. (try 4)
by Alex Henrie 20 Aug '12

20 Aug '12

Correction: I meant to write that try 4 exits the loop slightly faster when ending a base64 sequence, it has nothing to do with escaped plus signs which are handled a few lines earlier. -Alex

1 0

Re: [6/7] gdiplus: Add a test for extra space added by GdipMeasureString. Resend.
by Marvin 20 Aug '12

20 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21046 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: msctf: Call interface methods properly
by Marvin 20 Aug '12

20 Aug '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21043 Your paranoid android. === TEST64_W7SP1 (32 bit inputprocessor) === inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink inputprocessor.c:259: Test failed: Unexpected TextStoreACP_GetStatus sink

1 0

How to convert msvcp names to legible names?
by Bruno Jesus 19 Aug '12

19 Aug '12

Which is the roseta stone used to read all msvcp function names like "msvcp80.dll.??0?$basic_stringstream@GU?$char_traits@G@std@@V?$allocator@G@2@@std@@QAE@H@Z, aborting" as the real function name in source code? Thanks in advance, Bruno

3 2

Re: winedbg: Use standard fixed pitch UI font for the crash dialog.
by Dmitry Timoshkov 17 Aug '12

17 Aug '12

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > static void set_fixed_font( HWND dlg, UINT id ) > { > - HFONT hfont = (HFONT)SendDlgItemMessageW( dlg, id, WM_GETFONT, 0, 0); > - LOGFONTW font; > + HFONT hfont; > > - GetObjectW(hfont, sizeof(LOGFONTW), &font); > - font.lfPitchAndFamily = FIXED_PITCH; > - font.lfFaceName[0] = 0; > - hfont = CreateFontIndirectW(&font); > + hfont = GetStockObject( ANSI_FIXED_FONT ); > SendDlgItemMessageW( dlg, id, WM_SETFONT, (WPARAM)hfont, TRUE ); > } To clarify things a bit: current code uses empty font face name, and GDI uses "System" font in that case (regardless of requested FIXED_PITCH), which is absolutely not readable. ANSI_FIXED_FONT should use built-in "Courier", which is actually a FIXED_PITCH font and much more readable. -- Dmitry.

2 3

Re: [10/10] gdiplus: Filter tabs out until they are properly supported using stringformat.
by Vincent Povirk 17 Aug '12

17 Aug '12

This should probably be handled somehow by gdip_format_string. DrawDriverString doesn't have access to the StringFormat, and there's a good change that the native implementation really does draw tabs as squares. Also, MeasureCharacterRanges and MeasureString will have to account for tabstops. gdip_format_string already has logic to ignore certain characters, but it needs more thought as to how we can do that and keep the offsets passed to the callback accurate, and how to eventually pass information about tabs to the callback. If this does turn out to be a correct change for DrawDriverString (I predict that it is not), then MeasureDriverString should be updated as well.

2 1

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel