- wine-devel - winehq.org

Re: [PATCH 2/4] ieframe: Added more DoVerb tests
by Marvin 09 Jul '12

09 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19863 Your paranoid android. === WNT4WSSP6 (32 bit webbrowser) === webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3472: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3313: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3435: Test failed: Creating WebBrowser object failed: 80040154 webbrowser.c:3410: Test failed: Could not get WebBrowserV1 instance: 80040154 webbrowser: unhandled exception c0000005 at 0040AF8E === W2KPROSP4 (32 bit webbrowser) === webbrowser.c:2627: Test failed: expected GetOverridesKeyPath webbrowser.c:2632: Test failed: expected Invoke_SETSECURELOCKICON webbrowser.c:2633: Test failed: expected Invoke_FILEDOWNLOAD webbrowser.c:3052: Test failed: doc_disp == NULL webbrowser: unhandled exception c0000005 at 00402FCA

1 0

Re: [PATCH 1/8] hhctrl.ocx: Implement HH_CLOSE_ALL.
by Jacek Caban 09 Jul '12

09 Jul '12

Hi Erich, On 07/04/12 20:32, Erich E. Hoover wrote: > This series of patches is intended to fix the problems with HTML Help > associated with Bug #11303 (HtmlHelp causes problems in Elster). This > patch implements some of the framework required by the other patches > through implementing the HH_CLOSE_ALL functionality needed by the > application to safely shutdown the HTML Help windows on exit. The > framework provided in this patch is the ability to register specific > HTML Help windows (needed later to set and get window properties on > the fly). While it's not about this particular patch, I can see that you're changing hhctrl.ocx to the point where it has an useful API (as opposed to simple hh.exe-like help viewer). It is really nice to see, thanks. It would be great to have some tests for this. Please consider adding them (I'm sure you already have some code for testing, so I imagine it would be mostly integrating it with Wine test suite). Thanks, Jacek

2 2

App bundle patches for OS X
by Per Johansson 08 Jul '12

08 Jul '12

Hi, I think I've reached a committable stage for the application bundle code I took over from Steven Edwards last summer. But there are some controversial parts so I figured I'd ask the list first. The patch extracts all XDG specific parts of winemenubuilder into a separate file, and there is also a new file for app bundles. Which one is used is controlled by a dispatch table and is choosable in the registry. The new code reacts to the same events but instead of a .desktop file an app bundle is created, start menu is replicated at ~/Applications/Wine/. Associations are handled by modifying start.exe to make it able to receive the file to open using AppleEvent, and an app bundle execing start.exe is put in ~/Library/Wine/Associations/. The actual file name contains the associated extension but the display name is modified to be the application that will be launched. It should work out of the box, after you've installed this patch and run winemenubuilder -a you should be able to right click a text file and choose "Open with notepad" (there's a cache involved as well so you might also need to remove the wine fileassociations key in the registry). Commits can be found at https://github.com/morth/wine/commits/appbundle-proper (original commits are on the master branch). The major controversity is in the start.exe code (commit < https://github.com/morth/wine/commit/ec68ac2b2abc0a1d4559eb5490b1f12b21000e…>). It uses a private API to access the AppleEvent containing the file to open. I choose this way because: 1. The only official way to access this information is by using Objective-C, building a proper Mac application. 2. Another option was to use the deprecated Carbon, but would also take a lot of code to finish. IMO neither of the two are good options, which leaves either doing it this way or to ask Apple to open up the API. Unfortunately I don't think Apple will respond quickly to such a request. Now that 10.8 is close (maybe even GMed) it's very unlikely to happen before 10.9, and perhaps not even then without backing from a major developer (I suppose the wine project might count as a such). I've made sure to check with configure if the functions exist before calling, but it is of course not safe in case they change the signature. OTOH, I don't think that is overly likely to happen. Another thing to note is that the app bundle script will copy some environment variables when created (commit https://github.com/morth/wine/commit/58773927eb7da431ba47923d66768cd129e4da… function). The ones copied are: PATH, DYLD_FALLBACK_LIBRARY_PATH and WINEPREFIX. DYLD_FALLBACK_LIBRARY_PATH is needed or wine won't work much at all. PATH is copied because the default one is only /bin and /usr/bin, and on OS X wine is rarely in one of those locations but rather installed with MacPorts of fink or similar, which use non-default paths. Anyway, if I don't hear anything from the list I'll likely send in the commits. I suppose that will be a second chance to review them. Once again I'd like to mention that Steven Edwards did a major part of this code, thanks goes to him and also to the wine project as a whole, I really enjoy using it. Finally, I only work on this code once every few months or so, so if it's deemed that there's too many problems, anyone should feel free to pick up this code and make it done (it'd be nice if you notified me though). Regards, -- Per Johansson

1 0

Re-enable editing on the forum?
by Rosanne DiMesio 08 Jul '12

08 Jul '12

The main reason for disabling editing on the forum was the confusion it caused for mailing list users. Since the two are no longer connected, that is no longer an issue. Are there any objections to re-enabling editing on the forum? -- Rosanne DiMesio <dimesio(a)earthlink.net>

1 0

Re: [2/2] msxml3: Support xmlns[:*] attribute nodes intelligently.
by Nikolay Sivov 08 Jul '12

08 Jul '12

On 6/12/2012 11:55, Ulrik Dickow wrote: > Patch 2 of 2 from http://bugs.winehq.org/show_bug.cgi?id=26226 . > > > > + /* Emit appropriate fixme or warning in case of unsupported or invalid namespace. > + * The W3C spec would like us to exit earlier for attempts to redefine the namespace for > + * the reserved "xmlns" attribute or prefix (http://www.w3.org/TR/xml-names/#ns-decl), > + * likehttp://gdome2.cs.unibo.it/gtk-doc/gdome2-gdomeelement.html#GDOME-EL-SETATTRIBUTENS, > + * but since native msxml3 accepts anything here, it's safest to just continue with warning. > + */ The question is more like what libxml2 thinks about that. If it follows w3c here which is likely the question will be - won't it break somewhere internally in libxml2 code if we hack it that way? > + if(namespaceURI && namespaceURI[0] && node_type != NODE_ELEMENT) > + { > + if(node_type == NODE_ATTRIBUTE) > + switch((!strcmpW(name, xmlnsW) || > + !strncmpW(name, xmlnscW, sizeof(xmlnscW)/sizeof(WCHAR))) + > + !strcmpW(namespaceURI, w3xmlns)) Could you please simplify that, it's a bit hard to read. > + * Note: We would be more in line with the native msxml if we only detected a > + * redundancy/conflict for prefixes existing on the element itself (in element->ns > + * or in the linked list element->nsDef). But as long as our *_get_xml() doesn't > + * eliminate redundant namespace definitions in children, this behaviour may be > + * an advantage in some cases. As disadvantage is that we incorrectly regard the > + * redefinition in element 'b' in '<a xmlns="x"><b xmlns="y"/></a>' as a conflict. > + * Libxml2 currently doesn't have a function or option to only search for namespaces > + * on the current node; but it would be easy to make a reduced version of xmlSearchNs > + * (currently defined inhttp://git.gnome.org/browse/libxml2/tree/tree.c#n5871). > + * However, most apps probably set the ns to y on node b creation, so no conflict here. > + * I don't think it's better to potentially break one thing while fixing the other. And I guess I like a thought on making xmlSearchNs version that will do what we want from it. Just to clarify - is that right that libxml2 problem here is a lack of some checks that lead to duplication and conflicts later? (that are visible in doc dumps too) > +/* Convenient helper function for creating an attribute node in a given namespace. > + * Note: CHECK_HR() should not be here, but in caller, to give optimal line number info. > + */ You mean EXPECT_HR here I guess. > +static HRESULT create_attribute_ns( > + IXMLDOMDocument *doc, > + const char *attr_name, > + const char *nsURI, > + IXMLDOMAttribute **attr_ptr) > +{ > + HRESULT hr; > + VARIANT var; > + IXMLDOMNode *node; > + > + V_VT(&var) = VT_I1; > + V_I1(&var) = NODE_ATTRIBUTE; > + > + hr = IXMLDOMDocument_createNode(doc, var,_bstr_(attr_name),_bstr_(nsURI), &node); > + if (hr == S_OK) > + { > + IXMLDOMNode_QueryInterface(node, &IID_IXMLDOMAttribute, (void**) attr_ptr); > + IXMLDOMNode_Release(node); > + } > + return hr; > +} Please null out pointer in case of failure, or better always before createNode().

2 4

winebuild port to ARM?
by Roger Cruz 07 Jul '12

07 Jul '12

Has anyone worked or is currently working on porting the x86 specific code in Winebuild to ARM? Specifically the relay.c file? Thanks Roger R. Cruz

2 9

Re: [PATCH] ntdll: Add stubs for WinSqmStartSession / WinSqmEndSession
by André Hentschel 07 Jul '12

07 Jul '12

Am 07.07.2012 01:08, schrieb Detlef Riekenberg: > It was to simple for a stub. > I added more parameter, until the 32-Bit app stopped crashing. > > -- > By by ... Detlef > --- > dlls/ntdll/rtl.c | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > > diff --git a/dlls/ntdll/rtl.c b/dlls/ntdll/rtl.c > index 34869e7..ec35a23 100644 > --- a/dlls/ntdll/rtl.c > +++ b/dlls/ntdll/rtl.c > @@ -1310,3 +1310,21 @@ BOOL WINAPI RtlSetCurrentTransaction(HANDLE new_transaction) > FIXME("(%p) :stub\n", new_transaction); > return FALSE; > } > + > +/****************************************************************************** > + * WinSqmEndSession [NTDLL.@] > + */ > +NTSTATUS WINAPI WinSqmEndSession(void *unknown1) > +{ > + FIXME("(%p) :stub\n", unknown1); > + return STATUS_NOT_IMPLEMENTED; > +} > + > +/****************************************************************************** > + * WinSqmStartSession [NTDLL.@] > + */ > +NTSTATUS WINAPI WinSqmStartSession(void *unknown1, void *unknown2, void *unknown3) > +{ > + FIXME("(%p, %p, %p) :stub\n", unknown1, unknown2, unknown3); > + return STATUS_NOT_IMPLEMENTED; > +} > You forgot the spec update. -- Best Regards, André Hentschel

1 0

Debugging wine/windows applications
by John Yani 07 Jul '12

07 Jul '12

I tried to run wine under gdb and failed. Using multiprocess gdb I endup with weird trace: 0xf7ffd430 0x7bc846f9 0x7bc8480f 0x7bc84855 0x7bc42a94 0x7bc433b1 0x7b8772f7 0x7ebab89b 0x7bc80014 0x7bc8005d Where 0x7****** addresses are not connected to any module. And 0xf****** addresses are from /lib/ld-linux.so.2, debug symbols for which I can't find. Can somebody explain what's hapenning? Running wine with winedbg under gdb fails with message "err:module:LdrInitializeThunk Main exe initialization for L"C:\\windows\\system32\\notepad.exe" failed, status c0000022" Is there any tutorial on how to run wine with applications under gdb?

2 10

Policy for the Wiki?
by Kyle Auble 07 Jul '12

07 Jul '12

Hello all, I've been working on the wiki recently and noticed that a lot of out-of-date or redundant information is retained. For example, completed tasks on to-do lists are checked off and never removed. Isthere an unofficial policy of not deleting info, even if it may exist elsewhere (in the git repo history, wikipage revision history, etc)? Other instances might be stubs dedicated to features in development years ago, or pages on bugs that have already been fixed or triaged in Bugzilla.I know even page deletions can still be reverted, but I wanted to check first before cleaning things out more aggressively. If there are a few unwritten rules everyone likes the wiki to follow, I could add them somewhere as editing guidelines. While the topic's up, I was also wondering how moinmoin was chosen as the wiki engine. I couldn't really find a discussion on the mailing lists so I figured it was the best option when the wiki was first started. I can appreciate that it doesn't require a database and it's written in python instead of php. Allowing only inline CSS in tables causes some headaches, but mainly it can be really slow sometimes, especially when editing, and unless using wikilinks or going directly to a page, navigation is tricky. Has the possibility of migrating the wiki to a different engine ever come up? Or does the Wine wiki code just need some tweaking and maybe some tools? To be honest, I don't know if there is a better alternative (MediaWiki is designed for a very different use case and has really messy code). It just seems like something is discouraging even basic upkeep on the wiki, which kind of defeats its whole purpose. -Kyle

2 2

Building Wine on amd64 FreeBSD?
by Hilko Bengen 06 Jul '12

06 Jul '12

Following Marcus Meissner's advice how to build a WoW64 setup (thanks!), I have succeeded in building a set of co-installable i386/amd64 Debian packages. Those won't make it into the "wheezy" release as I was just a bit late for the freeze, but I have uploaded packages to experimental. What didn't work was building the 64-bits of wine on Debian/kfreebsd-amd64 (Debian userland including GNU libc on a FreeBSD kernel): <https://buildd.debian.org/status/fetch.php%3Fpkg%3Dwine%26arch%3Dkfreebsd-a…> Apparently the reason is that the uc_mcontext structure does not store the DS, ES, FS, and GS registers. After I made the changes below, everything compiled, but how useful is the result? Are those registers contained in uc_mcontext on "plain" FreeBSD? Cheers, -Hilko

2 1

Re: kernel32: add a stub for WerSetFlags
by Dmitry Timoshkov 05 Jul '12

05 Jul '12

Austin English <austinenglish(a)gmail.com> wrote: > +HRESULT WINAPI WerSetFlags(DWORD flags) > +{ > + FIXME("(%d) stub!\n", flags); > + return E_NOTIMPL; > +} 1. 'flags' is unsigned 2. if it's supposed to be bit flags then printing it in decimal is not helpful. -- Dmitry.

1 0

"winetricks dotnet40" fails verifier because System.EnterpriseServices.Wrapper.dll missing?
by Dan Kegel 05 Jul '12

05 Jul '12

With current git, when I try rm -rf .wine sh winetricks -q dotnet40 sh winetricks -q dotnet_verifier wine netfx_setupverifier.exe the verifier reports failure: ... [07/04/12,21:45:13] ****ERROR**** File C:\windows\Microsoft.NET\assembly\GAC_32\System.EnterpriseServices\v4.0_4.0.0.0__b03f5f7f11d50a3a\System.EnterpriseServices.Wrapper.dll is not installed on the system ... [07/04/12,21:45:15] ****ERROR**** Verification failed for product .NET Framework 4 Client That file does seem to be on disc, but somewhere else: c:/windows/Microsoft.NET/Framework/v4.0.30319/System.EnterpriseServices.Wra… Not sure how serious it is that that's misplaced. Have other folks seen this? - Dan

1 0

[PATCH] winepulse.drv: Add PulseAudio driver
by Joerg-Cyril.Hoehle＠t-systems.com 04 Jul '12

04 Jul '12

Hi, >If you don't paste all the mmdevapi tests with the fix in my git tree, it's a >regression. I don't want to see held_Frames because it's a shadow buffer. >If winmm and dsound don't work without it, they're wrong, fix those. I won't comment on the two individual pulseaudio drivers. Unfortunately, none of the two authors bothered to point me to a verbose log of the mmdevapi tests for my scrutiny. The tests should pass like they do on native. Regarding latency, I'm not aware of a flaw in Wine's winmm. HOWEVER, Wine's DSound needs a patch. Here the reason. To recap, latency is somehow related to the "distance" between what one hears and the PCM frames sent to the device. GetPosition is the only API call in that area in both winmm and mmdevapi. Buffer size is a completely different thing. I find it useful to have in mind a cascade of audio filters performing some buffering each. Then it's obvious that an app only sees the frontmost buffer size and knows nothing about the others. High latencies imply that there must be some large buffer space(s), somewhere. Period is an artificial entity related to how often the frontmost buffer is drained to feed the next buffer in the chain, in case that happens regularly. This is not guaranteed nor necessarily documented. You get the idea: regardless of arbitrary (front) buffer sizes and periods not worth this name, try and send a stable flow of data to play music without glitches and let explosions be heard ASAP. So far the situation, now the issue. It appears easier to write code that provides (frontmost) buffer space behaviour similar to native than one that provides similar latency. Alas, behaviour observable on MS-Windows differs from what we get with PulseAudio and some ALSA devices. Tests seem to indicate a latency of around 30-70ms from mmdevapi with MS-Windows. That good enough for games. OTOH if ALSA or PA gives us 2 seconds on Linux, that's a big cause of trouble. The authors of MS apps could never test them in an environment with such high latency. What happens with software not tested? It happens not to work. Two solutions: - Reduce actual latency or - lie about latency. Lying about latency causes apps to loose the ability to sync audio and video. However, given a choice between loss of lip sync and possible crashes or other weird behaviour because an app is executed in a environment that its developers never experienced, I consider the loss of lip sync to be less worrying. We designed the winealsa driver to accomodate an arbitrary latency and accept a large variation of periods. (Some bug report from Jack users seem to imply that it should accept even larger periods, e.g. 150ms, yet still pretend to use 10ms on the mmdevapi side). We choose to have the winealsa driver not lie about latency. That should be left to high level APIs. DirectSound is built around the "Direct" HW (lack of) abstraction: a circular buffer of samples is played by a DAC. The converted signal is immediately sent to the speaker. Hence: 1. GetPosition information in the DSound abstraction translates to a "playpos" -- well known. 2. No provision is made for additional buffering. The playpos must lie within the circular buffer. The reported free (writable) space shall never cross the playpos -- with subtle consequences. Wine's DSound needs a patch to ensure this second property. Given a 80ms primary buffer, Wine's DSound must not pretend its playpos is 2 seconds late! I think Wine should try and reduce latency but lie if that does not suffice. What's needed? 1. Have DSound always use a buffer large enough for typical situations (I believe 100-200ms). 2. Clamp the reported position such that it won't leave the (virtual) primary buffer. As a result, DSound must pretend to play even when Wine is solely pumping the huge 2s of cascading SW audio buffers. 3. Work on reducing the latency of the cascading audio filters. That device-level work is independent on the DSound one. Native's 30-70ms has the benefit that it nicely fits within typical DSound primary buffer sizes. PulseAudio's 2s does not (yet). I believe a total 80ms latency would be acceptable with games. Further areas of investigation and effort: - Maybe clamp latency in the mmdevapi drivers after all? After all, huge latencies are known to cause dead-locks in apps and we don't know what all apps or libraries built atop mmdevapi or winmm expect. (If yes, to what value? 150% buffer size?) - Try and find MS setups with huge latencies. USB headphones are said to be candidates, but I've yet to see an excellent and trustworthy report about what happens in that case. - Work on reducing the cascades of audio buffers - Work on further decoupling mmdevapi periods from UNIX audio API ones - Research the trade-off between glitch free playback and buffering in UNIX. The current settings in Wine's audio are IMHO not good enough yet. Regards, Jörg Höhle

2 1

Re: [1/4] gdiplus: Add a test for font and graphics using different base units. Resend.
by Vincent Povirk 04 Jul '12

04 Jul '12

> +todo_wine > + expectf(102.499985, bounds.Width); Please don't hard-code string widths in your tests. It's not likely or desirable to get them exactly right.

2 1

New Wine Gecko 1.7-beta1
by Jacek Caban 04 Jul '12

04 Jul '12

Hi all, It's a bit sooner for another Gecko update than usually. This is caused by the fact, that many existing bugs in our MSHTML are blocked by another bugs, which require Gecko changes for proper fix. These changes enable using Gecko's cycle collector to understand our objects. This solves quite a few problems. The update also contains merged Firefox 14 beta changes. To test it, download Wine Gecko [1] and install it as usually [2]. You will also need the attached patch. The patch contains not only Gecko API changes, but also partial (but substantial enough for test to be meaningful) support for cycle collector in MSHTML. You may find some bugs already fixed by this patch. Any help with testing will be appreciated. Thanks, Jacek [1] http://sourceforge.net/projects/wine/files/Wine%20Gecko/1.7-beta1/ [2] http://wiki.winehq.org/Gecko

1 0

Re: League of Legends patches
by Dan Kegel 04 Jul '12

04 Jul '12

On Tue, Jul 3, 2012 at 1:08 AM, Andrea Canciani <ranma42(a)gmail.com> wrote: > I tried to follow the http://wiki.winehq.org/SubmittingPatches > guidelines, but this is my first submission to wine, so I guess the > patches might need further improvement. > Please point out any issues that need fixing. On an administrivial note, you should send one patch per email to wine-patches. Do you think you could write a test that (semi-)reliably causes the deadlock you're fixing? > The patches have been tested by Dan Kegel (in CC) and are currently > being used by many MacOSX and Linux users to run LoL. Our emails may have crossed - with these patches applied, dlls/ieframe/tests/webbrowser.ok seems to crash here: Unhandled exception: privileged instruction in 32-bit code (0x02786624). Backtrace: =>0 0x02786624 (0x0032fcd8) 1 0x688e22db func_webbrowser+0x3ca() [dlls/ieframe/tests/webbrowser.c:3382] Otherwise the tests seem to pass. Thanks, Dan

3 3

Re: [3/4] gdiplus: Add some tests for GdipGetPropertyItemSize and GdipGetPropertyItem. Take 2.
by Marvin 04 Jul '12

04 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19764 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [4/4] gdiplus: Add a bunch of tests for TIFF image properties. Resend.
by Marvin 04 Jul '12

04 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19765 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 3/4] vbscript: Fixed function return crossing for loop
by Marvin 03 Jul '12

03 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19753 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Re: [PATCH 4/4] jscript: Added more apply and call tests
by Marvin 03 Jul '12

03 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19754 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 2/4] vbscript: Fixed 'exit do' statements crossing for in loops
by Marvin 03 Jul '12

03 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19752 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

1 0

Wine on the front page of Reddit
by Caleb Hearon 03 Jul '12

03 Jul '12

Hi all, In a conversation between myself (MaggotBrain on the forums) and Jarrex, I expressed some frustration that Blizzard had been banning Diablo III users who used Wine. He posted some of the excerpts I sent him from WineHQ, and it quickly got to 17 pages on Blizzard's forums. http://us.battle.net/d3/en/forum/topic/5978861022 Then it made the front page of Reddit with 25k votes! http://www.reddit.com/r/gaming/comments/vyc4z/linux_users_permanently_banne… It's likely a mistake on Blizzard's part. But I thought this might be interesting to some people here. It's amazing that this conversation I had while at work led to more widespread awareness of Wine (one of the top comments on Reddit asks what Wine is). And Wine hackers- great work, I've just finished playing 2 hours of Diablo III and it runs great. -Caleb

2 1

Re: [1/2] kernel32/tests: Improve some traces for the CreateTimerQueueTimer() tests.
by Marvin 03 Jul '12

03 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19733 Your paranoid android. === WVISTAADM (32 bit sync) === sync.c:924: Test failed: DeleteTimerQueueTimer sync.c:925: Test failed: ChangeTimerQueueTimer

2 1

user32: Add test for ComboBox repositioning behavior (try 2).
by Sergey Guralnik 03 Jul '12

03 Jul '12

Alexandre Julliard writes: >> @@ -5807,6 +5814,13 @@ static void test_combobox_messages(void) >> log_all_parent_messages--; >> ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a >> ComboBox", FALSE); >> >> + SetWindowLongPtr(combo, GWLP_WNDPROC, >> (LONG_PTR)combobox_hook_proc_2); >> + SendMessage(combo, CB_SETCURSEL, 0, 0); >> + SetWindowPos(combo, 0, 0, 0, 120, 130, >> SWP_NOZORDER|SWP_NOMOVE); >> + ret = SendMessage(combo, CB_GETCURSEL, 0, 0); >> +todo_wine >> + ok(ret == 1, "expected 1, got %ld\n", ret); >> + > > There's no reason to test just WM_SIZE when we have support for > testing > full sequences. Once again, what are you trying to test? I only try to test that combobox should send WM_SIZE to it's wndproc during WM_WINDOWPOSCHANGED handling. -- Sergey

2 1

Fwd: [GSoC Mentors] [Announce] 2012 GSoC Mentor Midterm Evaluations 9 July - 13 July
by Austin English 02 Jul '12

02 Jul '12

A friendly reminder for GSOC people. If you won't be able to submit your evaluation during the specified timeline, or have any other questions, please contact me privately. Cheers, Austin ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Fri, Jun 29, 2012 at 11:41 AM Subject: [GSoC Mentors] [Announce] 2012 GSoC Mentor Midterm Evaluations 9 July - 13 July To: Google Summer of Code Mentors List <google-summer-of-code-mentors-list(a)googlegroups.com> Hi GSoC 2012 Mentors and Org Admins, Per the program timeline [0], starting 9 July you will will be able to submit an evaluation of your student(s)' progress on their projects thus far. Here's some important info on midterm evaluations for those not familiar: Midterm evaluations are done via Melange [1]. Starting at 19:00 UTC on 9 July you will be able to submit an evaluation for your student(s).You can find the evaluation links on your dashboard under 'Evaluations', one for each student you are a mentor (or co-mentor) for. If you are curious about who can see evaluations after they are submitted, please check out the FAQ on Evaluations [2]. I have also pre-published the evaluation questions below in this email so you can prepare. The deadline is 19:00 UTC on 13 July. You may not submit your evaluation before or after the evaluation window. Please ask your org admin to submit your evaluation for you if you absolutely cannot submit yours during the time allotted. Primary mentors, co-mentors, and org admins may all submit evaluations of their students.**Students must have an evaluation on file from both themselves *and* their mentors in order to receive their midterm payments.** There is no excuse for missing the submission of a student's evaluation. You must submit an evaluation for every student you are the primary mentor for this year. You must fill out the entire survey in one session as there's no auto-save in Melange. You may submit, modify, and resubmit an evaluation as many times as you choose up until the deadline. Please note that failing a student at the midterm evaluation means *this student is immediately removed from the program.* There is no way to fail a student at the midterm and have the student continue with the program to try to "make it up" at the final. If your student fails, your student is out. You might find the FLOSS manual on GSoC evaluations [3] helpful as well. There's some excellent wisdom in there from your fellow mentors and org admins on the evaluation process. Finally, a reminder: This year we will not allow any mentor who misses an evaluation deadline to attend the mentor summit (assuming no one else submits the evaluation on the mentor's behalf before the deadline either). Also, any org that misses 2 or more evaluation deadlines (for the midterm, final, or midterm and final combined) will not be invited to attend the mentor summit this year. Please let me know directly if you have questions or concerns. [0] - http://www.google-melange.com/gsoc/events/google/gsoc2012 [1] - http://google-melange.com [2] - http://www.google-melange.com/document/show/gsoc_program/google/gsoc2012/fa… [3] - http://www.booki.cc/gsoc-mentoring/evaluations/ Cheers, Carol ------------ How many years have you been a mentor for Google Summer of Code (Total - this doesn’t have to be consecutive)? This is my first year 2-3 years More than 3 years If you answered 2-3 years or more than 3 years, what years did you participate? How many years have you been a student in Google Summer of Code? I have never been a student 1 year 2 years 3+ years If you answered 1 year, 2 years, or 3+ years, what years did you participate? At what point did you first make contact with your student? Before the program was announced After my organization was selected to participate in Google Summer of Code During the student application/acceptance phase of the program During the community bonding period After the start of coding How often do you and your student interact? Daily Every few days Weekly Every few weeks Monthly How do you communicate with your student? (Check all that apply) Voice (phone, Skype, etc.) IM/IRC Private emails Mailing Lists Student blog updates In-person meeting(s) Google+ Hangout Other Of the communication methods listed above, which do you use most frequently? How much time do you spend on Google Summer of Code per week (take into consideration your interactions with your student as well as time working with your org and on your own). 1-5 hours 5-10 hours 10-15 hours 15-20 hours More than 20 hours per week How many time zones apart from your student are you? Less than 3 3-6 More than 6 How often do you require status updates from your student? Daily Every few days Weekly Only when explicitly asked for by me Please rate the quality of your interactions and communications with the student (consider his/her communication with you as well as your responses). Very Good (Student is regularly responsive and the quality of communication is high) Good (Student is somewhat responsive and the quality of communication is ok) Bad (Student is only somewhat or not at all responsive and the quality of communication is low) Please rate the quality of the student’s interactions with your organization and community. Very Good (Student is regularly responsive and the quality of communication is high) Good (Student is somewhat responsive and the quality of communication is ok) Bad (Student is only somewhat or not at all responsive and the quality of communication is low) Is your student on track to complete his/her project? The student has already completed his/her project He/she is ahead of schedule He/she is on schedule He/she is behind schedule Please rate the quality of code/work the student has produced thus far. Amongst the best people I’ve ever worked with Solid-quality performance Good performance Mediocre performance Disappointing or not performing at all Give an example of a very good or very bad interaction you had with your student. What one thing could you do to improve the quality of interaction and communications with your student? Anything else you’d like to tell us or suggestions on how we could improve the program? -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Mentors List" group. To post to this group, send email to google-summer-of-code-mentors-list(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-mentors-list+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-mentors-list?hl=en. -- -Austin

1 0

[1/2] comctl32: Fix message sequence when right-clicking a treeview
by Daniel Jelinski 02 Jul '12

02 Jul '12

Resend from last month

1 0

Re: msvcp90: Fix __cdecl functions definitions that returns structures
by Alexandre Julliard 02 Jul '12

02 Jul '12

Piotr Caban <piotr(a)codeweavers.com> writes: > In code produced by gcc callee removes hidden return argument. In code > produced by MS Visual Studio caller is responsible for removing the > hidden argument. That's only for structures larger than 8 bytes, which isn't the case at least for _Getcoll. Some tests would probably be a good idea. -- Alexandre Julliard julliard(a)winehq.org

2 2

Integer overflow problem in string::compare()
by Dan Kegel 02 Jul '12

02 Jul '12

Hi Piotr, could you review the patch in http://bugs.winehq.org/show_bug.cgi?id=31085 ? If you like it, I'll submit it to wine-patches. It passes winetestbot and gets pulsen and stepmania past the splash screen abort. Why are there no tests for msvcp60? If you think it's appropriate, I can add the fix and test for msvcp60 as well. Thanks for all your hard work! - Dan

2 2

Re: [PATCH] wined3d: Add a switch to preserve vertex buffer copy in system memory.
by Henri Verbeet 02 Jul '12

02 Jul '12

In general we don't do hacks like this.

2 1

Re: user32: Add test for ComboBox repositioning behavior (try 2).
by Alexandre Julliard 02 Jul '12

02 Jul '12

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -5807,6 +5814,13 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); > > + SetWindowLongPtr(combo, GWLP_WNDPROC, (LONG_PTR)combobox_hook_proc_2); > + SendMessage(combo, CB_SETCURSEL, 0, 0); > + SetWindowPos(combo, 0, 0, 0, 120, 130, SWP_NOZORDER|SWP_NOMOVE); > + ret = SendMessage(combo, CB_GETCURSEL, 0, 0); > +todo_wine > + ok(ret == 1, "expected 1, got %ld\n", ret); > + There's no reason to test just WM_SIZE when we have support for testing full sequences. Once again, what are you trying to test? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [7/7] msxml3: Add support for bin.hex element type encoding
by Marvin 02 Jul '12

02 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19704 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: quartz/tests: Add COM aggregation test for NullRenderer. (2nd try)
by Marvin 02 Jul '12

02 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19686 Your paranoid android. === WNT4WSSP6 (32 bit misc) === misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL

2 1

Re: [2/5] gdiplus: Add a test for 'value' pointer in the PropertyItem structure.
by Marvin 02 Jul '12

02 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19697 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

2 1

Re: [5/5] gdiplus: Add some tests for GdipGetPropertySize and GdipGetAllPropertyItems.
by Marvin 02 Jul '12

02 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19698 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [PATCH 05/13] quartz/tests: Add COM aggregation test for NullRenderer.
by Marvin 01 Jul '12

01 Jul '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19684 Your paranoid android. === WNT4WSSP6 (32 bit misc) === misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL misc.c:60: Test failed: CoCreateInstance failed with 80040154 misc.c:61: Test failed: pUnkOuter is NULL === W2KPROSP4 (32 bit misc) === misc.c:72: Test failed: CoCreateInstance returned 80040154 misc.c:78: Test failed: CoCreateInstance returned 80040154 misc.c:79: Test failed: pUnkInner is NULL misc.c:72: Test failed: CoCreateInstance returned 80040154 misc.c:78: Test failed: CoCreateInstance returned 80040154 misc.c:79: Test failed: pUnkInner is NULL

1 0

Re: Dmitry Timoshkov : gdiplus: Implement GdipGetPropertyItem.
by Dmitry Timoshkov 01 Jul '12

01 Jul '12

Alexandre Julliard <julliard(a)winehq.org> wrote: > Module: wine > Branch: master > Commit: 670445b22b9ce027bc35c40359499447ef4f8632 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=670445b22b9ce027bc35c4035… > > Author: Dmitry Timoshkov <dmitry(a)baikal.ru> > Date: Thu Jun 28 13:26:49 2012 +0900 > > gdiplus: Implement GdipGetPropertyItem. With this patch committed property reading support should be mostly complete, as well as support for multiframe images (on gdiplus side). -- Dmitry.

1 0

Re: [PATCH 2/2] qedit/tests: Add COM aggregation test for MediaDet.
by Marvin 30 Jun '12

30 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19677 Your paranoid android. === WNT4WSSP6 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587 === W2KPROSP4 (32 bit mediadet) === mediadet.c:149: Test failed: CoCreateInstance failed: 80040154 mediadet: unhandled exception c0000005 at 00401587

2 1

Release schedule
by Alexandre Julliard 30 Jun '12

30 Jun '12

Folks, Because of various travels and vacations (and just to keep you on your toes ;-), during the month of July I'm planning to make releases on Tuesdays instead of Fridays. So 1.5.8 will be on July 3rd, and then I'll be out for the rest of that week. Subsequent releases should happen on July 17th and 31st, and I'll also be out the first 10 days of August. And if you find this confusing, just take some vacations too ;-) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include/basetsd.h: Fix int64 to int truncation warnings when compiling with a 64-bit PSDK compiler.
by Michael Stefaniuc 30 Jun '12

30 Jun '12

Dmitry, afair the fix is to disable the int truncation warnings in MSVC. For whatever reason they seem to enable those bogus warnings. bye michael On 06/28/2012 12:12 PM, Dmitry Timoshkov wrote: > --- > include/basetsd.h | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index 698dd5c..4a59897 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -153,12 +153,12 @@ typedef unsigned int UHALF_PTR, *PUHALF_PTR; > > static inline ULONG32 HandleToULong(const void *h) > { > - return (ULONG_PTR)h; > + return (ULONG32)(ULONG_PTR)h; > } > > static inline LONG32 HandleToLong(const void *h) > { > - return (LONG_PTR)h; > + return (LONG32)(LONG_PTR)h; > } > > static inline void *ULongToHandle(ULONG32 ul) > @@ -173,32 +173,32 @@ static inline void *LongToHandle(LONG32 l) > > static inline ULONG32 PtrToUlong(const void *p) > { > - return (ULONG_PTR)p; > + return (ULONG32)(ULONG_PTR)p; > } > > static inline LONG32 PtrToLong(const void *p) > { > - return (LONG_PTR)p; > + return (LONG32)(LONG_PTR)p; > } > > static inline UINT32 PtrToUint(const void *p) > { > - return (UINT_PTR)p; > + return (UINT32)(UINT_PTR)p; > } > > static inline INT32 PtrToInt(const void *p) > { > - return (INT_PTR)p; > + return (INT32)(INT_PTR)p; > } > > static inline UINT16 PtrToUshort(const void *p) > { > - return (ULONG_PTR)p; > + return (UINT16)(ULONG_PTR)p; > } > > static inline INT16 PtrToShort(const void *p) > { > - return (LONG_PTR)p; > + return (INT16)(LONG_PTR)p; > } > > static inline void *IntToPtr(INT32 i)

3 5

Re: windowscodecs: test for TIFFSetWarningHandlerExt
by Alexandre Julliard 29 Jun '12

29 Jun '12

Daniel Lehman <dlehman(a)esri.com> writes: > Fails to build on RHEL4 with libtiff 3.6.1 > > Alternative to this is a configure test for libtiff 3.8.0, which is when the function first appears I don't think this needs a configure test. Just define the prototype explicitly instead of using typeof. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] d3dx9: Implement D3DXLoadVolumeFromMemory.
by Matteo Bruni 29 Jun '12

29 Jun '12

2012/6/27 Józef Kucia <joseph.kucia(a)gmail.com>: > --- Hi Józef, > +void copy_simple_data(const BYTE *src, UINT srcpitch, SIZE src_size, const PixelFormatDesc *srcformat, > + BYTE *dest, UINT destpitch, SIZE dst_size, const PixelFormatDesc *destformat, D3DCOLOR colorkey) DECLSPEC_HIDDEN; > + You are not actually using this function in the patch. > + if (dst_box->Left > dst_box->Right || dst_box->Right > desc.Width) > + return D3DERR_INVALIDCALL; > + if (dst_box->Top > dst_box->Bottom || dst_box->Bottom > desc.Height) > + return D3DERR_INVALIDCALL; > + if (dst_box->Front > dst_box->Back || dst_box->Back > desc.Depth) > + return D3DERR_INVALIDCALL; > + > + dst_width = dst_box->Right - dst_box->Left; > + dst_height = dst_box->Bottom - dst_box->Top; > + dst_depth = dst_box->Back - dst_box->Front; > + if (!dst_width || !dst_height || !dst_depth) > + return D3DERR_INVALIDCALL; You can avoid the last check by comparing e.g. (dst_box->Left >= dst_box->Right) above, instead of using ">". > + if (src_box->Left & (src_format_desc->block_width - 1) > + || src_box->Top & (src_format_desc->block_height - 1) > + || (src_box->Right & (src_format_desc->block_width - 1) > + && src_width != desc.Width) > + || (src_box->Bottom & (src_format_desc->block_height - 1) > + && src_height != desc.Height)) > + { > + WARN("Source box (%u, %u, %u, %u) is misaligned\n", > + src_box->Left, src_box->Top, src_box->Right, src_box->Bottom); > + return D3DXERR_INVALIDDATA; > + } I'm not quite sure of the right and bottom misalignment checks. If the tests confirm that, of course that's okay. > + for (slice = 0; slice < src_depth; slice++) > + { > + src_addr = src_memory; > + src_addr += slice * src_slice_pitch; Shouldn't you take into account src_box->Front?

2 1

Re: user32: Add test for ComboBox repositioning behavior (try 2).
by Marvin 29 Jun '12

29 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19658 Your paranoid android. === W7PRO (32 bit msg) === msg.c:8219: Test failed: did not get zero count as expected (1).

2 1

Re: gdiplus: Add a test to show that GdipCloneImage is not supposed to increase refcount of the source image stream, but clone it instead.
by Vincent Povirk 29 Jun '12

29 Jun '12

I think it's most likely not keeping the input stream in the new image at all. It's probably also worth testing SelectActiveFrame, GetPropertyItem, and GetImageRawFormat with clones of images. Maybe they don't work.

2 1

Re: wbemprox: Add a Win32_LogicalDisk class stub.
by Hans Leidekker 28 Jun '12

28 Jun '12

On Thu, 2012-06-28 at 21:53 +0300, John Yani wrote: > +static void fill_logicaldisk( struct table *table ) > +{ > + static const WCHAR caption[] = > + {'C',':',0}; > + static const WCHAR description[] = > + {'L','o','c','a','l',' ','F','i','x','e','d',' ','D','i','s','k',0}; > + static const WCHAR device_id[] = > + {'C',':',0}; > + struct record_logicaldisk *rec; > + FIXME("returns a fake logical disks table\n"); > + if (!(table->data = heap_alloc( sizeof(*rec) ))) > + { > + return; > + } > + rec = (struct record_logicaldisk *)(table->data); > + rec->caption = caption; > + rec->description = description; > + rec->device_id = device_id; > + table->num_rows = 1; > + TRACE("created %u row(s)\n", table->num_rows); That's better. Does NFS actually query the Caption and Description properties?

2 4

Re: user32: Add a test for ComboBox WM_WINDOWPOSCHANGED handling.
by Alexandre Julliard 28 Jun '12

28 Jun '12

Sergey Guralnik <serhio(a)etersoft.ru> writes: > @@ -5807,6 +5830,25 @@ static void test_combobox_messages(void) > log_all_parent_messages--; > ok_sequence(WmKeyDownComboSeq, "WM_KEYDOWN/VK_DOWN on a ComboBox", FALSE); > > + wp.hwnd = combo; > + wp.hwndInsertAfter = HWND_TOP; > + wp.cx = wp.cy = wp.x = wp.y = 50; > + wp.flags = 0; > + flush_sequence(); > + SendMessage(combo, WM_WINDOWPOSCHANGED, 0, (LPARAM)&wp); It doesn't make much sense to send this message directly. What are you trying to test? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/2] gdiplus: Increase refcount of the source stream when loading a bitmap instead of cloning it.
by Vincent Povirk 28 Jun '12

28 Jun '12

This looks good to me. (I didn't think it was necessary to comment, but this is an important fix and I was surprised it was still New.)

1 0

Unused msvcp60 functions
by Francois Gouget 28 Jun '12

28 Jun '12

I get the following warnings when compiling msvcp60: main.c:108:51: warning: ‘std_BADOFF_func’ defined but not used [-Wunused-function] misc.c:66:40: warning: ‘mutex_mutex_lock’ defined but not used [-Wunused-function] misc.c:73:40: warning: ‘mutex_mutex_unlock’ defined but not used [-Wunused-function] misc.c:80:40: warning: ‘mutex_mutex_ctor’ defined but not used [-Wunused-function] misc.c:87:40: warning: ‘mutex_mutex_dtor’ defined but not used [-Wunused-function] misc.c:175:58: warning: ‘set_new_handler_reset’ defined but not used [-Wunused-function] Indeed msvcp60.spec contains no _BADOFF, _Mutex or set_new_handler function. I don't see them in my 'database' of exported Windows APIs for msvcp60 but maybe the Windows dlls I built it from where not entirely up to date. Still it looks like these were added in later revisions and thus can be removed from the above files. misc.c:127:50: warning: ‘wctype’ defined but not used [-Wunused-function] This one is actually forwarded to msvcp90 according to msvcp60.spec, thus making this implementation redundant. So it should either be removed or msvcp60.spec should be modified. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Only wimps use tape backup: _real_ men just upload their important stuff on ftp, and let the rest of the world mirror it ;)" -- Linus Torvalds

2 3

Re: windowscodecs: Make sure that stream is not reused once the decoder is initialized.
by Vincent Povirk 28 Jun '12

28 Jun '12

Looks good to me.

1 0

Re: kernel32/tests: Remove an unused variable in the sync tests.
by Marvin 28 Jun '12

28 Jun '12

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=19638 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

1 0

Re: [4/5] d3dx9: Implement D3DXCreateVolumeTextureFromFileInMemoryEx.
by Matteo Bruni 28 Jun '12

28 Jun '12

2012/6/27 Józef Kucia <joseph.kucia(a)gmail.com>: > --- > + for (mip_level = 0; mip_level < mip_levels; mip_level++) > + { > + hr = calculate_dds_surface_size(src_info, width, height, &src_pitch, &mip_level_size); > + if (FAILED(hr)) return hr; ... > + hr = D3DXLoadVolumeFromMemory(volume, palette, NULL, pixels, src_info->Format, > + src_pitch, mip_level_size, NULL, &box, filter, color_key); mip_level_size would be the source slice pitch, right? I'd just call it like that.

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel