> Date: Tue, 18 Nov 2008 10:17:46 +0100
> From: meissner@suse.de
> To: dmitry@codeweavers.com
> CC: ricardo_barbano@hotmail.com; wine-devel@winehq.org
> Subject: Re: dlls/cabinet: fix dead stores (llvm/clang)
>
> On Tue, Nov 18, 2008 at 03:11:52PM +0800, Dmitry Timoshkov wrote:
> > "ricardo filipe" <ricardo_barbano@hotmail.com> wrote:
> >
> > > --- a/dlls/cabinet/fci.c
> > > +++ b/dlls/cabinet/fci.c
> > > @@ -462,7 +462,7 @@ static cab_ULONG fci_get_checksum(const void *pv, UINT cb, CHECKSUM seed)
> > > case 2:
> > > ul |= (((ULONG)(*pb++)) << 8);
> > > case 1:
> > > - ul |= *pb++;
> > > + ul |= *pb;
> > > default:
> > > break;
> > > }
> >
> > Is there any reason that you ignored 2 similar cases above?
>
> Yes, because it would be wrong ... Its a Duffs Device, falling through
> to the last case. The other pb++ are necessary.
>
> Ciao, Marcus
 
yes only the last one is dead. although i have to ask you guys, today i think i messed up on this one and it's a false positive, because at the beggining pb = pv.
so it will affect the pv and this shouldn't be applied right?

---

Conheça já o Windows Live Spaces, o site de relacionamentos do Messenger! Crie já o seu!