Hi folks,

I tried to implement a lot of strcoll function these days, and I meet some trouble when I added the declaration into include/msvcrt/*.h.

With "grep coll *.spec" in dlls/msvcrt/ we can find there was a lot of strcoll function. Some of them was implemented

and some of them not:

@ cdecl ___lc_collate_cp_func()

@ stub __lc_collate

@ extern __lc_collate_cp MSVCRT___lc_collate_cp

@ cdecl _mbscoll(str str)

@ cdecl _mbscoll_l(str str ptr)

@ cdecl _mbsicoll(str str)

@ cdecl _mbsicoll_l(str str ptr)

@ cdecl _mbsnbcoll(str str long)

@ cdecl _mbsnbcoll_l(str str long ptr)

@ cdecl _mbsnbicoll(str str long)

@ cdecl _mbsnbicoll_l(str str long ptr)

@ stub _mbsncoll(str str long)

# stub _mbsncoll_l(str str long ptr)

@ stub _mbsnicoll(str str long)

# stub _mbsnicoll_l(str str long ptr)

@ cdecl _strcoll_l(str str ptr) MSVCRT_strcoll_l

@ cdecl _stricoll(str str) MSVCRT__stricoll

@ cdecl _stricoll_l(str str ptr) MSVCRT__stricoll_l

@ cdecl _strncoll(str str long) MSVCRT_strncoll_l

@ cdecl _strncoll_l(str str long ptr) MSVCRT_strncoll

@ cdecl _strnicoll(str str long) MSVCRT__strnicoll

@ cdecl _strnicoll_l(str str long ptr) MSVCRT__strnicoll_l

# stub _wcscoll_l(wstr wstr ptr)

@ cdecl _wcsicoll(wstr wstr) MSVCRT__wcsicoll

# stub _wcsicoll_l(wstr wstr ptr)

@ cdecl _wcsncoll(wstr wstr long) MSVCRT__wcsncoll

@ cdecl _wcsncoll_l(wstr wstr long ptr) MSVCRT__wcsncoll_l

@ cdecl _wcsnicoll(wstr wstr long) MSVCRT__wcsnicoll

# stub _wcsnicoll_l(wstr wstr long ptr)

@ cdecl strcoll(str str) MSVCRT_strcoll

@ cdecl wcscoll(wstr wstr) MSVCRT_wcscoll

With "grep coll *.h" in include/msvcrt/ we can find some declarations of some strcoll function:

crtdefs.h: unsigned int lc_collate_cp;

mbstring.h:int __cdecl _mbscoll(const unsigned char*,const unsigned char*);

mbstring.h:int __cdecl _mbsicoll(const unsigned char*,const unsigned char*);

mbstring.h:int __cdecl _mbsnbcoll(const unsigned char*,const unsigned char*,size_t);

mbstring.h:int __cdecl _mbsnbicoll(const unsigned char*,const unsigned char*,size_t);

mbstring.h:int __cdecl _mbsncoll(const unsigned char*,const unsigned char*,size_t);

mbstring.h:int __cdecl _mbsnicoll(const unsigned char*,const unsigned char*,size_t);

string.h:int __cdecl _stricoll(const char*,const char*);

string.h:int __cdecl strcoll(const char*,const char*);

string.h:int __cdecl _wcsicoll(const wchar_t*,const wchar_t*);

string.h:int __cdecl _wcsnicoll(const wchar_t*,const wchar_t*,size_t);

string.h:int __cdecl wcscoll(const wchar_t*,const wchar_t*);

string.h:static inline int stricoll(const char* s1, const char* s2) { return _stricoll(s1, s2); }

string.h:static inline int wcsicoll(const wchar_t* str1, const wchar_t* str2) { return _wcsicoll(str1, str2); }

wchar.h:int __cdecl _wcsicoll(const wchar_t*,const wchar_t*);

wchar.h:int __cdecl _wcsnicoll(const wchar_t*,const wchar_t*,size_t);

wchar.h:int __cdecl wcscoll(const wchar_t*,const wchar_t*);

As we can see, _strcoll_l and _mbsnbcoll_l were implemented but they were not declared.

Should we declare all of them? And whether the sequence was important?

Thank you.

Regards,

Jactry Zeng