De: Henri Verbeet <hverbeet@gmail.com>
Objet: Re: [PATCH] d3dx9_36: Implement D3DXCheckTextureRequirements + tests
À: wine-devel@winehq.org
Date: Lundi 19 avril 2010, 11h43

On 19 April 2010 09:43, Christian Costa <titan.costa@wanadoo.fr> wrote:
> +BOOL is_pow2(UINT num)
> +{
> +    UINT i;
> +
> +    if (!num) return FALSE;
> +    for (i = 0; num >> 1; i++) num >>= 1;
> +
> +    return (num << i) == num;
> +}
This should at least be static. You can also just replace it with
"return !(num & (num - 1));". You don't care about 0, since you
already check that earlier in D3DXCheckTextureRequirements().
make_pow2() can probably be simplified as well.