Hello,
some comments about this patch
+ if (hr != S_OK) return FALSE;
+ else return TRUE;
could be simplified as
return SUCCEEDED(hr);
+ trace("HRESULT when creating instance (%x)\n", hr);
Since tests are assumed to pass, we dont care about debug informations. So, traces are useless in tests. [It is my opinion. Better developpers could give an opposite opinion]
+ todo_wine ok(*(ULONG *)pDirectMusicPort != 0, "IDirectMusicPort not set\n");
Why is this cast useful?
A+
David