On Fri, Jun 28, 2013 at 9:16 AM, Qian Hong <fracting@gmail.com> wrote:

Dear Juan,

Thanks for reviewing!

On Fri, Jun 28, 2013 at 11:31 PM, Juan Lang <juan.lang@gmail.com> wrote:
> It's more in line with most C code to use !memcmp(...) instead of
> memcmp(...)==0. I find it easier to scan, anyway, as I've gotten used to !
> comparisons to check equality in memcmp, strcmp, and variants.
>

I'm glad to change, but the surrounding code use memcmp(...)==0
already, should I change that as well?

Ah. Thanks for following the existing style then :-/ No, don't bother changing the existing code. I leave it up to you whether to follow my suggestion or ignore it, either is fine in this case.

--Juan