Yes I agree, that FIXME looks strange. As you say, folder_icon.ico has all three icon sizes inside, so why is included in the resource three times? Does native have 3 icon resources? Is it ok to use the same multi-size icon 3 times?
Joel
On 20 April 2012 at 06:53 Francois Gouget <fgouget@free.fr> wrote:
>
> In dlls/shell32/shell32.rc I see the following fixme:
>
> /* FIXME: Following three resources are not yet added */
> /* @makedep: folder_open.ico */
> IDI_SHELL_FOLDER_OPEN_SMALL ICON folder_open.ico
> /* @makedep: folder_open.ico */
> IDI_SHELL_FOLDER_OPEN_LARGE ICON folder_open.ico
> /* @makedep: folder_open.ico */
> IDI_SHELL_FOLDER_SMALL_XP ICON folder_open.ico
>
> However folder_open.ico is generated from an SVG file and we seem to be
> having it in multiple sizes. Also this fixme has been there forever. So
> is there really still something to be fixed?
>
>
> --
> Francois Gouget <fgouget@free.fr> http://fgouget.free.fr/
> "Lotto: A tax on people who are bad at math." -- unknown
> "Windows: Microsoft's tax on computer illiterates." -- WE7U
>
>