Hi Michael,
Thanks for your long email about some sort of wine 'staging' project. I understand what you are you trying to accomplish, but I have various concerns, which I will share below.
The initial motivation for this project seems to be to allow users to test patches at an earlier stage. It may allow users to run their app sooner. For developers it can give their code more testing, which I agree can be useful.
My main concern is that the quality of a lot of the patches is unfortunately so-so, with various lose ends and side effects various developers can't oversee. AJ is right to reject such patches. This can be a hinder for a new developers, it is not always as easy to get feedback and yes some mentoring for new developers can really help.
Over the years there have been various projects in different forms like PlayOnLinux to allow users to run Wine with non-upstreamed patches. As you know the main concern of PlayOnLinux is that due to all the patching it is not vanilla Wine anymore, but a 'tainted version'. This makes us typically reject bug reports, because we don't know what code went in it, which can waste a developers time.
No matter how good the intentions are to do a better job than PlayOnLinux, I'm skeptical. I actually went over several of the patches in the repo and various of them look incorrect. I understand that they may make app Z work and while they may not always be as evil as PlayOnLinux-style hacks, I still don't want them to be out in the public. In my opinion any tainted Wine is bad for Wine developers. Yes, user may test your new patch, but I expect to get a lot of issues back due to other incomplete patches with side effects.
In an ideal world there would be no need for your project, because all patches make it upstream quickly. I think the discussion should be more on how to get closer and closer to this situation. I think it should more be found in mentoring and providing more feedback.
Since Wine is an open source project, nobody forbids you from working on your customized Wine. Providing builds to users to try it is fine with me, but clearly don't mark it as the official Wine, but as you already doing by calling it 'wine-compholio'.
What does really scare me are the Fedora Wine builds. After you said that they incorporate your changes, I checked the rpm and indeed it uses 150+ custom patches from your repo. In my opinion, distro packages need to be as vanilla as possible to prevent the PlayOnLinux-like bug rejection issues. Sometimes build system change or some minor change is needed, but such an amount of patches is not justified. Myself I don't have much time to work on Wine anymore these days, but if I got bugs from Fedora users, I would reject their bugs. I hope other Wine developers would really do the same, because the packages clearly can't be trusted.
Overall I know the intentions are good to allow users to test new code sooner and allow developers to get their stuff test sooner. I'm really skeptical about the benefit for developers due to the tainted Wine builds. I think overall it may actually be more negative than positive for Wine.
Thanks,
Roderick