Hi Yaron,

On 08/01/2010 10:52 AM, Yaron Shahrabani wrote:

Alexander and Paul, please notice I added the EXSTYLE WS_EX_LAYOUTRTL
for the dialogs, hope that helps.

Also found out that menus does not need any special RTL property, they
are self aligned according to the app.

What do you mean by that? Running Wordpad in Hebrew still gives me LTR menu styles/justification. The global (per process) RTL settings still need to be implemented for our internal apps.

Kind regards,
Yaron Shahrabani

   <Hebrew translator>

0002-wordpad-Added-Hebrew-translation.patch


 From 8f5dfcb55656e7e4d7943d622234fb37753210f7 Mon Sep 17 00:00:00 2001
From: Yaron Shahrabani<sh.yaron@gmail.com>
Date: Sun, 1 Aug 2010 11:48:23 +0300
Subject: wordpad: Added Hebrew translation.

---
 programs/wordpad/He.rc       |  282 ++++++++++++++++++++++++++++++++++++++++++
 programs/wordpad/Makefile.in |    1 +
 2 files changed, 283 insertions(+), 0 deletions(-)
 create mode 100644 programs/wordpad/He.rc

diff --git a/programs/wordpad/He.rc b/programs/wordpad/He.rc
new file mode 100644
index 0000000..091ec98
--- /dev/null
+++ b/programs/wordpad/He.rc
@@ -0,0 +1,282 @@
+/*
+ * Copyright 2004 by Krzysztof Foltman
+ * Hebrew Translation by Yaron Shahrabani<sh.yaron@gmail.com>, 2010

Minor, but why did you not use the same format (as we see in most files)? So something like:

/*
 * Hebrew Translation of wordpad
 *
 * Copyright 2004 by Krzysztof Foltman
 * Copyright 2010 Yaron Shahrabani<sh.yaron@gmail.com>

+IDD_DATETIME DIALOG 30, 20, 130, 80
+STYLE DS_MODALFRAME | WS_CAPTION | WS_SYSMENU
+EXSTYLE WS_EX_LAYOUTRTL

Eventually we probably have to but I'm not sure what Alexandre thinks about introducing it (now). We probably also have to teach our tools (like the translation site) that detects translation differences/issues to cope with this.

+STRINGTABLE
+BEGIN
+    STRING_ALIGN_LEFT,            "שמאל"
+    STRING_ALIGN_RIGHT,           "ימין"
+    STRING_ALIGN_CENTER,          "מרכז"
+END

This piece is already defined starting on line 226 and thus leads to:

../../../wine-git/programs/wordpad/He.rc:279:32: Error: Stringtable ID 1416 already in use

--
Cheers,

Paul.