On Thursday, September 3, 2015, Zhenbo Li &lt;<a href="mailto:litimetal@gmail.com">litimetal@gmail.com</a>&gt; wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<br>
<br>
As I&#39;m working on bug 25207, I found that previous test code<br>
(test_move() in shlfileop.c) had some disadvantages<br>
<br>
1. Duplicate tests<br>
2. Legacy test code (for Win98 or NT4)<br>
3. Lack of test for Vista or later Windows Versions<br>
<br>
As more applications are depending on the new behaviours introduced in<br>
Vista, IMHO, we should focus on Vista&#39;s new behaviour. So I rewrote<br>
test_move() to remove code for win98, mark xp behaviour as broken, and<br>
expect Vista&#39;s behaviour. My next step is to re-implement FO_MOVE<br>
operation of SHFileOperation to fix bug 25207.<br>
<br>
Any suggestion for this?</blockquote><div><br></div><div>Hi, I dislike the idea of removing tests because they are obsolete but that is just my opinion. At least I like to keep winsock running in NT4.</div><div><br></div><div>What I have done in patches that reached similar issues is to detect the OS using a specific test that you are sure differs between OS and then use if/else to separate the tests. This reduces the amount of broken required, broken can be a vilain sometimes because it does not specify which OS is failing.</div><div><br></div><div>Best wishes, </div><div>Bruno</div>