On a deeper look, it seems only GetTransform is such a thunk that doesn't have tests for version 1. I'll add this thunk and resend the patch, after the rearrangement changes.

Cheers,
Aaryaman

On Fri, Jun 17, 2016 at 11:44 PM, Stefan Dösinger <stefandoesinger@gmail.com> wrote:

> Am 17.06.2016 um 14:40 schrieb Aaryaman Vasishta <jem456.vasishta@gmail.com>:
>
> > Doesn't that potentially break currently working applications? And
> > while having tests is great, I'm not sure I agree with the premise
> > that it's better to return E_NOTIMPL than to forward to an
> > implementation that may have subtle differences but probably doesn't
> > in most cases.

> I don't disagree with you. I just want an acceptable patch for this as I'll need it for implementing viewports. Also a lot of version 2 stuff uses version 1 frames as well, which makes it more important. I've CC'd Stefan in this mail, hopefully we can agree on something which works for all.
I am fine with imperfect / possibly broken thunks. What I want to avoid is wasting too much time on possible corner cases for a thunk that thunks to an E_NOTIMPL or barely implemented function. I guess I forgot about the possibility that the existing Frame code runs any real application :-\ .