Thank you for commenting.

2014-07-11 16:50 GMT+08:00 Piotr Caban <piotr.caban@gmail.com>:

Hi,

On 07/11/14 05:49, Shuai Meng wrote:

static HRESULT Global_Abs(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res)
{
- FIXME("\n");
- return E_NOTIMPL;
+ TRACE("(%s)\n", debugstr_variant(arg));
+
+ assert(args_cnt == 1);
+
+ if(!res)
+ return S_OK;
+
+ return VarAbs(arg,res);
}

You're not handling res==NULL case correctly. E.g. Call Abs("string") should fail.

I have tested this case for many times, and I think Call Abs("string") is just OK https://testbot.winehq.org/JobDetails.pl?Key=7967

and it's OK that write directly using vbscript on wiinxp and win7.

Thanks,
Piotr