The patch is OK, this mail is just an answer to Henri&#39;s comment.<br><br><div class="gmail_quote">2011/12/8 Henri Verbeet <span dir="ltr">&lt;<a href="mailto:hverbeet@codeweavers.com">hverbeet@codeweavers.com</a>&gt;</span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">+static BOOL color_in_range(const struct wined3d_color_key *color_key, DWORD color)<br>
+{<br>
+    /* FIXME: Is this really how color keys are supposed to work? I think it<br>
+     * makes more sense to compare the individual channels. */<br>
+    return color &gt;= color_key-&gt;color_space_low_value<br>
+            &amp;&amp; color &lt;= color_key-&gt;color_space_high_value;<br>
+}<br></blockquote><div> I tried to test this a while ago, but no GPU supported range color keys for blitting, and the HEL doesn&#39;t support that either.</div><div><br></div><div>At least one of my GPUs seems to support this for YUV overlays(DDCKEYCAPS_SRCOVERLAYCLRSPACEYUV), but not RGB overlays or YUV blits. That could satisfy our curiosity, but an automated test is not possible.</div>
</div>