On Thu, Feb 18, 2016 at 2:08 PM, Ken Thomases <ken@codeweavers.com> wrote:
>
> On Feb 18, 2016, at 2:20 PM, Charles Davis <cdavis5x@gmail.com> wrote:
> >
> > Signed-off-by: Charles Davis <cdavis5x@gmail.com>
> > ---
> > dlls/secur32/schannel_macosx.c | 16 ++++++++--------
> > 1 file changed, 8 insertions(+), 8 deletions(-)
>
> In several other places throughout this file, the same problem was solved by casting to long in the logging call. Of course, that means that Clang doesn't warn about those. I don't mind your approach, but I think this should be handled consistently throughout the file, one way or the other.
I noticed that too, but I didn't want to needlessly change those bits. Actually, I used the cast approach originally, but when AJ rejected the first advapi32 patch for doing that, I changed this one, too. (And the winemac.drv patch.)
I guess I'll change all the c
asts to use int variables instead.
Chip
PS--I must apologize if this comes out as HTML email. I'm still using Gmail's web client since Mail.app is so broken in El Capitan.