It does match the style of the way that HeapAlloc is used elsewhere in
the file, though not malloc admittedly. I wasn't sure which convention
had precedent.
I'm afraid that I don't understand how my
changelog doesn't match the patch. I'm new here, can you help me out?
There's obviously something I'm missing!
Pete
Your changelog (right above) doesn't match the patch, andOn Wed, Oct 29, 2008 at 7:39 PM, Pete Myers
<peterdanielmyers@googlemail.com> wrote:
> In line with http://wiki.winehq.org/ReplaceMalloc this is a small patch that
> changes all malloc calls to HeapAlloc in the following files:
> ./dlls/iphlpapi/tests/iphlpapi.c
> ./dlls/wnaspi32/winaspi16.c
>
> Changelog:
> * malloc calls in dlls/kernel32/process.c have been change to HeapAlloc
>
- PMIB_IPADDRTABLE buf = (PMIB_IPADDRTABLE)malloc(dwSize);
+ PMIB_IPADDRTABLE buf = (PMIB_IPADDRTABLE)HeapAlloc(
GetProcessHeap(), 0, dwSize);
You've introduced a space after opening parentheses which does not
match the style of the rest of the file.
--
James Hawkins