2013/6/25 Henri Verbeet <hverbeet@gmail.com>

On 25 June 2013 11:05, Christian Costa <titan.costa@gmail.com> wrote:

> 2013/6/25 Henri Verbeet <hverbeet@gmail.com>
>> At least try to pretend you put
>> some effort into making sure the patch is as good as it can be before
>> submitting it.
>
>
> I could have send the patch to wine-devel first but would I get something
> longer that "several issues" as feedback?

No, you're missing the point. Why do you expect me to even look at a
patch if you clearly didn't even check for obvious typos yourself?
Bottom line, if you want me to spend time reviewing a patch and giving
feedback, make sure it's worth that time.

Are we really discussing about a typo in the subject line? "Implement" just comes naturally from the fixme when I create an empty patch. It turned out after coding that "Fix" is more appropriate. I forgot to updated it. This will be fix.

According to the feedback I got, altough the patch is not correct, it doesn't seem it does not worth looking at. And now there is materials to make it better.