Le 24/04/2013 20:10, James Eder a écrit :

On Wed, Apr 24, 2013 at 6:58 AM, Christian Costa <titan.costa@gmail.com> wrote:

Hi James,

That would be better to change the trace at the beginning by FIXME( "(%p, %d): semi-stub\n", info, size ); or FIXME( "(%p, %d): partial stub\n", info, size );

instead of adding another fixme (which is not really correct since it's not a stub).

Christian

Does this look better? http://source.winehq.org/patches/data/95866

-    TRACE( "(%p, %d)\n", info, size );
+    FIXME("semi-stub (%p, %d)\n", info, size );

Wine sources used to put semi-stub mention after parameters. There is also inconsistency with spaces near parenthesis. 0 before the format string and 1 after size parameter.
Something like  FIXME("(%p, %d): semi-stub\n", info, size);
Otherwise seems fine. :)

-    if (status)
+    if(size < sizeof(PERFORMANCE_INFORMATION))
     {

+
+    mem_status.dwLength = sizeof(mem_status);
+    if (!GlobalMemoryStatusEx( &mem_status ))

Oups. Forgot this one. Cosmetic again :|. Still space inconsitency. First if w/o and second w/ space.

Christian