Hi,

Thank you for the review.
I have sent an updated version of both patches with your suggestions applied.

Sincerely,
Gijs

Virus-free. www.avast.com

2017-03-17 15:44 GMT+01:00 Piotr Caban <piotr.caban@gmail.com>:
Hi,

Please also move this code to heap.c and rename the function and argument (e.g. to mem).

On 03/16/17 23:12, Gijs Vermeulen wrote:
+/* ?Free@Concurrency@@YAXPAX@Z */
+/* ?Free@Concurrency@@YAXPEAX@Z */
+void __cdecl Free(void * _PAllocation)
+{
+    FIXME("(%p) stub\n", _PAllocation);
Even so it's a semi-stub it's better to free the memory here. Applications have no guarantee that memory block will be cached anyway.

Thanks,
Piotr