-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Thanks for your patch! I have a few comments:

Am 2015-03-23 um 04:14 schrieb Kaipeng Zeng:
> index 5f5e9d5..f3056c7 100755
> --- a/configure
> +++ b/configure
You don't have to include the change to configure in your patch,
Alexandre will update it himself.

> diff --git a/configure.ac b/configure.ac
> index d23227a..822affe 100644
> ...
>  WINE_CONFIG_PROGRAM(findstr,,[install])
> +WINE_CONFIG_TEST(programs/findstr/tests)
>  WINE_CONFIG_PROGRAM(hh,,[install])
I don't think we have any precedent for having tests without having at
least a stub implementation. Personally I don't see anything wrong
with having just a test for now. Can you make sure that the test is
properly built and included in winetest.exe?

Do you intend to implement the program itself?

> +static DWORD runcmd(const char* cmd, char *output)
> ...
> +    CloseHandle(hRead);
> +    return TRUE;
> +}
I think it would be a good idea to return the return value of findstr
here instead of always returning true when CreateProcess succeeds.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVD/UWAAoJEN0/YqbEcdMwh8EP/37ev7ZrJHzmNy5AJfbuzY/s
3wxUIKIo5hwrjJeiwpdFCWAtDQGMo3Hz8weLLyAaCpT4OVrzz/DvbWFLxX3zCl2Z
9EhetkZkyfiPBUF1T+s/WdTse51J9qeP8mFI7NgQdwuwUOXyp2Ba7Kq8DVBM6sNW
MtWsKdItE298jTzL21oQ59w9ar6YrFwRTcVcvLQ3JPmLKSfJ5MR2qT1SxIO6nVC9
Omqc89R9Ba3jSFv+5c3l0Zn6zgnf/U5YBPmsOMYb9DWLNvD0ZgiBh5NZkLxYcV16
NLHQWxJy3mO11RNyjSn1Ank26rR1MiM4kVT7tK3WvneM1IZW7Z/RugGaymtTgfBq
vIIMKidz2hPrIwmuy4AYSEb9ScJIT+b2DCbwgJEWgmxTPl3mymW5ltXLx8yzcmhV
y7GNYGVKuaH6CZeyHLimeLGA845qCzXW15vWxaB6PGw+lVlqpq4mWJnWcB2NOsC+
Auw4vubTf8KTs2UHyQily9AaahthU5IkZA6sPBDpTlZCNlGpRXa+gW88WpKjd5wV
5y9otOU49Fhp704uZAiVcX9ag5cTFaseu0AsTN/TKmYToA50bzAmJr+2/+nJEQIf
lcahIWPeyYw1u7rF3cOEZfkN7FIx/ab1gv1hETLvyoKz/nnYb9NPztnnK3HDFNRP
XJl+R82YChN/YV946HfO
=6sQQ
-----END PGP SIGNATURE-----