September 2025 - wine-gitlab

[PATCH v6 0/1] MR7339: ntdll: implement create_logical_proc_info on FreeBSD.
by Damjan Jovanovic (＠dj) 04 Oct '25

04 Oct '25

Add Expat as a dependency, and use it to parse the XML returned from FreeBSD's kern.sched.topology_spec sysctl. -- v6: ntdll: implement create_logical_proc_info on FreeBSD. https://gitlab.winehq.org/wine/wine/-/merge_requests/7339

5 6

[PATCH v6 0/29] MR7226: ntdll: Implement in-process synchronization via the Linux "ntsync" driver.
by Elizabeth Figura (＠zfigura) 04 Oct '25

04 Oct '25

This introduces a faster implementation of signal and wait operations on NT events, semaphores, and mutexes, which improves performance to native levels for a wide variety of games and other applications. The goal here is similar to the long-standing out-of-tree "esync" and "fsync" patch sets, but without the flaws that make those patch sets not upstreamable. The Linux "ntsync" driver is not currently released. It has been accepted into the trunk Linux tree for 6.14, so barring any extraordinary circumstances, the API is frozen and it will be released in its current form in about 2 months. Since it has passed all relevant reviewers on the kernel side, and the API is all but released, it seems there is no reason any more not to submit the Wine side to match. Some important notes: * This patch set does *not* include any way to disable ntsync support, since that kind of configuration often seems to be dispreferred where not necessary. In essence, ntsync should just work everywhere. Probably the easiest way to effectively disable ntsync, for the purposes of testing, is to chmod the /dev/ntsync device to prevent its being opened. Regardless, a Wine switch to disable ntsync can be added simply enough. Note that it should probably not take the form of a registry key, however, since it needs to be easily accessible from the server itself. * It is, generally speaking, not possible for only some objects, or some processes, to have backing ntsync objects, while others use the old server path. The esync/fsync patch sets explicitly protected against this by making sure every process had a consistent view of whether esync was enabled. This is not provided here, since no switch is provided to toggle ntsync, and it should not be possible to get into such an inconsistent state without gross misconfiguration. * Similarly, no diagnostic messages are provided to note that ntsync is in use, or not in use. These messages are part of esync/fsync, as well as part of ntsync "testing" trees unofficially distributed. However, if ntsync is working correctly, no message should be necessary. The basic structure is: * Each type of server object which can be waited on by the client (including events, semaphores, mutexes, but also other types such as processes, files) must store an "inproc_sync" object. This "inproc_sync" object is a full server object (note that this differs from esync/fsync). A vector and server request is introduced to retrieve an NT handle to this object from an arbitrary NT handle. Since the actual ntsync objects are simply distinct file descriptions, we then call get_handle_fd from the client to retrieve an fd to the object, and then perform ioctls on it. * Objects signaled by the server (processes, files, etc) perform ntsync ioctls on that object. The backing object in all such cases is simply an event. * Signal and wait operations on the client side attempt to defer to an "inproc_\*" function, falling back to the server implementation if it returns STATUS_NOT_IMPLEMENTED. This mirrors how in-process synchronization objects (critical sections, SRW locks, etc) used to be implemented—attempting to use an architecture-specific "fast_\*" function and falling back if it returned STATUS_NOT_IMPLEMENTED. * The inproc_sync handles, once retrieved, are cached per-process. This caching takes a similar form to the fd cache. It does not reuse the same infrastructure, however. The primary reason for this is that the fd cache is designed to fit within a 64-bit value and uses 64-bit atomic operations to ensure consistency. However, we need to store more than 64 bits of information. [We also need to modify them after caching, in order to correctly implement handle closing—see below.] The secondary reason is that retrieving the ntsync fd from the inproc_sync handle itself uses the fd cache. * In order to keep the Linux driver simple, it does not implement access flags (EVENT_MODIFY_STATE etc.) Instead, the flags are cached locally and validated there. This too mirrors the fd cache. Note that this means that a malicious process can now modify objects it should not be able modify—which is less true than it is with wineserver—but this is no different from the way other objects (notably fds) are handled, and would require manual syscalls. * In order to achieve correct behaviour related to closing objects while they are used, this patch set essentially relies on refcounting. This is broadly true of the server as well, but because we need to avoid server calls when performing object operations, significantly more care must be taken. In particular, because waits need to be interruptable by signals and then be restarted, we need the backing ntsync object to remain valid until all users are done with it. On a process level, this is achieved by letting multiple processes own handles to the underlying inproc_sync server object. On a thread level, multiple simultaneous calls need to refcount the process's local handle. This refcount is stored in the sync object cache. When it reaches zero, the cache is cleared. Punting this behaviour to the Linux driver would have introduced a great deal more complexity, which is best kept in userspace and out of the kernel. * The cache is, as such, treated as a cache. The penultimate commit, which introduces client support but does not yet cache the objects, effectively illustrates this by never actually caching anything, and retrieving a new NT handle and fd every time. * Certain waits, on internal handles (such as async, startup_info, completion), are delegated to the server even when ntsync is used. Those server objects do not create an underlying ntsync object. -- v6: ntdll: Cache in-process synchronization objects. ntdll: Use server_wait_for_object() when waiting on only the queue object. ntdll: Use in-process synchronization objects. ntdll: Introduce a helper to wait on an internal server handle. server: Allow creating an event object for client-side user APC signaling. server: Introduce select_inproc_queue and unselect_inproc_queue requests. server: Add a request to retrieve the in-process synchronization object from a handle. server: Create in-process synchronization objects for fd-based objects. server: Create in-process synchronization objects for timers. server: Create in-process synchronization objects for threads. server: Create in-process synchronization objects for message queues. server: Create in-process synchronization objects for jobs. server: Create in-process synchronization objects for processes. server: Create in-process synchronization objects for keyed events. server: Create in-process synchronization objects for device managers. server: Create in-process synchronization objects for debug objects. server: Create in-process synchronization objects for console outputs. server: Create in-process synchronization objects for console inputs. server: Create in-process synchronization objects for screen buffers. server: Create in-process synchronization objects for console servers. server: Create in-process synchronization objects for consoles. server: Create in-process synchronization objects for completion ports. server: Create in-process synchronization objects for mutexes. server: Create in-process synchronization objects for semaphores. server: Create in-process synchronization objects for events. server: Add an object operation to retrieve an in-process synchronization object. ntdll: Retrieve and cache an ntsync device in wait calls. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/7226

8 13

[PATCH v2 0/3] MR9006: Several fixes & improvements when winedbg is started in auto mode.
by eric pouech (＠epo) 04 Oct '25

04 Oct '25

This series covers various fixes & improvements when a crash happens in a program which fires up winedbg in auto mode. Firstly, winedbg is a bit too strict for detecting the startup sequence (and fails to display the backtrace in these stricter cases). Third patch relaxes the startup conditions in that case. Secondly, if failing programs is a GUI, winedbg is launched in a new console (since GUI are now detached from console), but console is closed after winedbg terminates (which is after printing the crash details). So rather not useful :-( To work around this, conhost in its configuration dialog has tab 'Configuration' / 'End of program' / 'Close console' checkbox But which is not implemented. Second patch add supports for this in conhost. Lastly, conhost has the ability to store configuration per application. Hence, one can configure conhost with specific settings for winedbg. Interesting options are: - setting very high buffer zone so that conhost keeps track of all winedbg output, - unchecking the 'Close console' option. To set it for winedbg, - start it with './wine wineconsole winedbg' - use 'Properties' from the menu (right-click in conhost) to set the options for winedbg Since 68f3a8e699904bd308de0da4a1e1d2c9eb91ea96, conhost doesn't pick the registry entry for winedbg (if it exists) when started with './wine wineconsole winedbg'. Third patch solves that in a somehow hacky way, but couldn't find a better option that doesn't break https://bugs.winehq.org/show_bug.cgi?id=10941 -- v2: winedbg: No longer expect a startup sequence in auto mode. conhost: Support the close-on-exit configuration option. programs/wineconsole: Ensure conhost gets the expected title. https://gitlab.winehq.org/wine/wine/-/merge_requests/9006

4 8

[PATCH v6 0/7] MR8910: widl: Add support for generating proxies/stubs for parameterized interfaces.
by Vibhav Pant (＠vibhavp) 03 Oct '25

03 Oct '25

This MR introduces a few minor changes to widl to support generating proxy code for WinRT's parameterized interfaces: * Use the mangled, C-friendly interface name for naming variables `FormatStringOffsetTable`, `StubThunkTable`, etc) in proxy and stub code. * Use the default interface of a runtime class while creating type format strings in `write_ip_tfs`. * When proxy generation is enabled, also compute UUIDs for all specialized parameterized interface declarations in imported files. Finally, I have also enabled proxy generation and registration for wintypes.dll as an example. We use the `PROXY_CLSID_IS` define as WinRT IDLs cannot use `coclass` to declare the `PSFactoryBuffer` class for the DLL. -- v6: wintypes: Register proxies for interfaces. include: Add size and length annotations for IVector(View) and IIterator method params. include: Remove duplicate interface declarations. widl: Ignore all #included runtimeclass statements while generating registry entries. https://gitlab.winehq.org/wine/wine/-/merge_requests/8910

4 13

[PATCH v8 0/4] MR9045: windows.devices.enumeration: Add support for device properties in DeviceInformation objects.
by Vibhav Pant (＠vibhavp) 03 Oct '25

03 Oct '25

-- v8: windows.devices.enumeration: Implement IDeviceInformationStatics::{FindAllAsyncAqsFilterAndAdditionalProperties, CreateWatcherAqsFilterAndAdditionalProperties}. https://gitlab.winehq.org/wine/wine/-/merge_requests/9045

3 14

[PATCH v2 0/2] MR9003: Draft: makedep: Add support for generating winmd files.
by Hans Leidekker (＠hans) 03 Oct '25

03 Oct '25

-- v2: wine.inf: Install windows.networking.winmd. makedep: Add support for generating winmd files. https://gitlab.winehq.org/wine/wine/-/merge_requests/9003

4 8

[PATCH v3 0/1] MR8722: mf: Add a SUBMITTED command state to avoid multiple submission of the same op.
by Yuxuan Shui (＠yshui) 03 Oct '25

03 Oct '25

If a session is shutdown when its command_state is already COMPLETE, session_handle_source_shutdown calls session_set_stopped, which calls session_command_complete which will submit the op at the head of commands again, despite it having already been submitted. Given that only the op at the head of commands can be in the submitted state, tracking it as a command state makes more sense to me. And if the command state is SUBMITTED we know not to submit the op again. * * * Superceded !8270 -- v3: mf: Add a SUBMITTED command state to avoid multiple submission of the same op. https://gitlab.winehq.org/wine/wine/-/merge_requests/8722

4 8

[PATCH 0/4] MR8925: winemac.drv: Add EDID support.
by Jactry Zeng (＠jactry) 02 Oct '25

02 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/8925

3 9

[PATCH 0/2] MR9049: winemac.drv: Don't crash when a window with a GL context is minimized
by Tim Clem (＠tclem) 02 Oct '25

02 Oct '25

Since 7b28c6d17c7da278307756cfcd0da830e5d39baf, we directly use `NtUserGetClientRect` to get the size of the GL target windows. But that returns an empty rect for minimized windows, and attempting to set a zero size on a CGL context in `-[WineOpenGLContext wine_updateBackingSize:]` causes a Metal assertion. You can see this by minimizing e.g. Geometry Dash or Garry's Mod. We could just not call wine_updateBackingSize if we find a zero dimension for the window, but I think we want to attempt to keep the backing size correct. Perhaps there's a better way to get the client rect of a minimized window than the un-AdjustWindowRect approach I'm using here? If the window is minimized fullscreen, `get_win_data(hwnd)->rects.client` is (-32000, -32000) - (-32000, -32000). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9049

4 6

[PATCH v3 0/4] MR8992: mountmgr.sys: Do not create empty registry nodes for serial or parallel devices.
by Janne Kekkonen (＠Janne) 02 Oct '25

02 Oct '25

Empty registry node for parallel devices will cause Realterm to crash. Wine-bug:https://bugs.winehq.org/show_bug.cgi?id=58598 -- v3: mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. mountmgr.sys: Do not create empty registry nodes for serial or parallel ports. https://gitlab.winehq.org/wine/wine/-/merge_requests/8992

3 5

2025

2024

2023

2022

wine-gitlab September 2025