September 2025 - wine-gitlab

[PATCH v19 0/3] MR8367: shell32: Add shield icon.
by James McDonnell (＠ElementalWarrior) 02 Oct '25

02 Oct '25

The missing shield icon was causing Affinity Photo's installer to fail to start. -- v19: shell32/tests: Check hIcon value is non-zero. https://gitlab.winehq.org/wine/wine/-/merge_requests/8367

3 5

[PATCH v3 0/3] MR9056: msxml3/element: Implement removeAttributeNode function.
by Reinhold Gschweicher (＠neroburner) 02 Oct '25

02 Oct '25

Implement the function `IXMLDOMElement_removeAttributeNode`. Essentially pass the hard work to `IXMLDOMNamedNodeMap_removeNamedItem`. Use the fact, that attribute names are unique in elements. One case that isn't checked is wheter or not the value of the provided attribute match with the one stored in the dom-element. This MR implements according to the tests introduced in https://gitlab.winehq.org/wine/wine/-/merge_requests/8928 -- v3: fix formatting of if clause https://gitlab.winehq.org/wine/wine/-/merge_requests/9056

4 7

[PATCH v2 0/1] MR8914: msxml: IXMLDOMNamedNodeMap::getNamedItem to handle global namespace.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Oct '25

02 Oct '25

-- v2: msxml: IXMLDOMNamedNodeMap::getNamedItem to handle global namespace. https://gitlab.winehq.org/wine/wine/-/merge_requests/8914

3 2

[PATCH 0/1] MR8406: wined3d: Make sure swapchain can't be used after being released.
by Yuxuan Shui (＠yshui) 01 Oct '25

01 Oct '25

In wined3d_swapchain_cleanup, before decrementing the reference counts of each of the back/front buffers, we first set their swapchain to NULL, presumably to stop the current under-destruction swapchain from being used through them. But there is an oversight. When we call wined3d_texture_decref on the front_buffer, the back_buffers still have their swapchains pointing to the swapchain being destroyed. In texture_resource_unload, we call context_acquire(device, NULL, 0), note the NULL texture parameter here. When the texture parameter is NULL, wined3d_context_gl_acquire (in turn called by context_acquire) will default to using the first back buffer from the implicit swapchain of "device", which, as previously stated, has not had their swapchain set to NULL yet. From here, we reach wined3d_context_gl_activate with a texture whose swapchain is currently being destroyed. This swapchain is then assigned to "context_gl" here before being freed, leaving a dangling pointer. When this context_gl is acquired again later, we will try to access context_gl->c.swapchain->win_handle, thus complete the use-after-free cycle. This commit makes sure the swapchain pointer of ALL front and back buffers are set to NULL before decrementing their reference counts. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58325 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8406

3 5

[PATCH 0/1] MR9080: win32u: Implement NtUserDisplayConfigGetDeviceInfo( DISPLAYCONFIG_DEVICE_INFO_GET_ADAPTER_NAME ).
by Paul Gofman (＠gofman) 01 Oct '25

01 Oct '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/9080

3 2

[PATCH 0/1] MR7576: windowscodecs: Remove IWICWineDecoder interface.
by Nikolay Sivov (＠nsivov) 01 Oct '25

01 Oct '25

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7576

3 3

[PATCH v2 0/1] MR9014: server: Create an inproc sync for user APC signaling.
by Rémi Bernon (＠rbernon) 01 Oct '25

01 Oct '25

Unlike the message queue for which I believe we can get rid of any special handling, I don't see a way to avoid a dedicated inproc sync for user APCs. This will make sure that the sync gets created on thread creation. It could arguably be lazily allocated instead, but I don't see a reason to delay the failure to a later time and end up with successfully created but unalertable thread when they are supposed to be. -- v2: server: Create an inproc sync for user APC signaling. https://gitlab.winehq.org/wine/wine/-/merge_requests/9014

4 7

[PATCH v2 0/4] MR9069: win32u: Avoid sending WM_CHITTEST from TrackMouseEvents() and make that mouse tracking a little bit more consistent.
by Paul Gofman (＠gofman) 01 Oct '25

01 Oct '25

-- v2: win32u: Track mouse events based on last mouse message data. win32u: Move mouse tracking info into per-thread data. win32u: Use internal message to hanlde NtUserTrackMouseEvent() for other thread window. user32/tests: Add test for (no) messages during TrackMouseEvent() call. https://gitlab.winehq.org/wine/wine/-/merge_requests/9069

3 7

[PATCH v2 0/4] MR2928: xmllite/writer: Implement more APIs
by David Kahurani (＠kahurani) 30 Sep '25

30 Sep '25

Implements or at least tries to implement: WriteName WriteQualifiedName WriteNmToken WriteEntityRef Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: xmllite/writer: Implement WriteQualifiedName. xmllite/writer: Implement WriteNmToken. xmllite/writer: Implement WriteEntityRef. xmllite/writer: Implement WriteName. https://gitlab.winehq.org/wine/wine/-/merge_requests/2928

4 8

Re: [PATCH v2 0/1] MR9070: ddraw/tests: Use ANSI versions of user32 functions. - approved
by Alexandre Julliard (＠julliard) 30 Sep '25

30 Sep '25

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9070

1 0

2025

2024

2023

2022

wine-gitlab September 2025