- wine-gitlab - winehq.org

Re: [PATCH v9 0/8] MR5342: shell32: fix some divergence with Windows in FindExecutable, ShellExecute, and PathResolve
by Robbert van der Helm (＠robbert-vdh) 28 May '24

28 May '24

Robbert van der Helm (@robbert-vdh) commented about dlls/shell32/shlexec.c: > wcmd = malloc(len * sizeof(WCHAR)); > wcmdLen = len; > } > - lstrcpyW(wcmd, wszApplicationName); > - if (sei_tmp.lpDirectory) > - { > - LPCWSTR searchPath[] = { > - sei_tmp.lpDirectory, > - NULL > - }; > - PathFindOnPathW(wcmd, searchPath); > - } > - retval = SHELL_quote_and_execute( wcmd, wszParameters, L"", > - wszApplicationName, NULL, &sei_tmp, The removal of this call seems to have the unintended side effect of breaking WoW64 Winelib loading. For instance, if `foo.exe.so` is a Winelib binary, and `wine` has been configured with `--with-wine64`, then `wine foo.exe.so` no longer works after this change. See Wine issue [#56483](https://bugs.winehq.org/show_bug.cgi?id=56483) for more details. I would fix this myself, but I'm lacking some context here. Do you happen to know why this change would affect the execution of Winelibs? I have not checked the specifics but the `.exe.so` file tends to not be in Wine's current directory, so the removal of `PathFindOnPathW` should be unrelated (unless its path resolving is specifically needed for this). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5342#note_66412

1 0

[PATCH v3 0/2] MR5405: winegstreamer: Fallback to input caps only when no parser was found.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

Which is what !5255 was supposed to do. -- v3: winegstreamer: Fallback to input caps only when no parser was found. winegstreamer: Create the transform parsed caps from wg_format. https://gitlab.winehq.org/wine/wine/-/merge_requests/5405

3 4

[PATCH v3 0/2] MR5415: d3d10: Use older compiler for D3D10CompileEffectFromMemory().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Compilation output from D3D10CompileEffectFromMemory() always contains $Globals buffer, even if it's empty. That matches behaviour of 33-39 compilers. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: d3d10/tests: Add a test for effect compilation containing empty buffers. d3d10: Use older compiler for D3D10CompileEffectFromMemory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5415

3 4

[PATCH v3 0/5] MR5409: winevulkan: Move create/destroy instance out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v3: winevulkan: Remove now unnecessary vkDestroyInstance driver entry. winevulkan: Remove now unnecessary vkCreateInstance driver entry. winevulkan: Introduce a new get_host_surface_extension driver entry. winevulkan: Remove now unnecessary vkEnumerateInstanceExtensionProperties driver entry. winevulkan: Strip surface extensions in vkEnumerateInstanceExtensionProperties. https://gitlab.winehq.org/wine/wine/-/merge_requests/5409

3 8

[PATCH v2 0/5] MR5409: winevulkan: Move create/destroy instance out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- v2: winevulkan: Remove now unnecessary vkDestroyInstance driver entry. winevulkan: Remove now unnecessary vkCreateInstance driver entry. winevulkan: Introduce a new get_host_surface_extension driver entry. winevulkan: Remove now unnecessary vkEnumerateInstanceExtensionProperties driver entry. winevulkan: Strip surface extensions in vkEnumerateInstanceExtensionProperties. https://gitlab.winehq.org/wine/wine/-/merge_requests/5409

3 12

[PATCH v2 0/1] MR5415: d3d10: Use older compiler for D3D10CompileEffectFromMemory().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Compilation output from D3D10CompileEffectFromMemory() always contains $Globals buffer, even if it's empty. That matches behaviour of 33-39 compilers. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: d3d10: Use older compiler for D3D10CompileEffectFromMemory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5415

2 2

[PATCH 0/1] MR5415: d3d10: Use older compiler for D3D10CompileEffectFromMemory().
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

Compilation output from D3D10CompileEffectFromMemory() always contains $Globals buffer, even if it's empty. That matches behaviour of 33-39 compilers. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5415

3 2

[PATCH 0/2] MR5416: makedep: Add import and static libs to all.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

They are otherwise only built during `make install` which doesn't seem right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5416

3 5

[PATCH v4 0/1] MR5381: ddraw: Don't demand WINED3D_BIND_SHADER_RESOURCE for making surface in vidmem.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- v4: ddraw: Don't demand WINED3D_BIND_SHADER_RESOURCE for making surface in vidmem. https://gitlab.winehq.org/wine/wine/-/merge_requests/5381

5 5

[PATCH 0/6] MR5409: winevulkan: Move create/destroy instance out of the drivers.
by Rémi Bernon (＠rbernon) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5409

4 12

2025

2024

2023

2022

wine-gitlab