On Thu Nov 27 09:57:49 2025 +0000, Rémi Bernon wrote:
Should we really have usSource == usDestination and usControl set to the SF2 source? I'm pretty outdated on SF2 but it would feel more natural for connections to follow `<src> -> <dst>` or `<src> mod <ctrl> -> <dst>` patterns, rather than a seemingly recursive `<dst> mod <ctrl> -> <dst>`?
Some SF2 generators already map to `<src> -> <dst>` connections, e.g. `SF_GEN_VIB_LFO_TO_PITCH` is mapped to `CONN_SRC_VIBRATO -> CONN_DST_PITCH`. There are also modulators that output to such generators, e.g. `SF_MOD_CTRL_GEN_CHAN_PRESSURE -> SF_GEN_VIB_LFO_TO_PITCH` which is mapped to `CONN_SRC_VIBRATO mod CONN_SRC_CHANNELPRESSURE -> CONN_DST_PITCH`. It's the latter case that is handled by this `else` branch.