Re: [PATCH v12 0/5] MR9112: XCOPY and COPY should not attempt to copy a file to itself.

[eric pouech (＠epo)]

On Fri Nov  7 16:01:45 2025 +0000, Joe Souza wrote:
> changed this line in [version 12 of the diff](/wine/wine/-/merge_requests/9112/diffs?diff_id=221996&start_sha=d1b2fb007749aaf28c26e9a3349a1561bd9b1799#50aa41b98a0279d229f39762936025608dbac8ab_524_524)

you could skip printing the prompt is IsSameFile is TRUE, and output the error message if CopyFileW fails (sharing violation + another call to is same file

yes that would make two calls to issamefile in the case of xcopy foo foo, but this makes the code simpler to read, and only overloads the error path in that very case

we would need a tristate variable in we wanted to call issamefile only once, but I'm not sure that's worth the effort

please also get rid of the label & goto in issamefile helper