[PATCH v2 8/9] windows.security.credentials.ui.userconsentverifier: Synchronize IAsyncInfo implementation in async.c.

[Paul Gofman]

From: Paul Gofman

---
 .../async.c                                   | 62 +++++++++++--------
 .../async_private.idl                         |  2 +-
 .../main.c                                    |  4 +-
 3 files changed, 39 insertions(+), 29 deletions(-)

diff --git a/dlls/windows.security.credentials.ui.userconsentverifier/async.c b/dlls/windows.security.credentials.ui.userconsentverifier/async.c
index ea9db53d197..5f81f338119 100644
--- a/dlls/windows.security.credentials.ui.userconsentverifier/async.c
+++ b/dlls/windows.security.credentials.ui.userconsentverifier/async.c
@@ -175,6 +175,39 @@ static HRESULT WINAPI async_impl_get_Result( IAsyncInfoImpl *iface, PROPVARIANT
     return hr;
 }

+static BOOL async_info_complete( struct async_info *impl, BOOL called_async )
+{
+    IInspectable *operation = impl->IInspectable_outer;
+    PROPVARIANT result = {0};
+    HRESULT hr;
+
+    hr = impl->callback( impl->invoker, impl->param, &result, called_async );
+    if (!called_async && hr == STATUS_PENDING) return FALSE;
+
+    EnterCriticalSection( &impl->cs );
+    if (impl->status != Closed) impl->status = FAILED(hr) ? Error : Completed;
+    PropVariantCopy( &impl->result, &result );
+    impl->hr = hr;
+
+    if (impl->handler != NULL && impl->handler != HANDLER_NOT_SET)
+    {
+        IAsyncOperationCompletedHandlerImpl *handler = impl->handler;
+        AsyncStatus status = impl->status;
+        impl->handler = NULL; /* Prevent concurrent invoke. */
+        LeaveCriticalSection( &impl->cs );
+
+        IAsyncOperationCompletedHandlerImpl_Invoke( handler, operation, status );
+        IAsyncOperationCompletedHandlerImpl_Release( handler );
+    }
+    else LeaveCriticalSection( &impl->cs );
+
+    /* release refcount acquired in Start */
+    IInspectable_Release( operation );
+
+    PropVariantClear( &result );
+    return TRUE;
+}
+
 static HRESULT WINAPI async_impl_Start( IAsyncInfoImpl *iface )
 {
     struct async_info *impl = impl_from_IAsyncInfoImpl( iface );
@@ -183,7 +216,7 @@ static HRESULT WINAPI async_impl_Start( IAsyncInfoImpl *iface )

/* keep the async alive in the callback */
     IInspectable_AddRef( impl->IInspectable_outer );
-    SubmitThreadpoolWork( impl->async_run_work );
+    if (!async_info_complete( impl, FALSE )) SubmitThreadpoolWork( impl->async_run_work );

return S_OK;
 }
@@ -305,33 +338,8 @@ static const struct IAsyncInfoVtbl async_info_vtbl =
 static void CALLBACK async_info_callback( TP_CALLBACK_INSTANCE *instance, void *iface, TP_WORK *work )
 {
     struct async_info *impl = impl_from_IAsyncInfoImpl( iface );
-    IInspectable *operation = impl->IInspectable_outer;
-    PROPVARIANT result = {0};
-    HRESULT hr;
-
-    hr = impl->callback( impl->invoker, impl->param, &result );
-
-    EnterCriticalSection( &impl->cs );
-    if (impl->status != Closed) impl->status = FAILED(hr) ? Error : Completed;
-    PropVariantCopy( &impl->result, &result );
-    impl->hr = hr;

-    if (impl->handler != NULL && impl->handler != HANDLER_NOT_SET)
-    {
-        IAsyncOperationCompletedHandlerImpl *handler = impl->handler;
-        AsyncStatus status = impl->status;
-        impl->handler = NULL; /* Prevent concurrent invoke. */
-        LeaveCriticalSection( &impl->cs );
-
-        IAsyncOperationCompletedHandlerImpl_Invoke( handler, operation, status );
-        IAsyncOperationCompletedHandlerImpl_Release( handler );
-    }
-    else LeaveCriticalSection( &impl->cs );
-
-    /* release refcount acquired in Start */
-    IInspectable_Release( operation );
-
-    PropVariantClear( &result );
+    async_info_complete( impl, TRUE );
 }

static HRESULT async_info_create( IUnknown *invoker, IUnknown *param, async_operation_callback callback,
diff --git a/dlls/windows.security.credentials.ui.userconsentverifier/async_private.idl b/dlls/windows.security.credentials.ui.userconsentverifier/async_private.idl
index 10741572601..40ea63ca4c1 100644
--- a/dlls/windows.security.credentials.ui.userconsentverifier/async_private.idl
+++ b/dlls/windows.security.credentials.ui.userconsentverifier/async_private.idl
@@ -42,5 +42,5 @@ namespace Wine.Internal {
         HRESULT Start();
     }

-    typedef HRESULT (*async_operation_callback)( IUnknown *invoker, IUnknown *param, PROPVARIANT *result );
+    typedef HRESULT (*async_operation_callback)( IUnknown *invoker, IUnknown *param, PROPVARIANT *result, BOOL called_async );
 }
diff --git a/dlls/windows.security.credentials.ui.userconsentverifier/main.c b/dlls/windows.security.credentials.ui.userconsentverifier/main.c
index e3c5e783f6d..51ba6350ea7 100644
--- a/dlls/windows.security.credentials.ui.userconsentverifier/main.c
+++ b/dlls/windows.security.credentials.ui.userconsentverifier/main.c
@@ -118,8 +118,10 @@ static const struct IActivationFactoryVtbl factory_vtbl =

DEFINE_IINSPECTABLE( user_consent_verifier_statics, IUserConsentVerifierStatics, struct user_consent_verifier_statics, IActivationFactory_iface )

-static HRESULT check_availability_async( IUnknown *invoker, IUnknown *param, PROPVARIANT *result )
+static HRESULT check_availability_async( IUnknown *invoker, IUnknown *param, PROPVARIANT *result, BOOL called_async )
 {
+    if (!called_async) return STATUS_PENDING;
+
     result->vt = VT_UI4;
     result->ulVal = UserConsentVerifierAvailability_DeviceNotPresent;
     return S_OK;