On Fri Nov 28 20:28:01 2025 +0000, Rémi Bernon wrote:
Well, idk. IMO it's not a good thing to spread semi-stubbed async implementations around when they are all supposed to be implemented based on some common templates. If our shared code isn't capable of creating completed asyncs maybe it should be added, but it should probably be added everywhere and given the number of duplicates already that doesn't sound very exciting. In this particular case I don't think we consider Win10 as an old and unsupported Windows version already, and so making the async go through the threadpool seems acceptable to me.
I can add similar interface change (adding a possibility to complete async) throughout the other instances of async.c if you think it is better. I can also change windows.speech thing to use the same. Will that help?
But honestly I don't want to add the wrong way of completing request, it is a way to not immediately obvious (as sync-related) bugs. If we have the choice between old behaviour and new one we should be prefering newer. It is not really more complicated in this case, rather the opposite, the only complication is that existing wrapper doesn't support it and I believe we'd be better off fixing that instead.