Re: [PATCH 0/5] MR9607: dmusic: SF2 fixes, part 4

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmusic/instrument.c:
> -
>    }
> -
>    else
> -
>    {
> -
>        conn->usSource = gen_to_conn_src[mod->dest_gen];
> -
>        conn->usControl = mod_src_to_conn_src(mod->src_mod);
> -
>        src_transform = CONN_TRN_NONE;
> -
>        ctrl_transform = mod_src_to_conn_transform(mod->src_mod);
> -
>    }
> -
>    conn->usTransform = (src_transform << 10) | (ctrl_transform << 4);
> -
> -
>    if (mod->dest_gen == SF_GEN_SUSTAIN_MOD_ENV || mod->dest_gen == SF_GEN_SUSTAIN_VOL_ENV)
> -
>        conn->lScale = mod->amount * -65536;
> -
>    else if (mod->dest_gen == SF_GEN_MOD_LFO_TO_VOLUME && mod->src_mod == SF_MOD_CTRL_GEN_CHAN_PRESSURE)
> -
>        conn->lScale = mod->amount * 655360;
> -
>    else if (mod->amount == -32768)
> -
>        conn->lScale = 0x80000000;

Same