I'm sorry but this has been merged without my approval, when I had explicitly requested changes to the code which I found ugly and inconsistent, by squeezing the change to a different MR which I wasn't assigned to.
I really don’t see why this is being made into such a big issue. The final version of !9263 never received any comments. I tried to address all of your comments, both ones that I found reasonable and the ones that I didn't.
I realize now that you’re probably referring to a comment buried in a thread where I was focused on explaining how those basic OpenGL functions work. If there was a problem, one more simple comment would have been enough in my view. It was just an oversight.
The whole change has always been part of !9032 in my tree. I split it out because that part was ready sooner, but I think applying it all together seemed equally fine. Since I considered !9032 ready, I saw no reason to keep it as a draft. I also believe merging it was the right call. Nothing in this MR seems worth delaying a release cycle of testing for a major feature.
I can’t help but notice that not a single comment in !9263 was about correctness. I also still think that if you’d considered my comments about the longer-term plans, it would be clearer why the initial version was a better fit than this ad-hoc tokenizing approach.
I believe code should be kept consistent to avoid wasting our time on such considerations.
Since we both agree it’s a waste of time, could you please stop making such a big deal out of it?