Kai Blin : secur32: Avoid double HeapFree() of password and session key.

Alexandre Julliard julliard at wine.codeweavers.com
Sat Nov 4 13:32:35 CST 2006


Module: wine
Branch: master
Commit: 0c3f45eda0341ab03eb6cebb8e9a3e8813c90b25
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0c3f45eda0341ab03eb6cebb8e9a3e8813c90b25

Author: Kai Blin <kai.blin at gmail.com>
Date:   Sat Nov  4 02:50:31 2006 +0100

secur32: Avoid double HeapFree() of password and session key.

---

 dlls/secur32/dispatcher.c |    1 -
 dlls/secur32/ntlm.c       |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/dlls/secur32/dispatcher.c b/dlls/secur32/dispatcher.c
index 7b5d6af..b7b9f9d 100644
--- a/dlls/secur32/dispatcher.c
+++ b/dlls/secur32/dispatcher.c
@@ -257,7 +257,6 @@ void cleanup_helper(PNegoHelper helper)
     if( (helper == NULL) || (helper->helper_pid == 0))
         return;
 
-    HeapFree(GetProcessHeap(), 0, helper->password);
     HeapFree(GetProcessHeap(), 0, helper->com_buf);
     HeapFree(GetProcessHeap(), 0, helper->session_key);
 
diff --git a/dlls/secur32/ntlm.c b/dlls/secur32/ntlm.c
index 6c340d2..8f124d7 100644
--- a/dlls/secur32/ntlm.c
+++ b/dlls/secur32/ntlm.c
@@ -1373,7 +1373,6 @@ static SECURITY_STATUS SEC_ENTRY ntlm_Fr
         PNegoHelper helper = (PNegoHelper) phCredential->dwLower;
         phCredential->dwUpper = 0;
         phCredential->dwLower = 0;
-        HeapFree(GetProcessHeap(), 0, helper->session_key);
         cleanup_helper(helper);
         ret = SEC_E_OK;
     }




More information about the wine-cvs mailing list