[PATCH] testbot/WineSendLog: Report TestBot errors to the mailing list too.

Francois Gouget fgouget at codeweavers.com
Wed Aug 29 18:59:53 CDT 2018


TestBot errors may or may not be caused by the patch but either way
they make it impossible to know if there are new errors. Thus the patch
requires extra scrutiny anyway.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineSendLog.pl | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index b0efa8c33..a4b1c823d 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -279,13 +279,10 @@ EOF
     my $StepTask = $StepsTasks->GetItem($Key);
     my $TaskDir = $StepTask->GetTaskDir();
 
-    if ($StepTask->Status eq "boterror")
-    {
-      # TestBot errors are not the developer's fault and prevent us from
-      # identifying new errors. So skip.
-      Error "A Task error was found in '$TaskDir/log.err'\n";
-      next;
-    }
+    # Note: We could check $StepTask->Status for TestBot errors. However,
+    # whether they are caused by the patch or not, they prevent the TestBot
+    # from checking for new errors which justifies sending an email to the
+    # mailing list so that the patch receives greater scrutiny.
 
     foreach my $LogName (@{$JobErrors->{$Key}->{LogNames}})
     {
-- 
2.18.0




More information about the wine-devel mailing list