[PATCH 0/4] MR233: win32u: Partially move raw input APIs.
Rémi Bernon (@rbernon)
wine at gitlab.winehq.org
Mon Jun 13 03:43:40 CDT 2022
Rémi Bernon (@rbernon) commented about dlls/win32u/rawinput.c:
> + if (!rawinput_from_hardware_message( data, msg_data )) break;
> + if (overhead)
> + memmove( (char *)&data->data + overhead, &data->data,
> + data->header.dwSize - sizeof(RAWINPUTHEADER) );
> + data->header.dwSize += overhead;
> + remaining -= data->header.dwSize;
> + data = NEXTRAWINPUTBLOCK(data);
> + msg_data = (struct hardware_msg_data *)((char *)msg_data + msg_data->size);
> + }
> +
> + if (!next_size)
> + {
> + if (!count)
> + *data_size = 0;
> + else
> + next_size = rawinput_size;
NP: The new nested if is fine but single line ifs inside could be nicer imho.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/233#note_1941
More information about the wine-devel
mailing list