[Bug 1956] [PATCH] Incorrect random multicast MAC address creation in UUID generator

[Tony Lambregts]

Ralf S. Engelschall wrote:
> On Sun, Mar 13, 2005, Wine Bugs wrote:
> 
> 
>> the way UuidCreate() was impliment was changed by this patch:
>> 
>> Hans Leidekker <hans at it.vu.nl> Reimplement UuidCreate() with Win32 APIs.
>> 
>> http://www.winehq.org/hypermail/wine-cvs/2004/04/0380.html
>> 
>> I am not sure that this bug is actually fixed though
> 
> 
> No, it isn't.
> 
> According to the change there is still the following fix in the function
> RPC_UuidGetNodeAddress() necessary:
> 
> -   address[0] |= 0x80; +   address[0] |= 0x01;
> 
> 
Ralf:

First off thanks for your prompt reply. Technically you should have added this
comment to the bug report though. ;-)

I have attached a patch to fix this and am sending this to wine patches as well.

Alexandre:

If you have questions about this patch please look at bug 1956

http://bugs.winehq.org/show_bug.cgi?id=1956

Change Log: Ralf S. Engelschall <rse at engelschall.com>
             Fix Incorrect random multicast MAC address creation.

Files Changed: dlls/rpcrt4/rpcrt4_main.c

-------------- next part --------------
Index: dlls/rpcrt4/rpcrt4_main.c
===================================================================
RCS file: /home/wine/wine/dlls/rpcrt4/rpcrt4_main.c,v
retrieving revision 1.52
diff -u -r1.52 rpcrt4_main.c
--- dlls/rpcrt4/rpcrt4_main.c	14 Jan 2005 15:11:40 -0000	1.52
+++ dlls/rpcrt4/rpcrt4_main.c	13 Mar 2005 23:18:24 -0000
@@ -349,7 +349,7 @@
             address[i] = rand() & 0xff;
         }
 
-        address[0] |= 0x80;
+        address[0] |= 0x01;
         status = RPC_S_UUID_LOCAL_ONLY;
     }