[PATCH 2/2] winmm: Parse MCI colon notation as in T:MM:SS:F
Joerg-Cyril.Hoehle at t-systems.com
Joerg-Cyril.Hoehle at t-systems.com
Mon Mar 14 02:53:07 CDT 2011
Hi,
finally, the colon syntax parser to allow you to easily play an audio CD.
Unsurprisingly, colon notation works everywhere, since the parser has no idea of the semantic of the input, all it knows is MCI_INTEGER.
The strtol family of functions really prevent reliable software.
Their skipping of whitespace may be practical for PERL, but here
it allows bogus input like "2: 1:4: 3" to be accepted as colon syntax.
Truly, there should be a third patch to this series, but I've not written it yet. Negative integers must be accepted as well, as in
put a window at -3 -5 200 100
step a by -1 ; synonym to step a by 1 reverse
Testbot may choke at this patch, as it touches two test files.
A patch to dlls/winmm/tests/mci.c alone was sent to testbot some time ago.
Regards,
Jörg Höhle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-winmm-Parse-MCI-colon-notation-as-in-T-MM-SS-F.patch
Type: application/octet-stream
Size: 6078 bytes
Desc: 0002-winmm-Parse-MCI-colon-notation-as-in-T-MM-SS-F.patch
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20110314/14210079/attachment.obj>
More information about the wine-patches
mailing list