January 2010 - Wine-commits

Christian Costa : d3drm: Add definitions for IDirect3DRMFrame.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 547eb0367ac4959a66c5de81a3d617bdf212661e URL: http://source.winehq.org/git/wine.git/?a=commit;h=547eb0367ac4959a66c5de81a… Author: Christian Costa <titan.costa(a)wanadoo.fr> Date: Fri Jan 15 11:37:07 2010 +0100 d3drm: Add definitions for IDirect3DRMFrame. --- include/d3drmdef.h | 37 ++++++++ include/d3drmobj.h | 232 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 269 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=547eb0367ac4959a66c5d…

1 0

Christian Costa : d3drm: Add definitions for IDirect3DRMFrame2.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 2f5cca9481f7d82a73269e62e6798d9252850a98 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2f5cca9481f7d82a73269e62e… Author: Christian Costa <titan.costa(a)wanadoo.fr> Date: Fri Jan 15 11:37:13 2010 +0100 d3drm: Add definitions for IDirect3DRMFrame2. --- include/d3drmdef.h | 18 ++++ include/d3drmobj.h | 280 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 298 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2f5cca9481f7d82a73269…

1 0

Christian Costa : d3drm: Add definitions for IDirect3DRMFrame3.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: e95645d897ef294990663e3aaa9b180117a09719 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e95645d897ef294990663e3aa… Author: Christian Costa <titan.costa(a)wanadoo.fr> Date: Fri Jan 15 11:37:20 2010 +0100 d3drm: Add definitions for IDirect3DRMFrame3. --- include/d3drmdef.h | 11 ++ include/d3drmobj.h | 299 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 310 insertions(+), 0 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e95645d897ef294990663…

1 0

Dmitry Timoshkov : winmm: Buffer size must be at least MMIO_DEFAULTBUFFER ( 8192) bytes.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 7639ea31849e2fbc7654515818ecbc5ca53f9893 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7639ea31849e2fbc765451581… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Thu Jan 14 13:52:14 2010 -0600 winmm: Buffer size must be at least MMIO_DEFAULTBUFFER (8192) bytes. mmioOpen() with the length of buffer set to 0 expects the buffer to be at least MMIO_DEFAULTBUFFER (8192) bytes in size, and using buffer of smaller size can lead to various problems when the buffer actually gets used. --- dlls/winmm/tests/mmio.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/winmm/tests/mmio.c b/dlls/winmm/tests/mmio.c index 79ae031..d7218ea 100644 --- a/dlls/winmm/tests/mmio.c +++ b/dlls/winmm/tests/mmio.c @@ -199,7 +199,7 @@ static void test_mmioDescend(char *fname) static void test_mmioOpen(char *fname) { - char buf[256]; + char buf[MMIO_DEFAULTBUFFER]; MMRESULT ret; HMMIO hmmio; MMIOINFO mmio;

1 0

André Hentschel : msvcrt: Forward __C_specific_handler to ntdll.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: a65738061218079ec813dc5d52c311d0331a075c URL: http://source.winehq.org/git/wine.git/?a=commit;h=a65738061218079ec813dc5d5… Author: André Hentschel <nerv(a)dawncrow.de> Date: Thu Jan 14 20:52:06 2010 +0100 msvcrt: Forward __C_specific_handler to ntdll. --- dlls/msvcrt/msvcrt.spec | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 721bdbc..ff7d971 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -78,6 +78,7 @@ @ cdecl __CppXcptFilter(long ptr) @ cdecl __CxxDetectRethrow(ptr) @ cdecl -i386 -norelay __CxxFrameHandler(ptr ptr ptr ptr) +@ stdcall -arch=x86_64 __C_specific_handler(ptr long ptr ptr) ntdll.__C_specific_handler @ stdcall -i386 __CxxLongjmpUnwind(ptr) @ cdecl __CxxQueryExceptionSize() @ cdecl __RTCastToVoid(ptr) MSVCRT___RTCastToVoid

1 0

Stefan Leichter : user.exe: Forward WNetGetUser16 to WNetGetUserA of mpr. dll, based on a patch from Andrew Nguyen.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 5ef5ead15fbebc52b799e1b5e59a52f69aed01b3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5ef5ead15fbebc52b799e1b5e… Author: Stefan Leichter <Stefan.Leichter(a)camline.com> Date: Thu Jan 14 21:09:54 2010 +0100 user.exe: Forward WNetGetUser16 to WNetGetUserA of mpr.dll, based on a patch from Andrew Nguyen. --- dlls/user.exe16/Makefile.in | 2 +- dlls/user.exe16/network.c | 23 ++++++++++++++++++++--- dlls/user.exe16/user.exe16.spec | 2 +- include/wine/winnet16.h | 2 +- 4 files changed, 23 insertions(+), 6 deletions(-) diff --git a/dlls/user.exe16/Makefile.in b/dlls/user.exe16/Makefile.in index 9efa686..e5015cb 100644 --- a/dlls/user.exe16/Makefile.in +++ b/dlls/user.exe16/Makefile.in @@ -3,7 +3,7 @@ TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ MODULE = user.exe16 -IMPORTS = user32 gdi32 kernel32 kernel ntdll +IMPORTS = mpr user32 gdi32 kernel32 kernel ntdll EXTRADLLFLAGS = -Wb,--subsystem,win16,--main-module,user32.dll,--heap,65520 EXTRARCFLAGS = -O res16 diff --git a/dlls/user.exe16/network.c b/dlls/user.exe16/network.c index 105d016..8dc31b1 100644 --- a/dlls/user.exe16/network.c +++ b/dlls/user.exe16/network.c @@ -30,6 +30,7 @@ #include "windef.h" #include "winbase.h" +#include "winnetwk.h" #include "wine/winnet16.h" #include "wine/debug.h" @@ -306,10 +307,26 @@ WORD WINAPI WNetGetCaps16( WORD capability ) /************************************************************************** * WNetGetUser [USER.516] */ -WORD WINAPI WNetGetUser16( LPCSTR lpName, LPSTR szUser, LPINT16 nBufferSize ) +WORD WINAPI WNetGetUser16( LPSTR szUser, LPINT16 nBufferSize ) { - FIXME( "(%p, %p, %p): stub\n", lpName, szUser, nBufferSize ); - return WN16_NOT_SUPPORTED; + DWORD lpBufferSize, ret; + + if(!szUser || !nBufferSize) return WN16_BAD_POINTER; + + lpBufferSize = *nBufferSize; + ret = WNetGetUserA( NULL, szUser, &lpBufferSize ); + *nBufferSize = lpBufferSize; + + switch (ret) + { + case NO_ERROR: + return WN16_SUCCESS; + case ERROR_MORE_DATA: + return WN16_MORE_DATA; + default: + FIXME("Untranslated return value %d\n", ret); + } + return ret; } diff --git a/dlls/user.exe16/user.exe16.spec b/dlls/user.exe16/user.exe16.spec index 517ced8..7094f47 100644 --- a/dlls/user.exe16/user.exe16.spec +++ b/dlls/user.exe16/user.exe16.spec @@ -463,7 +463,7 @@ 513 pascal -ret16 WNetGetCaps(word) WNetGetCaps16 514 pascal -ret16 WNetDeviceMode(word) WNetDeviceMode16 515 pascal -ret16 WNetBrowseDialog(word word ptr) WNetBrowseDialog16 -516 pascal -ret16 WNetGetUser(ptr ptr ptr) WNetGetUser16 +516 pascal -ret16 WNetGetUser(ptr ptr) WNetGetUser16 517 pascal -ret16 WNetAddConnection(str str str) WNetAddConnection16 518 pascal -ret16 WNetCancelConnection(str word) WNetCancelConnection16 519 pascal -ret16 WNetGetError(ptr) WNetGetError16 diff --git a/include/wine/winnet16.h b/include/wine/winnet16.h index 8f04860..15b046e 100644 --- a/include/wine/winnet16.h +++ b/include/wine/winnet16.h @@ -199,7 +199,7 @@ WORD WINAPI WNetGetCaps16(WORD); * Get User */ -WORD WINAPI WNetGetUser16(LPCSTR,LPSTR,LPINT16); +WORD WINAPI WNetGetUser16(LPSTR,LPINT16); /*

1 0

Michael Stefaniuc : d3d10: Remove superfluous NULL check before HeapFree ( Smatch).
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 5cc257e5c215b4538512924eaedbd46ab80e77ea URL: http://source.winehq.org/git/wine.git/?a=commit;h=5cc257e5c215b4538512924ea… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Jan 14 21:58:05 2010 +0100 d3d10: Remove superfluous NULL check before HeapFree (Smatch). --- dlls/d3d10/effect.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/dlls/d3d10/effect.c b/dlls/d3d10/effect.c index ae757f3..9dc94b6 100644 --- a/dlls/d3d10/effect.c +++ b/dlls/d3d10/effect.c @@ -1726,10 +1726,7 @@ static void d3d10_effect_pass_destroy(struct d3d10_effect_pass *p) TRACE("pass %p\n", p); HeapFree(GetProcessHeap(), 0, p->name); - if (p->objects) - { - HeapFree(GetProcessHeap(), 0, p->objects); - } + HeapFree(GetProcessHeap(), 0, p->objects); if (p->annotations) {

1 0

Michael Stefaniuc : d3d10: Remove break after return (Smatch).
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: ea5896861f8af68d256938e33fc38068d3870748 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ea5896861f8af68d256938e33… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Jan 14 21:58:11 2010 +0100 d3d10: Remove break after return (Smatch). --- dlls/d3d10/effect.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/d3d10/effect.c b/dlls/d3d10/effect.c index 9dc94b6..f31bddd 100644 --- a/dlls/d3d10/effect.c +++ b/dlls/d3d10/effect.c @@ -308,7 +308,6 @@ static HRESULT parse_shader(struct d3d10_effect_variable *v, const char *data) default: ERR("This should not happen!\n"); return E_FAIL; - break; } return parse_dxbc(ptr, dxbc_size, shader_chunk_handler, s);

1 0

Nikolay Sivov : msxml3: Don't preallocate root element, return new instance on each call.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 5afdfaba86f089dfef6f2ad2897321c3dc540f12 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5afdfaba86f089dfef6f2ad28… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Fri Jan 15 00:10:22 2010 +0300 msxml3: Don't preallocate root element, return new instance on each call. --- dlls/msxml3/tests/xmldoc.c | 7 ++ dlls/msxml3/tests/xmlelem.c | 136 +++++++++++++++++++++++++++++++++++++++--- dlls/msxml3/xmldoc.c | 15 ++--- 3 files changed, 139 insertions(+), 19 deletions(-) diff --git a/dlls/msxml3/tests/xmldoc.c b/dlls/msxml3/tests/xmldoc.c index 7cc6cd5..aadf088 100644 --- a/dlls/msxml3/tests/xmldoc.c +++ b/dlls/msxml3/tests/xmldoc.c @@ -141,6 +141,13 @@ static void test_xmldoc(void) ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); ok(element != NULL, "Expected non-NULL element\n"); + /* ::root() returns new instance each time */ + hr = IXMLDocument_get_root(doc, &child); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(child != NULL, "Expected non-NULL element\n"); + ok(child != element, "Expected new element instance\n"); + IXMLElement_Release(child); + hr = IXMLElement_get_type(element, &type); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); ok(type == XMLELEMTYPE_ELEMENT, "Expected XMLELEMTYPE_ELEMENT, got %d\n", type); diff --git a/dlls/msxml3/tests/xmlelem.c b/dlls/msxml3/tests/xmlelem.c index 1738b2c..38b621f 100644 --- a/dlls/msxml3/tests/xmlelem.c +++ b/dlls/msxml3/tests/xmlelem.c @@ -53,11 +53,7 @@ static void test_xmlelem(void) hr = CoCreateInstance(&CLSID_XMLDocument, NULL, CLSCTX_INPROC_SERVER, &IID_IXMLDocument, (LPVOID*)&doc); - if (FAILED(hr)) - { - skip("Failed to create XMLDocument instance\n"); - return; - } + ok(hr == S_OK, "Expected S_OK, got 0x%08x\n", hr); V_VT(&vType) = VT_I4; V_I4(&vType) = XMLELEMTYPE_ELEMENT; @@ -265,11 +261,7 @@ static void test_xmlelem_collection(void) hr = CoCreateInstance(&CLSID_XMLDocument, NULL, CLSCTX_INPROC_SERVER, &IID_IXMLDocument, (LPVOID*)&doc); - if (FAILED(hr)) - { - skip("Failed to create XMLDocument instance\n"); - return; - } + ok(hr == S_OK, "Expected S_OK, got 0x%08x\n", hr); create_xml_file(szBankXML); GetFullPathNameA(szBankXML, MAX_PATH, pathA, NULL); @@ -438,6 +430,123 @@ cleanup: DeleteFileA("bank.xml"); } +static void test_xmlelem_children(void) +{ + IXMLDocument *doc = NULL; + IXMLElement *element = NULL, *child = NULL, *child2 = NULL; + IXMLElementCollection *collection = NULL; + VARIANT vType, vName, vIndex; + LONG length; + HRESULT hr; + + hr = CoCreateInstance(&CLSID_XMLDocument, NULL, CLSCTX_INPROC_SERVER, + &IID_IXMLDocument, (LPVOID*)&doc); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + V_VT(&vType) = VT_I4; + V_I4(&vType) = XMLELEMTYPE_ELEMENT; + V_VT(&vName) = VT_NULL; + hr = IXMLDocument_createElement(doc, vType, vName, &element); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(element != NULL, "Expected non-NULL element\n"); + + V_VT(&vType) = VT_I4; + V_I4(&vType) = XMLELEMTYPE_TEXT; + V_VT(&vName) = VT_NULL; + hr = IXMLDocument_createElement(doc, vType, vName, &child); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(child != NULL, "Expected non-NULL child\n"); + + V_VT(&vType) = VT_I4; + V_I4(&vType) = XMLELEMTYPE_TEXT; + V_VT(&vName) = VT_NULL; + hr = IXMLDocument_createElement(doc, vType, vName, &child2); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(child2 != NULL, "Expected non-NULL child\n"); + + hr = IXMLElement_addChild(element, child, 0, -1); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + hr = IXMLElement_get_children(element, &collection); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(collection != NULL, "Expected non-NULL collection\n"); + + length = 0; + hr = IXMLElementCollection_get_length(collection, &length); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(length == 1, "Expected 1, got %08x\n", length); + + /* remove/add child and check what happens with collection */ + hr = IXMLElement_removeChild(element, child); + todo_wine ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + length = -1; + hr = IXMLElementCollection_get_length(collection, &length); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + todo_wine ok(length == 0, "Expected 0, got %08x\n", length); + IXMLElementCollection_Release(collection); + + hr = IXMLElement_AddRef(child); + ok(hr == 2, "Expected 2, got %08x\n", hr); + IXMLElement_Release(child); + hr = IXMLElement_addChild(element, child, 0, -1); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + hr = IXMLElement_AddRef(child); + ok(hr == 2, "Expected 2, got %08x\n", hr); + IXMLElement_Release(child); + hr = IXMLElement_addChild(element, child2, 0, -1); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + hr = IXMLElement_get_children(element, &collection); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(collection != NULL, "Expected non-NULL collection\n"); + + hr = IXMLElement_AddRef(child); + ok(hr == 2, "Expected 2, got %08x\n", hr); + IXMLElement_Release(child); + + length = 0; + hr = IXMLElementCollection_get_length(collection, &length); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(length == 2, "Expected 2, got %08x\n", length); + + IXMLElement_Release(child2); + + length = 0; + hr = IXMLElementCollection_get_length(collection, &length); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(length == 2, "Expected 2, got %08x\n", length); + + V_VT(&vIndex) = VT_I4; + V_I4(&vIndex) = 1; + hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child2); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(child2 != NULL, "Expected not NULL child\n"); + + IXMLElement_Release(element); + IXMLElement_Release(child); + IXMLElementCollection_Release(collection); + IXMLDocument_Release(doc); +} + + +static BOOL test_try_xmldoc(void) +{ + IXMLDocument *doc = NULL; + HRESULT hr; + + hr = CoCreateInstance(&CLSID_XMLDocument, NULL, CLSCTX_INPROC_SERVER, + &IID_IXMLDocument, (LPVOID*)&doc); + if (FAILED(hr)) + { + skip("Failed to create XMLDocument instance\n"); + return FALSE; + } + + IXMLDocument_Release(doc); + return TRUE; +} + START_TEST(xmlelem) { HRESULT hr; @@ -445,8 +554,15 @@ START_TEST(xmlelem) hr = CoInitialize(NULL); ok(hr == S_OK, "failed to init com\n"); + if (!test_try_xmldoc()) + { + CoUninitialize(); + return; + } + test_xmlelem(); test_xmlelem_collection(); + test_xmlelem_children(); CoUninitialize(); } diff --git a/dlls/msxml3/xmldoc.c b/dlls/msxml3/xmldoc.c index cf39cc5..af67d4e 100644 --- a/dlls/msxml3/xmldoc.c +++ b/dlls/msxml3/xmldoc.c @@ -54,7 +54,6 @@ typedef struct _xmldoc HRESULT error; /* IXMLDocument */ - IXMLElement *root; xmlDocPtr xmldoc; /* IPersistStream */ @@ -198,17 +197,19 @@ static HRESULT WINAPI xmldoc_Invoke(IXMLDocument *iface, DISPID dispIdMember, static HRESULT WINAPI xmldoc_get_root(IXMLDocument *iface, IXMLElement **p) { xmldoc *This = impl_from_IXMLDocument(iface); + xmlNodePtr root; TRACE("(%p, %p)\n", iface, p); if (!p) return E_INVALIDARG; - *p = This->root; - if (!*p) + *p = NULL; + + if (!(root = xmlDocGetRootElement(This->xmldoc))) return E_FAIL; - return S_OK; + return XMLElement_create((IUnknown *)This, root, (LPVOID *)p); } static HRESULT WINAPI xmldoc_get_fileSize(IXMLDocument *iface, BSTR *p) @@ -604,7 +605,6 @@ static HRESULT WINAPI xmldoc_IPersistStreamInit_Load( IPersistStreamInit *iface, LPSTREAM pStm) { xmldoc *This = impl_from_IPersistStreamInit(iface); - xmlNodePtr xmlnode; HRESULT hr; HGLOBAL hglobal; DWORD read, written, len; @@ -653,9 +653,7 @@ static HRESULT WINAPI xmldoc_IPersistStreamInit_Load( return E_FAIL; } - if (This->root) IXMLElement_Release(This->root); - xmlnode = xmlDocGetRootElement(This->xmldoc); - return XMLElement_create((IUnknown *)This, xmlnode, (LPVOID *)&This->root); + return S_OK; } static HRESULT WINAPI xmldoc_IPersistStreamInit_Save( @@ -708,7 +706,6 @@ HRESULT XMLDocument_create(IUnknown *pUnkOuter, LPVOID *ppObj) doc->lpvtblIPersistStreamInit = &xmldoc_IPersistStreamInit_VTable; doc->ref = 1; doc->error = S_OK; - doc->root = NULL; doc->xmldoc = NULL; doc->stream = NULL;

1 0

Nikolay Sivov : msxml3: Implement IXMLElement::removeChild() with some tests.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 7f5cedf70aa01f23ee7a6a92c63e62405c9adc88 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f5cedf70aa01f23ee7a6a92c… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Fri Jan 15 00:13:50 2010 +0300 msxml3: Implement IXMLElement::removeChild() with some tests. --- dlls/msxml3/tests/xmlelem.c | 26 +++++++++++++++++++++++--- dlls/msxml3/xmlelem.c | 17 +++++++++++++++-- 2 files changed, 38 insertions(+), 5 deletions(-) diff --git a/dlls/msxml3/tests/xmlelem.c b/dlls/msxml3/tests/xmlelem.c index 38b621f..dec1464 100644 --- a/dlls/msxml3/tests/xmlelem.c +++ b/dlls/msxml3/tests/xmlelem.c @@ -478,7 +478,7 @@ static void test_xmlelem_children(void) /* remove/add child and check what happens with collection */ hr = IXMLElement_removeChild(element, child); - todo_wine ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); length = -1; hr = IXMLElementCollection_get_length(collection, &length); @@ -522,14 +522,34 @@ static void test_xmlelem_children(void) hr = IXMLElementCollection_item(collection, vIndex, vName, (IDispatch **)&child2); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); ok(child2 != NULL, "Expected not NULL child\n"); + IXMLElementCollection_Release(collection); + + /* add element->child->child2 structure, then remove child2 from node */ + V_VT(&vType) = VT_I4; + V_I4(&vType) = XMLELEMTYPE_TEXT; + V_VT(&vName) = VT_NULL; + hr = IXMLDocument_createElement(doc, vType, vName, &child2); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + ok(child2 != NULL, "Expected non-NULL child\n"); + + hr = IXMLElement_addChild(child, child2, 0, -1); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + hr = IXMLElement_removeChild(element, child2); + ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); + + hr = IXMLElement_removeChild(child, child2); + ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); + + hr = IXMLElement_removeChild(child, NULL); + ok(hr == E_INVALIDARG, "Expected E_INVALIDARG, got %08x\n", hr); IXMLElement_Release(element); IXMLElement_Release(child); - IXMLElementCollection_Release(collection); + IXMLElement_Release(child2); IXMLDocument_Release(doc); } - static BOOL test_try_xmldoc(void) { IXMLDocument *doc = NULL; diff --git a/dlls/msxml3/xmlelem.c b/dlls/msxml3/xmlelem.c index b91722c..8fe24eb 100644 --- a/dlls/msxml3/xmlelem.c +++ b/dlls/msxml3/xmlelem.c @@ -412,8 +412,21 @@ static HRESULT WINAPI xmlelem_addChild(IXMLElement *iface, IXMLElement *pChildEl static HRESULT WINAPI xmlelem_removeChild(IXMLElement *iface, IXMLElement *pChildElem) { - FIXME("(%p, %p): stub\n", iface, pChildElem); - return E_NOTIMPL; + xmlelem *This = impl_from_IXMLElement(iface); + xmlelem *childElem = impl_from_IXMLElement(pChildElem); + + TRACE("(%p, %p)\n", This, childElem); + + if (!pChildElem) + return E_INVALIDARG; + + /* only supported for This is childElem parent case */ + if (This->node != childElem->node->parent) + return E_INVALIDARG; + + xmlUnlinkNode(childElem->node); + + return S_OK; } static const struct IXMLElementVtbl xmlelem_vtbl =

1 0