January 2010 - Wine-commits

Nikolay Sivov : msxml3: In IXMLElementCollection store pointer to node instead of pointer to children .
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 20e63dcfd1634352ae8d94b8f985749dc34f65f7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=20e63dcfd1634352ae8d94b8f… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Fri Jan 15 00:16:03 2010 +0300 msxml3: In IXMLElementCollection store pointer to node instead of pointer to children. Collection should be able to track node removal from children list. --- dlls/msxml3/tests/xmlelem.c | 2 +- dlls/msxml3/xmlelem.c | 36 ++++++++++++++++++++++-------------- 2 files changed, 23 insertions(+), 15 deletions(-) diff --git a/dlls/msxml3/tests/xmlelem.c b/dlls/msxml3/tests/xmlelem.c index dec1464..bcbae94 100644 --- a/dlls/msxml3/tests/xmlelem.c +++ b/dlls/msxml3/tests/xmlelem.c @@ -483,7 +483,7 @@ static void test_xmlelem_children(void) length = -1; hr = IXMLElementCollection_get_length(collection, &length); ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); - todo_wine ok(length == 0, "Expected 0, got %08x\n", length); + ok(length == 0, "Expected 0, got %08x\n", length); IXMLElementCollection_Release(collection); hr = IXMLElement_AddRef(child); diff --git a/dlls/msxml3/xmlelem.c b/dlls/msxml3/xmlelem.c index 8fe24eb..b96df3a 100644 --- a/dlls/msxml3/xmlelem.c +++ b/dlls/msxml3/xmlelem.c @@ -316,7 +316,7 @@ static HRESULT WINAPI xmlelem_get_children(IXMLElement *iface, IXMLElementCollec if (!p) return E_INVALIDARG; - return XMLElementCollection_create((IUnknown *)iface, This->node->children, (LPVOID *)p); + return XMLElementCollection_create((IUnknown *)iface, This->node, (LPVOID *)p); } static LONG type_libxml_to_msxml(xmlElementType type) @@ -492,6 +492,19 @@ typedef struct _xmlelem_collection xmlNodePtr current; } xmlelem_collection; +static inline LONG xmlelem_collection_updatelength(xmlelem_collection *collection) +{ + xmlNodePtr ptr = collection->node->children; + + collection->length = 0; + while (ptr) + { + collection->length++; + ptr = ptr->next; + } + return collection->length; +} + static inline xmlelem_collection *impl_from_IXMLElementCollection(IXMLElementCollection *iface) { return (xmlelem_collection *)((char*)iface - FIELD_OFFSET(xmlelem_collection, lpVtbl)); @@ -596,7 +609,7 @@ static HRESULT WINAPI xmlelem_collection_get_length(IXMLElementCollection *iface if (!p) return E_INVALIDARG; - *p = This->length; + *p = xmlelem_collection_updatelength(This); return S_OK; } @@ -618,7 +631,7 @@ static HRESULT WINAPI xmlelem_collection_item(IXMLElementCollection *iface, VARI VARIANT var2, IDispatch **ppDisp) { xmlelem_collection *This = impl_from_IXMLElementCollection(iface); - xmlNodePtr ptr = This->node; + xmlNodePtr ptr = This->node->children; int index, i; TRACE("(%p, %p)\n", iface, ppDisp); @@ -631,6 +644,8 @@ static HRESULT WINAPI xmlelem_collection_item(IXMLElementCollection *iface, VARI index = V_I4(&var1); if (index < 0) return E_INVALIDARG; + + xmlelem_collection_updatelength(This); if (index >= This->length) return E_FAIL; @@ -711,7 +726,7 @@ static HRESULT WINAPI xmlelem_collection_IEnumVARIANT_Reset( IEnumVARIANT *iface) { xmlelem_collection *This = impl_from_IEnumVARIANT(iface); - This->current = This->node; + This->current = This->node->children; return S_OK; } @@ -736,13 +751,12 @@ static const struct IEnumVARIANTVtbl xmlelem_collection_IEnumVARIANTvtbl = static HRESULT XMLElementCollection_create(IUnknown *pUnkOuter, xmlNodePtr node, LPVOID *ppObj) { xmlelem_collection *collection; - xmlNodePtr ptr; TRACE("(%p,%p)\n", pUnkOuter, ppObj); *ppObj = NULL; - if (!node) + if (!node->children) return S_FALSE; collection = HeapAlloc(GetProcessHeap(), 0, sizeof (*collection)); @@ -754,14 +768,8 @@ static HRESULT XMLElementCollection_create(IUnknown *pUnkOuter, xmlNodePtr node, collection->ref = 1; collection->length = 0; collection->node = node; - collection->current = node; - - ptr = node; - while (ptr) - { - collection->length++; - ptr = ptr->next; - } + collection->current = node->children; + xmlelem_collection_updatelength(collection); *ppObj = &collection->lpVtbl;

1 0

Nikolay Sivov : msxml3: Track linked/ unlinked state for element and free node data only when unlinked.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: f9cb63116d2558dd2bb0759218b2d6773fb048a3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f9cb63116d2558dd2bb075921… Author: Nikolay Sivov <bunglehead(a)gmail.com> Date: Fri Jan 15 00:18:32 2010 +0300 msxml3: Track linked/unlinked state for element and free node data only when unlinked. --- dlls/msxml3/msxml_private.h | 2 +- dlls/msxml3/tests/xmlelem.c | 1 + dlls/msxml3/xmldoc.c | 4 ++-- dlls/msxml3/xmlelem.c | 16 ++++++++++++---- 4 files changed, 16 insertions(+), 7 deletions(-) diff --git a/dlls/msxml3/msxml_private.h b/dlls/msxml3/msxml_private.h index d62a8a4..e46642d 100644 --- a/dlls/msxml3/msxml_private.h +++ b/dlls/msxml3/msxml_private.h @@ -135,7 +135,7 @@ extern LONG xmldoc_release( xmlDocPtr doc ); extern HRESULT xmldoc_add_orphan( xmlDocPtr doc, xmlNodePtr node ); extern HRESULT xmldoc_remove_orphan( xmlDocPtr doc, xmlNodePtr node ); -extern HRESULT XMLElement_create( IUnknown *pUnkOuter, xmlNodePtr node, LPVOID *ppObj ); +extern HRESULT XMLElement_create( IUnknown *pUnkOuter, xmlNodePtr node, LPVOID *ppObj, BOOL own ); extern xmlDocPtr parse_xml(char *ptr, int len); diff --git a/dlls/msxml3/tests/xmlelem.c b/dlls/msxml3/tests/xmlelem.c index bcbae94..3304d5a 100644 --- a/dlls/msxml3/tests/xmlelem.c +++ b/dlls/msxml3/tests/xmlelem.c @@ -523,6 +523,7 @@ static void test_xmlelem_children(void) ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); ok(child2 != NULL, "Expected not NULL child\n"); IXMLElementCollection_Release(collection); + IXMLElement_Release(child2); /* add element->child->child2 structure, then remove child2 from node */ V_VT(&vType) = VT_I4; diff --git a/dlls/msxml3/xmldoc.c b/dlls/msxml3/xmldoc.c index af67d4e..b77fd00 100644 --- a/dlls/msxml3/xmldoc.c +++ b/dlls/msxml3/xmldoc.c @@ -209,7 +209,7 @@ static HRESULT WINAPI xmldoc_get_root(IXMLDocument *iface, IXMLElement **p) if (!(root = xmlDocGetRootElement(This->xmldoc))) return E_FAIL; - return XMLElement_create((IUnknown *)This, root, (LPVOID *)p); + return XMLElement_create((IUnknown *)This, root, (LPVOID *)p, FALSE); } static HRESULT WINAPI xmldoc_get_fileSize(IXMLDocument *iface, BSTR *p) @@ -520,7 +520,7 @@ static HRESULT WINAPI xmldoc_createElement(IXMLDocument *iface, VARIANT vType, node->type = type_msxml_to_libxml(V_I4(&vType)); /* FIXME: create xmlNodePtr based on vType and var1 */ - return XMLElement_create((IUnknown *)iface, node, (LPVOID *)ppElem); + return XMLElement_create((IUnknown *)iface, node, (LPVOID *)ppElem, TRUE); } static const struct IXMLDocumentVtbl xmldoc_vtbl = diff --git a/dlls/msxml3/xmlelem.c b/dlls/msxml3/xmlelem.c index b96df3a..3c1f4f2 100644 --- a/dlls/msxml3/xmlelem.c +++ b/dlls/msxml3/xmlelem.c @@ -48,6 +48,7 @@ typedef struct _xmlelem const IXMLElementVtbl *lpVtbl; LONG ref; xmlNodePtr node; + BOOL own; } xmlelem; static inline xmlelem *impl_from_IXMLElement(IXMLElement *iface) @@ -94,6 +95,7 @@ static ULONG WINAPI xmlelem_Release(IXMLElement *iface) ref = InterlockedDecrement(&This->ref); if (ref == 0) { + if (This->own) xmlFreeNode(This->node); HeapFree(GetProcessHeap(), 0, This); } @@ -212,7 +214,7 @@ static HRESULT WINAPI xmlelem_get_parent(IXMLElement *iface, IXMLElement **paren if (!This->node->parent) return S_FALSE; - return XMLElement_create((IUnknown *)iface, This->node->parent, (LPVOID *)parent); + return XMLElement_create((IUnknown *)iface, This->node->parent, (LPVOID *)parent, FALSE); } static HRESULT WINAPI xmlelem_setAttribute(IXMLElement *iface, BSTR strPropertyName, @@ -407,6 +409,9 @@ static HRESULT WINAPI xmlelem_addChild(IXMLElement *iface, IXMLElement *pChildEl else child = xmlAddNextSibling(This->node, childElem->node->last); + /* parent is responsible for child data */ + if (child) childElem->own = FALSE; + return (child) ? S_OK : S_FALSE; } @@ -425,6 +430,8 @@ static HRESULT WINAPI xmlelem_removeChild(IXMLElement *iface, IXMLElement *pChil return E_INVALIDARG; xmlUnlinkNode(childElem->node); + /* standalone element now */ + childElem->own = TRUE; return S_OK; } @@ -452,7 +459,7 @@ static const struct IXMLElementVtbl xmlelem_vtbl = xmlelem_removeChild }; -HRESULT XMLElement_create(IUnknown *pUnkOuter, xmlNodePtr node, LPVOID *ppObj) +HRESULT XMLElement_create(IUnknown *pUnkOuter, xmlNodePtr node, LPVOID *ppObj, BOOL own) { xmlelem *elem; @@ -470,6 +477,7 @@ HRESULT XMLElement_create(IUnknown *pUnkOuter, xmlNodePtr node, LPVOID *ppObj) elem->lpVtbl = &xmlelem_vtbl; elem->ref = 1; elem->node = node; + elem->own = own; *ppObj = &elem->lpVtbl; @@ -652,7 +660,7 @@ static HRESULT WINAPI xmlelem_collection_item(IXMLElementCollection *iface, VARI for (i = 0; i < index; i++) ptr = ptr->next; - return XMLElement_create((IUnknown *)iface, ptr, (LPVOID *)ppDisp); + return XMLElement_create((IUnknown *)iface, ptr, (LPVOID *)ppDisp, FALSE); } static const struct IXMLElementCollectionVtbl xmlelem_collection_vtbl = @@ -712,7 +720,7 @@ static HRESULT WINAPI xmlelem_collection_IEnumVARIANT_Next( This->current = This->current->next; V_VT(rgVar) = VT_DISPATCH; - return XMLElement_create((IUnknown *)iface, ptr, (LPVOID *)&V_DISPATCH(rgVar)); + return XMLElement_create((IUnknown *)iface, ptr, (LPVOID *)&V_DISPATCH(rgVar), FALSE); } static HRESULT WINAPI xmlelem_collection_IEnumVARIANT_Skip(

1 0

Alexandre Julliard : winebuild: Rename __wine_call_from_32_regs for consistency with 64-bit.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 102dd9e92feaae767c84111d60298551715c87b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=102dd9e92feaae767c84111d6… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Jan 16 15:41:48 2010 +0100 winebuild: Rename __wine_call_from_32_regs for consistency with 64-bit. --- dlls/krnl386.exe16/kernel16_private.h | 2 +- dlls/ntdll/ntdll_misc.h | 2 +- dlls/ntdll/signal_i386.c | 6 +++--- tools/winebuild/relay.c | 11 ++++++----- 4 files changed, 11 insertions(+), 10 deletions(-) diff --git a/dlls/krnl386.exe16/kernel16_private.h b/dlls/krnl386.exe16/kernel16_private.h index 2f68c57..8ab4c89 100644 --- a/dlls/krnl386.exe16/kernel16_private.h +++ b/dlls/krnl386.exe16/kernel16_private.h @@ -287,7 +287,7 @@ static inline struct kernel_thread_data *kernel_get_thread_data(void) ".byte 0x68\n\t" /* pushl $__regs_func */ \ ".long " __ASM_NAME("__regs_") #name "-.-11\n\t" \ ".byte 0x6a," #args "\n\t" /* pushl $args */ \ - "call " __ASM_NAME("__wine_call_from_32_regs") "\n\t" \ + "call " __ASM_NAME("__wine_call_from_regs") "\n\t" \ "ret $(4*" #args ")" ) /* fake ret to make copy protections happy */ #endif /* __WINE_KERNEL16_PRIVATE_H */ diff --git a/dlls/ntdll/ntdll_misc.h b/dlls/ntdll/ntdll_misc.h index 32966b7..586250d 100644 --- a/dlls/ntdll/ntdll_misc.h +++ b/dlls/ntdll/ntdll_misc.h @@ -237,7 +237,7 @@ static inline struct ntdll_thread_data *ntdll_get_thread_data(void) ".byte 0x68\n\t" /* pushl $__regs_func */ \ ".long " __ASM_NAME("__regs_") #name "-.-11\n\t" \ ".byte 0x6a," #args "\n\t" /* pushl $args */ \ - "call " __ASM_NAME("__wine_call_from_32_regs") "\n\t" \ + "call " __ASM_NAME("__wine_call_from_regs") "\n\t" \ "ret $(4*" #args ")" ) /* fake ret to make copy protections happy */ #elif defined(__x86_64__) #define DEFINE_REGS_ENTRYPOINT( name, args ) \ diff --git a/dlls/ntdll/signal_i386.c b/dlls/ntdll/signal_i386.c index 5a919b3..4eccb61 100644 --- a/dlls/ntdll/signal_i386.c +++ b/dlls/ntdll/signal_i386.c @@ -423,7 +423,7 @@ static wine_signal_handler handlers[256]; static int fpux_support; /* whether the CPU support extended fpu context */ -extern void DECLSPEC_NORETURN __wine_call_from_32_restore_regs( const CONTEXT *context ); +extern void DECLSPEC_NORETURN __wine_restore_regs( const CONTEXT *context ); enum i386_trap_code { @@ -1173,7 +1173,7 @@ void set_cpu_context( const CONTEXT *context ) if (!(flags & CONTEXT_CONTROL)) FIXME( "setting partial context (%x) not supported\n", flags ); else if (flags & CONTEXT_SEGMENTS) - __wine_call_from_32_restore_regs( context ); + __wine_restore_regs( context ); else { CONTEXT newcontext = *context; @@ -1181,7 +1181,7 @@ void set_cpu_context( const CONTEXT *context ) newcontext.SegEs = wine_get_es(); newcontext.SegFs = wine_get_fs(); newcontext.SegGs = wine_get_gs(); - __wine_call_from_32_restore_regs( &newcontext ); + __wine_restore_regs( &newcontext ); } } } diff --git a/tools/winebuild/relay.c b/tools/winebuild/relay.c index 3f95545..64bb2d5 100644 --- a/tools/winebuild/relay.c +++ b/tools/winebuild/relay.c @@ -752,7 +752,8 @@ static void BuildCallFrom32Regs(void) /* Function header */ - function_header( "__wine_call_from_32_regs" ); + output( "\t.text\n" ); + function_header( "__wine_call_from_regs" ); /* Allocate some buffer space on the stack */ @@ -845,12 +846,12 @@ static void BuildCallFrom32Regs(void) output( "\tpopl %%ds\n" ); output( "\tiret\n" ); - output_function_size( "__wine_call_from_32_regs" ); + output_function_size( "__wine_call_from_regs" ); - function_header( "__wine_call_from_32_restore_regs" ); + function_header( "__wine_restore_regs" ); output( "\tmovl 4(%%esp),%%ecx\n" ); output( "\tjmp 2b\n" ); - output_function_size( "__wine_call_from_32_restore_regs" ); + output_function_size( "__wine_restore_regs" ); } @@ -991,6 +992,7 @@ static void build_call_from_regs_x86_64(void) /* Function header */ + output( "\t.text\n" ); function_header( "__wine_call_from_regs" ); output( "\t.cfi_startproc\n" ); @@ -1170,7 +1172,6 @@ void BuildRelays32(void) case CPU_x86_64: output( "/* File generated automatically. Do not edit! */\n\n" ); - output( "\t.text\n" ); build_call_from_regs_x86_64(); output_gnu_stack_note(); break;

1 0

Alexandre Julliard : winebuild: Output the asm relay functions as needed and get rid of --relay32 mode.
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 10e4a55b6c87793fc424870b77a30cb8b4dc73bb URL: http://source.winehq.org/git/wine.git/?a=commit;h=10e4a55b6c87793fc424870b7… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Jan 16 15:50:27 2010 +0100 winebuild: Output the asm relay functions as needed and get rid of --relay32 mode. --- dlls/ntdll/Makefile.in | 5 ----- tools/winebuild/build.h | 4 +++- tools/winebuild/import.c | 8 ++++++-- tools/winebuild/main.c | 11 ----------- tools/winebuild/relay.c | 29 ++++++++--------------------- tools/winebuild/spec32.c | 1 + tools/winebuild/winebuild.man.in | 4 ---- 7 files changed, 18 insertions(+), 44 deletions(-) diff --git a/dlls/ntdll/Makefile.in b/dlls/ntdll/Makefile.in index a372044..41bc5d3 100644 --- a/dlls/ntdll/Makefile.in +++ b/dlls/ntdll/Makefile.in @@ -56,11 +56,6 @@ C_SRCS = \ RC_SRCS = version.rc -EXTRA_OBJS = relay32.o - @MAKE_DLL_RULES@ -relay32.o: $(WINEBUILD) - $(WINEBUILD) $(WINEBUILDFLAGS) -o $@ --relay32 - @DEPENDENCIES@ # everything below this line is overwritten by make depend diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h index 06e2887..23b9bd1 100644 --- a/tools/winebuild/build.h +++ b/tools/winebuild/build.h @@ -244,7 +244,8 @@ extern void add_delayed_import( const char *name ); extern void add_ignore_symbol( const char *name ); extern void add_extra_ld_symbol( const char *name ); extern void read_undef_symbols( DLLSPEC *spec, char **argv ); -extern int resolve_imports( DLLSPEC *spec ); +extern void resolve_imports( DLLSPEC *spec ); +extern int is_undefined( const char *name ); extern int has_imports(void); extern int has_relays( DLLSPEC *spec ); extern void output_get_pc_thunk(void); @@ -266,6 +267,7 @@ extern void output_bin_res16_directory( DLLSPEC *spec, unsigned int data_offset extern void output_spec16_file( DLLSPEC *spec ); extern void output_fake_module16( DLLSPEC *spec16 ); extern void output_res_o_file( DLLSPEC *spec ); +extern void output_asm_relays(void); extern void BuildRelays16(void); extern void BuildRelays32(void); diff --git a/tools/winebuild/import.c b/tools/winebuild/import.c index e5e87d3..dc703f1 100644 --- a/tools/winebuild/import.c +++ b/tools/winebuild/import.c @@ -585,7 +585,7 @@ void read_undef_symbols( DLLSPEC *spec, char **argv ) } /* resolve the imports for a Win32 module */ -int resolve_imports( DLLSPEC *spec ) +void resolve_imports( DLLSPEC *spec ) { int i; unsigned int j, removed; @@ -628,8 +628,12 @@ int resolve_imports( DLLSPEC *spec ) sort_names( &undef_symbols ); check_undefined_exports( spec ); +} - return 1; +/* check if symbol is still undefined */ +int is_undefined( const char *name ) +{ + return find_name( name, &undef_symbols ) != NULL; } /* output the get_pc thunk if needed */ diff --git a/tools/winebuild/main.c b/tools/winebuild/main.c index aa487ef..2563d53 100644 --- a/tools/winebuild/main.c +++ b/tools/winebuild/main.c @@ -102,7 +102,6 @@ enum exec_mode_values MODE_DEF, MODE_IMPLIB, MODE_RELAY16, - MODE_RELAY32, MODE_RESOURCES }; @@ -271,7 +270,6 @@ static const char usage_str[] = " --exe Build a .c file for an executable\n" " --implib Build an import library\n" " --relay16 Build the 16-bit relay assembly routines\n" -" --relay32 Build the 32-bit relay assembly routines\n" " --resources Build a .o file for the resource files\n\n" "The mode options are mutually exclusive; you must specify one and only one.\n\n"; @@ -289,7 +287,6 @@ enum long_options_values LONG_OPT_NMCMD, LONG_OPT_NXCOMPAT, LONG_OPT_RELAY16, - LONG_OPT_RELAY32, LONG_OPT_RESOURCES, LONG_OPT_SAVE_TEMPS, LONG_OPT_SUBSYSTEM, @@ -312,7 +309,6 @@ static const struct option long_options[] = { "nm-cmd", 1, 0, LONG_OPT_NMCMD }, { "nxcompat", 1, 0, LONG_OPT_NXCOMPAT }, { "relay16", 0, 0, LONG_OPT_RELAY16 }, - { "relay32", 0, 0, LONG_OPT_RELAY32 }, { "resources", 0, 0, LONG_OPT_RESOURCES }, { "save-temps", 0, 0, LONG_OPT_SAVE_TEMPS }, { "subsystem", 1, 0, LONG_OPT_SUBSYSTEM }, @@ -507,9 +503,6 @@ static char **parse_options( int argc, char **argv, DLLSPEC *spec ) case LONG_OPT_RELAY16: set_exec_mode( MODE_RELAY16 ); break; - case LONG_OPT_RELAY32: - set_exec_mode( MODE_RELAY32 ); - break; case LONG_OPT_RESOURCES: set_exec_mode( MODE_RESOURCES ); break; @@ -671,10 +664,6 @@ int main(int argc, char **argv) if (argv[0]) fatal_error( "file argument '%s' not allowed in this mode\n", argv[0] ); BuildRelays16(); break; - case MODE_RELAY32: - if (argv[0]) fatal_error( "file argument '%s' not allowed in this mode\n", argv[0] ); - BuildRelays32(); - break; case MODE_RESOURCES: load_resources( argv, spec ); output_res_o_file( spec ); diff --git a/tools/winebuild/relay.c b/tools/winebuild/relay.c index 64bb2d5..221fc5a 100644 --- a/tools/winebuild/relay.c +++ b/tools/winebuild/relay.c @@ -721,7 +721,7 @@ static void BuildCallTo32CBClient( int isEx ) /******************************************************************* - * BuildCallFrom32Regs + * build_call_from_regs_x86 * * Build a 32-bit-to-Wine call-back function for a 'register' function. * 'args' is the number of dword arguments. @@ -746,7 +746,7 @@ static void BuildCallTo32CBClient( int isEx ) * pointer on return (with the return address and arguments already * removed). */ -static void BuildCallFrom32Regs(void) +static void build_call_from_regs_x86(void) { static const int STACK_SPACE = 128 + 0x2cc /* sizeof(CONTEXT86) */; @@ -962,7 +962,7 @@ void BuildRelays16(void) output( "\t.text\n" ); output( "%s:\n\n", asm_name("__wine_spec_thunk_text_32") ); - BuildCallFrom32Regs(); + build_call_from_regs_x86(); output_function_size( "__wine_spec_thunk_text_32" ); output_gnu_stack_note(); @@ -1150,34 +1150,21 @@ static void build_call_from_regs_x86_64(void) /******************************************************************* - * BuildRelays32 + * output_asm_relays * - * Build all the 32-bit relay callbacks + * Build all the assembly relay callbacks */ -void BuildRelays32(void) +void output_asm_relays(void) { switch (target_cpu) { case CPU_x86: - output( "/* File generated automatically. Do not edit! */\n\n" ); - output( "\t.text\n" ); - output( "%s:\n\n", asm_name("__wine_spec_thunk_text_32") ); - - /* 32-bit register entry point */ - BuildCallFrom32Regs(); - - output_function_size( "__wine_spec_thunk_text_32" ); - output_gnu_stack_note(); + build_call_from_regs_x86(); break; - case CPU_x86_64: - output( "/* File generated automatically. Do not edit! */\n\n" ); build_call_from_regs_x86_64(); - output_gnu_stack_note(); break; - default: - output( "/* File not used with this architecture. Do not edit! */\n\n" ); - return; + break; } } diff --git a/tools/winebuild/spec32.c b/tools/winebuild/spec32.c index a594deb..3152660 100644 --- a/tools/winebuild/spec32.c +++ b/tools/winebuild/spec32.c @@ -554,6 +554,7 @@ void BuildSpec32File( DLLSPEC *spec ) output_stubs( spec ); output_exports( spec ); output_imports( spec ); + if (is_undefined( "__wine_call_from_regs" )) output_asm_relays(); output_resources( spec ); output_gnu_stack_note(); } diff --git a/tools/winebuild/winebuild.man.in b/tools/winebuild/winebuild.man.in index 7ca151c..4897290 100644 --- a/tools/winebuild/winebuild.man.in +++ b/tools/winebuild/winebuild.man.in @@ -54,10 +54,6 @@ specified via the -E option. Generate the assembly code for the 16-bit relay routines. This is for Wine internal usage only, you should never need to use this option. .TP -.B \--relay32 -Generate the assembly code for the 32-bit relay routines. This is for -Wine internal usage only, you should never need to use this option. -.TP .B \--resources Generate a .o file containing all the input resources. This is useful when building with a PE compiler, since the PE binutils cannot handle

1 0

Alexandre Julliard : winebuild: Output the 16-bit asm relay functions as needed and get rid of --relay16 mode .
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 539da1b073be3a0c74f82d6b9a0fb00c1f214c14 URL: http://source.winehq.org/git/wine.git/?a=commit;h=539da1b073be3a0c74f82d6b9… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Sat Jan 16 15:58:48 2010 +0100 winebuild: Output the 16-bit asm relay functions as needed and get rid of --relay16 mode. --- dlls/krnl386.exe16/Makefile.in | 5 ----- tools/winebuild/build.h | 3 +-- tools/winebuild/main.c | 11 ----------- tools/winebuild/relay.c | 17 +++-------------- tools/winebuild/spec16.c | 1 + tools/winebuild/winebuild.man.in | 4 ---- 6 files changed, 5 insertions(+), 36 deletions(-) diff --git a/dlls/krnl386.exe16/Makefile.in b/dlls/krnl386.exe16/Makefile.in index be18b05..1e25735 100644 --- a/dlls/krnl386.exe16/Makefile.in +++ b/dlls/krnl386.exe16/Makefile.in @@ -59,11 +59,6 @@ C_SRCS = \ RC_SRCS = version.rc -EXTRA_OBJS = relay16asm.o - @MAKE_DLL_RULES@ -relay16asm.o: $(WINEBUILD) - $(WINEBUILD) $(WINEBUILDFLAGS) -o $@ --relay16 - @DEPENDENCIES@ # everything below this line is overwritten by make depend diff --git a/tools/winebuild/build.h b/tools/winebuild/build.h index 23b9bd1..5620763 100644 --- a/tools/winebuild/build.h +++ b/tools/winebuild/build.h @@ -268,9 +268,8 @@ extern void output_spec16_file( DLLSPEC *spec ); extern void output_fake_module16( DLLSPEC *spec16 ); extern void output_res_o_file( DLLSPEC *spec ); extern void output_asm_relays(void); +extern void output_asm_relays16(void); -extern void BuildRelays16(void); -extern void BuildRelays32(void); extern void BuildSpec32File( DLLSPEC *spec ); extern void add_16bit_exports( DLLSPEC *spec32, DLLSPEC *spec16 ); diff --git a/tools/winebuild/main.c b/tools/winebuild/main.c index 2563d53..4a11519 100644 --- a/tools/winebuild/main.c +++ b/tools/winebuild/main.c @@ -101,7 +101,6 @@ enum exec_mode_values MODE_EXE, MODE_DEF, MODE_IMPLIB, - MODE_RELAY16, MODE_RESOURCES }; @@ -269,7 +268,6 @@ static const char usage_str[] = " --def Build a .def file from a .spec file\n" " --exe Build a .c file for an executable\n" " --implib Build an import library\n" -" --relay16 Build the 16-bit relay assembly routines\n" " --resources Build a .o file for the resource files\n\n" "The mode options are mutually exclusive; you must specify one and only one.\n\n"; @@ -286,7 +284,6 @@ enum long_options_values LONG_OPT_LDCMD, LONG_OPT_NMCMD, LONG_OPT_NXCOMPAT, - LONG_OPT_RELAY16, LONG_OPT_RESOURCES, LONG_OPT_SAVE_TEMPS, LONG_OPT_SUBSYSTEM, @@ -308,7 +305,6 @@ static const struct option long_options[] = { "ld-cmd", 1, 0, LONG_OPT_LDCMD }, { "nm-cmd", 1, 0, LONG_OPT_NMCMD }, { "nxcompat", 1, 0, LONG_OPT_NXCOMPAT }, - { "relay16", 0, 0, LONG_OPT_RELAY16 }, { "resources", 0, 0, LONG_OPT_RESOURCES }, { "save-temps", 0, 0, LONG_OPT_SAVE_TEMPS }, { "subsystem", 1, 0, LONG_OPT_SUBSYSTEM }, @@ -500,9 +496,6 @@ static char **parse_options( int argc, char **argv, DLLSPEC *spec ) if (optarg[0] == 'n' || optarg[0] == 'N') spec->dll_characteristics &= ~IMAGE_DLLCHARACTERISTICS_NX_COMPAT; break; - case LONG_OPT_RELAY16: - set_exec_mode( MODE_RELAY16 ); - break; case LONG_OPT_RESOURCES: set_exec_mode( MODE_RESOURCES ); break; @@ -660,10 +653,6 @@ int main(int argc, char **argv) if (!parse_input_file( spec )) break; output_import_lib( spec, argv ); break; - case MODE_RELAY16: - if (argv[0]) fatal_error( "file argument '%s' not allowed in this mode\n", argv[0] ); - BuildRelays16(); - break; case MODE_RESOURCES: load_resources( argv, spec ); output_res_o_file( spec ); diff --git a/tools/winebuild/relay.c b/tools/winebuild/relay.c index 221fc5a..7073d74 100644 --- a/tools/winebuild/relay.c +++ b/tools/winebuild/relay.c @@ -903,23 +903,15 @@ static void BuildPendingEventCheck(void) /******************************************************************* - * BuildRelays16 + * output_asm_relays16 * * Build all the 16-bit relay callbacks */ -void BuildRelays16(void) +void output_asm_relays16(void) { - if (target_cpu != CPU_x86) - { - output( "/* File not used with this architecture. Do not edit! */\n\n" ); - return; - } - /* File header */ - output( "/* File generated automatically. Do not edit! */\n\n" ); output( "\t.text\n" ); - output( "%s:\n\n", asm_name("__wine_spec_thunk_text_16") ); output( "%s\n", asm_globl("__wine_call16_start") ); @@ -958,14 +950,11 @@ void BuildRelays16(void) output( "\n\t.data\n\t.align %d\n", get_alignment(4) ); output( "%s\n\t.long 0\n", asm_globl("CallTo16_DataSelector") ); output( "%s\n\t.long 0\n", asm_globl("CallTo16_TebSelector") ); - if (UsePIC) output( "wine_ldt_copy_ptr:\t.long %s\n", asm_name("wine_ldt_copy") ); output( "\t.text\n" ); - output( "%s:\n\n", asm_name("__wine_spec_thunk_text_32") ); + output( "%s:\n", asm_name("__wine_spec_thunk_text_32") ); build_call_from_regs_x86(); output_function_size( "__wine_spec_thunk_text_32" ); - - output_gnu_stack_note(); } diff --git a/tools/winebuild/spec16.c b/tools/winebuild/spec16.c index a9e67ad..e60b4bc 100644 --- a/tools/winebuild/spec16.c +++ b/tools/winebuild/spec16.c @@ -773,6 +773,7 @@ void output_spec16_file( DLLSPEC *spec16 ) output_stubs( spec16 ); output_exports( spec32 ); output_imports( spec16 ); + if (is_undefined( "__wine_call_from_16" )) output_asm_relays16(); if (spec16->main_module) { output( "\n\t%s\n", get_asm_string_section() ); diff --git a/tools/winebuild/winebuild.man.in b/tools/winebuild/winebuild.man.in index 4897290..88452d3 100644 --- a/tools/winebuild/winebuild.man.in +++ b/tools/winebuild/winebuild.man.in @@ -50,10 +50,6 @@ Build a .def file from a spec file. The .spec file is specified via the Build a PE import library from a spec file. The .spec file is specified via the -E option. .TP -.B \--relay16 -Generate the assembly code for the 16-bit relay routines. This is for -Wine internal usage only, you should never need to use this option. -.TP .B \--resources Generate a .o file containing all the input resources. This is useful when building with a PE compiler, since the PE binutils cannot handle

1 0

James Hawkins : Revert "advapi32: Free descriptor if it isn' t returned from GetSecurityInfo().".
by Alexandre Julliard 18 Jan '10

18 Jan '10

Module: wine Branch: master Commit: 72158ac286dfbf5908c2bc281678422469d0653b URL: http://source.winehq.org/git/wine.git/?a=commit;h=72158ac286dfbf5908c2bc281… Author: James Hawkins <truiken(a)gmail.com> Date: Thu Jan 14 11:35:09 2010 -0800 Revert "advapi32: Free descriptor if it isn't returned from GetSecurityInfo().". This reverts commit dbd76575ef8353484afa0b0d2da95760c26f34fe. According to MSDN, ppSecurityDescriptor must not be NULL if any of the SID or ACL parameters are non-NULL. This is wrong, and native GetSecurityInfo will happily return those pointers, leaving one unable to free the original security descriptor. --- dlls/advapi32/security.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index babe468..821fb86 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -3118,8 +3118,11 @@ DWORD WINAPI GetSecurityInfo( } if (ppSecurityDescriptor) *ppSecurityDescriptor = sd; - else - LocalFree(sd); + + /* The security descriptor (sd) cannot be freed if ppSecurityDescriptor is + * NULL, because native happily returns the SIDs and ACLs that are requested + * in this case. + */ return ERROR_SUCCESS; }

1 0

Jason Edmeades : comctl32/listview: Issue LVM_DELETEALLITEMS from WM_DESTROY.
by Alexandre Julliard 14 Jan '10

14 Jan '10

Module: wine Branch: master Commit: 81d813542426d660c2289b4cb72797d7f156d285 URL: http://source.winehq.org/git/wine.git/?a=commit;h=81d813542426d660c2289b4cb… Author: Jason Edmeades <jason.edmeades(a)googlemail.com> Date: Wed Jan 13 14:51:01 2010 -0800 comctl32/listview: Issue LVM_DELETEALLITEMS from WM_DESTROY. --- dlls/comctl32/listview.c | 9 +++++---- dlls/comctl32/tests/listview.c | 30 +++++++++++++++++++++++++++++- 2 files changed, 34 insertions(+), 5 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index d21935f..80a32f7 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -9188,10 +9188,14 @@ static LRESULT LISTVIEW_Create(HWND hwnd, const CREATESTRUCTW *lpcs) * Success: 0 * Failure: -1 */ -static LRESULT LISTVIEW_Destroy(const LISTVIEW_INFO *infoPtr) +static LRESULT LISTVIEW_Destroy(LISTVIEW_INFO *infoPtr) { HTHEME theme = GetWindowTheme(infoPtr->hwndSelf); CloseThemeData(theme); + + /* delete all items */ + LISTVIEW_DeleteAllItems(infoPtr, TRUE); + return 0; } @@ -9923,9 +9927,6 @@ static LRESULT LISTVIEW_NCDestroy(LISTVIEW_INFO *infoPtr) TRACE("()\n"); - /* delete all items */ - LISTVIEW_DeleteAllItems(infoPtr, TRUE); - /* destroy data structure */ DPA_Destroy(infoPtr->hdpaItems); DPA_Destroy(infoPtr->hdpaItemIds); diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c index 0122886..0bac4ec 100644 --- a/dlls/comctl32/tests/listview.c +++ b/dlls/comctl32/tests/listview.c @@ -32,7 +32,8 @@ #define PARENT_FULL_SEQ_INDEX 1 #define LISTVIEW_SEQ_INDEX 2 #define EDITBOX_SEQ_INDEX 3 -#define NUM_MSG_SEQUENCES 4 +#define COMBINED_SEQ_INDEX 4 +#define NUM_MSG_SEQUENCES 5 #define LISTVIEW_ID 0 #define HEADER_ID 1 @@ -286,6 +287,18 @@ static const struct message hover_parent[] = { { 0 } }; +static const struct message listview_destroy[] = { + { 0x0090, sent|optional }, /* Vista */ + { WM_PARENTNOTIFY, sent }, + { WM_SHOWWINDOW, sent }, + { WM_WINDOWPOSCHANGING, sent }, + { WM_WINDOWPOSCHANGED, sent|optional }, + { WM_DESTROY, sent }, + { WM_NOTIFY, sent|id, 0, 0, LVN_DELETEALLITEMS }, + { WM_NCDESTROY, sent }, + { 0 } +}; + static LRESULT WINAPI parent_wnd_proc(HWND hwnd, UINT message, WPARAM wParam, LPARAM lParam) { static LONG defwndproc_counter = 0; @@ -312,6 +325,7 @@ static LRESULT WINAPI parent_wnd_proc(HWND hwnd, UINT message, WPARAM wParam, LP trace("parent: %p, %04x, %08lx, %08lx\n", hwnd, message, wParam, lParam); add_message(sequences, PARENT_SEQ_INDEX, &msg); + add_message(sequences, COMBINED_SEQ_INDEX, &msg); } add_message(sequences, PARENT_FULL_SEQ_INDEX, &msg); @@ -460,6 +474,7 @@ static LRESULT WINAPI listview_subclass_proc(HWND hwnd, UINT message, WPARAM wPa msg.lParam = lParam; msg.id = LISTVIEW_ID; add_message(sequences, LISTVIEW_SEQ_INDEX, &msg); + add_message(sequences, COMBINED_SEQ_INDEX, &msg); defwndproc_counter++; ret = CallWindowProcA(oldproc, hwnd, message, wParam, lParam); @@ -4263,6 +4278,18 @@ static void test_hover(void) DestroyWindow(hwnd); } +static void test_destroynotify(void) +{ + HWND hwnd; + + hwnd = create_listview_control(LVS_REPORT); + ok(hwnd != NULL, "failed to create listview window\n"); + + flush_sequences(sequences, NUM_MSG_SEQUENCES); + DestroyWindow(hwnd); + ok_sequence(sequences, COMBINED_SEQ_INDEX, listview_destroy, "check destroy order", FALSE); +} + START_TEST(listview) { HMODULE hComctl32; @@ -4323,6 +4350,7 @@ START_TEST(listview) test_approximate_viewrect(); test_finditem(); test_hover(); + test_destroynotify(); if (!load_v6_module(&ctx_cookie, &hCtx)) {

1 0

Jacek Caban : mshtml.idl: Added IHTMLIFrameElement interface declaration.
by Alexandre Julliard 14 Jan '10

14 Jan '10

Module: wine Branch: master Commit: f5430010cf974df38ff380e854a929dcfa07a0ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=f5430010cf974df38ff380e85… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Jan 14 09:47:30 2010 -0600 mshtml.idl: Added IHTMLIFrameElement interface declaration. --- include/mshtml.idl | 32 +++++++++++++++++++++++++++++++- 1 files changed, 31 insertions(+), 1 deletions(-) diff --git a/include/mshtml.idl b/include/mshtml.idl index 4a182f2..1f3a8a8 100644 --- a/include/mshtml.idl +++ b/include/mshtml.idl @@ -1,5 +1,5 @@ /* - * Copyright 2004-2007 Jacek Caban for CodeWeavers + * Copyright 2004-2010 Jacek Caban for CodeWeavers * Copyright 2008 Konstantin Kondratyuk (Etersoft) * * This library is free software; you can redistribute it and/or @@ -14729,6 +14729,36 @@ interface IHTMLFrameBase2 : IDispatch } /***************************************************************************** + * IHTMLIFrameElement dispinterface + */ +[ + odl, + oleautomation, + dual, + uuid(3050f315-98b5-11cf-bb82-00aa00bdce0b) +] +interface IHTMLIFrameElement : IDispatch +{ + [propput, id(DISPID_IHTMLIFRAMEELEMENT_VSPACE)] + HRESULT vspace([in] LONG v); + + [propget, id(DISPID_IHTMLIFRAMEELEMENT_VSPACE)] + HRESULT vspace([retval, out] LONG *p); + + [propput, id(DISPID_IHTMLIFRAMEELEMENT_HSPACE)] + HRESULT hspace([in] LONG v); + + [propget, id(DISPID_IHTMLIFRAMEELEMENT_HSPACE)] + HRESULT hspace([retval, out] LONG *p); + + [propput, id(DISPID_IHTMLIFRAMEELEMENT_ALIGN), displaybind, bindable] + HRESULT align([in] BSTR v); + + [propget, id(DISPID_IHTMLIFRAMEELEMENT_ALIGN), displaybind, bindable] + HRESULT align([retval, out] BSTR *p); +} + +/***************************************************************************** * DispHTMLIFrame dispinterface */ [

1 0

Jacek Caban : mshtml: Added IHTMLIFrameElement stub implementation.
by Alexandre Julliard 14 Jan '10

14 Jan '10

Module: wine Branch: master Commit: 91140222b5623273f88d1c9810b61ce0a7bc4638 URL: http://source.winehq.org/git/wine.git/?a=commit;h=91140222b5623273f88d1c981… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Jan 14 09:47:59 2010 -0600 mshtml: Added IHTMLIFrameElement stub implementation. --- dlls/mshtml/htmliframe.c | 127 +++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 126 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/htmliframe.c b/dlls/mshtml/htmliframe.c index ddb32c8..689b432 100644 --- a/dlls/mshtml/htmliframe.c +++ b/dlls/mshtml/htmliframe.c @@ -33,15 +33,139 @@ WINE_DEFAULT_DEBUG_CHANNEL(mshtml); typedef struct { HTMLFrameBase framebase; + const IHTMLIFrameElementVtbl *lpIHTMLIFrameElementVtbl; } HTMLIFrame; +#define HTMLIFRAMEELEM(x) ((IHTMLIFrameElement*) &(x)->lpIHTMLIFrameElementVtbl) + +#define HTMLIFRAME_THIS(iface) DEFINE_THIS(HTMLIFrame, IHTMLIFrameElement, iface) + +static HRESULT WINAPI HTMLIFrameElement_QueryInterface(IHTMLIFrameElement *iface, + REFIID riid, void **ppv) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + + return IHTMLDOMNode_QueryInterface(HTMLDOMNODE(&This->framebase.element.node), riid, ppv); +} + +static ULONG WINAPI HTMLIFrameElement_AddRef(IHTMLIFrameElement *iface) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + + return IHTMLDOMNode_AddRef(HTMLDOMNODE(&This->framebase.element.node)); +} + +static ULONG WINAPI HTMLIFrameElement_Release(IHTMLIFrameElement *iface) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + + return IHTMLDOMNode_Release(HTMLDOMNODE(&This->framebase.element.node)); +} + +static HRESULT WINAPI HTMLIFrameElement_GetTypeInfoCount(IHTMLIFrameElement *iface, UINT *pctinfo) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + return IDispatchEx_GetTypeInfoCount(DISPATCHEX(&This->framebase.element.node.dispex), pctinfo); +} + +static HRESULT WINAPI HTMLIFrameElement_GetTypeInfo(IHTMLIFrameElement *iface, UINT iTInfo, + LCID lcid, ITypeInfo **ppTInfo) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + return IDispatchEx_GetTypeInfo(DISPATCHEX(&This->framebase.element.node.dispex), iTInfo, lcid, ppTInfo); +} + +static HRESULT WINAPI HTMLIFrameElement_GetIDsOfNames(IHTMLIFrameElement *iface, REFIID riid, + LPOLESTR *rgszNames, UINT cNames, LCID lcid, DISPID *rgDispId) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + return IDispatchEx_GetIDsOfNames(DISPATCHEX(&This->framebase.element.node.dispex), riid, rgszNames, cNames, lcid, rgDispId); +} + +static HRESULT WINAPI HTMLIFrameElement_Invoke(IHTMLIFrameElement *iface, DISPID dispIdMember, + REFIID riid, LCID lcid, WORD wFlags, DISPPARAMS *pDispParams, + VARIANT *pVarResult, EXCEPINFO *pExcepInfo, UINT *puArgErr) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + return IDispatchEx_Invoke(DISPATCHEX(&This->framebase.element.node.dispex), dispIdMember, riid, + lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); +} + +static HRESULT WINAPI HTMLIFrameElement_put_vspace(IHTMLIFrameElement *iface, LONG v) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + FIXME("(%p)->(%d)\n", This, v); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement_get_vspace(IHTMLIFrameElement *iface, LONG *p) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + FIXME("(%p)->(%p)\n", This, p); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement_put_hspace(IHTMLIFrameElement *iface, LONG v) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + FIXME("(%p)->(%d)\n", This, v); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement_get_hspace(IHTMLIFrameElement *iface, LONG *p) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + FIXME("(%p)->(%p)\n", This, p); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement_put_align(IHTMLIFrameElement *iface, BSTR v) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + FIXME("(%p)->(%s)\n", This, debugstr_w(v)); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement_get_align(IHTMLIFrameElement *iface, BSTR *p) +{ + HTMLIFrame *This = HTMLIFRAME_THIS(iface); + FIXME("(%p)->(%p)\n", This, p); + return E_NOTIMPL; +} + +#undef HTMLIFRAME_THIS + +static const IHTMLIFrameElementVtbl HTMLIFrameElementVtbl = { + HTMLIFrameElement_QueryInterface, + HTMLIFrameElement_AddRef, + HTMLIFrameElement_Release, + HTMLIFrameElement_GetTypeInfoCount, + HTMLIFrameElement_GetTypeInfo, + HTMLIFrameElement_GetIDsOfNames, + HTMLIFrameElement_Invoke, + HTMLIFrameElement_put_vspace, + HTMLIFrameElement_get_vspace, + HTMLIFrameElement_put_hspace, + HTMLIFrameElement_get_hspace, + HTMLIFrameElement_put_align, + HTMLIFrameElement_get_align +}; + #define HTMLIFRAME_NODE_THIS(iface) DEFINE_THIS2(HTMLIFrame, framebase.element.node, iface) static HRESULT HTMLIFrame_QI(HTMLDOMNode *iface, REFIID riid, void **ppv) { HTMLIFrame *This = HTMLIFRAME_NODE_THIS(iface); - return HTMLFrameBase_QI(&This->framebase, riid, ppv); + if(IsEqualGUID(&IID_IHTMLIFrameElement, riid)) { + TRACE("(%p)->(IID_IHTMLIFrameElement %p)\n", This, ppv); + *ppv = HTMLIFRAMEELEM(This); + }else { + return HTMLFrameBase_QI(&This->framebase, riid, ppv); + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; } static void HTMLIFrame_destructor(HTMLDOMNode *iface) @@ -154,6 +278,7 @@ HTMLElement *HTMLIFrame_Create(HTMLDocumentNode *doc, nsIDOMHTMLElement *nselem) ret = heap_alloc_zero(sizeof(HTMLIFrame)); + ret->lpIHTMLIFrameElementVtbl = &HTMLIFrameElementVtbl; ret->framebase.element.node.vtbl = &HTMLIFrameImplVtbl; HTMLFrameBase_Init(&ret->framebase, doc, nselem, &HTMLIFrame_dispex);

1 0

Jacek Caban : mshtml: Added IHTMLIFrameElement IDispatchEx support.
by Alexandre Julliard 14 Jan '10

14 Jan '10

Module: wine Branch: master Commit: b5caee220d86bd7465bca0a7ef2e55340f235fd8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b5caee220d86bd7465bca0a7e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Jan 14 09:48:18 2010 -0600 mshtml: Added IHTMLIFrameElement IDispatchEx support. --- dlls/mshtml/dispex.c | 1 + dlls/mshtml/htmliframe.c | 1 + dlls/mshtml/mshtml_private.h | 1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index c77ebb9..be44748 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -133,6 +133,7 @@ static REFIID tid_ids[] = { &IID_IHTMLFrameBase, &IID_IHTMLFrameBase2, &IID_IHTMLGenericElement, + &IID_IHTMLIFrameElement, &IID_IHTMLImageElementFactory, &IID_IHTMLImgElement, &IID_IHTMLInputElement, diff --git a/dlls/mshtml/htmliframe.c b/dlls/mshtml/htmliframe.c index 689b432..b776077 100644 --- a/dlls/mshtml/htmliframe.c +++ b/dlls/mshtml/htmliframe.c @@ -262,6 +262,7 @@ static const tid_t HTMLIFrame_iface_tids[] = { IHTMLElement3_tid, IHTMLFrameBase_tid, IHTMLFrameBase2_tid, + IHTMLIFrameElement_tid, 0 }; diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 68b3393..4529231 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -109,6 +109,7 @@ typedef enum { IHTMLFrameBase_tid, IHTMLFrameBase2_tid, IHTMLGenericElement_tid, + IHTMLIFrameElement_tid, IHTMLImageElementFactory_tid, IHTMLImgElement_tid, IHTMLInputElement_tid,

1 0