December 2010 - Wine-commits

Michael Stefaniuc : mshtml: COM cleanup for the IOleInPlaceObjectWindowless iface.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: 62e9961e29487584fa1805e5d502644d295b2634 URL: http://source.winehq.org/git/wine.git/?a=commit;h=62e9961e29487584fa1805e5d… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Dec 23 02:22:21 2010 +0100 mshtml: COM cleanup for the IOleInPlaceObjectWindowless iface. --- dlls/mshtml/htmldoc.c | 6 +++--- dlls/mshtml/mshtml_private.h | 4 +--- dlls/mshtml/oleobj.c | 2 +- dlls/mshtml/olewnd.c | 31 ++++++++++++++++--------------- dlls/mshtml/view.c | 2 +- 5 files changed, 22 insertions(+), 23 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 15240de..4898fc6 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -1767,10 +1767,10 @@ static BOOL htmldoc_qi(HTMLDocument *This, REFIID riid, void **ppv) *ppv = &This->IOleInPlaceActiveObject_iface; }else if(IsEqualGUID(&IID_IOleInPlaceObject, riid)) { TRACE("(%p)->(IID_IOleInPlaceObject, %p)\n", This, ppv); - *ppv = INPLACEOBJ(This); + *ppv = &This->IOleInPlaceObjectWindowless_iface; }else if(IsEqualGUID(&IID_IOleInPlaceObjectWindowless, riid)) { TRACE("(%p)->(IID_IOleInPlaceObjectWindowless, %p)\n", This, ppv); - *ppv = INPLACEWIN(This); + *ppv = &This->IOleInPlaceObjectWindowless_iface; }else if(IsEqualGUID(&IID_IServiceProvider, riid)) { TRACE("(%p)->(IID_IServiceProvider, %p)\n", This, ppv); *ppv = SERVPROV(This); @@ -2106,7 +2106,7 @@ static ULONG WINAPI CustomDoc_Release(ICustomDoc *iface) if(This->hostui) ICustomDoc_SetUIHandler(CUSTOMDOC(This), NULL); if(This->in_place_active) - IOleInPlaceObjectWindowless_InPlaceDeactivate(INPLACEWIN(&This->basedoc)); + IOleInPlaceObjectWindowless_InPlaceDeactivate(&This->basedoc.IOleInPlaceObjectWindowless_iface); if(This->ipsite) IOleDocumentView_SetInPlaceSite(&This->basedoc.IOleDocumentView_iface, NULL); if(This->undomgr) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 703d5ff..2ef0d62 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -356,7 +356,7 @@ struct HTMLDocument { IOleDocumentView IOleDocumentView_iface; IOleInPlaceActiveObject IOleInPlaceActiveObject_iface; IViewObjectEx IViewObjectEx_iface; - const IOleInPlaceObjectWindowlessVtbl *lpOleInPlaceObjectWindowlessVtbl; + IOleInPlaceObjectWindowless IOleInPlaceObjectWindowless_iface; const IServiceProviderVtbl *lpServiceProviderVtbl; const IOleCommandTargetVtbl *lpOleCommandTargetVtbl; const IOleControlVtbl *lpOleControlVtbl; @@ -625,8 +625,6 @@ struct HTMLDocumentNode { #define HTMLWINDOW2(x) ((IHTMLWindow2*) &(x)->lpHTMLWindow2Vtbl) #define HTMLWINDOW3(x) ((IHTMLWindow3*) &(x)->lpHTMLWindow3Vtbl) #define HTMLWINDOW4(x) ((IHTMLWindow4*) &(x)->lpHTMLWindow4Vtbl) -#define INPLACEOBJ(x) ((IOleInPlaceObject*) &(x)->lpOleInPlaceObjectWindowlessVtbl) -#define INPLACEWIN(x) ((IOleInPlaceObjectWindowless*) &(x)->lpOleInPlaceObjectWindowlessVtbl) #define SERVPROV(x) ((IServiceProvider*) &(x)->lpServiceProviderVtbl) #define CMDTARGET(x) ((IOleCommandTarget*) &(x)->lpOleCommandTargetVtbl) #define CONTROL(x) ((IOleControl*) &(x)->lpOleControlVtbl) diff --git a/dlls/mshtml/oleobj.c b/dlls/mshtml/oleobj.c index 8f49a28..166af0c 100644 --- a/dlls/mshtml/oleobj.c +++ b/dlls/mshtml/oleobj.c @@ -267,7 +267,7 @@ static HRESULT WINAPI OleObject_Close(IOleObject *iface, DWORD dwSaveOption) FIXME("OLECLOSE_PROMPTSAVE not implemented\n"); if(This->doc_obj->in_place_active) - IOleInPlaceObjectWindowless_InPlaceDeactivate(INPLACEWIN(This)); + IOleInPlaceObjectWindowless_InPlaceDeactivate(&This->IOleInPlaceObjectWindowless_iface); HTMLDocument_LockContainer(This->doc_obj, FALSE); diff --git a/dlls/mshtml/olewnd.c b/dlls/mshtml/olewnd.c index 99d9b9e..18b98f6 100644 --- a/dlls/mshtml/olewnd.c +++ b/dlls/mshtml/olewnd.c @@ -146,44 +146,47 @@ static const IOleInPlaceActiveObjectVtbl OleInPlaceActiveObjectVtbl = { * IOleInPlaceObjectWindowless implementation */ -#define OLEINPLACEWND_THIS(iface) DEFINE_THIS(HTMLDocument, OleInPlaceObjectWindowless, iface) +static inline HTMLDocument *impl_from_IOleInPlaceObjectWindowless(IOleInPlaceObjectWindowless *iface) +{ + return CONTAINING_RECORD(iface, HTMLDocument, IOleInPlaceObjectWindowless_iface); +} static HRESULT WINAPI OleInPlaceObjectWindowless_QueryInterface(IOleInPlaceObjectWindowless *iface, REFIID riid, void **ppv) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); return htmldoc_query_interface(This, riid, ppv); } static ULONG WINAPI OleInPlaceObjectWindowless_AddRef(IOleInPlaceObjectWindowless *iface) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); return htmldoc_addref(This); } static ULONG WINAPI OleInPlaceObjectWindowless_Release(IOleInPlaceObjectWindowless *iface) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); return htmldoc_release(This); } static HRESULT WINAPI OleInPlaceObjectWindowless_GetWindow(IOleInPlaceObjectWindowless *iface, HWND *phwnd) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); return IOleWindow_GetWindow(&This->IOleInPlaceActiveObject_iface, phwnd); } static HRESULT WINAPI OleInPlaceObjectWindowless_ContextSensitiveHelp(IOleInPlaceObjectWindowless *iface, BOOL fEnterMode) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); return IOleWindow_ContextSensitiveHelp(&This->IOleInPlaceActiveObject_iface, fEnterMode); } static HRESULT WINAPI OleInPlaceObjectWindowless_InPlaceDeactivate(IOleInPlaceObjectWindowless *iface) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); TRACE("(%p)\n", This); @@ -224,7 +227,7 @@ static HRESULT WINAPI OleInPlaceObjectWindowless_InPlaceDeactivate(IOleInPlaceOb static HRESULT WINAPI OleInPlaceObjectWindowless_UIDeactivate(IOleInPlaceObjectWindowless *iface) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); FIXME("(%p)\n", This); return E_NOTIMPL; } @@ -232,14 +235,14 @@ static HRESULT WINAPI OleInPlaceObjectWindowless_UIDeactivate(IOleInPlaceObjectW static HRESULT WINAPI OleInPlaceObjectWindowless_SetObjectRects(IOleInPlaceObjectWindowless *iface, LPCRECT lprcPosRect, LPCRECT lprcClipRect) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); FIXME("(%p)->(%p %p)\n", This, lprcPosRect, lprcClipRect); return E_NOTIMPL; } static HRESULT WINAPI OleInPlaceObjectWindowless_ReactivateAndUndo(IOleInPlaceObjectWindowless *iface) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); FIXME("(%p)\n", This); return E_NOTIMPL; } @@ -247,7 +250,7 @@ static HRESULT WINAPI OleInPlaceObjectWindowless_ReactivateAndUndo(IOleInPlaceOb static HRESULT WINAPI OleInPlaceObjectWindowless_OnWindowMessage(IOleInPlaceObjectWindowless *iface, UINT msg, WPARAM wParam, LPARAM lParam, LRESULT *lpResult) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); FIXME("(%p)->(%u %lu %lu %p)\n", This, msg, wParam, lParam, lpResult); return E_NOTIMPL; } @@ -255,7 +258,7 @@ static HRESULT WINAPI OleInPlaceObjectWindowless_OnWindowMessage(IOleInPlaceObje static HRESULT WINAPI OleInPlaceObjectWindowless_GetDropTarget(IOleInPlaceObjectWindowless *iface, IDropTarget **ppDropTarget) { - HTMLDocument *This = OLEINPLACEWND_THIS(iface); + HTMLDocument *This = impl_from_IOleInPlaceObjectWindowless(iface); FIXME("(%p)->(%p)\n", This, ppDropTarget); return E_NOTIMPL; } @@ -274,10 +277,8 @@ static const IOleInPlaceObjectWindowlessVtbl OleInPlaceObjectWindowlessVtbl = { OleInPlaceObjectWindowless_GetDropTarget }; -#undef INPLACEWIN_THIS - void HTMLDocument_Window_Init(HTMLDocument *This) { This->IOleInPlaceActiveObject_iface.lpVtbl = &OleInPlaceActiveObjectVtbl; - This->lpOleInPlaceObjectWindowlessVtbl = &OleInPlaceObjectWindowlessVtbl; + This->IOleInPlaceObjectWindowless_iface.lpVtbl = &OleInPlaceObjectWindowlessVtbl; } diff --git a/dlls/mshtml/view.c b/dlls/mshtml/view.c index 1b6a32f..1878e15 100644 --- a/dlls/mshtml/view.c +++ b/dlls/mshtml/view.c @@ -574,7 +574,7 @@ static HRESULT WINAPI OleDocumentView_Show(IOleDocumentView *iface, BOOL fShow) ShowWindow(This->doc_obj->hwnd, SW_HIDE); if(This->doc_obj->in_place_active) - IOleInPlaceObjectWindowless_InPlaceDeactivate(INPLACEWIN(This)); + IOleInPlaceObjectWindowless_InPlaceDeactivate(&This->IOleInPlaceObjectWindowless_iface); if(This->doc_obj->ip_window) { IOleInPlaceUIWindow_Release(This->doc_obj->ip_window);

1 0

Austin English : mscoree/tests: Fix a broken test (LLVM/Clang).
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: cccc36e25a83336a996362f7652e839338718787 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cccc36e25a83336a996362f76… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Dec 22 22:27:55 2010 -0800 mscoree/tests: Fix a broken test (LLVM/Clang). --- dlls/mscoree/tests/mscoree.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mscoree/tests/mscoree.c b/dlls/mscoree/tests/mscoree.c index 0155fdd..4226493 100644 --- a/dlls/mscoree/tests/mscoree.c +++ b/dlls/mscoree/tests/mscoree.c @@ -115,7 +115,7 @@ static void test_versioninfo(void) trace(" installed in directory %s is .net version %s\n", wine_dbgstr_w(path), wine_dbgstr_w(version)); hr = pGetRequestedRuntimeInfo( NULL, v1_1, NULL, 0, 0, path, MAX_PATH, &path_len, version, MAX_PATH, &size); - ok(hr == S_OK || CLR_E_SHIM_RUNTIME /*v1_1 not installed*/, "GetRequestedRuntimeInfo returned %08x\n", hr); + ok(hr == S_OK || hr == CLR_E_SHIM_RUNTIME /*v1_1 not installed*/, "GetRequestedRuntimeInfo returned %08x\n", hr); if(hr == S_OK) trace(" installed in directory %s is .net version %s\n", wine_dbgstr_w(path), wine_dbgstr_w(version)); /* version number NULL not allowed without RUNTIME_INFO_UPGRADE_VERSION flag */

1 0

Austin English : quartz: Avoid %L in traces (LLVM/Clang).
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: a5c50a25fbd2401f9a2b616ffd225d4c856ef402 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a5c50a25fbd2401f9a2b616ff… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Dec 22 23:18:25 2010 -0800 quartz: Avoid %L in traces (LLVM/Clang). --- dlls/quartz/dsoundrender.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index f48cc77..d472145 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -1193,7 +1193,7 @@ static DWORD WINAPI DSoundAdviseThread(LPVOID lpParam) { FIXME("Could not get time: %08x\n", hr); continue; } - TRACE("Time: %Li\n", curtime); + TRACE("Time: %s\n", wine_dbgstr_longlong(curtime)); while (prev->next) { cur = prev->next; if (cur->start > curtime) { @@ -1207,7 +1207,7 @@ static DWORD WINAPI DSoundAdviseThread(LPVOID lpParam) { prev = cur; } else { struct dsoundrender_timer *next = cur->next; - TRACE("Firing %p %Li < %Li\n", cur, cur->start, curtime); + TRACE("Firing %p %s < %s\n", cur, wine_dbgstr_longlong(cur->start), wine_dbgstr_longlong(curtime)); SetEvent(cur->handle); HeapFree(GetProcessHeap(), 0, cur); prev->next = next;

1 0

Hwang YunSong : hhctl.ocx: Update Korean resource.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: 719b60187d43be317746f388698691e55e99c907 URL: http://source.winehq.org/git/wine.git/?a=commit;h=719b60187d43be317746f3886… Author: Hwang YunSong <hys545(a)dreamwiz.com> Date: Thu Dec 23 16:38:37 2010 +0900 hhctl.ocx: Update Korean resource. --- dlls/hhctrl.ocx/Ko.rc | 36 +++++++++++++++++++----------------- 1 files changed, 19 insertions(+), 17 deletions(-) diff --git a/dlls/hhctrl.ocx/Ko.rc b/dlls/hhctrl.ocx/Ko.rc index c641404..9912b92 100644 --- a/dlls/hhctrl.ocx/Ko.rc +++ b/dlls/hhctrl.ocx/Ko.rc @@ -3,7 +3,7 @@ * Korean Language Support * * Copyright 2005 James Hawkins - * Copyright 2005 YunSong Hwang + * Copyright 2005,2010 YunSong Hwang * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -22,28 +22,30 @@ #include "resource.h" +#pragma code_page(65001) + LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT STRINGTABLE BEGIN - IDS_CONTENTS "��(&C)" - IDS_INDEX "�ε��(&N)" - IDS_SEARCH "ã��(&S)" - IDS_FAVORITES "��ã��(&I)" + IDS_CONTENTS "목록(&C)" + IDS_INDEX "인덱스(&N)" + IDS_SEARCH "찾기(&S)" + IDS_FAVORITES "즐겨찾기(&I)" END STRINGTABLE BEGIN - IDTB_EXPAND "��ֱ�" - IDTB_CONTRACT "��" - IDTB_STOP "��" - IDTB_REFRESH "�� ħ" - IDTB_BACK "�ڷ�" - IDTB_HOME "Ȩ" - IDTB_SYNC "��ȭ" - IDTB_PRINT "�μ�" - IDTB_OPTIONS "�ɼ�" - IDTB_FORWARD "��" + IDTB_EXPAND "보여주기" + IDTB_CONTRACT "숨기기" + IDTB_STOP "정지" + IDTB_REFRESH "새로 고침" + IDTB_BACK "뒤로" + IDTB_HOME "홈" + IDTB_SYNC "동기화" + IDTB_PRINT "인쇄" + IDTB_OPTIONS "옵션" + IDTB_FORWARD "앞으로" IDTB_NOTES "IDTB_NOTES" IDTB_BROWSE_FWD "IDTB_BROWSE_FWD" IDTB_BROWSE_BACK "IDT_BROWSE_BACK" @@ -54,8 +56,8 @@ BEGIN IDTB_FAVORITES "IDTB_FAVORITES" IDTB_JUMP1 "Jump1" IDTB_JUMP2 "Jump2" - IDTB_CUSTOMIZE "��" - IDTB_ZOOM "Ȯ��" + IDTB_CUSTOMIZE "사용자정의" + IDTB_ZOOM "확대" IDTB_TOC_NEXT "IDTB_TOC_NEXT" IDTB_TOC_PREV "IDTB_TOC_PREV" END

1 0

Hwang YunSong : iccvid: Update Korean resource.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: 36cbe780ec30b116628f6837d73b22523229aad0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=36cbe780ec30b116628f6837d… Author: Hwang YunSong <hys545(a)dreamwiz.com> Date: Thu Dec 23 16:39:56 2010 +0900 iccvid: Update Korean resource. --- dlls/iccvid/iccvid_Ko.rc | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/dlls/iccvid/iccvid_Ko.rc b/dlls/iccvid/iccvid_Ko.rc index 1d1ba86..e4f6069 100644 --- a/dlls/iccvid/iccvid_Ko.rc +++ b/dlls/iccvid/iccvid_Ko.rc @@ -1,6 +1,6 @@ /* * Copyright 2005 Dmitry Timoshkov - * Copyright 2005 YunSomg Hwang + * Copyright 2005,2010 YunSomg Hwang * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -19,10 +19,12 @@ #include "iccvid_private.h" +#pragma code_page(65001) + LANGUAGE LANG_KOREAN, SUBLANG_DEFAULT STRINGTABLE { - IDS_NAME "�ó�� ڵ�" - IDS_DESCRIPTION "�ó�� ڵ�" + IDS_NAME "시네팩 비디오 코덱" + IDS_DESCRIPTION "시네팩 비디오 코덱" }

1 0

Frédéric Delanoy : wininet: Update French translation.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: 79f36b2a08daa235cf6a342898bc344052550931 URL: http://source.winehq.org/git/wine.git/?a=commit;h=79f36b2a08daa235cf6a34289… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Wed Dec 22 23:42:11 2010 +0100 wininet: Update French translation. --- dlls/wininet/wininet_Fr.rc | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/dlls/wininet/wininet_Fr.rc b/dlls/wininet/wininet_Fr.rc index aa1b463..0cb2a02 100644 --- a/dlls/wininet/wininet_Fr.rc +++ b/dlls/wininet/wininet_Fr.rc @@ -69,6 +69,18 @@ FONT 8, "MS Shell Dlg" PUSHBUTTON "Annuler", IDCANCEL, 147, 128, 56, 14, WS_GROUP | WS_TABSTOP } +IDD_INVCERTDLG DIALOG 3, 24, 250, 86 +STYLE DS_MODALFRAME | WS_POPUP | WS_CAPTION | WS_SYSMENU +CAPTION "Alerte de sécurité" +FONT 8, "MS Shell Dlg" +{ + LTEXT "Le certificat pour ce site pose problème.", -1, 40, 6, 200, 20 + LTEXT "", IDC_CERT_ERROR, 40, 26, 200, 20 + LTEXT "Voulez-vous tout de même continuer ?", -1, 40, 46, 200, 20 + PUSHBUTTON "Oui", IDOK, 40, 66, 56, 14, WS_GROUP | WS_TABSTOP | BS_DEFPUSHBUTTON + PUSHBUTTON "Non", IDCANCEL, 100, 66, 56, 14, WS_GROUP | WS_TABSTOP +} + STRINGTABLE { IDS_LANCONNECTION "Connexion réseau local (LAN)"

1 0

André Hentschel : shell32/tests: Fix a typo.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: 2bbb9cb88886372a77fa6c1d12f4babf76dd90dc URL: http://source.winehq.org/git/wine.git/?a=commit;h=2bbb9cb88886372a77fa6c1d1… Author: André Hentschel <nerv(a)dawncrow.de> Date: Thu Dec 23 03:03:22 2010 +0100 shell32/tests: Fix a typo. --- dlls/shell32/tests/shlexec.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/tests/shlexec.c b/dlls/shell32/tests/shlexec.c index 47f640f..c32a065 100644 --- a/dlls/shell32/tests/shlexec.c +++ b/dlls/shell32/tests/shlexec.c @@ -1714,7 +1714,7 @@ static void test_dde(void) { if (!create_test_association(".sde")) { - skip("Unable to create association for '.sfe'\n"); + skip("Unable to create association for '.sde'\n"); return; } create_test_verb_dde(".sde", "Open", 0, test->command, test->ddeexec,

1 0

André Hentschel : advapi32: Print a FIXME also for the unknown levels.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: c6682ef5dc1200844874309909f0de61754afb3c URL: http://source.winehq.org/git/wine.git/?a=commit;h=c6682ef5dc120084487430990… Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Dec 22 21:10:10 2010 +0100 advapi32: Print a FIXME also for the unknown levels. --- dlls/advapi32/service.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 92790c1..96b0848 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -1406,6 +1406,8 @@ cleanup: /****************************************************************************** * QueryServiceConfig2W [ADVAPI32.@] + * + * See QueryServiceConfig2A. */ BOOL WINAPI QueryServiceConfig2W(SC_HANDLE hService, DWORD dwLevel, LPBYTE buffer, DWORD size, LPDWORD needed) @@ -1413,13 +1415,7 @@ BOOL WINAPI QueryServiceConfig2W(SC_HANDLE hService, DWORD dwLevel, LPBYTE buffe DWORD err; if(dwLevel != SERVICE_CONFIG_DESCRIPTION) { - if((dwLevel == SERVICE_CONFIG_DELAYED_AUTO_START_INFO) || - (dwLevel == SERVICE_CONFIG_FAILURE_ACTIONS) || - (dwLevel == SERVICE_CONFIG_FAILURE_ACTIONS_FLAG) || - (dwLevel == SERVICE_CONFIG_PRESHUTDOWN_INFO) || - (dwLevel == SERVICE_CONFIG_REQUIRED_PRIVILEGES_INFO) || - (dwLevel == SERVICE_CONFIG_SERVICE_SID_INFO)) - FIXME("Level %d not implemented\n", dwLevel); + FIXME("Level %d not implemented\n", dwLevel); SetLastError(ERROR_INVALID_LEVEL); return FALSE; }

1 0

Michael Stefaniuc : mshtml: COM cleanup for the IMonikerProp iface.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: 7e32a1abb31fe5667a586bce40b0afda2136e949 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7e32a1abb31fe5667a586bce4… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Dec 23 02:12:25 2010 +0100 mshtml: COM cleanup for the IMonikerProp iface. --- dlls/mshtml/htmldoc.c | 2 +- dlls/mshtml/mshtml_private.h | 3 +-- dlls/mshtml/persist.c | 15 +++++++++------ 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 90cafd7..486eefa 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -1740,7 +1740,7 @@ static BOOL htmldoc_qi(HTMLDocument *This, REFIID riid, void **ppv) *ppv = &This->IPersistFile_iface; }else if(IsEqualGUID(&IID_IMonikerProp, riid)) { TRACE("(%p)->(IID_IMonikerProp, %p)\n", This, ppv); - *ppv = MONPROP(This); + *ppv = &This->IMonikerProp_iface; }else if(IsEqualGUID(&IID_IOleObject, riid)) { TRACE("(%p)->(IID_IOleObject, %p)\n", This, ppv); *ppv = OLEOBJ(This); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 9059ded..62a2adf 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -350,7 +350,7 @@ struct HTMLDocument { IPersistMoniker IPersistMoniker_iface; IPersistFile IPersistFile_iface; IPersistHistory IPersistHistory_iface; - const IMonikerPropVtbl *lpMonikerPropVtbl; + IMonikerProp IMonikerProp_iface; const IOleObjectVtbl *lpOleObjectVtbl; const IOleDocumentVtbl *lpOleDocumentVtbl; const IOleDocumentViewVtbl *lpOleDocumentViewVtbl; @@ -626,7 +626,6 @@ struct HTMLDocumentNode { #define HTMLWINDOW3(x) ((IHTMLWindow3*) &(x)->lpHTMLWindow3Vtbl) #define HTMLWINDOW4(x) ((IHTMLWindow4*) &(x)->lpHTMLWindow4Vtbl) -#define MONPROP(x) ((IMonikerProp*) &(x)->lpMonikerPropVtbl) #define OLEOBJ(x) ((IOleObject*) &(x)->lpOleObjectVtbl) #define OLEDOC(x) ((IOleDocument*) &(x)->lpOleDocumentVtbl) #define DOCVIEW(x) ((IOleDocumentView*) &(x)->lpOleDocumentViewVtbl) diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c index 46d00a3..24d3c21 100644 --- a/dlls/mshtml/persist.c +++ b/dlls/mshtml/persist.c @@ -466,29 +466,32 @@ static const IPersistMonikerVtbl PersistMonikerVtbl = { * IMonikerProp implementation */ -#define MONPROP_THIS(iface) DEFINE_THIS(HTMLDocument, MonikerProp, iface) +static inline HTMLDocument *impl_from_IMonikerProp(IMonikerProp *iface) +{ + return CONTAINING_RECORD(iface, HTMLDocument, IMonikerProp_iface); +} static HRESULT WINAPI MonikerProp_QueryInterface(IMonikerProp *iface, REFIID riid, void **ppv) { - HTMLDocument *This = MONPROP_THIS(iface); + HTMLDocument *This = impl_from_IMonikerProp(iface); return htmldoc_query_interface(This, riid, ppv); } static ULONG WINAPI MonikerProp_AddRef(IMonikerProp *iface) { - HTMLDocument *This = MONPROP_THIS(iface); + HTMLDocument *This = impl_from_IMonikerProp(iface); return htmldoc_addref(This); } static ULONG WINAPI MonikerProp_Release(IMonikerProp *iface) { - HTMLDocument *This = MONPROP_THIS(iface); + HTMLDocument *This = impl_from_IMonikerProp(iface); return htmldoc_release(This); } static HRESULT WINAPI MonikerProp_PutProperty(IMonikerProp *iface, MONIKERPROPERTY mkp, LPCWSTR val) { - HTMLDocument *This = MONPROP_THIS(iface); + HTMLDocument *This = impl_from_IMonikerProp(iface); TRACE("(%p)->(%d %s)\n", This, mkp, debugstr_w(val)); @@ -835,7 +838,7 @@ void HTMLDocument_Persist_Init(HTMLDocument *This) { This->IPersistMoniker_iface.lpVtbl = &PersistMonikerVtbl; This->IPersistFile_iface.lpVtbl = &PersistFileVtbl; - This->lpMonikerPropVtbl = &MonikerPropVtbl; + This->IMonikerProp_iface.lpVtbl = &MonikerPropVtbl; This->IPersistStreamInit_iface.lpVtbl = &PersistStreamInitVtbl; This->IPersistHistory_iface.lpVtbl = &PersistHistoryVtbl; }

1 0

Michael Stefaniuc : mshtml: COM cleanup for the IOleObject iface.
by Alexandre Julliard 23 Dec '10

23 Dec '10

Module: wine Branch: master Commit: 6c3bb4de6f4fa8d57bb166cfd223f6a8d25f1c2d URL: http://source.winehq.org/git/wine.git/?a=commit;h=6c3bb4de6f4fa8d57bb166cfd… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Dec 23 02:16:00 2010 +0100 mshtml: COM cleanup for the IOleObject iface. --- dlls/mshtml/hlink.c | 2 +- dlls/mshtml/htmldoc.c | 4 +- dlls/mshtml/mshtml_private.h | 3 +- dlls/mshtml/oleobj.c | 57 +++++++++++++++++++++-------------------- dlls/mshtml/persist.c | 2 +- 5 files changed, 34 insertions(+), 34 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6c3bb4de6f4fa8d57bb16…

1 0