October 2011 - Wine-commits

Michael Stefaniuc : shell32: Get rid of a local typedef for a struct.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: d81f55fae6f3fd146fc9517c276b7f67c1e20d61 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d81f55fae6f3fd146fc9517c2… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Oct 10 00:58:43 2011 +0200 shell32: Get rid of a local typedef for a struct. --- dlls/shell32/enumidlist.c | 19 +++++++++---------- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/dlls/shell32/enumidlist.c b/dlls/shell32/enumidlist.c index f04ddd5..fbfe881 100644 --- a/dlls/shell32/enumidlist.c +++ b/dlls/shell32/enumidlist.c @@ -36,20 +36,19 @@ WINE_DEFAULT_DEBUG_CHANNEL(shell); -typedef struct tagENUMLIST +struct enumlist { - struct tagENUMLIST *pNext; + struct enumlist *pNext; LPITEMIDLIST pidl; - -} ENUMLIST, *LPENUMLIST; +}; typedef struct { IEnumIDList IEnumIDList_iface; LONG ref; - LPENUMLIST mpFirst; - LPENUMLIST mpLast; - LPENUMLIST mpCurrent; + struct enumlist *mpFirst; + struct enumlist *mpLast; + struct enumlist *mpCurrent; } IEnumIDListImpl; @@ -62,14 +61,14 @@ BOOL AddToEnumList( { IEnumIDListImpl *This = (IEnumIDListImpl *)iface; - LPENUMLIST pNew; + struct enumlist *pNew; TRACE("(%p)->(pidl=%p)\n",This,pidl); if (!iface || !pidl) return FALSE; - pNew = SHAlloc(sizeof(ENUMLIST)); + pNew = SHAlloc(sizeof(*pNew)); if(pNew) { /*set the next pointer */ @@ -164,7 +163,7 @@ BOOL CreateFolderEnumList( static BOOL DeleteList(IEnumIDListImpl *This) { - LPENUMLIST pDelete; + struct enumlist *pDelete; TRACE("(%p)->()\n",This);

1 0

Michael Stefaniuc : shell32: Simplify RecycleBin_EnumObjects() a little.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: 27b284d4c9501047c77d79beb0c2740397c5f5c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=27b284d4c9501047c77d79beb… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Oct 10 01:00:46 2011 +0200 shell32: Simplify RecycleBin_EnumObjects() a little. --- dlls/shell32/recyclebin.c | 24 +++++++++--------------- 1 files changed, 9 insertions(+), 15 deletions(-) diff --git a/dlls/shell32/recyclebin.c b/dlls/shell32/recyclebin.c index 44e99fc..9e75c30 100644 --- a/dlls/shell32/recyclebin.c +++ b/dlls/shell32/recyclebin.c @@ -410,33 +410,27 @@ static HRESULT WINAPI RecycleBin_EnumObjects(IShellFolder2 *iface, HWND hwnd, SH RecycleBin *This = impl_from_IShellFolder2(iface); IEnumIDList *list; LPITEMIDLIST *pidls; - HRESULT ret; + HRESULT ret = E_OUTOFMEMORY; int pidls_count; int i=0; TRACE("(%p, %p, %x, %p)\n", This, hwnd, grfFlags, ppenumIDList); + *ppenumIDList = NULL; + list = IEnumIDList_Constructor(); + if (!list) + return E_OUTOFMEMORY; + if (grfFlags & SHCONTF_NONFOLDERS) { - *ppenumIDList = NULL; if (FAILED(ret = TRASH_EnumItems(&pidls, &pidls_count))) - return ret; - - list = IEnumIDList_Constructor(); - if (list == NULL) goto failed; for (i=0; i<pidls_count; i++) if (!AddToEnumList(list, pidls[i])) goto failed; - *ppenumIDList = list; } - else - { - *ppenumIDList = IEnumIDList_Constructor(); - if (*ppenumIDList == NULL) - return E_OUTOFMEMORY; - } - + + *ppenumIDList = list; return S_OK; failed: @@ -445,7 +439,7 @@ failed: for (; i<pidls_count; i++) ILFree(pidls[i]); SHFree(pidls); - return E_OUTOFMEMORY; + return ret; } static HRESULT WINAPI RecycleBin_BindToObject(IShellFolder2 *This, LPCITEMIDLIST pidl, LPBC pbc, REFIID riid, void **ppv)

1 0

Thomas Mullaly : urlmon: Added custom security manager support to MapUrlToZoneEx2.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: 8fc8823d5c651e82acc5342aff19d8aeb6e04a26 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8fc8823d5c651e82acc5342af… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Thu Sep 8 17:59:59 2011 -0400 urlmon: Added custom security manager support to MapUrlToZoneEx2. --- dlls/urlmon/sec_mgr.c | 24 ++++++++++++++++++++++++ 1 files changed, 24 insertions(+), 0 deletions(-) diff --git a/dlls/urlmon/sec_mgr.c b/dlls/urlmon/sec_mgr.c index 314605e..0c7170c 100644 --- a/dlls/urlmon/sec_mgr.c +++ b/dlls/urlmon/sec_mgr.c @@ -1070,6 +1070,30 @@ static HRESULT WINAPI SecManagerImpl_MapUrlToZoneEx2(IInternetSecurityManagerEx2 TRACE("(%p)->(%p %p %08x %p %p)\n", This, pUri, pdwZone, dwFlags, ppwszMappedUrl, pdwOutFlags); + if(This->custom_manager) { + HRESULT hres; + IInternetSecurityManagerEx2 *sec_mgr2; + + hres = IInternetSecurityManager_QueryInterface(This->custom_manager, &IID_IInternetSecurityManagerEx2, + (void**)&sec_mgr2); + if(SUCCEEDED(hres)) { + hres = IInternetSecurityManagerEx2_MapUrlToZoneEx2(sec_mgr2, pUri, pdwZone, dwFlags, ppwszMappedUrl, pdwOutFlags); + IInternetSecurityManagerEx2_Release(sec_mgr2); + } else { + BSTR url; + + hres = IUri_GetDisplayUri(pUri, &url); + if(FAILED(hres)) + return hres; + + hres = IInternetSecurityManager_MapUrlToZone(This->custom_manager, url, pdwZone, dwFlags); + SysFreeString(url); + } + + if(hres != INET_E_DEFAULT_ACTION) + return hres; + } + if(!pdwZone) return E_INVALIDARG;

1 0

Thomas Mullaly : urlmon: Improved MapUrlToZone{Ex2} and GetSecurityId support.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: 253fccc82eef1f4d10460e7a792e73a1647d7898 URL: http://source.winehq.org/git/wine.git/?a=commit;h=253fccc82eef1f4d10460e7a7… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Thu Sep 15 21:36:18 2011 -0400 urlmon: Improved MapUrlToZone{Ex2} and GetSecurityId support. --- dlls/urlmon/sec_mgr.c | 26 ++++++++++++++++++++++++-- dlls/urlmon/tests/sec_mgr.c | 30 +++++++++++++++++++++++++++++- 2 files changed, 53 insertions(+), 3 deletions(-) diff --git a/dlls/urlmon/sec_mgr.c b/dlls/urlmon/sec_mgr.c index 0c7170c..c74fbce 100644 --- a/dlls/urlmon/sec_mgr.c +++ b/dlls/urlmon/sec_mgr.c @@ -62,6 +62,15 @@ static inline BOOL is_drive_path(const WCHAR *path) return isalphaW(*path) && *(path+1) == ':'; } +/* List of schemes types Windows seems to expect to be hierarchical. */ +static inline BOOL is_hierarchical_scheme(URL_SCHEME type) { + return(type == URL_SCHEME_HTTP || type == URL_SCHEME_FTP || + type == URL_SCHEME_GOPHER || type == URL_SCHEME_NNTP || + type == URL_SCHEME_TELNET || type == URL_SCHEME_WAIS || + type == URL_SCHEME_FILE || type == URL_SCHEME_HTTPS || + type == URL_SCHEME_RES); +} + /******************************************************************** * get_string_from_reg [internal] * @@ -466,6 +475,19 @@ static HRESULT get_zone_from_domains(IUri *uri, DWORD *zone) if(FAILED(hres)) return hres; + /* Known hierarchical scheme types must have a host. If they don't Windows + * assigns URLZONE_INVALID to the zone. + */ + if((scheme_type != URL_SCHEME_UNKNOWN && scheme_type != URL_SCHEME_FILE) + && is_hierarchical_scheme(scheme_type) && !*host) { + *zone = URLZONE_INVALID; + + SysFreeString(host); + + /* The MapUrlToZone functions return S_OK when this condition occurs. */ + return S_OK; + } + hres = IUri_GetSchemeName(uri, &scheme); if(FAILED(hres)) { SysFreeString(host); @@ -695,8 +717,8 @@ static HRESULT get_security_id(LPCWSTR url, BYTE *secid, DWORD *secid_len) static const WCHAR wszFile[] = {'f','i','l','e',':'}; hres = map_url_to_zone(url, &zone, &secur_url); - if(FAILED(hres)) - return hres == 0x80041001 ? E_INVALIDARG : hres; + if(zone == URLZONE_INVALID) + return (hres == 0x80041001 || hres == S_OK) ? E_INVALIDARG : hres; /* file protocol is a special case */ if(strlenW(secur_url) >= sizeof(wszFile)/sizeof(WCHAR) diff --git a/dlls/urlmon/tests/sec_mgr.c b/dlls/urlmon/tests/sec_mgr.c index fca17e8..869cc35 100644 --- a/dlls/urlmon/tests/sec_mgr.c +++ b/dlls/urlmon/tests/sec_mgr.c @@ -100,6 +100,8 @@ static const WCHAR url10[] = {'f','i','l','e',':','/','/','s','o','m','e','%','2 '.','j','p','g',0}; static const WCHAR url11[] = {'f','i','l','e',':','/','/','c',':','/','I','n','d','e','x','.','h','t','m',0}; static const WCHAR url12[] = {'f','i','l','e',':','/','/','/','c',':','/','I','n','d','e','x','.','h','t','m',0}; +static const WCHAR url13[] = {'h','t','t','p',':','g','o','o','g','l','e','.','c','o','m',0}; +static const WCHAR url14[] = {'z','i','p',':','t','e','s','t','i','n','g','.','c','o','m','/','t','e','s','t','i','n','g',0}; static const WCHAR url4e[] = {'f','i','l','e',':','s','o','m','e',' ','f','i','l','e', '.','j','p','g',0}; @@ -121,6 +123,8 @@ static const BYTE secid7[] = {'f','t','p',':','z','o','n','e','3', '.','w','i','n','e','t','e','s','t',3,0,0,0}; static const BYTE secid10[] = {'f','i','l','e',':','s','o','m','e','%','2','0','f','i','l','e','.','j','p','g',3,0,0,0}; +static const BYTE secid14[] = + {'z','i','p',':','t','e','s','t','i','n','g','.','c','o','m','/','t','e','s','t','i','n','g',3,0,0,0}; static const BYTE secid10_2[] = {'f','i','l','e',':','s','o','m','e',' ','f','i','l','e','.','j','p','g',3,0,0,0}; @@ -416,6 +420,28 @@ static void test_SecurityManager(void) "wrong secid\n"); zone = 100; + hres = IInternetSecurityManager_MapUrlToZone(secmgr, url13, &zone, 0); + ok(hres == S_OK, "MapUrlToZone failed: %08x\n", hres); + ok(zone == URLZONE_INVALID || broken(zone == URLZONE_INTERNET), "zone=%d\n", zone); + + size = sizeof(buf); + memset(buf, 0xf0, sizeof(buf)); + hres = IInternetSecurityManager_GetSecurityId(secmgr, url13, buf, &size, 0); + ok(hres == E_INVALIDARG || broken(hres == S_OK), "GetSecurityId failed: %08x\n", hres); + + zone = 100; + hres = IInternetSecurityManager_MapUrlToZone(secmgr, url14, &zone, 0); + ok(hres == S_OK, "MapUrlToZone failed: %08x, expected S_OK\n", hres); + ok(zone == URLZONE_INTERNET, "zone=%d\n", zone); + + size = sizeof(buf); + memset(buf, 0xf0, sizeof(buf)); + hres = IInternetSecurityManager_GetSecurityId(secmgr, url14, buf, &size, 0); + ok(hres == S_OK, "GetSecurityId failed: %08x, expected S_OK\n", hres); + todo_wine ok(size == sizeof(secid14), "size=%d\n", size); + todo_wine ok(!memcmp(buf, secid14, size), "wrong secid\n"); + + zone = 100; hres = IInternetSecurityManager_MapUrlToZone(secmgr, NULL, &zone, 0); ok(hres == E_INVALIDARG, "MapUrlToZone failed: %08x, expected E_INVALIDARG\n", hres); ok(zone == 100 || zone == -1, "zone=%d\n", zone); @@ -1734,7 +1760,9 @@ static const struct { {"ftp://zone3.winetest/file.test",0,0,URLZONE_INTERNET}, {"/file/testing/test.test",Uri_CREATE_ALLOW_RELATIVE,0,URLZONE_INTERNET}, {"zip://testing.com/",0,0,URLZONE_INTERNET}, - {"zip:testing.com",0,0,URLZONE_INTERNET} + {"zip:testing.com",0,0,URLZONE_INTERNET}, + {"http:google.com",0,S_OK,URLZONE_INVALID}, + {"http:/google.com",0,S_OK,URLZONE_INVALID} }; static void test_SecurityManagerEx2(void)

1 0

Thomas Mullaly : urlmon: Improved IUri support for wildcard URLs.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: 2784e1acedf31506fc402dd71daf0b455718d2ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=2784e1acedf31506fc402dd71… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Sat Sep 24 17:56:22 2011 -0400 urlmon: Improved IUri support for wildcard URLs. --- dlls/urlmon/tests/uri.c | 25 +++++++++++++++++++++++++ dlls/urlmon/uri.c | 18 ++++++++++++++---- 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c index d08dd5b..3483878 100644 --- a/dlls/urlmon/tests/uri.c +++ b/dlls/urlmon/tests/uri.c @@ -4291,6 +4291,31 @@ static const uri_properties uri_tests[] = { {URL_SCHEME_JAVASCRIPT,S_OK}, {URLZONE_INVALID,E_NOTIMPL} } + }, + { "*://google.com", 0, S_OK, FALSE, + { + {"*:google.com/",S_OK,FALSE}, + {"google.com",S_OK}, + {"*:google.com/",S_OK,FALSE}, + {"google.com",S_OK,FALSE}, + {"",S_FALSE,FALSE}, + {"",S_FALSE,FALSE}, + {"google.com",S_OK,FALSE}, + {"",S_FALSE,FALSE}, + {"/",S_OK,FALSE}, + {"/",S_OK,FALSE}, + {"",S_FALSE,FALSE}, + {"*://google.com",S_OK,FALSE}, + {"*",S_OK,FALSE}, + {"",S_FALSE,FALSE}, + {"",S_FALSE,FALSE} + }, + { + {Uri_HOST_DNS,S_OK,FALSE}, + {0,S_FALSE,FALSE}, + {URL_SCHEME_WILDCARD,S_OK,FALSE}, + {URLZONE_INVALID,E_NOTIMPL,FALSE} + } } }; diff --git a/dlls/urlmon/uri.c b/dlls/urlmon/uri.c index 5dfa8b8..2b0b9ad 100644 --- a/dlls/urlmon/uri.c +++ b/dlls/urlmon/uri.c @@ -155,6 +155,7 @@ typedef struct { BOOL has_implicit_scheme; BOOL has_implicit_ip; UINT implicit_ipv4; + BOOL must_have_path; const WCHAR *scheme; DWORD scheme_len; @@ -1938,10 +1939,7 @@ static BOOL parse_path_hierarchical(const WCHAR **ptr, parse_data *data, DWORD f const BOOL is_file = data->scheme_type == URL_SCHEME_FILE; if(is_path_delim(**ptr)) { - if(data->scheme_type == URL_SCHEME_WILDCARD) { - /* Wildcard schemes don't get a '/' attached if their path is - * empty. - */ + if(data->scheme_type == URL_SCHEME_WILDCARD && !data->must_have_path) { data->path = NULL; data->path_len = 0; } else if(!(flags & Uri_CREATE_NO_CANONICALIZE)) { @@ -2068,6 +2066,8 @@ static BOOL parse_path_opaque(const WCHAR **ptr, parse_data *data, DWORD flags) static BOOL parse_hierpart(const WCHAR **ptr, parse_data *data, DWORD flags) { const WCHAR *start = *ptr; + data->must_have_path = FALSE; + /* For javascript: URIs, simply set everything as a path */ if(data->scheme_type == URL_SCHEME_JAVASCRIPT) { data->path = *ptr; @@ -2087,6 +2087,13 @@ static BOOL parse_hierpart(const WCHAR **ptr, parse_data *data, DWORD flags) { TRACE("(%p %p %x): Treating URI as an hierarchical URI.\n", ptr, data, flags); data->is_opaque = FALSE; + if(data->scheme_type == URL_SCHEME_WILDCARD && !data->has_implicit_scheme) { + if(**ptr == '/' && *(*ptr+1) == '/') { + data->must_have_path = TRUE; + *ptr += 2; + } + } + /* TODO: Handle hierarchical URI's, parse authority then parse the path. */ if(!parse_authority(ptr, data, flags)) return FALSE; @@ -3184,6 +3191,9 @@ static BOOL canonicalize_hierpart(const parse_data *data, Uri *uri, DWORD flags, */ if((data->is_relative && (data->host || data->has_port)) || (!data->is_relative && data->scheme_type != URL_SCHEME_WILDCARD)) { + if(data->scheme_type == URL_SCHEME_WILDCARD) + FIXME("Here\n"); + if(!computeOnly) { INT pos = uri->canon_len;

1 0

Thomas Mullaly : urlmon/tests: Added tests for GetSecurityIdEx2.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: 714941f8a8af3118a4ac2749d472c556965a20d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=714941f8a8af3118a4ac2749d… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Mon Sep 12 18:38:45 2011 -0400 urlmon/tests: Added tests for GetSecurityIdEx2. --- dlls/urlmon/tests/sec_mgr.c | 97 ++++++++++++++++++++++++++++++++++++++----- 1 files changed, 86 insertions(+), 11 deletions(-) diff --git a/dlls/urlmon/tests/sec_mgr.c b/dlls/urlmon/tests/sec_mgr.c index 869cc35..54b01cd 100644 --- a/dlls/urlmon/tests/sec_mgr.c +++ b/dlls/urlmon/tests/sec_mgr.c @@ -102,6 +102,7 @@ static const WCHAR url11[] = {'f','i','l','e',':','/','/','c',':','/','I','n','d static const WCHAR url12[] = {'f','i','l','e',':','/','/','/','c',':','/','I','n','d','e','x','.','h','t','m',0}; static const WCHAR url13[] = {'h','t','t','p',':','g','o','o','g','l','e','.','c','o','m',0}; static const WCHAR url14[] = {'z','i','p',':','t','e','s','t','i','n','g','.','c','o','m','/','t','e','s','t','i','n','g',0}; +static const WCHAR url15[] = {'h','t','t','p',':','/','/','g','o','o','g','l','e','.','c','o','m','.','u','k',0}; static const WCHAR url4e[] = {'f','i','l','e',':','s','o','m','e',' ','f','i','l','e', '.','j','p','g',0}; @@ -116,6 +117,7 @@ static const char *szZoneMapDomainsKey = "Software\\Microsoft\\Windows\\CurrentV static const char *szInternetSettingsKey = "Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings"; static const BYTE secid1[] = {'f','i','l','e',':',0,0,0,0}; +static const BYTE secid2[] = {'*',':','i','n','d','e','x','.','h','t','m',3,0,0,0}; static const BYTE secid5[] = {'h','t','t','p',':','w','w','w','.','z','o','n','e','3', '.','w','i','n','e','t','e','s','t',3,0,0,0}; static const BYTE secid6[] = {'a','b','o','u','t',':','b','l','a','n','k',3,0,0,0}; @@ -127,6 +129,8 @@ static const BYTE secid14[] = {'z','i','p',':','t','e','s','t','i','n','g','.','c','o','m','/','t','e','s','t','i','n','g',3,0,0,0}; static const BYTE secid10_2[] = {'f','i','l','e',':','s','o','m','e',' ','f','i','l','e','.','j','p','g',3,0,0,0}; +static const BYTE secid13[] = {'h','t','t','p',':','c','o','m','.','u','k',3,0,0,0}; +static const BYTE secid13_2[] = {'h','t','t','p',':','g','o','o','g','l','e','.','c','o','m','.','u','k',3,0,0,0}; static const GUID CLSID_TestActiveX = {0x178fc163,0xf585,0x4e24,{0x9c,0x13,0x4b,0xb7,0xfa,0xf8,0x06,0x46}}; @@ -1745,34 +1749,45 @@ static void test_InternetGetSecurityUrlEx_Pluggable(void) if(uri) IUri_Release(uri); } +static const BYTE secidex2_1[] = {'z','i','p',':','/','/','t','e','s','t','i','n','g','.','c','o','m','/',3,0,0,0}; +static const BYTE secidex2_2[] = {'z','i','p',':','t','e','s','t','i','n','g','.','c','o','m',3,0,0,0}; + static const struct { const char *uri; DWORD create_flags; HRESULT map_hres; DWORD zone; BOOL map_todo; + const BYTE *secid; + DWORD secid_size; + HRESULT secid_hres; + BOOL secid_todo; } sec_mgr_ex2_tests[] = { - {"res://mshtml.dll/blank.htm",0,S_OK,URLZONE_LOCAL_MACHINE}, - {"index.htm",Uri_CREATE_ALLOW_RELATIVE,0,URLZONE_INTERNET}, - {"file://c:\\Index.html",0,0,URLZONE_LOCAL_MACHINE}, - {"http://www.zone3.winetest/",0,0,URLZONE_INTERNET}, - {"about:blank",0,0,URLZONE_INTERNET}, - {"ftp://zone3.winetest/file.test",0,0,URLZONE_INTERNET}, - {"/file/testing/test.test",Uri_CREATE_ALLOW_RELATIVE,0,URLZONE_INTERNET}, - {"zip://testing.com/",0,0,URLZONE_INTERNET}, - {"zip:testing.com",0,0,URLZONE_INTERNET}, - {"http:google.com",0,S_OK,URLZONE_INVALID}, - {"http:/google.com",0,S_OK,URLZONE_INVALID} + {"res://mshtml.dll/blank.htm",0,S_OK,URLZONE_LOCAL_MACHINE,FALSE,secid1,sizeof(secid1),S_OK,TRUE}, + {"index.htm",Uri_CREATE_ALLOW_RELATIVE,0,URLZONE_INTERNET,FALSE,secid2,sizeof(secid2),S_OK,TRUE}, + {"file://c:\\Index.html",0,0,URLZONE_LOCAL_MACHINE,FALSE,secid1,sizeof(secid1),S_OK,TRUE}, + {"http://www.zone3.winetest/",0,0,URLZONE_INTERNET,FALSE,secid5,sizeof(secid5),S_OK,TRUE}, + {"about:blank",0,0,URLZONE_INTERNET,FALSE,secid6,sizeof(secid6),S_OK,TRUE}, + {"ftp://zone3.winetest/file.test",0,0,URLZONE_INTERNET,FALSE,secid7,sizeof(secid7),S_OK,TRUE}, + {"/file/testing/test.test",Uri_CREATE_ALLOW_RELATIVE,0,URLZONE_INTERNET,FALSE,NULL,0,E_INVALIDARG,TRUE}, + {"zip://testing.com/",0,0,URLZONE_INTERNET,FALSE,secidex2_1,sizeof(secidex2_1),S_OK,TRUE}, + {"zip:testing.com",0,0,URLZONE_INTERNET,FALSE,secidex2_2,sizeof(secidex2_2),S_OK,TRUE}, + {"http:google.com",0,S_OK,URLZONE_INVALID,FALSE,NULL,0,E_INVALIDARG,TRUE}, + {"http:/google.com",0,S_OK,URLZONE_INVALID,FALSE,NULL,0,E_INVALIDARG,TRUE} }; static void test_SecurityManagerEx2(void) { HRESULT hres; DWORD i, zone; + BYTE buf[512]; + DWORD buf_size = sizeof(buf); IInternetSecurityManager *sec_mgr; IInternetSecurityManagerEx2 *sec_mgr2; IUri *uri = NULL; + static const WCHAR domainW[] = {'c','o','m','.','u','k',0}; + if(!pCreateUri) { win_skip("Skipping SecurityManagerEx2, IE is too old\n"); return; @@ -1792,12 +1807,24 @@ static void test_SecurityManagerEx2(void) ok(hres == E_INVALIDARG, "MapUrlToZoneEx2 returned %08x, expected E_INVALIDARG\n", hres); ok(zone == URLZONE_INVALID, "zone was %d\n", zone); + hres = IInternetSecurityManagerEx2_GetSecurityIdEx2(sec_mgr2, NULL, buf, &buf_size, 0); + todo_wine ok(hres == E_INVALIDARG, "GetSecurityIdEx2 returned %08x, expected E_INVALIDARG\n", hres); + ok(buf_size == sizeof(buf), "buf_size was %d\n", buf_size); + hres = pCreateUri(url5, 0, 0, &uri); ok(hres == S_OK, "CreateUri failed: %08x\n", hres); hres = IInternetSecurityManagerEx2_MapUrlToZoneEx2(sec_mgr2, uri, NULL, 0, NULL, NULL); ok(hres == E_INVALIDARG, "MapToUrlZoneEx2 returned %08x, expected E_INVALIDARG\n", hres); + buf_size = sizeof(buf); + hres = IInternetSecurityManagerEx2_GetSecurityIdEx2(sec_mgr2, uri, NULL, &buf_size, 0); + todo_wine ok(hres == E_INVALIDARG || broken(hres == S_OK), "GetSecurityIdEx2 failed: %08x\n", hres); + ok(buf_size == sizeof(buf), "bug_size was %d\n", buf_size); + + hres = IInternetSecurityManagerEx2_GetSecurityIdEx2(sec_mgr2, uri, buf, NULL, 0); + todo_wine ok(hres == E_INVALIDARG, "GetSecurityIdEx2 returned %08x, expected E_INVALIDARG\n", hres); + IUri_Release(uri); for(i = 0; i < sizeof(sec_mgr_ex2_tests)/sizeof(sec_mgr_ex2_tests[0]); ++i) { @@ -1824,10 +1851,58 @@ static void test_SecurityManagerEx2(void) zone, sec_mgr_ex2_tests[i].uri); } + buf_size = sizeof(buf); + memset(buf, 0xf0, buf_size); + + hres = IInternetSecurityManagerEx2_GetSecurityIdEx2(sec_mgr2, uri, buf, &buf_size, 0); + if(sec_mgr_ex2_tests[i].secid_todo) { + todo_wine + ok(hres == sec_mgr_ex2_tests[i].secid_hres, "GetSecurityIdEx2 returned %08x, expected %08x on test '%s'\n", + hres, sec_mgr_ex2_tests[i].secid_hres, sec_mgr_ex2_tests[i].uri); + if(sec_mgr_ex2_tests[i].secid) { + todo_wine { + ok(buf_size == sec_mgr_ex2_tests[i].secid_size, "Got wrong security id size=%d, expected %d on test '%s'\n", + buf_size, sec_mgr_ex2_tests[i].secid_size, sec_mgr_ex2_tests[i].uri); + ok(!memcmp(buf, sec_mgr_ex2_tests[i].secid, sec_mgr_ex2_tests[i].secid_size), "Got wrong security id on test '%s'\n", + sec_mgr_ex2_tests[i].uri); + } + } + } else { + ok(hres == sec_mgr_ex2_tests[i].secid_hres, "GetSecurityIdEx2 returned %08x, expected %08x on test '%s'\n", + hres, sec_mgr_ex2_tests[i].secid_hres, sec_mgr_ex2_tests[i].uri); + if(sec_mgr_ex2_tests[i].secid) { + ok(buf_size == sec_mgr_ex2_tests[i].secid_size, "Got wrong security id size=%d, expected %d on test '%s'\n", + buf_size, sec_mgr_ex2_tests[i].secid_size, sec_mgr_ex2_tests[i].uri); + ok(!memcmp(buf, sec_mgr_ex2_tests[i].secid, sec_mgr_ex2_tests[i].secid_size), "Got wrong security id on test '%s'\n", + sec_mgr_ex2_tests[i].uri); + } + } + heap_free(uriW); IUri_Release(uri); } + hres = pCreateUri(url15, 0, 0, &uri); + ok(hres == S_OK, "CreateUri failed: %08x\n", hres); + + buf_size = sizeof(buf); + memset(buf, 0xf0, buf_size); + + hres = IInternetSecurityManagerEx2_GetSecurityIdEx2(sec_mgr2, uri, buf, &buf_size, (DWORD_PTR)domainW); + todo_wine ok(hres == S_OK, "GetSecurityIdEx2 failed: %08x\n", hres); + todo_wine ok(buf_size == sizeof(secid13), "buf_size was %d\n", buf_size); + todo_wine ok(!memcmp(buf, secid13, sizeof(secid13)), "Got wrong secid\n"); + + buf_size = sizeof(buf); + memset(buf, 0xf0, buf_size); + + hres = IInternetSecurityManagerEx2_GetSecurityIdEx2(sec_mgr2, uri, buf, &buf_size, 0); + todo_wine ok(hres == S_OK, "GetSecurityIdEx2 failed: %08x\n", hres); + todo_wine ok(buf_size == sizeof(secid13_2), "buf_size was %d\n", buf_size); + todo_wine ok(!memcmp(buf, secid13_2, sizeof(secid13_2)), "Got wrong secid\n"); + + IUri_Release(uri); + IInternetSecurityManagerEx2_Release(sec_mgr2); IInternetSecurityManager_Release(sec_mgr); }

1 0

Thomas Mullaly : urlmon: Added basic GetSecurityIdEx2 implementation.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: 269fe5a4d433aae10a815b32fa7e5e8dd2b23d72 URL: http://source.winehq.org/git/wine.git/?a=commit;h=269fe5a4d433aae10a815b32f… Author: Thomas Mullaly <thomas.mullaly(a)gmail.com> Date: Mon Sep 12 22:01:02 2011 -0400 urlmon: Added basic GetSecurityIdEx2 implementation. --- dlls/urlmon/sec_mgr.c | 160 ++++++++++++++++++++++++++++++------------ dlls/urlmon/tests/sec_mgr.c | 43 ++++++------ 2 files changed, 137 insertions(+), 66 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=269fe5a4d433aae10a815…

1 0

Charles Davis : server: Use syscall(2) instead of inline assembly on Mac OS , too.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: a51aaf898cc95bc226f68b1d5a31137e87a3344b URL: http://source.winehq.org/git/wine.git/?a=commit;h=a51aaf898cc95bc226f68b1d5… Author: Charles Davis <cdavis(a)mymail.mines.edu> Date: Sat Oct 8 12:08:18 2011 -0600 server: Use syscall(2) instead of inline assembly on Mac OS, too. --- server/mach.c | 24 ++++-------------------- 1 files changed, 4 insertions(+), 20 deletions(-) diff --git a/server/mach.c b/server/mach.c index f890321..03c88ec 100644 --- a/server/mach.c +++ b/server/mach.c @@ -29,6 +29,9 @@ #include <stdarg.h> #include <sys/types.h> #include <unistd.h> +#ifdef HAVE_SYS_SYSCALL_H +#include <sys/syscall.h> +#endif #include "ntstatus.h" #define WIN32_NO_STATUS @@ -47,21 +50,6 @@ #include <mach/thread_act.h> #include <servers/bootstrap.h> -#if defined(__APPLE__) && defined(__i386__) -extern int pthread_kill_syscall( mach_port_t, int ); -__ASM_GLOBAL_FUNC( pthread_kill_syscall, - "movl $328,%eax\n\t" /* SYS___pthread_kill */ - "int $0x80\n\t" - "jae 1f\n\t" - "negl %eax\n" - "1:\tret" ) -#else -static inline int pthread_kill_syscall( mach_port_t, int ) -{ - return -ENOSYS; -} -#endif - static mach_port_t server_mach_port; void sigchld_callback(void) @@ -268,11 +256,7 @@ int send_thread_signal( struct thread *thread, int sig ) if (!mach_port_extract_right( process_port, thread->unix_tid, MACH_MSG_TYPE_COPY_SEND, &port, &type )) { - if ((ret = pthread_kill_syscall( port, sig )) < 0) - { - errno = -ret; - ret = -1; - } + ret = syscall( SYS___pthread_kill, port, sig ); mach_port_deallocate( mach_task_self(), port ); } else errno = ESRCH;

1 0

Andrew Talbot : jscript: Mark a fall-through in a switch statement.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: 30cab39056cedfe9112439cb693f1ec9b014b9ea URL: http://source.winehq.org/git/wine.git/?a=commit;h=30cab39056cedfe9112439cb6… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Oct 8 20:10:15 2011 +0100 jscript: Mark a fall-through in a switch statement. --- dlls/jscript/dispex.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index 0d584f0..e40f370 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -664,6 +664,7 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc switch(wFlags) { case DISPATCH_METHOD|DISPATCH_PROPERTYGET: wFlags = DISPATCH_METHOD; + /* fall through */ case DISPATCH_METHOD: case DISPATCH_CONSTRUCT: hres = invoke_prop_func(This, This, prop, wFlags, pdp, pvarRes, &jsexcept, pspCaller);

1 0

Andrew Talbot : jscript: Add breaks to some switch statements.
by Alexandre Julliard 10 Oct '11

10 Oct '11

Module: wine Branch: master Commit: e67aaab27a67affc21178ce66483be222d6d3319 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e67aaab27a67affc21178ce66… Author: Andrew Talbot <andrew.talbot(a)talbotville.com> Date: Sat Oct 8 20:10:24 2011 +0100 jscript: Add breaks to some switch statements. --- dlls/jscript/regexp.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/regexp.c b/dlls/jscript/regexp.c index 0fa13ff..e38e6ea 100644 --- a/dlls/jscript/regexp.c +++ b/dlls/jscript/regexp.c @@ -4037,9 +4037,10 @@ static HRESULT RegExpConstr_leftContext(script_ctx_t *ctx, vdisp_t *jsthis, WORD V_VT(retv) = VT_BSTR; V_BSTR(retv) = ret; + break; } case DISPATCH_PROPERTYPUT: - return S_OK; + break; default: FIXME("unsupported flags\n"); return E_NOTIMPL; @@ -4063,9 +4064,10 @@ static HRESULT RegExpConstr_rightContext(script_ctx_t *ctx, vdisp_t *jsthis, WOR V_VT(retv) = VT_BSTR; V_BSTR(retv) = ret; + break; } case DISPATCH_PROPERTYPUT: - return S_OK; + break; default: FIXME("unsupported flags\n"); return E_NOTIMPL;

1 0