May 2012 - Wine-commits - list.winehq.org

Józef Kucia : d3dx9: Add traces.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: b47c92bae323424308fd9be54a10d0af4c0365a9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b47c92bae323424308fd9be54… Author: Józef Kucia <joseph.kucia(a)gmail.com> Date: Sun May 13 23:00:10 2012 +0200 d3dx9: Add traces. --- dlls/d3dx9_36/surface.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/surface.c b/dlls/d3dx9_36/surface.c index ef4833f..28975b9 100644 --- a/dlls/d3dx9_36/surface.c +++ b/dlls/d3dx9_36/surface.c @@ -334,6 +334,8 @@ static HRESULT get_image_info_from_dds(const void *buffer, UINT length, D3DXIMAG if (info->Format == D3DFMT_UNKNOWN) return D3DXERR_INVALIDDATA; + TRACE("Pixel format is %#x\n", info->Format); + if (header->caps2 & DDS_CAPS2_VOLUME) { info->Depth = header->depth; @@ -528,8 +530,10 @@ HRESULT WINAPI D3DXGetImageInfoFromFileInMemory(LPCVOID data, UINT datasize, D3D if (!info) return D3D_OK; - if ((datasize >= 4) && !strncmp(data, "DDS ", 4)) + if ((datasize >= 4) && !strncmp(data, "DDS ", 4)) { + TRACE("File type is DDS\n"); return get_image_info_from_dds(data, datasize, info); + } initresult = CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);

1 0

Józef Kucia : d3dx9: Properly check if a texture is lockable in D3DXCreateTextureFromFileInMemoryEx .
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 3728a882311fce55d3a3ca5b79b7251cbb0a9e79 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3728a882311fce55d3a3ca5b7… Author: Józef Kucia <joseph.kucia(a)gmail.com> Date: Sun May 13 23:00:11 2012 +0200 d3dx9: Properly check if a texture is lockable in D3DXCreateTextureFromFileInMemoryEx. --- dlls/d3dx9_36/tests/texture.c | 17 +++++++++++++++++ dlls/d3dx9_36/texture.c | 10 +++++----- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/dlls/d3dx9_36/tests/texture.c b/dlls/d3dx9_36/tests/texture.c index 60017ec..1314fa2 100644 --- a/dlls/d3dx9_36/tests/texture.c +++ b/dlls/d3dx9_36/tests/texture.c @@ -1149,6 +1149,22 @@ static void test_D3DXCreateTextureFromFileInMemory(IDirect3DDevice9 *device) ok(hr == D3DXERR_INVALIDDATA, "D3DXCreateTextureFromFileInMemory returned %#x, expected %#x\n", hr, D3DXERR_INVALIDDATA); } +static void test_D3DXCreateTextureFromFileInMemoryEx(IDirect3DDevice9 *device) +{ + HRESULT hr; + IDirect3DTexture9 *texture; + + hr = D3DXCreateTextureFromFileInMemoryEx(device, dds_16bit, sizeof(dds_16bit), D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, + 0, D3DFMT_UNKNOWN, D3DPOOL_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, 0, NULL, NULL, &texture); + ok(hr == D3D_OK, "D3DXCreateTextureFromFileInMemoryEx returned %#x, expected %#x\n", hr, D3D_OK); + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); + + hr = D3DXCreateTextureFromFileInMemoryEx(device, dds_16bit, sizeof(dds_16bit), D3DX_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, + D3DUSAGE_DYNAMIC, D3DFMT_UNKNOWN, D3DPOOL_DEFAULT, D3DX_DEFAULT, D3DX_DEFAULT, 0, NULL, NULL, &texture); + ok(hr == D3D_OK, "D3DXCreateTextureFromFileInMemoryEx returned %#x, expected %#x\n", hr, D3D_OK); + if (SUCCEEDED(hr)) IDirect3DTexture9_Release(texture); +} + static void test_D3DXCreateCubeTextureFromFileInMemory(IDirect3DDevice9 *device) { HRESULT hr; @@ -1273,6 +1289,7 @@ START_TEST(texture) test_D3DXFillCubeTexture(device); test_D3DXFillVolumeTexture(device); test_D3DXCreateTextureFromFileInMemory(device); + test_D3DXCreateTextureFromFileInMemoryEx(device); test_D3DXCreateCubeTextureFromFileInMemory(device); test_D3DXCreateVolumeTextureFromFileInMemory(device); diff --git a/dlls/d3dx9_36/texture.c b/dlls/d3dx9_36/texture.c index 07e3d02..6a33547 100644 --- a/dlls/d3dx9_36/texture.c +++ b/dlls/d3dx9_36/texture.c @@ -590,15 +590,15 @@ HRESULT WINAPI D3DXCreateTextureFromFileInMemoryEx(LPDIRECT3DDEVICE9 device, return D3DERR_INVALIDCALL; /* Create the to-be-filled texture */ - if ((caps.Caps2 & D3DCAPS2_DYNAMICTEXTURES) && (pool != D3DPOOL_DEFAULT) && (usage != D3DUSAGE_DYNAMIC)) + if (pool == D3DPOOL_DEFAULT && !((caps.Caps2 & D3DCAPS2_DYNAMICTEXTURES) && usage == D3DUSAGE_DYNAMIC)) { - hr = D3DXCreateTexture(device, width, height, miplevels, usage, format, pool, texture); - texptr = texture; + hr = D3DXCreateTexture(device, width, height, miplevels, usage, format, D3DPOOL_SYSTEMMEM, &buftex); + texptr = &buftex; } else { - hr = D3DXCreateTexture(device, width, height, miplevels, usage, format, D3DPOOL_SYSTEMMEM, &buftex); - texptr = &buftex; + hr = D3DXCreateTexture(device, width, height, miplevels, usage, format, pool, texture); + texptr = texture; } if (FAILED(hr))

1 0

Austin English : msxml3: Avoid a dangling else (LLVM/Clang).
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 5de180beeb04aee97474e161bdf7b1f3362b4e5f URL: http://source.winehq.org/git/wine.git/?a=commit;h=5de180beeb04aee97474e161b… Author: Austin English <austinenglish(a)gmail.com> Date: Mon May 14 01:01:10 2012 -0500 msxml3: Avoid a dangling else (LLVM/Clang). --- dlls/msxml3/domdoc.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 6805c75..5097ff6 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -2277,8 +2277,7 @@ static HRESULT WINAPI domdoc_loadXML( /* skip leading spaces if needed */ if (This->properties->version == MSXML_DEFAULT || This->properties->version == MSXML26) - while (*ptr) - if (isspaceW(*ptr)) ptr++; else break; + while (*ptr && isspaceW(*ptr)) ptr++; xmldoc = doparse(This, (char*)ptr, strlenW(ptr)*sizeof(WCHAR), XML_CHAR_ENCODING_UTF16LE); if ( !xmldoc )

1 0

Alexandre Julliard : ole32: Add a NULL pointer check in CoDisconnectObject.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 2736d28064437a470897bb9cb8688e354bb93908 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2736d28064437a470897bb9cb… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon May 14 18:24:19 2012 +0200 ole32: Add a NULL pointer check in CoDisconnectObject. --- dlls/ole32/compobj.c | 2 ++ dlls/ole32/tests/marshal.c | 3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index 72ba32a..ff8f961 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -1557,6 +1557,8 @@ HRESULT WINAPI CoDisconnectObject( LPUNKNOWN lpUnk, DWORD reserved ) TRACE("(%p, 0x%08x)\n", lpUnk, reserved); + if (!lpUnk) return E_INVALIDARG; + hr = IUnknown_QueryInterface(lpUnk, &IID_IMarshal, (void **)&marshal); if (hr == S_OK) { diff --git a/dlls/ole32/tests/marshal.c b/dlls/ole32/tests/marshal.c index c178912..91de43b 100644 --- a/dlls/ole32/tests/marshal.c +++ b/dlls/ole32/tests/marshal.c @@ -1331,6 +1331,9 @@ static void test_disconnect_stub(void) CoDisconnectObject((IUnknown*)&Test_ClassFactory, 0); ok_no_locks(); + + hr = CoDisconnectObject(NULL, 0); + ok( hr == E_INVALIDARG, "wrong status %x\n", hr ); } /* tests failure case of a same-thread marshal and unmarshal twice */

1 0

Andrew Eikum : dsound: Remove minlen, since we always mix full chunks anyway.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 2c6087457b97e815ee094e7ed75ca79317a5d14a URL: http://source.winehq.org/git/wine.git/?a=commit;h=2c6087457b97e815ee094e7ed… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon May 14 12:31:01 2012 -0500 dsound: Remove minlen, since we always mix full chunks anyway. --- dlls/dsound/mixer.c | 28 +++++++++------------------- 1 files changed, 9 insertions(+), 19 deletions(-) diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c index ec5a264..81cbd02 100644 --- a/dlls/dsound/mixer.c +++ b/dlls/dsound/mixer.c @@ -609,10 +609,9 @@ static DWORD DSOUND_MixOne(IDirectSoundBufferImpl *dsb, DWORD writepos, DWORD mi * Returns: the length beyond the writepos that was mixed to. */ -static DWORD DSOUND_MixToPrimary(const DirectSoundDevice *device, DWORD writepos, DWORD mixlen, BOOL recover, BOOL *all_stopped) +static void DSOUND_MixToPrimary(const DirectSoundDevice *device, DWORD writepos, DWORD mixlen, BOOL recover, BOOL *all_stopped) { - INT i, len; - DWORD minlen = 0; + INT i; IDirectSoundBufferImpl *dsb; /* unless we find a running buffer, all have stopped */ @@ -643,22 +642,13 @@ static DWORD DSOUND_MixToPrimary(const DirectSoundDevice *device, DWORD writepos dsb->state = STATE_PLAYING; /* mix next buffer into the main buffer */ - len = DSOUND_MixOne(dsb, writepos, mixlen); - - if (!minlen) minlen = len; - - /* record the minimum length mixed from all buffers */ - /* we only want to return the length which *all* buffers have mixed */ - else if (len) minlen = (len < minlen) ? len : minlen; + DSOUND_MixOne(dsb, writepos, mixlen); *all_stopped = FALSE; } RtlReleaseResource(&dsb->lock); } } - - TRACE("Mixed at least %d from all buffers\n", minlen); - return minlen; } /** @@ -801,7 +791,7 @@ static void DSOUND_PerformMix(DirectSoundDevice *device) if (device->priolevel != DSSCL_WRITEPRIMARY) { BOOL recover = FALSE, all_stopped = FALSE; - DWORD playpos, writepos, writelead, maxq, frag, prebuff_max, prebuff_left, size1, size2, mixplaypos, mixplaypos2; + DWORD playpos, writepos, writelead, maxq, prebuff_max, prebuff_left, size1, size2, mixplaypos, mixplaypos2; LPVOID buf1, buf2; int nfiller; @@ -873,19 +863,19 @@ static void DSOUND_PerformMix(DirectSoundDevice *device) prebuff_left, device->prebuf, device->fraglen, prebuff_max, writelead); /* do the mixing */ - frag = DSOUND_MixToPrimary(device, writepos, maxq, recover, &all_stopped); + DSOUND_MixToPrimary(device, writepos, maxq, recover, &all_stopped); - if (frag + writepos > device->buflen) + if (maxq + writepos > device->buflen) { DWORD todo = device->buflen - writepos; device->normfunction(device->mix_buffer + DSOUND_bufpos_to_mixpos(device, writepos), device->buffer + writepos, todo); - device->normfunction(device->mix_buffer, device->buffer, frag - todo); + device->normfunction(device->mix_buffer, device->buffer, maxq - todo); } else - device->normfunction(device->mix_buffer + DSOUND_bufpos_to_mixpos(device, writepos), device->buffer + writepos, frag); + device->normfunction(device->mix_buffer + DSOUND_bufpos_to_mixpos(device, writepos), device->buffer + writepos, maxq); /* update the mix position, taking wrap-around into account */ - device->mixpos = writepos + frag; + device->mixpos = writepos + maxq; device->mixpos %= device->buflen; /* update prebuff left */

1 0

Andrew Eikum : dsound: Express buffer positions in terms of bytes, not fragments.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 1053bfb48d7a1ebb593b03dcea7bc51ec0867e65 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1053bfb48d7a1ebb593b03dce… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon May 14 12:31:10 2012 -0500 dsound: Express buffer positions in terms of bytes, not fragments. --- dlls/dsound/dsound_private.h | 2 +- dlls/dsound/mixer.c | 65 ++++++++++++++++++----------------------- dlls/dsound/primary.c | 13 ++------ 3 files changed, 34 insertions(+), 46 deletions(-) diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h index bed6959..d7cb183 100644 --- a/dlls/dsound/dsound_private.h +++ b/dlls/dsound/dsound_private.h @@ -83,7 +83,7 @@ struct DirectSoundDevice DSCAPS drvcaps; DWORD priolevel; PWAVEFORMATEX pwfx; - UINT timerID, pwplay, pwqueue, prebuf, helfrags; + UINT timerID, playing_offs_bytes, in_mmdev_bytes, prebuf, helfrags; UINT64 last_pos_bytes; DWORD fraglen; LPBYTE buffer; diff --git a/dlls/dsound/mixer.c b/dlls/dsound/mixer.c index 81cbd02..625665f 100644 --- a/dlls/dsound/mixer.c +++ b/dlls/dsound/mixer.c @@ -663,53 +663,47 @@ static void DSOUND_MixToPrimary(const DirectSoundDevice *device, DWORD writepos, static void DSOUND_WaveQueue(DirectSoundDevice *device, BOOL force) { - DWORD prebuf_frames, buf_offs_bytes, wave_fragpos; - int prebuf_frags; + DWORD prebuf_frames, prebuf_bytes, read_offs_bytes; BYTE *buffer; HRESULT hr; TRACE("(%p)\n", device); - /* calculate the current wave frag position */ - wave_fragpos = (device->pwplay + device->pwqueue) % device->helfrags; + read_offs_bytes = (device->playing_offs_bytes + device->in_mmdev_bytes) % device->buflen; - /* calculate the current wave write position */ - buf_offs_bytes = wave_fragpos * device->fraglen; - - TRACE("wave_fragpos = %i, buf_offs_bytes = %i, pwqueue = %i, prebuf = %i\n", - wave_fragpos, buf_offs_bytes, device->pwqueue, device->prebuf); + TRACE("read_offs_bytes = %u, playing_offs_bytes = %u, in_mmdev_bytes: %u, prebuf = %u\n", + read_offs_bytes, device->playing_offs_bytes, device->in_mmdev_bytes, device->prebuf); if (!force) { - /* check remaining prebuffered frags */ - prebuf_frags = device->mixpos / device->fraglen; - if (prebuf_frags == device->helfrags) - --prebuf_frags; - TRACE("wave_fragpos = %d, mixpos_frags = %d\n", wave_fragpos, prebuf_frags); - if (prebuf_frags < wave_fragpos) - prebuf_frags += device->helfrags; - prebuf_frags -= wave_fragpos; - TRACE("wanted prebuf_frags = %d\n", prebuf_frags); + if(device->mixpos < device->playing_offs_bytes) + prebuf_bytes = device->mixpos + device->buflen - device->playing_offs_bytes; + else + prebuf_bytes = device->mixpos - device->playing_offs_bytes; } else /* buffer the maximum amount of frags */ - prebuf_frags = device->prebuf; + prebuf_bytes = device->prebuf * device->fraglen; /* limit to the queue we have left */ - if ((prebuf_frags + device->pwqueue) > device->prebuf) - prebuf_frags = device->prebuf - device->pwqueue; + if(device->in_mmdev_bytes + prebuf_bytes > device->prebuf * device->fraglen) + prebuf_bytes = device->prebuf * device->fraglen - device->in_mmdev_bytes; - TRACE("prebuf_frags = %i\n", prebuf_frags); + TRACE("prebuf_bytes = %u\n", prebuf_bytes); - if(!prebuf_frags) + if(!prebuf_bytes) return; - /* adjust queue */ - device->pwqueue += prebuf_frags; + device->in_mmdev_bytes += prebuf_bytes; - prebuf_frames = ((prebuf_frags + wave_fragpos > device->helfrags) ? - (device->helfrags - wave_fragpos) : - (prebuf_frags)) * device->fraglen / device->pwfx->nBlockAlign; + if(prebuf_bytes + read_offs_bytes > device->buflen){ + DWORD chunk_bytes = device->buflen - read_offs_bytes; + prebuf_frames = chunk_bytes / device->pwfx->nBlockAlign; + prebuf_bytes -= chunk_bytes; + }else{ + prebuf_frames = prebuf_bytes / device->pwfx->nBlockAlign; + prebuf_bytes = 0; + } hr = IAudioRenderClient_GetBuffer(device->render, prebuf_frames, &buffer); if(FAILED(hr)){ @@ -717,7 +711,7 @@ static void DSOUND_WaveQueue(DirectSoundDevice *device, BOOL force) return; } - memcpy(buffer, device->buffer + buf_offs_bytes, + memcpy(buffer, device->buffer + read_offs_bytes, prebuf_frames * device->pwfx->nBlockAlign); hr = IAudioRenderClient_ReleaseBuffer(device->render, prebuf_frames, 0); @@ -727,9 +721,8 @@ static void DSOUND_WaveQueue(DirectSoundDevice *device, BOOL force) } /* check if anything wrapped */ - prebuf_frags = prebuf_frags + wave_fragpos - device->helfrags; - if(prebuf_frags > 0){ - prebuf_frames = prebuf_frags * device->fraglen / device->pwfx->nBlockAlign; + if(prebuf_bytes > 0){ + prebuf_frames = prebuf_bytes / device->pwfx->nBlockAlign; hr = IAudioRenderClient_GetBuffer(device->render, prebuf_frames, &buffer); if(FAILED(hr)){ @@ -746,7 +739,7 @@ static void DSOUND_WaveQueue(DirectSoundDevice *device, BOOL force) } } - TRACE("queue now = %i\n", device->pwqueue); + TRACE("in_mmdev_bytes now = %i\n", device->in_mmdev_bytes); } /** @@ -783,9 +776,9 @@ static void DSOUND_PerformMix(DirectSoundDevice *device) delta_frags = (pos_bytes - device->last_pos_bytes) / device->fraglen; if(delta_frags > 0){ - device->pwplay += delta_frags; - device->pwplay %= device->helfrags; - device->pwqueue -= delta_frags; + device->playing_offs_bytes += delta_frags * device->fraglen; + device->playing_offs_bytes %= device->buflen; + device->in_mmdev_bytes -= delta_frags * device->fraglen; device->last_pos_bytes = pos_bytes - (pos_bytes % device->fraglen); } diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c index b5a09f8..aec053b 100644 --- a/dlls/dsound/primary.c +++ b/dlls/dsound/primary.c @@ -210,7 +210,7 @@ static HRESULT DSOUND_PrimaryOpen(DirectSoundDevice *device) device->normfunction = normfunctions[device->pwfx->wBitsPerSample/8 - 1]; FillMemory(device->buffer, device->buflen, (device->pwfx->wBitsPerSample == 8) ? 128 : 0); FillMemory(device->mix_buffer, device->mix_buffer_len, 0); - device->last_pos_bytes = device->pwplay = device->pwqueue = device->playpos = device->mixpos = 0; + device->last_pos_bytes = device->playing_offs_bytes = device->in_mmdev_bytes = device->playpos = device->mixpos = 0; return DS_OK; } @@ -221,8 +221,6 @@ static void DSOUND_PrimaryClose(DirectSoundDevice *device) TRACE("(%p)\n", device); - device->pwqueue = (DWORD)-1; /* resetting queues */ - if(device->client){ hr = IAudioClient_Stop(device->client); if(FAILED(hr)) @@ -230,7 +228,7 @@ static void DSOUND_PrimaryClose(DirectSoundDevice *device) } /* clear the queue */ - device->pwqueue = 0; + device->in_mmdev_bytes = 0; } HRESULT DSOUND_PrimaryCreate(DirectSoundDevice *device) @@ -308,17 +306,14 @@ HRESULT DSOUND_PrimaryGetPosition(DirectSoundDevice *device, LPDWORD playpos, LP { TRACE("(%p,%p,%p)\n", device, playpos, writepos); - TRACE("pwplay=%i, pwqueue=%i\n", device->pwplay, device->pwqueue); - /* check if playpos was requested */ if (playpos) - /* use the cached play position */ - *playpos = device->pwplay * device->fraglen; + *playpos = device->playing_offs_bytes; /* check if writepos was requested */ if (writepos) /* the writepos is the first non-queued position */ - *writepos = ((device->pwplay + device->pwqueue) % device->helfrags) * device->fraglen; + *writepos = (device->playing_offs_bytes + device->in_mmdev_bytes) % device->buflen; TRACE("playpos = %d, writepos = %d (%p, time=%d)\n", playpos?*playpos:-1, writepos?*writepos:-1, device, GetTickCount()); return DS_OK;

1 0

Andrew Eikum : dsound: Base fragment size off of the MMDevice's period.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 7dce1418ffabe9c63fe40178fe455e23671bb998 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7dce1418ffabe9c63fe40178f… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon May 14 12:31:13 2012 -0500 dsound: Base fragment size off of the MMDevice's period. --- dlls/dsound/dsound_private.h | 1 - dlls/dsound/primary.c | 46 +++++++++++++++-------------------------- 2 files changed, 17 insertions(+), 30 deletions(-) diff --git a/dlls/dsound/dsound_private.h b/dlls/dsound/dsound_private.h index d7cb183..44d4d2f 100644 --- a/dlls/dsound/dsound_private.h +++ b/dlls/dsound/dsound_private.h @@ -276,7 +276,6 @@ HRESULT DSOUND_Create8(REFIID riid, LPDIRECTSOUND8 *ppDS) DECLSPEC_HIDDEN; /* primary.c */ -DWORD DSOUND_fraglen(DWORD nSamplesPerSec, DWORD nBlockAlign) DECLSPEC_HIDDEN; HRESULT DSOUND_PrimaryCreate(DirectSoundDevice *device) DECLSPEC_HIDDEN; HRESULT DSOUND_PrimaryDestroy(DirectSoundDevice *device) DECLSPEC_HIDDEN; HRESULT DSOUND_PrimaryPlay(DirectSoundDevice *device) DECLSPEC_HIDDEN; diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c index aec053b..153f1a1 100644 --- a/dlls/dsound/primary.c +++ b/dlls/dsound/primary.c @@ -40,41 +40,29 @@ WINE_DEFAULT_DEBUG_CHANNEL(dsound); -/** Calculate how long a fragment length of about 10 ms should be in frames - * - * nSamplesPerSec: Frequency rate in samples per second - * nBlockAlign: Size of a single blockalign - * - * Returns: - * Size in bytes of a single fragment - */ -DWORD DSOUND_fraglen(DWORD nSamplesPerSec, DWORD nBlockAlign) +static DWORD DSOUND_fraglen(DirectSoundDevice *device) { - /* Given a timer delay of 10ms, the fragment size is approximately: - * fraglen = (nSamplesPerSec * 10 / 1000) * nBlockAlign - * ==> fraglen = (nSamplesPerSec / 100) * nBlockSize - * - * ALSA uses buffers that are powers of 2. Because of this, fraglen - * is rounded up to the nearest power of 2: - */ - - if (nSamplesPerSec <= 12800) - return 128 * nBlockAlign; - - if (nSamplesPerSec <= 25600) - return 256 * nBlockAlign; - - if (nSamplesPerSec <= 51200) - return 512 * nBlockAlign; + REFERENCE_TIME period; + HRESULT hr; + DWORD ret; - return 1024 * nBlockAlign; + hr = IAudioClient_GetDevicePeriod(device->client, &period, NULL); + if(FAILED(hr)){ + /* just guess at 10ms */ + WARN("GetDevicePeriod failed: %08x\n", hr); + ret = MulDiv(device->pwfx->nBlockAlign, device->pwfx->nSamplesPerSec, 100); + }else + ret = MulDiv(device->pwfx->nSamplesPerSec * device->pwfx->nBlockAlign, period, 10000000); + + ret -= ret % device->pwfx->nBlockAlign; + return ret; } static void DSOUND_RecalcPrimary(DirectSoundDevice *device) { TRACE("(%p)\n", device); - device->fraglen = DSOUND_fraglen(device->pwfx->nSamplesPerSec, device->pwfx->nBlockAlign); + device->fraglen = DSOUND_fraglen(device); device->helfrags = device->buflen / device->fraglen; TRACE("fraglen=%d helfrags=%d\n", device->fraglen, device->helfrags); @@ -114,7 +102,7 @@ HRESULT DSOUND_ReopenDevice(DirectSoundDevice *device, BOOL forcewave) return hres; } - prebuf_frames = device->prebuf * DSOUND_fraglen(device->pwfx->nSamplesPerSec, device->pwfx->nBlockAlign) / device->pwfx->nBlockAlign; + prebuf_frames = device->prebuf * DSOUND_fraglen(device) / device->pwfx->nBlockAlign; prebuf_rt = (10000000 * (UINT64)prebuf_frames) / device->pwfx->nSamplesPerSec; hres = IAudioClient_Initialize(device->client,

1 0

Andrew Eikum : dsound: Ensure primary buffer' s buffer is large enough to hold the entire prebuffer.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 8327e6f4234bcc073c6d2979286341ff6103b220 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8327e6f4234bcc073c6d29792… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon May 14 12:31:17 2012 -0500 dsound: Ensure primary buffer's buffer is large enough to hold the entire prebuffer. --- dlls/dsound/primary.c | 36 ++++++++++++++---------------------- 1 files changed, 14 insertions(+), 22 deletions(-) diff --git a/dlls/dsound/primary.c b/dlls/dsound/primary.c index 153f1a1..7fed78e 100644 --- a/dlls/dsound/primary.c +++ b/dlls/dsound/primary.c @@ -58,18 +58,6 @@ static DWORD DSOUND_fraglen(DirectSoundDevice *device) return ret; } -static void DSOUND_RecalcPrimary(DirectSoundDevice *device) -{ - TRACE("(%p)\n", device); - - device->fraglen = DSOUND_fraglen(device); - device->helfrags = device->buflen / device->fraglen; - TRACE("fraglen=%d helfrags=%d\n", device->fraglen, device->helfrags); - - /* calculate the 10ms write lead */ - device->writelead = (device->pwfx->nSamplesPerSec / 100) * device->pwfx->nBlockAlign; -} - HRESULT DSOUND_ReopenDevice(DirectSoundDevice *device, BOOL forcewave) { UINT prebuf_frames; @@ -153,18 +141,23 @@ HRESULT DSOUND_ReopenDevice(DirectSoundDevice *device, BOOL forcewave) static HRESULT DSOUND_PrimaryOpen(DirectSoundDevice *device) { - DWORD buflen; LPBYTE newbuf; TRACE("(%p)\n", device); + device->fraglen = DSOUND_fraglen(device); + /* on original windows, the buffer it set to a fixed size, no matter what the settings are. on windows this size is always fixed (tested on win-xp) */ if (!device->buflen) device->buflen = ds_hel_buflen; - buflen = device->buflen; - buflen -= buflen % device->pwfx->nBlockAlign; - device->buflen = buflen; + device->buflen -= device->buflen % device->pwfx->nBlockAlign; + while(device->buflen < device->fraglen * device->prebuf){ + device->buflen += ds_hel_buflen; + device->buflen -= device->buflen % device->pwfx->nBlockAlign; + } + + device->helfrags = device->buflen / device->fraglen; device->mix_buffer_len = DSOUND_bufpos_to_mixpos(device, device->buflen); device->mix_buffer = HeapAlloc(GetProcessHeap(), 0, device->mix_buffer_len); @@ -174,13 +167,11 @@ static HRESULT DSOUND_PrimaryOpen(DirectSoundDevice *device) if (device->state == STATE_PLAYING) device->state = STATE_STARTING; else if (device->state == STATE_STOPPING) device->state = STATE_STOPPED; - TRACE("desired buflen=%d, old buffer=%p\n", buflen, device->buffer); - /* reallocate emulated primary buffer */ if (device->buffer) - newbuf = HeapReAlloc(GetProcessHeap(),0,device->buffer, buflen); + newbuf = HeapReAlloc(GetProcessHeap(),0,device->buffer, device->buflen); else - newbuf = HeapAlloc(GetProcessHeap(),0, buflen); + newbuf = HeapAlloc(GetProcessHeap(),0, device->buflen); if (!newbuf) { ERR("failed to allocate primary buffer\n"); @@ -188,11 +179,12 @@ static HRESULT DSOUND_PrimaryOpen(DirectSoundDevice *device) /* but the old buffer might still exist and must be re-prepared */ } - DSOUND_RecalcPrimary(device); + device->writelead = (device->pwfx->nSamplesPerSec / 100) * device->pwfx->nBlockAlign; device->buffer = newbuf; - TRACE("fraglen=%d\n", device->fraglen); + TRACE("buflen: %u, fraglen: %u, helfrags: %u, mix_buffer_len: %u\n", + device->buflen, device->fraglen, device->helfrags, device->mix_buffer_len); device->mixfunction = mixfunctions[device->pwfx->wBitsPerSample/8 - 1]; device->normfunction = normfunctions[device->pwfx->wBitsPerSample/8 - 1];

1 0

Jacek Caban : mshtml: Always use English locale in document_write to perform type conversion.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 888505d458cf77e449039108e578ea48cf5bc5b4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=888505d458cf77e449039108e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon May 14 11:33:10 2012 +0200 mshtml: Always use English locale in document_write to perform type conversion. --- dlls/mshtml/htmldoc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 71f0db9..6b616da 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -831,7 +831,7 @@ static HRESULT document_write(HTMLDocument *This, SAFEARRAY *psarray, BOOL ln) if(V_VT(var+i) == VT_BSTR) { nsAString_InitDepend(&nsstr, V_BSTR(var+i)); }else { - hres = VariantChangeType(&tmp, var+i, 0, VT_BSTR); + hres = VariantChangeTypeEx(&tmp, var+i, MAKELCID(MAKELANGID(LANG_ENGLISH,SUBLANG_ENGLISH_US),SORT_DEFAULT), 0, VT_BSTR); if(FAILED(hres)) { WARN("Could not convert %s to string\n", debugstr_variant(var+i)); break;

1 0

Piotr Caban : wininet: Store connect timeout in all layers.
by Alexandre Julliard 14 May '12

14 May '12

Module: wine Branch: master Commit: 0b421006158baa5d539f021e70d89a7cb3e8212c URL: http://source.winehq.org/git/wine.git/?a=commit;h=0b421006158baa5d539f021e7… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Mon May 14 13:49:29 2012 +0200 wininet: Store connect timeout in all layers. --- dlls/wininet/http.c | 2 +- dlls/wininet/internet.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++- dlls/wininet/internet.h | 1 + 3 files changed, 57 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/http.c b/dlls/wininet/http.c index a0b4a62..01f0f95 100644 --- a/dlls/wininet/http.c +++ b/dlls/wininet/http.c @@ -5606,7 +5606,7 @@ DWORD HTTP_Connect(appinfo_t *hIC, LPCWSTR lpszServerName, session->password = heap_strdupW(lpszPassword); session->serverPort = serverPort; session->hostPort = serverPort; - session->connect_timeout = INFINITE; + session->connect_timeout = hIC->connect_timeout; session->send_timeout = INFINITE; session->receive_timeout = INFINITE; diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c index f631469..ba4794c 100644 --- a/dlls/wininet/internet.c +++ b/dlls/wininet/internet.c @@ -109,6 +109,7 @@ typedef struct } proxyinfo_t; static ULONG max_conns = 2, max_1_0_conns = 4; +static ULONG connect_timeout = 60000; static const WCHAR szInternetSettings[] = { 'S','o','f','t','w','a','r','e','\\','M','i','c','r','o','s','o','f','t','\\', @@ -874,16 +875,47 @@ static DWORD APPINFO_QueryOption(object_header_t *hdr, DWORD option, void *buffe *size = sizeof(INTERNET_PROXY_INFOA) + proxyBytesRequired + proxyBypassBytesRequired; return ERROR_SUCCESS; } + + case INTERNET_OPTION_CONNECT_TIMEOUT: + TRACE("INTERNET_OPTION_CONNECT_TIMEOUT\n"); + + if (*size < sizeof(ULONG)) + return ERROR_INSUFFICIENT_BUFFER; + + *(ULONG*)buffer = ai->connect_timeout; + *size = sizeof(ULONG); + + return ERROR_SUCCESS; } return INET_QueryOption(hdr, option, buffer, size, unicode); } +static DWORD APPINFO_SetOption(object_header_t *hdr, DWORD option, void *buf, DWORD size) +{ + appinfo_t *ai = (appinfo_t*)hdr; + + switch(option) { + case INTERNET_OPTION_CONNECT_TIMEOUT: + TRACE("INTERNET_OPTION_CONNECT_TIMEOUT\n"); + + if(size != sizeof(connect_timeout)) + return ERROR_INTERNET_BAD_OPTION_LENGTH; + if(!*(ULONG*)buf) + return ERROR_BAD_ARGUMENTS; + + ai->connect_timeout = *(ULONG*)buf; + return ERROR_SUCCESS; + } + + return INET_SetOption(hdr, option, buf, size); +} + static const object_vtbl_t APPINFOVtbl = { APPINFO_Destroy, NULL, APPINFO_QueryOption, - INET_SetOption, + APPINFO_SetOption, NULL, NULL, NULL, @@ -946,6 +978,7 @@ HINTERNET WINAPI InternetOpenW(LPCWSTR lpszAgent, DWORD dwAccessType, lpwai->accessType = dwAccessType; lpwai->proxyUsername = NULL; lpwai->proxyPassword = NULL; + lpwai->connect_timeout = connect_timeout; lpwai->agent = heap_strdupW(lpszAgent); if(dwAccessType == INTERNET_OPEN_TYPE_PRECONFIG) @@ -2438,6 +2471,16 @@ static DWORD query_global_option(DWORD option, void *buffer, DWORD *size, BOOL u return ERROR_INTERNET_INCORRECT_HANDLE_TYPE; case INTERNET_OPTION_POLICY: return ERROR_INVALID_PARAMETER; + case INTERNET_OPTION_CONNECT_TIMEOUT: + TRACE("INTERNET_OPTION_CONNECT_TIMEOUT\n"); + + if (*size < sizeof(ULONG)) + return ERROR_INSUFFICIENT_BUFFER; + + *(ULONG*)buffer = connect_timeout; + *size = sizeof(ULONG); + + return ERROR_SUCCESS; } FIXME("Stub for %d\n", option); @@ -2581,6 +2624,17 @@ static DWORD set_global_option(DWORD option, void *buf, DWORD size) max_1_0_conns = *(ULONG*)buf; return ERROR_SUCCESS; + + case INTERNET_OPTION_CONNECT_TIMEOUT: + TRACE("INTERNET_OPTION_CONNECT_TIMEOUT\n"); + + if(size != sizeof(connect_timeout)) + return ERROR_INTERNET_BAD_OPTION_LENGTH; + if(!*(ULONG*)buf) + return ERROR_BAD_ARGUMENTS; + + connect_timeout = *(ULONG*)buf; + return ERROR_SUCCESS; } return ERROR_INTERNET_INVALID_OPTION; diff --git a/dlls/wininet/internet.h b/dlls/wininet/internet.h index b515a71..1956e07 100644 --- a/dlls/wininet/internet.h +++ b/dlls/wininet/internet.h @@ -253,6 +253,7 @@ typedef struct LPWSTR proxyUsername; LPWSTR proxyPassword; DWORD accessType; + DWORD connect_timeout; } appinfo_t; typedef struct

1 0