September 2012 - Wine-commits

Charles Davis : advapi32: Eliminate dead stores (Clang).
by Alexandre Julliard 17 Sep '12

17 Sep '12

Module: wine Branch: master Commit: 9285306a5bd3964ab65c98cefbc7d65b764b22c0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9285306a5bd3964ab65c98cef… Author: Charles Davis <cdavis5x(a)gmail.com> Date: Fri Sep 14 18:28:32 2012 -0600 advapi32: Eliminate dead stores (Clang). --- dlls/advapi32/cred.c | 12 ++---------- 1 files changed, 2 insertions(+), 10 deletions(-) diff --git a/dlls/advapi32/cred.c b/dlls/advapi32/cred.c index 3da71bf..5463198 100644 --- a/dlls/advapi32/cred.c +++ b/dlls/advapi32/cred.c @@ -190,7 +190,6 @@ static DWORD registry_read_credential(HKEY hkey, PCREDENTIALW credential, else if (ret != ERROR_SUCCESS) return ret; credential->CredentialBlobSize = count; - buffer += count; } /* FIXME: Attributes */ @@ -425,7 +424,6 @@ static DWORD mac_read_credential_from_item(SecKeychainItemRef item, BOOL require str_len = MultiByteToWideChar(CP_UTF8, 0, cred_blob, cred_blob_len, (LPWSTR)buffer, 0xffff); credential->CredentialBlobSize = str_len * sizeof(WCHAR); - buffer += str_len * sizeof(WCHAR); *len += str_len * sizeof(WCHAR); } else @@ -771,17 +769,11 @@ static DWORD registry_enumerate_credentials(HKEY hkeyMgr, LPCWSTR filter, break; } else if (ret != ERROR_SUCCESS) - { - ret = ERROR_SUCCESS; continue; - } TRACE("target_name = %s\n", debugstr_w(target_name)); ret = RegOpenKeyExW(hkeyMgr, target_name, 0, KEY_QUERY_VALUE, &hkeyCred); if (ret != ERROR_SUCCESS) - { - ret = ERROR_SUCCESS; continue; - } if (!credential_matches_filter(hkeyCred, filter)) { RegCloseKey(hkeyCred); @@ -1677,8 +1669,8 @@ BOOL WINAPI CredReadDomainCredentialsA(PCREDENTIAL_TARGET_INFORMATIONA TargetInf if (TargetInformation->PackageName) { TargetInformationW->PackageName = buffer; - buffer += MultiByteToWideChar(CP_ACP, 0, TargetInformation->PackageName, -1, - TargetInformationW->PackageName, end - buffer); + MultiByteToWideChar(CP_ACP, 0, TargetInformation->PackageName, -1, + TargetInformationW->PackageName, end - buffer); } else TargetInformationW->PackageName = NULL;

1 0

Charles Davis : advapi32: Actually return an error if status indicates an error (Clang).
by Alexandre Julliard 17 Sep '12

17 Sep '12

Module: wine Branch: master Commit: 7b0cea0d540f1456b47e4b1a1b4de83faff53eab URL: http://source.winehq.org/git/wine.git/?a=commit;h=7b0cea0d540f1456b47e4b1a1… Author: Charles Davis <cdavis5x(a)gmail.com> Date: Fri Sep 14 18:28:33 2012 -0600 advapi32: Actually return an error if status indicates an error (Clang). --- dlls/advapi32/cred.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/advapi32/cred.c b/dlls/advapi32/cred.c index 5463198..98c4ba7 100644 --- a/dlls/advapi32/cred.c +++ b/dlls/advapi32/cred.c @@ -622,6 +622,8 @@ static DWORD mac_write_credential(const CREDENTIALW *credential, BOOL preserve_b HeapFree(GetProcessHeap(), 0, password); /* FIXME: set TargetAlias attribute */ CFRelease(keychain_item); + if (status != noErr) + return ERROR_GEN_FAILURE; return ERROR_SUCCESS; } #endif

1 0

Marcus Meissner : mshtml: Print initialized anchor (Coverity).
by Alexandre Julliard 17 Sep '12

17 Sep '12

Module: wine Branch: master Commit: d182a123d1251d3b0c6498a9b63c54b38a30d612 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d182a123d1251d3b0c6498a9b… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Sep 15 18:56:26 2012 +0200 mshtml: Print initialized anchor (Coverity). --- dlls/mshtml/htmlanchor.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/htmlanchor.c b/dlls/mshtml/htmlanchor.c index 2243954..fac2d63 100644 --- a/dlls/mshtml/htmlanchor.c +++ b/dlls/mshtml/htmlanchor.c @@ -86,9 +86,8 @@ static HRESULT navigate_anchor(HTMLAnchorElement *This) if(NS_SUCCEEDED(nsres)) { const PRUnichar *target; - TRACE("target %s\n", debugstr_w(target)); - nsAString_GetData(&target_str, &target); + TRACE("target %s\n", debugstr_w(target)); if(*target && strcmpiW(target, _selfW)) { if(!strcmpiW(target, _topW)) { TRACE("target _top\n");

1 0

Marcus Meissner : propsys: PropVariantClear does not clear on uninitialized values (Coverity).
by Alexandre Julliard 17 Sep '12

17 Sep '12

Module: wine Branch: master Commit: 1104678b4005223a94e056e8dbddf3c786ec4d17 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1104678b4005223a94e056e8d… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Sep 15 19:06:48 2012 +0200 propsys: PropVariantClear does not clear on uninitialized values (Coverity). --- dlls/propsys/tests/propsys.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/propsys/tests/propsys.c b/dlls/propsys/tests/propsys.c index a18d6b1..df4b8d7 100644 --- a/dlls/propsys/tests/propsys.c +++ b/dlls/propsys/tests/propsys.c @@ -774,6 +774,11 @@ static void test_intconversions(void) ULONGLONG ullval; HRESULT hr; + propvar.vt = 0xdead; + hr = PropVariantClear(&propvar); + ok (FAILED(hr), "PropVariantClear fails on invalid vt.\n"); + + propvar.vt = VT_I8; PropVariantClear(&propvar); propvar.vt = VT_I8;

1 0

Marcus Meissner : dinput: Added a missing close(fd) in disabled case ( Coverity).
by Alexandre Julliard 17 Sep '12

17 Sep '12

Module: wine Branch: master Commit: 1c3b1c3fec25901db1dc9c21da5b04803ff7d3b5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c3b1c3fec25901db1dc9c21d… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sat Sep 15 20:17:11 2012 +0200 dinput: Added a missing close(fd) in disabled case (Coverity). --- dlls/dinput/joystick_linux.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/dinput/joystick_linux.c b/dlls/dinput/joystick_linux.c index ed2498b..a91c5e8 100644 --- a/dlls/dinput/joystick_linux.c +++ b/dlls/dinput/joystick_linux.c @@ -158,7 +158,10 @@ static INT find_joystick_devices(void) /* Append driver name */ strcat(joydev.name, JOYDEVDRIVER); - if (device_disabled_registry(joydev.name)) continue; + if (device_disabled_registry(joydev.name)) { + close(fd); + continue; + } #ifdef JSIOCGAXES if (ioctl(fd, JSIOCGAXES, &joydev.axis_count) < 0)

1 0

Michael Stefaniuc : ntdll/tests: Fix a memory leak (Smatch).
by Alexandre Julliard 17 Sep '12

17 Sep '12

Module: wine Branch: master Commit: dfd4191de42bee5e79085ad9cca01056cc3d615d URL: http://source.winehq.org/git/wine.git/?a=commit;h=dfd4191de42bee5e79085ad9c… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Sun Sep 16 15:12:36 2012 +0200 ntdll/tests: Fix a memory leak (Smatch). --- dlls/ntdll/tests/info.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c index a50f23b..b376d93 100644 --- a/dlls/ntdll/tests/info.c +++ b/dlls/ntdll/tests/info.c @@ -621,6 +621,8 @@ static void test_query_logicalproc(void) if(si.dwNumberOfProcessors <= 32) ok(proc_no == si.dwNumberOfProcessors, "Incorrect number of logical processors: %d, expected %d\n", proc_no, si.dwNumberOfProcessors); + + HeapFree(GetProcessHeap(), 0, slpi); } static void test_query_processor_power_info(void)

1 0

Michael Stefaniuc : urlmon: Don't generate unreachable break after return ( Smatch).
by Alexandre Julliard 17 Sep '12

17 Sep '12

Module: wine Branch: master Commit: ab381658e0e6f57026ed619c5032ad974ad47587 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab381658e0e6f57026ed619c5… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Sun Sep 16 15:14:02 2012 +0200 urlmon: Don't generate unreachable break after return (Smatch). --- dlls/urlmon/urlmon_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/urlmon/urlmon_main.c b/dlls/urlmon/urlmon_main.c index 7fb2090..95ff83f 100644 --- a/dlls/urlmon/urlmon_main.c +++ b/dlls/urlmon/urlmon_main.c @@ -169,7 +169,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID fImpLoad) const char *debugstr_bindstatus(ULONG status) { switch(status) { -#define X(x) case x: return #x; break +#define X(x) case x: return #x X(BINDSTATUS_FINDINGRESOURCE); X(BINDSTATUS_CONNECTING); X(BINDSTATUS_REDIRECTING);

1 0

Łukasz Wojniłowicz : Polish translation for release 1.5.13
by Jeremy Newman 17 Sep '12

17 Sep '12

Module: website Branch: master Commit: 2a7588a018c5494df303b3f2d12591bee02c06ac URL: http://source.winehq.org/git/website.git/?a=commit;h=2a7588a018c5494df303b3… Author: Łukasz Wojniłowicz <lukasz.wojnilowicz(a)gmail.com> Date: Sat Sep 15 06:39:26 2012 +0200 Polish translation for release 1.5.13 --- news/pl/2012091401.xml | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/news/pl/2012091401.xml b/news/pl/2012091401.xml new file mode 100644 index 0000000..642c96a --- /dev/null +++ b/news/pl/2012091401.xml @@ -0,0 +1,18 @@ +<news> +<date>Wrzesień 14, 2012</date> +<title>Wydano Wine 1.5.13</title> +<body> + Wydanie rozwojowe Wine 1.5.13 jest już dostępne. + <a href="{$root}/announce/1.5.13">Co nowego</a> w tym wydaniu: +<ul> + <li>Renderowanie okien po stronie klienta przy użyciu silnika DIB.</li> + <li>Wsparcie nieprzetworzonego wejścia dla klawiatury i myszy.</li> + <li>Wsparcie przezroczystych obszarów okna przy użyciu wkomponowywań kolorów.</li> + <li>Odpowiednie wsparcie C++ RTTI na 64-bitach.</li> + <li>Zaimplementowanie informacji o logicznych procesorach.</li> + <li>Wpsarcie dla czcionek z przetłumaczonymi nazwami.</li> + <li>Rozmaite poprawki błędów.</li> +</ul> +Źródło jest <a href="http://prdownloads.sourceforge.net/wine/wine-1.5.13.tar.bz2">już dostępne</a>. +Paczki binarne są w trakcie budowy i ukażą się wkrótce w przeznaczonych dla nich <a href="{$root}/download">pobieralniach</a>. +</body></news>

1 0

André Hentschel : Wine 1.5.13 freigegeben
by Jeremy Newman 17 Sep '12

17 Sep '12

Module: website Branch: master Commit: 474d54421c967c92a20dcd8ee5b07d4f8ac1fde7 URL: http://source.winehq.org/git/website.git/?a=commit;h=474d54421c967c92a20dcd… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Sep 15 18:37:36 2012 +0200 Wine 1.5.13 freigegeben --- news/de/2012091401.xml | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/news/de/2012091401.xml b/news/de/2012091401.xml new file mode 100644 index 0000000..ae9a2a6 --- /dev/null +++ b/news/de/2012091401.xml @@ -0,0 +1,18 @@ +<news> +<date>14. September 2012</date> +<title>Wine 1.5.13 freigegeben</title> +<body> + Die Entwicklungsversion 1.5.13 von Wine ist jetzt verfügbar. + <a href="{$root}/announce/1.5.13">Neuerungen (en)</a> in dieser Version: +<ul> + <li>Client-seitiges Window Rendering mit der DIB Engine.</li> + <li>Raw Input Unterstützung für Tastatur und Maus.</li> + <li>Unterstützung für transparente Fensterbereiche per Color-Keying.</li> + <li>Ordnungsgemäße C++ RTTI Unterstützung unter 64-bit.</li> + <li>Logische Prozessor Information wurden implementiert.</li> + <li>Unterstützung für Schriftarten mit lokalisierten Namen.</li> + <li>Verschiedene Fehlerbehebungen.</li> +</ul> +Der Quellcode ist jetzt <a href="http://prdownloads.sourceforge.net/wine/wine-1.5.13.tar.bz2">verfügbar</a>. +Binärpakete werden gerade erstellt und stehen bald auf den jeweiligen <a href="{$root}/download">Downloadseiten</a> zur Verfügung. +</body></news>

1 0

Frédéric Delanoy : French translation for release 1.5.13
by Jeremy Newman 17 Sep '12

17 Sep '12

Module: website Branch: master Commit: 44b7ff5c8de6a6b85ad172b7e0b6706a2c8c64c9 URL: http://source.winehq.org/git/website.git/?a=commit;h=44b7ff5c8de6a6b85ad172… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Sun Sep 16 21:37:48 2012 +0200 French translation for release 1.5.13 --- news/fr/2012091401.xml | 17 +++++++++++++++++ 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/news/fr/2012091401.xml b/news/fr/2012091401.xml new file mode 100644 index 0000000..e34379d --- /dev/null +++ b/news/fr/2012091401.xml @@ -0,0 +1,17 @@ +<news> +<date>14 septembre 2012</date> +<title>Sortie de Wine 1.5.13</title> +<body> + La version de développement 1.5.13 de Wine est disponible. + <a href="{$root}/announce/1.5.13">Nouveautés</a> de cette version : +<ul> + <li>Rendu de fenêtre côté client via le moteur DIB.</li> + <li>Prise en charge de l'entrée en mode brut pour les claviers et souris.</li> + <li>Prise en charge des zones de fenêtres transparentes en utilisant l'incrustation.</li> + <li>Prise en charge correcte du RTTI C++ sous 64 bits.</li> + <li>Implémentation des informations sur les processeurs logiques.</li> + <li>Prise en charges des fontes de caractères possédant des noms régionalisés.</li> + <li>Diverses corrections de bogues.</li> +</ul> +Le <a href="http://prdownloads.sourceforge.net/wine/wine-1.5.13.tar.bz2">code source</a> est disponible dès à présent. Les paquets binaires sont en cours de construction, et apparaîtront sous peu sur leurs <a href="{$root}/download">sites de téléchargement</a> respectifs. +</body></news>

1 0