September 2012 - Wine-commits

Kyle Auble : Delete moved/untranslated pages
by Jeremy Newman 04 Sep '12

04 Sep '12

Module: website Branch: master Commit: 19231b80af5afcb12457022022e62190c08951ea URL: http://source.winehq.org/git/website.git/?a=commit;h=19231b80af5afcb1245702… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Sun Sep 2 22:33:26 2012 -0700 Delete moved/untranslated pages --- templates/en/why.template | 174 --------------------------------------------- templates/fr/why.template | 174 --------------------------------------------- templates/he/why.template | 174 --------------------------------------------- 3 files changed, 0 insertions(+), 522 deletions(-) Diff: http://source.winehq.org/git/website.git/?a=commitdiff;h=19231b80af5afcb124…

1 0

Kyle Auble : Redirect acknowledgement links to wiki
by Jeremy Newman 04 Sep '12

04 Sep '12

Module: website Branch: master Commit: 6f1d3490367ad1fcbc949b5e6d5bbe2ef69a7c96 URL: http://source.winehq.org/git/website.git/?a=commit;h=6f1d3490367ad1fcbc949b… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Sun Sep 2 22:33:34 2012 -0700 Redirect acknowledgement links to wiki --- templates/pl/about.template | 2 +- templates/pt/about.template | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/pl/about.template b/templates/pl/about.template index f8a72f0..2301289 100644 --- a/templates/pl/about.template +++ b/templates/pl/about.template @@ -38,7 +38,7 @@ Julliard kieruje projektem Wine, i można się z nim skontaktować przez e-mail <li><a href="http://wiki.winehq.org/ImportanceOfWine">Dlaczego Wine jest tak ważny</a></li> <li><a href="http://wiki.winehq.org/Debunking_Wine_Myths">Obalanie mitów o Wine</a></li> <li><a href="http://wiki.winehq.org/WineFeatures">Możliwości Wine</a></li> - <li><a href="{$root}/acknowledgement">Dowody uznania</a></li> + <li><a href="http://wiki.winehq.org/DowodyUznania">Dowody uznania</a></li> <li><a href="{$root}/wwn">World Wine News</a></li> <li><a href="{$root}/interview">Wywiady</a></li> </ul> diff --git a/templates/pt/about.template b/templates/pt/about.template index b0ee4de..ef35e2c 100644 --- a/templates/pt/about.template +++ b/templates/pt/about.template @@ -40,7 +40,7 @@ projecto:</p> <li><a href="http://wiki.winehq.org/ImportanceOfWine">Porque é que o Wine é importante</a></li> <li><a href="http://wiki.winehq.org/Debunking_Wine_Myths">Clarificação dos Mitos do Wine</a></li> <li><a href="http://wiki.winehq.org/WineFeatures">Características do Wine</a></li> - <li><a href="{$root}/acknowledgement">Agradecimentos</a></li> + <li><a href="http://wiki.winehq.org/Agradecimentos">Agradecimentos</a></li> <li><a href="{$root}/wwn">World Wine News</a></li> <li><a href="{$root}/interview">Entrevistas</a></li> </ul>

1 0

Kyle Auble : Delete moved acknowledgement pages
by Jeremy Newman 04 Sep '12

04 Sep '12

Module: website Branch: master Commit: dac02682581cfaf8477aa9dcd5620f21e1f5b534 URL: http://source.winehq.org/git/website.git/?a=commit;h=dac02682581cfaf8477aa9… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Sun Sep 2 22:33:54 2012 -0700 Delete moved acknowledgement pages --- templates/de/acknowledgement.template | 209 -------------------------------- templates/en/acknowledgement.template | 207 ------------------------------- templates/he/acknowledgement.template | 195 ------------------------------ templates/pl/acknowledgement.template | 206 ------------------------------- templates/pt/acknowledgement.template | 214 --------------------------------- 5 files changed, 0 insertions(+), 1031 deletions(-) Diff: http://source.winehq.org/git/website.git/?a=commitdiff;h=dac02682581cfaf847…

1 0

Kyle Auble : Move Spanish patch guide to wiki
by Jeremy Newman 04 Sep '12

04 Sep '12

Module: website Branch: master Commit: f418f863859805a1dba5c57a9bcd29ac8a0e1522 URL: http://source.winehq.org/git/website.git/?a=commit;h=f418f863859805a1dba5c5… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Sun Sep 2 22:34:04 2012 -0700 Move Spanish patch guide to wiki --- templates/es/sending_patches.template | 119 --------------------------------- 1 files changed, 0 insertions(+), 119 deletions(-) diff --git a/templates/es/sending_patches.template b/templates/es/sending_patches.template deleted file mode 100644 index 38cbb58..0000000 --- a/templates/es/sending_patches.template +++ /dev/null @@ -1,119 +0,0 @@ - - - -<h1>Generando y enviando parches</h1> - -<p><b>Nota</b>: esto es una referencia rápida sobre como enviarnos -parches. Para obtener instrucciones detalladas por favor vea el -capítulo -<a href="{$root}/docs/winedev-guide/codingpractice">Práctica de -codificación</a> en nuestra documentación en linea. -</p> - -<p> Por favor envie los parches a la lista de correo de parches de -Wine, <a href="mailto:wine-patches(a)winehq.org"> -wine-patches(a)winehq.org </a>. -(Tenga en cuenta que si usted no está <a href="{$root}/forums">suscrito</a> -a la lista de correo, los administradores de la lista de correo -deben comprobar primero su envío para asegurarse de que no se trata de spam -antes de que se pueda aceptar el parche. -No habrá ningún intento de aplicar los parches que no aparezcan en el grupo de noticias -o en cualquier otro lugar que no sea el árbol Git) -</p> - -<p> Al presentar parches, por favor: </p> -<ul> - <li>Incluya una entrada del fichero de cambios (ChangeLog) con su - <b>nombre real</b>, dirección de correo electrónico y - una descripción de lo que hace el parche. - - <li>Mantenga el parche pequeño y el punto del cambio claro. - - <li>Envíe un arreglo o grupo de cambios relacionados por parche. - - <li>Genere su parche de nuevo con la versión más reciente de Wine desde el árbol Git WineHQ (véase más adelante). - - <li>Pon a prueba tu parche, y si es posible escribe una prueba que demuestre que es correcto. - - <li>Tenga cuidado de no corromper el parche a través de envolturas de línea. - - <li>Evite innecesariamente cambios de formateo del código. - - <li>No mezcle tabuladores y espacios porque hace que la salida diff sea ilegible, use identación consistente. - - <li>Use C estándar, evite comentarios C++ y declaraciones de variables en línea. - - <li>Lea el diff y asegúrese de que contenga sólo lo que quiere en él. -</ul> - -<p>Los parches aceptados se publicarán en la lista de correo <a href="{$root}/forums">wine-cvs </a>. - -<p>Los parches con problemas evidentes pueden recibir una respuesta en wine-devel. - -<p>Algunos parches no podrán recibir ninguna respuesta. En ese caso, su parche - puede considerarse <i>Obviamente No Correcto</i>, y puede hacer lo siguiente: - -<ul> - <li> Compruebe el parche usted mismo, y piense en lo que se puede hacer para - aclarar el parche (pistas en la lista anterior). - - <li> Escribir un correo electrónico a wine-devel, explicando el parche y solicitud para que sea - examinado por cualquier persona encargada de revisar. - - <li> Pida consejo acerca de su parche en #winehackers. - - <li> A menos que ya existe uno, abra un bug en bugzilla describiendo el - problema que está tratando de resolver (por ejemplo: ./configure falla en Solaris, - etc) y adjuntar su parche. -</ ul> - -<p> - Si el parche no ha recibido una respuesta en 3 días del WineHQ Git confirma - que tu parche tiene una gran oportunidad de estar en esta categoría. - <br/> - Tal vez le resulte difícil el solicitar información, - a fin de reflexionar cuidadosamente sobre los comentarios que recibe. - <br/> - ¡Simplemente no se dé por vencido! -</p> - -<hr> - -<h2>Generación de un parche para WineHQ con Git</h2> - -<p> Es mejor enviar pequeños parches contra el actual árbol utilizando Git. -En primer lugar, asegúrese de que su árbol es hasta la fecha, tal y como -se describe en la página <a href="http://wiki.winehq.org/GitWine">Git</a>. - -<p>Compruebe sus parches en su árbol Git utilizando -<a href="http://www.kernel.org/pub/software/scm/git/docs/git-commit.html">git commit</a>.</p> - -<p> Si va a utilizar -<a href="http://www.kernel.org/pub/software/scm/git/docs/git-imap-send.html">git imap-send</a> -asegúrese de que ha creado las opciones adecuadas en su fichero de -configuración de Git, y a continuación, ejecute:</p> - - <table width="700" border=0 cellpadding=10><tr><td class=black> - <span class=inverse> - git format-patch --stdout --keep-subject --attach origin | git imap-send<br> - </span> - </td></tr> - </table> - -<p>Esto debería subir sus parches en su carpeta de proyectos IMAP, y -le permitirá comprobar y enviarlos. En Mozilla Thunderbird, eso es tan -simple como hacer clic en "Editar Proyecto..." y luego "Enviar" si -tiene configurado el archivo de cabeceras de correo Git correctamente. - -<p>Si usted no puede utilizar IMAP, utilice el siguiente comando para generar parches:</p> - - <table width="700" border=0 cellpadding=10><tr><td class=black> - <span class=inverse> - git format-patch --keep-subject origin<br> - </span> - </td></tr> - </table> - -<p>Esto debería generar una serie de archivos txt, que puede enviar manualmente.</p> - -<p> </p>

1 0

Jacek Caban : mshtml: Added IHTMLIFrameElement3 stub implementation.
by Alexandre Julliard 03 Sep '12

03 Sep '12

Module: wine Branch: master Commit: fcc3a77ae5e8be2fa6d540cdde5569a9d384635d URL: http://source.winehq.org/git/wine.git/?a=commit;h=fcc3a77ae5e8be2fa6d540cdd… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Sep 3 13:16:57 2012 +0200 mshtml: Added IHTMLIFrameElement3 stub implementation. --- dlls/mshtml/htmliframe.c | 131 ++++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/mshtml_private.h | 1 + 2 files changed, 132 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/htmliframe.c b/dlls/mshtml/htmliframe.c index dccc7d0..faeb8f3 100644 --- a/dlls/mshtml/htmliframe.c +++ b/dlls/mshtml/htmliframe.c @@ -35,6 +35,7 @@ typedef struct { HTMLFrameBase framebase; IHTMLIFrameElement IHTMLIFrameElement_iface; IHTMLIFrameElement2 IHTMLIFrameElement2_iface; + IHTMLIFrameElement3 IHTMLIFrameElement3_iface; } HTMLIFrame; static inline HTMLIFrame *impl_from_IHTMLIFrameElement(IHTMLIFrameElement *iface) @@ -255,6 +256,131 @@ static const IHTMLIFrameElement2Vtbl HTMLIFrameElement2Vtbl = { HTMLIFrameElement2_get_width }; +static inline HTMLIFrame *impl_from_IHTMLIFrameElement3(IHTMLIFrameElement3 *iface) +{ + return CONTAINING_RECORD(iface, HTMLIFrame, IHTMLIFrameElement3_iface); +} + +static HRESULT WINAPI HTMLIFrameElement3_QueryInterface(IHTMLIFrameElement3 *iface, + REFIID riid, void **ppv) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + + return IHTMLDOMNode_QueryInterface(&This->framebase.element.node.IHTMLDOMNode_iface, riid, ppv); +} + +static ULONG WINAPI HTMLIFrameElement3_AddRef(IHTMLIFrameElement3 *iface) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + + return IHTMLDOMNode_AddRef(&This->framebase.element.node.IHTMLDOMNode_iface); +} + +static ULONG WINAPI HTMLIFrameElement3_Release(IHTMLIFrameElement3 *iface) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + + return IHTMLDOMNode_Release(&This->framebase.element.node.IHTMLDOMNode_iface); +} + +static HRESULT WINAPI HTMLIFrameElement3_GetTypeInfoCount(IHTMLIFrameElement3 *iface, UINT *pctinfo) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + return IDispatchEx_GetTypeInfoCount(&This->framebase.element.node.dispex.IDispatchEx_iface, + pctinfo); +} + +static HRESULT WINAPI HTMLIFrameElement3_GetTypeInfo(IHTMLIFrameElement3 *iface, UINT iTInfo, + LCID lcid, ITypeInfo **ppTInfo) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + return IDispatchEx_GetTypeInfo(&This->framebase.element.node.dispex.IDispatchEx_iface, iTInfo, + lcid, ppTInfo); +} + +static HRESULT WINAPI HTMLIFrameElement3_GetIDsOfNames(IHTMLIFrameElement3 *iface, REFIID riid, + LPOLESTR *rgszNames, UINT cNames, LCID lcid, DISPID *rgDispId) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + return IDispatchEx_GetIDsOfNames(&This->framebase.element.node.dispex.IDispatchEx_iface, riid, + rgszNames, cNames, lcid, rgDispId); +} + +static HRESULT WINAPI HTMLIFrameElement3_Invoke(IHTMLIFrameElement3 *iface, DISPID dispIdMember, + REFIID riid, LCID lcid, WORD wFlags, DISPPARAMS *pDispParams, + VARIANT *pVarResult, EXCEPINFO *pExcepInfo, UINT *puArgErr) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + return IDispatchEx_Invoke(&This->framebase.element.node.dispex.IDispatchEx_iface, dispIdMember, + riid, lcid, wFlags, pDispParams, pVarResult, pExcepInfo, puArgErr); +} + +static HRESULT WINAPI HTMLIFrameElement3_get_contentDocument(IHTMLIFrameElement3 *iface, IDispatch **p) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + FIXME("(%p)->(%p)\n", This, p); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement3_put_src(IHTMLIFrameElement3 *iface, BSTR v) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + FIXME("(%p)->(%s)\n", This, debugstr_w(v)); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement3_get_src(IHTMLIFrameElement3 *iface, BSTR *p) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + FIXME("(%p)->(%p)\n", This, p); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement3_put_longDesc(IHTMLIFrameElement3 *iface, BSTR v) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + FIXME("(%p)->(%s)\n", This, debugstr_w(v)); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement3_get_longDesc(IHTMLIFrameElement3 *iface, BSTR *p) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + FIXME("(%p)->(%p)\n", This, p); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement3_put_frameBorder(IHTMLIFrameElement3 *iface, BSTR v) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + FIXME("(%p)->(%s)\n", This, debugstr_w(v)); + return E_NOTIMPL; +} + +static HRESULT WINAPI HTMLIFrameElement3_get_frameBorder(IHTMLIFrameElement3 *iface, BSTR *p) +{ + HTMLIFrame *This = impl_from_IHTMLIFrameElement3(iface); + FIXME("(%p)->(%p)\n", This, p); + return E_NOTIMPL; +} + +static const IHTMLIFrameElement3Vtbl HTMLIFrameElement3Vtbl = { + HTMLIFrameElement3_QueryInterface, + HTMLIFrameElement3_AddRef, + HTMLIFrameElement3_Release, + HTMLIFrameElement3_GetTypeInfoCount, + HTMLIFrameElement3_GetTypeInfo, + HTMLIFrameElement3_GetIDsOfNames, + HTMLIFrameElement3_Invoke, + HTMLIFrameElement3_get_contentDocument, + HTMLIFrameElement3_put_src, + HTMLIFrameElement3_get_src, + HTMLIFrameElement3_put_longDesc, + HTMLIFrameElement3_get_longDesc, + HTMLIFrameElement3_put_frameBorder, + HTMLIFrameElement3_get_frameBorder +}; + static inline HTMLIFrame *impl_from_HTMLDOMNode(HTMLDOMNode *iface) { return CONTAINING_RECORD(iface, HTMLIFrame, framebase.element.node); @@ -270,6 +396,9 @@ static HRESULT HTMLIFrame_QI(HTMLDOMNode *iface, REFIID riid, void **ppv) }else if(IsEqualGUID(&IID_IHTMLIFrameElement2, riid)) { TRACE("(%p)->(IID_IHTMLIFrameElement2 %p)\n", This, ppv); *ppv = &This->IHTMLIFrameElement2_iface; + }else if(IsEqualGUID(&IID_IHTMLIFrameElement3, riid)) { + TRACE("(%p)->(IID_IHTMLIFrameElement3 %p)\n", This, ppv); + *ppv = &This->IHTMLIFrameElement3_iface; }else { return HTMLFrameBase_QI(&This->framebase, riid, ppv); } @@ -372,6 +501,7 @@ static const tid_t HTMLIFrame_iface_tids[] = { IHTMLFrameBase2_tid, IHTMLIFrameElement_tid, IHTMLIFrameElement2_tid, + IHTMLIFrameElement3_tid, 0 }; @@ -392,6 +522,7 @@ HRESULT HTMLIFrame_Create(HTMLDocumentNode *doc, nsIDOMHTMLElement *nselem, HTML ret->IHTMLIFrameElement_iface.lpVtbl = &HTMLIFrameElementVtbl; ret->IHTMLIFrameElement2_iface.lpVtbl = &HTMLIFrameElement2Vtbl; + ret->IHTMLIFrameElement3_iface.lpVtbl = &HTMLIFrameElement3Vtbl; ret->framebase.element.node.vtbl = &HTMLIFrameImplVtbl; HTMLFrameBase_Init(&ret->framebase, doc, nselem, &HTMLIFrame_dispex); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 8b5f841..f23dc10 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -147,6 +147,7 @@ typedef struct event_target_t event_target_t; XIID(IHTMLHeadElement) \ XIID(IHTMLIFrameElement) \ XIID(IHTMLIFrameElement2) \ + XIID(IHTMLIFrameElement3) \ XIID(IHTMLImageElementFactory) \ XIID(IHTMLImgElement) \ XIID(IHTMLInputElement) \

1 0

Marcus Meissner : gdiplus: Avoid uninitialized usage of bitmap (Coverity).
by Alexandre Julliard 03 Sep '12

03 Sep '12

Module: wine Branch: master Commit: 5ae8629fca1eefc6cc16d5c8843e0888205ff179 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5ae8629fca1eefc6cc16d5c88… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Sep 3 18:56:47 2012 +0200 gdiplus: Avoid uninitialized usage of bitmap (Coverity). --- dlls/gdiplus/image.c | 22 ++++++++++++---------- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index c3a542b..b657969 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -3124,17 +3124,19 @@ static GpStatus decode_image_wic(IStream* stream, REFCLSID clsid, UINT active_fr IWICBitmapSource_Release(source); } - bitmap->metadata_reader = NULL; - if (IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICMetadataBlockReader, (void **)&block_reader) == S_OK) - { - UINT block_count = 0; - if (IWICMetadataBlockReader_GetCount(block_reader, &block_count) == S_OK && block_count) - IWICMetadataBlockReader_GetReaderByIndex(block_reader, 0, &bitmap->metadata_reader); - IWICMetadataBlockReader_Release(block_reader); - } + if (SUCCEEDED(hr)) { + bitmap->metadata_reader = NULL; + if (IWICBitmapFrameDecode_QueryInterface(frame, &IID_IWICMetadataBlockReader, (void **)&block_reader) == S_OK) + { + UINT block_count = 0; + if (IWICMetadataBlockReader_GetCount(block_reader, &block_count) == S_OK && block_count) + IWICMetadataBlockReader_GetReaderByIndex(block_reader, 0, &bitmap->metadata_reader); + IWICMetadataBlockReader_Release(block_reader); + } - palette = get_palette(frame, palette_type); - IWICBitmapFrameDecode_Release(frame); + palette = get_palette(frame, palette_type); + IWICBitmapFrameDecode_Release(frame); + } } IWICBitmapDecoder_Release(decoder);

1 0

Marcus Meissner : dinput: No need for null ptr check of pKeyboard.
by Alexandre Julliard 03 Sep '12

03 Sep '12

Module: wine Branch: master Commit: 439605634e193ba0147058afc40b2d15c2fce7e5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=439605634e193ba0147058afc… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Sep 3 19:02:54 2012 +0200 dinput: No need for null ptr check of pKeyboard. --- dlls/dinput/tests/keyboard.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/dinput/tests/keyboard.c b/dlls/dinput/tests/keyboard.c index 5d32abe..4cd36c4 100644 --- a/dlls/dinput/tests/keyboard.c +++ b/dlls/dinput/tests/keyboard.c @@ -190,7 +190,7 @@ static void test_capabilities(LPDIRECTINPUT pDI, HWND hwnd) ok (LOWORD(HIBYTE(caps.dwDevType)) != DIDEVTYPEKEYBOARD_UNKNOWN, "GetCapabilities invalid device subtype for dwDevType: 0x%08x\n", caps.dwDevType); - if (pKeyboard) IUnknown_Release(pKeyboard); + IUnknown_Release(pKeyboard); } static void keyboard_tests(DWORD version)

1 0

Marcus Meissner : msctf: Also free the sink in the non-source branch ( Coverity).
by Alexandre Julliard 03 Sep '12

03 Sep '12

Module: wine Branch: master Commit: 2288851c90197398e9cae200deaff34c29af6754 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2288851c90197398e9cae200d… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Sep 3 19:07:55 2012 +0200 msctf: Also free the sink in the non-source branch (Coverity). --- dlls/msctf/tests/inputprocessor.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/msctf/tests/inputprocessor.c b/dlls/msctf/tests/inputprocessor.c index a732730..027795d 100644 --- a/dlls/msctf/tests/inputprocessor.c +++ b/dlls/msctf/tests/inputprocessor.c @@ -1901,10 +1901,9 @@ static void test_TStoApplicationText(void) { hr = ITfSource_UnadviseSink(source, editSinkCookie); ok(SUCCEEDED(hr),"Failed to unadvise Sink\n"); - ITfTextEditSink_Release(sink); ITfSource_Release(source); } - + ITfTextEditSink_Release(sink); ITfContext_Release(cxt); ITfDocumentMgr_Release(dm); ITfEditSession_Release(es);

1 0

Marcus Meissner : joy.cpl: Added missing break; (Coverity).
by Alexandre Julliard 03 Sep '12

03 Sep '12

Module: wine Branch: master Commit: bf8c45f3edc73a99226b45eb5d43ba5da391d6f6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bf8c45f3edc73a99226b45eb5… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Sep 3 19:23:07 2012 +0200 joy.cpl: Added missing break; (Coverity). --- dlls/joy.cpl/main.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/joy.cpl/main.c b/dlls/joy.cpl/main.c index e72f93d..dec83ff 100644 --- a/dlls/joy.cpl/main.c +++ b/dlls/joy.cpl/main.c @@ -310,6 +310,7 @@ static INT_PTR CALLBACK list_dlgproc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM initialize_disabled_joysticks_list(hwnd); } } + break; case IDC_JOYSTICKLIST: EnableWindow(GetDlgItem(hwnd, IDC_BUTTONENABLE), FALSE);

1 0

Marcus Meissner : wbemprox: Break out of loop when out of memory (Coverity) .
by Alexandre Julliard 03 Sep '12

03 Sep '12

Module: wine Branch: master Commit: 54f06e6b8425ec1a35f46ba491d5b70ba5ad7c69 URL: http://source.winehq.org/git/wine.git/?a=commit;h=54f06e6b8425ec1a35f46ba49… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Sep 3 19:23:25 2012 +0200 wbemprox: Break out of loop when out of memory (Coverity). --- dlls/wbemprox/builtin.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 19afa0c..01a7da4 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -924,6 +924,11 @@ static void fill_service( struct table *table ) service = OpenServiceW(manager, services[i].lpServiceName, GENERIC_READ); QueryServiceConfigW(service, NULL, 0, &size); config = heap_alloc(size); + if (!config) + { + CloseServiceHandle(service); + break; + } if (QueryServiceConfigW(service, config, size, &size)) startmode = config->dwStartType; else

1 0