May 2015 - Wine-commits - list.winehq.org

Marcus Meissner : mshtml: Fixed incorrect NULL ptr check (Coverity).
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: 47086b9aaf5ff6a6c84e0f55c1e9b7ba8d828953 URL: http://source.winehq.org/git/wine.git/?a=commit;h=47086b9aaf5ff6a6c84e0f55c… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Wed May 20 21:23:20 2015 +0200 mshtml: Fixed incorrect NULL ptr check (Coverity). --- dlls/mshtml/htmlevent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index ef6929c..596c171 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1408,7 +1408,7 @@ static HRESULT set_event_handler_disp(EventTarget *event_target, eventid_t eid, return S_OK; data = get_event_target_data(event_target, TRUE); - if(!event_target) + if(!data) return E_OUTOFMEMORY; if(!alloc_handler_vector(data, eid, 0))

1 0

Marcus Meissner : rpcrt4: Make sure we do not have *data allocated on error (Coverity).
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: 7b9efb1f4578eb39faec8a2b133a0227582b2964 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7b9efb1f4578eb39faec8a2b1… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu May 21 00:10:57 2015 +0200 rpcrt4: Make sure we do not have *data allocated on error (Coverity). --- dlls/rpcrt4/rpc_transport.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c index 34f434d..a6438a7 100644 --- a/dlls/rpcrt4/rpc_transport.c +++ b/dlls/rpcrt4/rpc_transport.c @@ -2359,6 +2359,7 @@ static RPC_STATUS rpcrt4_http_read_http_packet(HINTERNET request, RpcHttpAsyncDa if (!RPCRT4_IsValidHttpPacket(hdr, *data, data_len)) { ERR("invalid http packet\n"); + HeapFree(GetProcessHeap(), 0, *data); return RPC_S_PROTOCOL_ERROR; }

1 0

Sebastian Lackner : ntdll: Add stub for NtImpersonateAnonymousToken.
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: 39abfc4d749b88c045487f463ef4b12199a6e6e3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=39abfc4d749b88c045487f463… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu May 21 06:42:16 2015 +0200 ntdll: Add stub for NtImpersonateAnonymousToken. --- dlls/ntdll/ntdll.spec | 2 +- dlls/ntdll/sec.c | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec index e87b2c7..6d86157 100644 --- a/dlls/ntdll/ntdll.spec +++ b/dlls/ntdll/ntdll.spec @@ -182,7 +182,7 @@ @ stub NtGetPlugPlayEvent @ stdcall NtGetTickCount() @ stdcall NtGetWriteWatch(long long ptr long ptr ptr ptr) -@ stub NtImpersonateAnonymousToken +@ stdcall NtImpersonateAnonymousToken(long) @ stub NtImpersonateClientOfPort @ stub NtImpersonateThread @ stub NtInitializeRegistry diff --git a/dlls/ntdll/sec.c b/dlls/ntdll/sec.c index 0917780..360a579 100644 --- a/dlls/ntdll/sec.c +++ b/dlls/ntdll/sec.c @@ -1523,6 +1523,16 @@ RtlImpersonateSelf(SECURITY_IMPERSONATION_LEVEL ImpersonationLevel) } /****************************************************************************** + * NtImpersonateAnonymousToken [NTDLL.@] + */ +NTSTATUS WINAPI +NtImpersonateAnonymousToken(HANDLE thread) +{ + FIXME("(%p): stub\n", thread); + return STATUS_NOT_IMPLEMENTED; +} + +/****************************************************************************** * NtAccessCheck [NTDLL.@] * ZwAccessCheck [NTDLL.@] *

1 0

Sebastian Lackner : advapi32: Forward ImpersonateAnonymousToken to ntdll.
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: e24eb501d3880c59ce0495cc5ef60b2f1db83017 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e24eb501d3880c59ce0495cc5… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Thu May 21 06:43:29 2015 +0200 advapi32: Forward ImpersonateAnonymousToken to ntdll. --- dlls/advapi32/advapi32.spec | 2 +- dlls/advapi32/security.c | 9 +++++++++ .../api-ms-win-security-base-l1-1-0.spec | 2 +- .../api-ms-win-security-base-l1-2-0.spec | 2 +- 4 files changed, 12 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec index e885684..4600142 100644 --- a/dlls/advapi32/advapi32.spec +++ b/dlls/advapi32/advapi32.spec @@ -376,7 +376,7 @@ @ stub I_ScSetServiceBitsA # @ stub I_ScSetServiceBitsW # @ stub IdentifyCodeAuthzLevelW -# @ stub ImpersonateAnonymousToken +@ stdcall ImpersonateAnonymousToken(long) @ stdcall ImpersonateLoggedOnUser(long) @ stdcall ImpersonateNamedPipeClient(long) @ stdcall ImpersonateSelf(long) diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index d27b2e7..028dcc6 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -2501,6 +2501,15 @@ BOOL WINAPI ImpersonateLoggedOnUser(HANDLE hToken) } /****************************************************************************** + * ImpersonateAnonymousToken [ADVAPI32.@] + */ +BOOL WINAPI ImpersonateAnonymousToken( HANDLE thread ) +{ + TRACE("(%p)\n", thread); + return set_ntstatus( NtImpersonateAnonymousToken( thread ) ); +} + +/****************************************************************************** * AccessCheck [ADVAPI32.@] */ BOOL WINAPI diff --git a/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec b/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec index 548ae83..4277706 100644 --- a/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec +++ b/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec @@ -58,7 +58,7 @@ @ stdcall GetSidSubAuthorityCount(ptr) advapi32.GetSidSubAuthorityCount @ stdcall GetTokenInformation(long long ptr long ptr) advapi32.GetTokenInformation @ stub GetWindowsAccountDomainSid -@ stub ImpersonateAnonymousToken +@ stdcall ImpersonateAnonymousToken(long) advapi32.ImpersonateAnonymousToken @ stdcall ImpersonateLoggedOnUser(long) advapi32.ImpersonateLoggedOnUser @ stdcall ImpersonateSelf(long) advapi32.ImpersonateSelf @ stdcall InitializeAcl(ptr long long) advapi32.InitializeAcl diff --git a/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec b/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec index d268183..3adef23 100644 --- a/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec +++ b/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec @@ -64,7 +64,7 @@ @ stdcall GetSidSubAuthorityCount(ptr) advapi32.GetSidSubAuthorityCount @ stdcall GetTokenInformation(long long ptr long ptr) advapi32.GetTokenInformation @ stub GetWindowsAccountDomainSid -@ stub ImpersonateAnonymousToken +@ stdcall ImpersonateAnonymousToken(long) advapi32.ImpersonateAnonymousToken @ stdcall ImpersonateLoggedOnUser(long) advapi32.ImpersonateLoggedOnUser @ stdcall ImpersonateSelf(long) advapi32.ImpersonateSelf @ stdcall InitializeAcl(ptr long long) advapi32.InitializeAcl

1 0

Ken Thomases : ntdll: Increase name buffer size in read_directory_getattrlist() for UTF-8 encoding.
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: f6926b35153888f85453856f3d3e74ac62ba3e70 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f6926b35153888f85453856f3… Author: Ken Thomases <ken(a)codeweavers.com> Date: Wed May 20 14:58:52 2015 -0500 ntdll: Increase name buffer size in read_directory_getattrlist() for UTF-8 encoding. The docs for getattrlist() say that ATTR_CMN_NAME can return up to NAME_MAX + 1 Unicode characters (code points) encoded in UTF-8, which means it can be up to NAME_MAX * 3 + 1 bytes. --- dlls/ntdll/directory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index 455fbc6..0e5af8a 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -2144,7 +2144,7 @@ static int read_directory_getattrlist( int fd, IO_STATUS_BLOCK *io, void *buffer { u_int32_t length; struct attrreference name_reference; - char name[NAME_MAX + 1]; + char name[NAME_MAX * 3 + 1]; } attrlist_buffer; TRACE("looking up file %s\n", debugstr_us( mask ));

1 0

Ken Thomases : ntdll: If read_directory_getattrlist() finds that the file doesn't exist, return successful "no file" result to stop search.
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: 5c98448aa3acb9bac40a0afa28ffbee3001081d0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c98448aa3acb9bac40a0afa2… Author: Ken Thomases <ken(a)codeweavers.com> Date: Wed May 20 14:59:11 2015 -0500 ntdll: If read_directory_getattrlist() finds that the file doesn't exist, return successful "no file" result to stop search. --- dlls/ntdll/directory.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index 0e5af8a..267f019 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -2185,6 +2185,11 @@ static int read_directory_getattrlist( int fd, IO_STATUS_BLOCK *io, void *buffer } else io->u.Status = STATUS_NO_MORE_FILES; } + else if ((errno == ENOENT || errno == ENOTDIR) && !get_dir_case_sensitivity(".")) + { + io->u.Status = STATUS_NO_MORE_FILES; + ret = 0; + } } else ret = -1;

1 0

Jacek Caban : mshtml: Use vtbl for binding to event in attach_event.
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: 189cb568eecddbd83e8d2a5e33292fa43be5b7da URL: http://source.winehq.org/git/wine.git/?a=commit;h=189cb568eecddbd83e8d2a5e3… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 20 19:46:53 2015 +0200 mshtml: Use vtbl for binding to event in attach_event. --- dlls/mshtml/htmldoc.c | 11 +++++++++-- dlls/mshtml/htmlelem.c | 11 +++++++++-- dlls/mshtml/htmlevent.c | 22 +++++++++++++++------- dlls/mshtml/htmlevent.h | 3 ++- dlls/mshtml/htmlwindow.c | 11 +++++++++-- dlls/mshtml/mshtml_private.h | 1 + 6 files changed, 45 insertions(+), 14 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index e377d55..203cc51 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -2032,7 +2032,7 @@ static HRESULT WINAPI HTMLDocument3_attachEvent(IHTMLDocument3 *iface, BSTR even TRACE("(%p)->(%s %p %p)\n", This, debugstr_w(event), pDisp, pfResult); - return attach_event(&This->doc_node->node.event_target, This, event, pDisp, pfResult); + return attach_event(&This->doc_node->node.event_target, event, pDisp, pfResult); } static HRESULT WINAPI HTMLDocument3_detachEvent(IHTMLDocument3 *iface, BSTR event, @@ -4571,12 +4571,19 @@ static HRESULT HTMLDocumentNode_invoke(DispatchEx *dispex, DISPID id, LCID lcid, return S_OK; } +static void HTMLDocumentNode_bind_event(DispatchEx *dispex, int eid) +{ + HTMLDocumentNode *This = impl_from_DispatchEx(dispex); + ensure_doc_nsevent_handler(This, eid); +} static const dispex_static_data_vtbl_t HTMLDocumentNode_dispex_vtbl = { NULL, NULL, HTMLDocumentNode_invoke, - NULL + NULL, + NULL, + HTMLDocumentNode_bind_event }; static const NodeImplVtbl HTMLDocumentFragmentImplVtbl = { diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index d2ae0be..4277890 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -2566,7 +2566,7 @@ static HRESULT WINAPI HTMLElement2_attachEvent(IHTMLElement2 *iface, BSTR event, TRACE("(%p)->(%s %p %p)\n", This, debugstr_w(event), pDisp, pfResult); - return attach_event(&This->node.event_target, &This->node.doc->basedoc, event, pDisp, pfResult); + return attach_event(&This->node.event_target, event, pDisp, pfResult); } static HRESULT WINAPI HTMLElement2_detachEvent(IHTMLElement2 *iface, BSTR event, IDispatch *pDisp) @@ -3996,6 +3996,12 @@ static event_target_t **HTMLElement_get_event_target_ptr(DispatchEx *dispex) : &This->node.event_target.ptr; } +static void HTMLElement_bind_event(DispatchEx *dispex, int eid) +{ + HTMLElement *This = impl_from_DispatchEx(dispex); + This->node.doc->node.event_target.dispex.data->vtbl->bind_event(&This->node.doc->node.event_target.dispex, eid); +} + static const tid_t HTMLElement_iface_tids[] = { HTMLELEMENT_TIDS, 0 @@ -4006,7 +4012,8 @@ static dispex_static_data_vtbl_t HTMLElement_dispex_vtbl = { HTMLElement_get_dispid, HTMLElement_invoke, HTMLElement_populate_props, - HTMLElement_get_event_target_ptr + HTMLElement_get_event_target_ptr, + HTMLElement_bind_event }; static dispex_static_data_t HTMLElement_dispex = { diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 897350f..d359e4a 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1336,7 +1336,7 @@ static BOOL alloc_handler_vector(event_target_t *event_target, eventid_t eid, in return TRUE; } -static HRESULT ensure_nsevent_handler(HTMLDocumentNode *doc, eventid_t eid) +HRESULT ensure_doc_nsevent_handler(HTMLDocumentNode *doc, eventid_t eid) { nsIDOMNode *nsnode = NULL; @@ -1374,6 +1374,13 @@ void detach_events(HTMLDocumentNode *doc) release_nsevents(doc); } +static void bind_event(EventTarget *event_target, eventid_t eid) +{ + if(event_target->dispex.data->vtbl->bind_event) + event_target->dispex.data->vtbl->bind_event(&event_target->dispex, eid); + else + FIXME("Unsupported event binding on target %p\n", event_target); +} static void remove_event_handler(EventTarget *event_target, eventid_t eid) { @@ -1410,7 +1417,7 @@ static HRESULT set_event_handler_disp(EventTarget *event_target, HTMLDocumentNod data->event_table[eid]->handler_prop = disp; IDispatch_AddRef(disp); - return ensure_nsevent_handler(doc, eid); + return ensure_doc_nsevent_handler(doc, eid); } HRESULT set_event_handler(EventTarget *event_target, HTMLDocumentNode *doc, eventid_t eid, VARIANT *var) @@ -1478,8 +1485,7 @@ HRESULT get_event_handler(EventTarget *event_target, eventid_t eid, VARIANT *var return S_OK; } -HRESULT attach_event(EventTarget *event_target, HTMLDocument *doc, BSTR name, - IDispatch *disp, VARIANT_BOOL *res) +HRESULT attach_event(EventTarget *event_target, BSTR name, IDispatch *disp, VARIANT_BOOL *res) { event_target_t *data; eventid_t eid; @@ -1508,8 +1514,10 @@ HRESULT attach_event(EventTarget *event_target, HTMLDocument *doc, BSTR name, IDispatch_AddRef(disp); data->event_table[eid]->handlers[i] = disp; + bind_event(event_target, eid); + *res = VARIANT_TRUE; - return ensure_nsevent_handler(doc->doc_node, eid); + return S_OK; } HRESULT detach_event(EventTarget *event_target, HTMLDocument *doc, BSTR name, IDispatch *disp) @@ -1563,7 +1571,7 @@ void update_doc_cp_events(HTMLDocumentNode *doc, cp_static_data_t *cp) for(i=0; i < EVENTID_LAST; i++) { if((event_info[i].flags & EVENT_DEFAULTLISTENER) && is_cp_event(cp, event_info[i].dispid)) - ensure_nsevent_handler(doc, i); + ensure_doc_nsevent_handler(doc, i); } } @@ -1612,7 +1620,7 @@ HRESULT doc_init_events(HTMLDocumentNode *doc) for(i=0; i < EVENTID_LAST; i++) { if(event_info[i].flags & EVENT_HASDEFAULTHANDLERS) { - hres = ensure_nsevent_handler(doc, i); + hres = ensure_doc_nsevent_handler(doc, i); if(FAILED(hres)) return hres; } diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index 62e808f..e10a87d 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -56,7 +56,7 @@ void release_event_target(event_target_t*) DECLSPEC_HIDDEN; void fire_event(HTMLDocumentNode*,eventid_t,BOOL,nsIDOMNode*,nsIDOMEvent*,IDispatch*) DECLSPEC_HIDDEN; HRESULT set_event_handler(EventTarget*,HTMLDocumentNode*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; HRESULT get_event_handler(EventTarget*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; -HRESULT attach_event(EventTarget*,HTMLDocument*,BSTR,IDispatch*,VARIANT_BOOL*) DECLSPEC_HIDDEN; +HRESULT attach_event(EventTarget*,BSTR,IDispatch*,VARIANT_BOOL*) DECLSPEC_HIDDEN; HRESULT detach_event(EventTarget*,HTMLDocument*,BSTR,IDispatch*) DECLSPEC_HIDDEN; HRESULT dispatch_event(HTMLDOMNode*,const WCHAR*,VARIANT*,VARIANT_BOOL*) DECLSPEC_HIDDEN; HRESULT call_fire_event(HTMLDOMNode*,eventid_t) DECLSPEC_HIDDEN; @@ -65,6 +65,7 @@ HRESULT doc_init_events(HTMLDocumentNode*) DECLSPEC_HIDDEN; void detach_events(HTMLDocumentNode *doc) DECLSPEC_HIDDEN; HRESULT create_event_obj(IHTMLEventObj**) DECLSPEC_HIDDEN; void bind_target_event(HTMLDocumentNode*,EventTarget*,const WCHAR*,IDispatch*) DECLSPEC_HIDDEN; +HRESULT ensure_doc_nsevent_handler(HTMLDocumentNode*,eventid_t) DECLSPEC_HIDDEN; void init_nsevents(HTMLDocumentNode*) DECLSPEC_HIDDEN; void release_nsevents(HTMLDocumentNode*) DECLSPEC_HIDDEN; diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 01ce10e..d38e704 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -1654,7 +1654,7 @@ static HRESULT WINAPI HTMLWindow3_attachEvent(IHTMLWindow3 *iface, BSTR event, I return E_FAIL; } - return attach_event(&window->event_target, &window->doc->basedoc, event, pDisp, pfResult); + return attach_event(&window->event_target, event, pDisp, pfResult); } static HRESULT WINAPI HTMLWindow3_detachEvent(IHTMLWindow3 *iface, BSTR event, IDispatch *pDisp) @@ -2854,12 +2854,19 @@ static event_target_t **HTMLWindow_get_event_target_ptr(DispatchEx *dispex) return &This->doc->body_event_target; } +static void HTMLWindow_bind_event(DispatchEx *dispex, int eid) +{ + HTMLInnerWindow *This = impl_from_DispatchEx(dispex); + This->doc->node.event_target.dispex.data->vtbl->bind_event(&This->doc->node.event_target.dispex, eid); +} + static const dispex_static_data_vtbl_t HTMLWindow_dispex_vtbl = { NULL, NULL, HTMLWindow_invoke, NULL, - HTMLWindow_get_event_target_ptr + HTMLWindow_get_event_target_ptr, + HTMLWindow_bind_event }; static const tid_t HTMLWindow_iface_tids[] = { diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 7d743b6..28e728e 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -232,6 +232,7 @@ typedef struct { HRESULT (*populate_props)(DispatchEx*); /* We abuse this vtbl for EventTarget functions to avoid separated vtbl. */ event_target_t **(*get_event_target_ptr)(DispatchEx*); + void (*bind_event)(DispatchEx*,int); } dispex_static_data_vtbl_t; typedef struct {

1 0

Jacek Caban : mshtml: Get rid of no longer needed detach_event argument.
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: 7950f780df32d44bce7f04cba290cea247714b66 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7950f780df32d44bce7f04cba… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 20 19:47:00 2015 +0200 mshtml: Get rid of no longer needed detach_event argument. --- dlls/mshtml/htmldoc.c | 2 +- dlls/mshtml/htmlelem.c | 2 +- dlls/mshtml/htmlevent.c | 2 +- dlls/mshtml/htmlevent.h | 2 +- dlls/mshtml/htmlwindow.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index 203cc51..2b660df 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -2042,7 +2042,7 @@ static HRESULT WINAPI HTMLDocument3_detachEvent(IHTMLDocument3 *iface, BSTR even TRACE("(%p)->(%s %p)\n", This, debugstr_w(event), pDisp); - return detach_event(&This->doc_node->node.event_target, This, event, pDisp); + return detach_event(&This->doc_node->node.event_target, event, pDisp); } static HRESULT WINAPI HTMLDocument3_put_onrowsdelete(IHTMLDocument3 *iface, VARIANT v) diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index 4277890..ae2eeee 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -2575,7 +2575,7 @@ static HRESULT WINAPI HTMLElement2_detachEvent(IHTMLElement2 *iface, BSTR event, TRACE("(%p)->(%s %p)\n", This, debugstr_w(event), pDisp); - return detach_event(&This->node.event_target, &This->node.doc->basedoc, event, pDisp); + return detach_event(&This->node.event_target, event, pDisp); } static HRESULT WINAPI HTMLElement2_get_readyState(IHTMLElement2 *iface, VARIANT *p) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index d359e4a..4bc9847 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1520,7 +1520,7 @@ HRESULT attach_event(EventTarget *event_target, BSTR name, IDispatch *disp, VARI return S_OK; } -HRESULT detach_event(EventTarget *event_target, HTMLDocument *doc, BSTR name, IDispatch *disp) +HRESULT detach_event(EventTarget *event_target, BSTR name, IDispatch *disp) { event_target_t *data; eventid_t eid; diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index e10a87d..3946243 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -57,7 +57,7 @@ void fire_event(HTMLDocumentNode*,eventid_t,BOOL,nsIDOMNode*,nsIDOMEvent*,IDispa HRESULT set_event_handler(EventTarget*,HTMLDocumentNode*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; HRESULT get_event_handler(EventTarget*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; HRESULT attach_event(EventTarget*,BSTR,IDispatch*,VARIANT_BOOL*) DECLSPEC_HIDDEN; -HRESULT detach_event(EventTarget*,HTMLDocument*,BSTR,IDispatch*) DECLSPEC_HIDDEN; +HRESULT detach_event(EventTarget*,BSTR,IDispatch*) DECLSPEC_HIDDEN; HRESULT dispatch_event(HTMLDOMNode*,const WCHAR*,VARIANT*,VARIANT_BOOL*) DECLSPEC_HIDDEN; HRESULT call_fire_event(HTMLDOMNode*,eventid_t) DECLSPEC_HIDDEN; void update_doc_cp_events(HTMLDocumentNode*,cp_static_data_t*) DECLSPEC_HIDDEN; diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index d38e704..9f9e341 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -1669,7 +1669,7 @@ static HRESULT WINAPI HTMLWindow3_detachEvent(IHTMLWindow3 *iface, BSTR event, I return E_FAIL; } - return detach_event(&window->event_target, &window->doc->basedoc, event, pDisp); + return detach_event(&window->event_target, event, pDisp); } static HRESULT window_set_timer(HTMLInnerWindow *This, VARIANT *expr, LONG msec, VARIANT *language,

1 0

Jacek Caban : mshtml: Use bind_event in set_event_handler.
by Alexandre Julliard 21 May '15

21 May '15

Module: wine Branch: master Commit: c1079f2571702d3bac57e0bf2c83535e971b3e82 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1079f2571702d3bac57e0bf2… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 20 19:47:11 2015 +0200 mshtml: Use bind_event in set_event_handler. --- dlls/mshtml/htmlevent.c | 13 +++++++------ dlls/mshtml/htmlevent.h | 4 ++-- dlls/mshtml/htmlwindow.c | 2 +- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 4bc9847..ef6929c 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1399,7 +1399,7 @@ static void remove_event_handler(EventTarget *event_target, eventid_t eid) } } -static HRESULT set_event_handler_disp(EventTarget *event_target, HTMLDocumentNode *doc, eventid_t eid, IDispatch *disp) +static HRESULT set_event_handler_disp(EventTarget *event_target, eventid_t eid, IDispatch *disp) { event_target_t *data; @@ -1417,10 +1417,11 @@ static HRESULT set_event_handler_disp(EventTarget *event_target, HTMLDocumentNod data->event_table[eid]->handler_prop = disp; IDispatch_AddRef(disp); - return ensure_doc_nsevent_handler(doc, eid); + bind_event(event_target, eid); + return S_OK; } -HRESULT set_event_handler(EventTarget *event_target, HTMLDocumentNode *doc, eventid_t eid, VARIANT *var) +HRESULT set_event_handler(EventTarget *event_target, eventid_t eid, VARIANT *var) { switch(V_VT(var)) { case VT_NULL: @@ -1428,7 +1429,7 @@ HRESULT set_event_handler(EventTarget *event_target, HTMLDocumentNode *doc, even return S_OK; case VT_DISPATCH: - return set_event_handler_disp(event_target, doc, eid, V_DISPATCH(var)); + return set_event_handler_disp(event_target, eid, V_DISPATCH(var)); case VT_BSTR: { VARIANT *v; @@ -1562,7 +1563,7 @@ void bind_target_event(HTMLDocumentNode *doc, EventTarget *event_target, const W return; } - set_event_handler_disp(event_target, doc, eid, disp); + set_event_handler_disp(event_target, eid, disp); } void update_doc_cp_events(HTMLDocumentNode *doc, cp_static_data_t *cp) @@ -1597,7 +1598,7 @@ void check_event_attr(HTMLDocumentNode *doc, nsIDOMHTMLElement *nselem) if(disp) { hres = get_node(doc, (nsIDOMNode*)nselem, TRUE, &node); if(SUCCEEDED(hres)) { - set_event_handler_disp(&node->event_target, node->doc, i, disp); + set_event_handler_disp(&node->event_target, i, disp); node_release(node); } IDispatch_Release(disp); diff --git a/dlls/mshtml/htmlevent.h b/dlls/mshtml/htmlevent.h index 3946243..4579617f 100644 --- a/dlls/mshtml/htmlevent.h +++ b/dlls/mshtml/htmlevent.h @@ -54,7 +54,7 @@ eventid_t str_to_eid(LPCWSTR) DECLSPEC_HIDDEN; void check_event_attr(HTMLDocumentNode*,nsIDOMHTMLElement*) DECLSPEC_HIDDEN; void release_event_target(event_target_t*) DECLSPEC_HIDDEN; void fire_event(HTMLDocumentNode*,eventid_t,BOOL,nsIDOMNode*,nsIDOMEvent*,IDispatch*) DECLSPEC_HIDDEN; -HRESULT set_event_handler(EventTarget*,HTMLDocumentNode*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; +HRESULT set_event_handler(EventTarget*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; HRESULT get_event_handler(EventTarget*,eventid_t,VARIANT*) DECLSPEC_HIDDEN; HRESULT attach_event(EventTarget*,BSTR,IDispatch*,VARIANT_BOOL*) DECLSPEC_HIDDEN; HRESULT detach_event(EventTarget*,BSTR,IDispatch*) DECLSPEC_HIDDEN; @@ -74,7 +74,7 @@ void detach_nsevent(HTMLDocumentNode*,const WCHAR*) DECLSPEC_HIDDEN; static inline HRESULT set_node_event(HTMLDOMNode *node, eventid_t eid, VARIANT *var) { - return set_event_handler(&node->event_target, node->doc, eid, var); + return set_event_handler(&node->event_target, eid, var); } static inline HRESULT get_node_event(HTMLDOMNode *node, eventid_t eid, VARIANT *var) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 9f9e341..618648e 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -95,7 +95,7 @@ static inline HRESULT set_window_event(HTMLWindow *window, eventid_t eid, VARIAN return E_FAIL; } - return set_event_handler(&window->inner_window->event_target, window->inner_window->doc, eid, var); + return set_event_handler(&window->inner_window->event_target, eid, var); } static inline HRESULT get_window_event(HTMLWindow *window, eventid_t eid, VARIANT *var)

1 0

Matteo Bruni : ntdll/tests: Add a test for filename casing with NtQueryDirectoryFile().
by Alexandre Julliard 20 May '15

20 May '15

Module: wine Branch: master Commit: cb5c92f33c56d469e5e061e8ac2f090e88358c34 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cb5c92f33c56d469e5e061e8a… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Tue May 19 23:32:35 2015 +0200 ntdll/tests: Add a test for filename casing with NtQueryDirectoryFile(). --- dlls/ntdll/tests/directory.c | 96 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/dlls/ntdll/tests/directory.c b/dlls/ntdll/tests/directory.c index ec8cd5a..21aa31f 100644 --- a/dlls/ntdll/tests/directory.c +++ b/dlls/ntdll/tests/directory.c @@ -276,6 +276,101 @@ done: pRtlFreeUnicodeString(&ntdirname); } +static void set_up_case_test(const char *testdir) +{ + BOOL ret; + char buf[MAX_PATH]; + HANDLE h; + + ret = CreateDirectoryA(testdir, NULL); + ok(ret, "couldn't create dir '%s', error %d\n", testdir, GetLastError()); + + sprintf(buf, "%s\\%s", testdir, "TesT"); + h = CreateFileA(buf, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, + FILE_ATTRIBUTE_NORMAL, 0); + ok(h != INVALID_HANDLE_VALUE, "failed to create temp file '%s'\n", buf); + CloseHandle(h); +} + +static void tear_down_case_test(const char *testdir) +{ + int ret; + char buf[MAX_PATH]; + + sprintf(buf, "%s\\%s", testdir, "TesT"); + ret = DeleteFileA(buf); + ok(ret || (GetLastError() == ERROR_PATH_NOT_FOUND), + "Failed to rm %s, error %d\n", buf, GetLastError()); + RemoveDirectoryA(testdir); +} + +static void test_NtQueryDirectoryFile_case(void) +{ + static const char testfile[] = "TesT"; + static const WCHAR testfile_w[] = {'T','e','s','T'}; + static int testfile_len = sizeof(testfile) - 1; + static WCHAR testmask[] = {'t','e','s','t'}; + OBJECT_ATTRIBUTES attr; + UNICODE_STRING ntdirname; + char testdir[MAX_PATH]; + WCHAR testdir_w[MAX_PATH]; + HANDLE dirh; + UNICODE_STRING mask; + IO_STATUS_BLOCK io; + UINT data_size, data_len; + BYTE data[8192]; + FILE_BOTH_DIRECTORY_INFORMATION *dir_info = (FILE_BOTH_DIRECTORY_INFORMATION *)data; + DWORD status; + WCHAR *name; + ULONG name_len; + + /* Clean up from prior aborted run, if any, then set up test files */ + ok(GetTempPathA(MAX_PATH, testdir), "couldn't get temp dir\n"); + strcat(testdir, "case.tmp"); + tear_down_case_test(testdir); + set_up_case_test(testdir); + + pRtlMultiByteToUnicodeN(testdir_w, sizeof(testdir_w), NULL, testdir, strlen(testdir) + 1); + if (!pRtlDosPathNameToNtPathName_U(testdir_w, &ntdirname, NULL, NULL)) + { + ok(0, "RtlDosPathNametoNtPathName_U failed\n"); + goto done; + } + InitializeObjectAttributes(&attr, &ntdirname, OBJ_CASE_INSENSITIVE, 0, NULL); + + data_size = offsetof(FILE_BOTH_DIRECTORY_INFORMATION, FileName[256]); + + status = pNtOpenFile(&dirh, SYNCHRONIZE | FILE_LIST_DIRECTORY, &attr, &io, FILE_SHARE_READ, + FILE_SYNCHRONOUS_IO_NONALERT | FILE_OPEN_FOR_BACKUP_INTENT | FILE_DIRECTORY_FILE); + ok (status == STATUS_SUCCESS, "failed to open dir '%s', ret 0x%x, error %d\n", testdir, status, GetLastError()); + if (status != STATUS_SUCCESS) + { + skip("can't test if we can't open the directory\n"); + return; + } + + mask.Buffer = testmask; + mask.Length = mask.MaximumLength = lstrlenW(testmask) * sizeof(WCHAR); + pNtQueryDirectoryFile(dirh, NULL, NULL, NULL, &io, data, data_size, + FileBothDirectoryInformation, TRUE, &mask, FALSE); + ok(U(io).Status == STATUS_SUCCESS, "failed to query directory; status %x\n", U(io).Status); + data_len = io.Information; + ok(data_len >= sizeof(FILE_BOTH_DIRECTORY_INFORMATION), "not enough data in directory\n"); + + name = dir_info->FileName; + name_len = dir_info->FileNameLength / sizeof(WCHAR); + + ok(name_len == testfile_len, "unexpected filename length %u\n", name_len); + ok(!memcmp(name, testfile_w, testfile_len * sizeof(WCHAR)), "unexpected filename %s\n", + wine_dbgstr_wn(name, name_len)); + + pNtClose(dirh); + +done: + tear_down_case_test(testdir); + pRtlFreeUnicodeString(&ntdirname); +} + static void test_redirection(void) { ULONG old, cur; @@ -345,5 +440,6 @@ START_TEST(directory) pRtlWow64EnableFsRedirectionEx = (void *)GetProcAddress(hntdll,"RtlWow64EnableFsRedirectionEx"); test_NtQueryDirectoryFile(); + test_NtQueryDirectoryFile_case(); test_redirection(); }

1 0