April 2016 - Wine-commits - list.winehq.org

Hans Leidekker : webservices: Implement WsCreateChannel and WsFreeChannel.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 8d9bf5375879ab3c220029966faffa4c74d4793c URL: http://source.winehq.org/git/wine.git/?a=commit;h=8d9bf5375879ab3c220029966… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Apr 13 13:49:44 2016 +0200 webservices: Implement WsCreateChannel and WsFreeChannel. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/Makefile.in | 1 + dlls/webservices/channel.c | 158 +++++++++++++++++++++++++++++++++ dlls/webservices/webservices.spec | 4 +- dlls/webservices/webservices_private.h | 12 +++ 4 files changed, 173 insertions(+), 2 deletions(-) diff --git a/dlls/webservices/Makefile.in b/dlls/webservices/Makefile.in index d48e3c6..c052252 100644 --- a/dlls/webservices/Makefile.in +++ b/dlls/webservices/Makefile.in @@ -3,6 +3,7 @@ IMPORTLIB = webservices IMPORTS = user32 C_SRCS = \ + channel.c \ main.c \ reader.c \ writer.c diff --git a/dlls/webservices/channel.c b/dlls/webservices/channel.c new file mode 100644 index 0000000..c8a920d --- /dev/null +++ b/dlls/webservices/channel.c @@ -0,0 +1,158 @@ +/* + * Copyright 2016 Hans Leidekker for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "winuser.h" +#include "webservices.h" + +#include "wine/debug.h" +#include "wine/list.h" +#include "webservices_private.h" + +WINE_DEFAULT_DEBUG_CHANNEL(webservices); + +static const struct +{ + ULONG size; + BOOL readonly; +} +channel_props[] = +{ + { sizeof(ULONG), FALSE }, /* WS_CHANNEL_PROPERTY_MAX_BUFFERED_MESSAGE_SIZE */ + { sizeof(UINT64), FALSE }, /* WS_CHANNEL_PROPERTY_MAX_STREAMED_MESSAGE_SIZE */ + { sizeof(ULONG), FALSE }, /* WS_CHANNEL_PROPERTY_MAX_STREAMED_START_SIZE */ + { sizeof(ULONG), FALSE }, /* WS_CHANNEL_PROPERTY_MAX_STREAMED_FLUSH_SIZE */ + { sizeof(WS_ENCODING), FALSE }, /* WS_CHANNEL_PROPERTY_ENCODING */ + { sizeof(WS_ENVELOPE_VERSION), FALSE }, /* WS_CHANNEL_PROPERTY_ENVELOPE_VERSION */ + { sizeof(WS_ADDRESSING_VERSION), FALSE }, /* WS_CHANNEL_PROPERTY_ADDRESSING_VERSION */ + { sizeof(ULONG), FALSE }, /* WS_CHANNEL_PROPERTY_MAX_SESSION_DICTIONARY_SIZE */ + { sizeof(WS_CHANNEL_STATE), TRUE }, /* WS_CHANNEL_PROPERTY_STATE */ +}; + +static struct channel *alloc_channel(void) +{ + static const ULONG count = sizeof(channel_props)/sizeof(channel_props[0]); + struct channel *ret; + ULONG i, size = sizeof(*ret) + count * sizeof(WS_CHANNEL_PROPERTY); + char *ptr; + + for (i = 0; i < count; i++) size += channel_props[i].size; + if (!(ret = heap_alloc_zero( size ))) return NULL; + + ptr = (char *)&ret->prop[count]; + for (i = 0; i < count; i++) + { + ret->prop[i].value = ptr; + ret->prop[i].valueSize = channel_props[i].size; + ptr += ret->prop[i].valueSize; + } + ret->prop_count = count; + return ret; +} + +static HRESULT set_channel_prop( struct channel *channel, WS_CHANNEL_PROPERTY_ID id, const void *value, + ULONG size ) +{ + if (id >= channel->prop_count || size != channel_props[id].size || channel_props[id].readonly) + return E_INVALIDARG; + + memcpy( channel->prop[id].value, value, size ); + return S_OK; +} + +void free_channel( struct channel *channel ) +{ + heap_free( channel ); +} + +HRESULT create_channel( WS_CHANNEL_TYPE type, WS_CHANNEL_BINDING binding, + const WS_CHANNEL_PROPERTY *properties, ULONG count, struct channel **ret ) +{ + struct channel *channel; + ULONG i, msg_size = 65536; + HRESULT hr; + + if (!(channel = alloc_channel())) return E_OUTOFMEMORY; + + set_channel_prop( channel, WS_CHANNEL_PROPERTY_MAX_BUFFERED_MESSAGE_SIZE, &msg_size, sizeof(msg_size) ); + + for (i = 0; i < count; i++) + { + hr = set_channel_prop( channel, properties[i].id, properties[i].value, properties[i].valueSize ); + if (hr != S_OK) + { + free_channel( channel ); + return hr; + } + } + + channel->type = type; + channel->binding = binding; + + *ret = channel; + return S_OK; +} + +/************************************************************************** + * WsCreateChannel [webservices.@] + */ +HRESULT WINAPI WsCreateChannel( WS_CHANNEL_TYPE type, WS_CHANNEL_BINDING binding, + const WS_CHANNEL_PROPERTY *properties, ULONG count, + const WS_SECURITY_DESCRIPTION *desc, WS_CHANNEL **handle, + WS_ERROR *error ) +{ + struct channel *channel; + HRESULT hr; + + TRACE( "%u %u %p %u %p %p %p\n", type, binding, properties, count, desc, handle, error ); + if (error) FIXME( "ignoring error parameter\n" ); + if (desc) FIXME( "ignoring security description\n" ); + + if (!handle) return E_INVALIDARG; + + if (type != WS_CHANNEL_TYPE_REQUEST) + { + FIXME( "channel type %u not implemented\n", type ); + return E_NOTIMPL; + } + if (binding != WS_HTTP_CHANNEL_BINDING) + { + FIXME( "channel binding %u not implemented\n", binding ); + return E_NOTIMPL; + } + + if ((hr = create_channel( type, binding, properties, count, &channel )) != S_OK) + return hr; + + *handle = (WS_CHANNEL *)channel; + return S_OK; +} + +/************************************************************************** + * WsFreeChannel [webservices.@] + */ +void WINAPI WsFreeChannel( WS_CHANNEL *handle ) +{ + struct channel *channel = (struct channel *)handle; + + TRACE( "%p\n", handle ); + free_channel( channel ); +} diff --git a/dlls/webservices/webservices.spec b/dlls/webservices/webservices.spec index 9c0b3c7..2ddda72 100644 --- a/dlls/webservices/webservices.spec +++ b/dlls/webservices/webservices.spec @@ -20,7 +20,7 @@ @ stub WsCombineUrl @ stub WsCopyError @ stub WsCopyNode -@ stub WsCreateChannel +@ stdcall WsCreateChannel(long long ptr long ptr ptr ptr) @ stub WsCreateChannelForListener @ stdcall WsCreateError(ptr long ptr) @ stub WsCreateFaultFromError @@ -48,7 +48,7 @@ @ stdcall WsFindAttribute(ptr ptr ptr long ptr ptr) @ stub WsFlushBody @ stub WsFlushWriter -@ stub WsFreeChannel +@ stdcall WsFreeChannel(ptr) @ stdcall WsFreeError(ptr) @ stdcall WsFreeHeap(ptr) @ stub WsFreeListener diff --git a/dlls/webservices/webservices_private.h b/dlls/webservices/webservices_private.h index c286fd2..1ec3eeb 100644 --- a/dlls/webservices/webservices_private.h +++ b/dlls/webservices/webservices_private.h @@ -50,6 +50,18 @@ static inline WS_XML_NODE_TYPE node_type( const struct node *node ) return node->hdr.node.nodeType; } +struct channel +{ + WS_CHANNEL_TYPE type; + WS_CHANNEL_BINDING binding; + ULONG prop_count; + WS_CHANNEL_PROPERTY prop[9]; +}; + +HRESULT create_channel( WS_CHANNEL_TYPE, WS_CHANNEL_BINDING, const WS_CHANNEL_PROPERTY *, + ULONG, struct channel ** ) DECLSPEC_HIDDEN; +void free_channel( struct channel * ) DECLSPEC_HIDDEN; + static inline void *heap_alloc( SIZE_T size ) { return HeapAlloc( GetProcessHeap(), 0, size );

1 0

Hans Leidekker : webservices: Implement WsGetChannelProperty and WsSetChannelProperty.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 5f5c389010371242316bbecbaedecdb7daf1c365 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5f5c389010371242316bbecba… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Apr 13 13:49:45 2016 +0200 webservices: Implement WsGetChannelProperty and WsSetChannelProperty. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/channel.c | 37 +++++++++++++++++++++++++++++++++++++ dlls/webservices/webservices.spec | 4 ++-- 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/dlls/webservices/channel.c b/dlls/webservices/channel.c index c8a920d..54e159d 100644 --- a/dlls/webservices/channel.c +++ b/dlls/webservices/channel.c @@ -78,6 +78,15 @@ static HRESULT set_channel_prop( struct channel *channel, WS_CHANNEL_PROPERTY_ID return S_OK; } +static HRESULT get_channel_prop( struct channel *channel, WS_CHANNEL_PROPERTY_ID id, void *buf, ULONG size ) +{ + if (id >= channel->prop_count || size != channel_props[id].size) + return E_INVALIDARG; + + memcpy( buf, channel->prop[id].value, channel->prop[id].valueSize ); + return S_OK; +} + void free_channel( struct channel *channel ) { heap_free( channel ); @@ -156,3 +165,31 @@ void WINAPI WsFreeChannel( WS_CHANNEL *handle ) TRACE( "%p\n", handle ); free_channel( channel ); } + +/************************************************************************** + * WsGetChannelProperty [webservices.@] + */ +HRESULT WINAPI WsGetChannelProperty( WS_CHANNEL *handle, WS_CHANNEL_PROPERTY_ID id, void *buf, + ULONG size, WS_ERROR *error ) +{ + struct channel *channel = (struct channel *)handle; + + TRACE( "%p %u %p %u %p\n", handle, id, buf, size, error ); + if (error) FIXME( "ignoring error parameter\n" ); + + return get_channel_prop( channel, id, buf, size ); +} + +/************************************************************************** + * WsSetChannelProperty [webservices.@] + */ +HRESULT WINAPI WsSetChannelProperty( WS_CHANNEL *handle, WS_CHANNEL_PROPERTY_ID id, const void *value, + ULONG size, WS_ERROR *error ) +{ + struct channel *channel = (struct channel *)handle; + + TRACE( "%p %u %p %u\n", handle, id, value, size ); + if (error) FIXME( "ignoring error parameter\n" ); + + return set_channel_prop( channel, id, value, size ); +} diff --git a/dlls/webservices/webservices.spec b/dlls/webservices/webservices.spec index 2ddda72..001b3ca 100644 --- a/dlls/webservices/webservices.spec +++ b/dlls/webservices/webservices.spec @@ -59,7 +59,7 @@ @ stub WsFreeServiceHost @ stub WsFreeServiceProxy @ stdcall WsFreeWriter(ptr) -@ stub WsGetChannelProperty +@ stdcall WsGetChannelProperty(ptr long ptr long ptr) @ stub WsGetCustomHeader @ stub WsGetDictionary @ stdcall WsGetErrorProperty(ptr long ptr long) @@ -145,7 +145,7 @@ @ stub WsSendFaultMessageForError @ stub WsSendMessage @ stub WsSendReplyMessage -@ stub WsSetChannelProperty +@ stdcall WsSetChannelProperty(ptr long ptr long ptr) @ stdcall WsSetErrorProperty(ptr long ptr long) @ stub WsSetFaultErrorDetail @ stub WsSetFaultErrorProperty

1 0

Hans Leidekker : webservices/tests: Add channel tests.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 1f79f36373a098e937d718b7dfe7c9f823979b02 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f79f36373a098e937d718b7d… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Apr 13 13:49:46 2016 +0200 webservices/tests: Add channel tests. Signed-off-by: Hans Leidekker <hans(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/webservices/tests/Makefile.in | 1 + dlls/webservices/tests/channel.c | 63 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/dlls/webservices/tests/Makefile.in b/dlls/webservices/tests/Makefile.in index 1456b44..5f79fcb 100644 --- a/dlls/webservices/tests/Makefile.in +++ b/dlls/webservices/tests/Makefile.in @@ -2,5 +2,6 @@ TESTDLL = webservices.dll IMPORTS = webservices C_SRCS = \ + channel.c \ reader.c \ writer.c diff --git a/dlls/webservices/tests/channel.c b/dlls/webservices/tests/channel.c new file mode 100644 index 0000000..82a7a69 --- /dev/null +++ b/dlls/webservices/tests/channel.c @@ -0,0 +1,63 @@ +/* + * Copyright 2016 Hans Leidekker for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <stdio.h> +#include "windows.h" +#include "webservices.h" +#include "wine/test.h" + +static void test_WsCreateChannel(void) +{ + HRESULT hr; + WS_CHANNEL *channel; + WS_CHANNEL_STATE state; + ULONG size, value; + + hr = WsCreateChannel( WS_CHANNEL_TYPE_REQUEST, WS_HTTP_CHANNEL_BINDING, NULL, 0, NULL, NULL, NULL ) ; + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + channel = NULL; + hr = WsCreateChannel( WS_CHANNEL_TYPE_REQUEST, WS_HTTP_CHANNEL_BINDING, NULL, 0, NULL, &channel, NULL ) ; + ok( hr == S_OK, "got %08x\n", hr ); + ok( channel != NULL, "channel not set\n" ); + + value = 0xdeadbeef; + size = sizeof(value); + hr = WsGetChannelProperty( channel, WS_CHANNEL_PROPERTY_MAX_BUFFERED_MESSAGE_SIZE, &value, size, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( value == 65536, "got %u\n", value ); + + /* read-only property */ + state = 0xdeadbeef; + size = sizeof(state); + hr = WsGetChannelProperty( channel, WS_CHANNEL_PROPERTY_STATE, &state, size, NULL ); + ok( hr == S_OK, "got %08x\n", hr ); + ok( state == WS_CHANNEL_STATE_CREATED, "got %u\n", state ); + + state = WS_CHANNEL_STATE_CREATED; + size = sizeof(state); + hr = WsSetChannelProperty( channel, WS_CHANNEL_PROPERTY_STATE, &state, size, NULL ); + ok( hr == E_INVALIDARG, "got %08x\n", hr ); + + WsFreeChannel( channel ); +} + +START_TEST(channel) +{ + test_WsCreateChannel(); +}

1 0

Francois Gouget : hidclass.sys: Fix spelling of a private struct's name.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 742d8f4808a3cdbfceede814368d346e37eacbc5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=742d8f4808a3cdbfceede8143… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Apr 13 11:28:17 2016 +0200 hidclass.sys: Fix spelling of a private struct's name. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/hidclass.sys/hid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/hidclass.sys/hid.h b/dlls/hidclass.sys/hid.h index 2820c9d..34c2a09 100644 --- a/dlls/hidclass.sys/hid.h +++ b/dlls/hidclass.sys/hid.h @@ -39,7 +39,7 @@ typedef NTSTATUS (WINAPI *pAddDevice)(DRIVER_OBJECT *DriverObject, DEVICE_OBJECT /* Ring buffer functions */ struct ReportRingBuffer; -typedef struct _BASE_DEVICE_EXTENSTION { +typedef struct _BASE_DEVICE_EXTENSION { HID_DEVICE_EXTENSION deviceExtension; HID_COLLECTION_INFORMATION information;

1 0

Francois Gouget : wintrust: Fix spelling of a variable name.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 17d1126d03b69f4acb2e8734df3bd3da4cdc3b27 URL: http://source.winehq.org/git/wine.git/?a=commit;h=17d1126d03b69f4acb2e8734d… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Apr 13 11:28:32 2016 +0200 wintrust: Fix spelling of a variable name. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wintrust/register.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/dlls/wintrust/register.c b/dlls/wintrust/register.c index 303426c..b9a7559 100644 --- a/dlls/wintrust/register.c +++ b/dlls/wintrust/register.c @@ -40,7 +40,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(wintrust); static CRYPT_TRUST_REG_ENTRY SoftpubInitialization; static CRYPT_TRUST_REG_ENTRY SoftpubMessage; static CRYPT_TRUST_REG_ENTRY SoftpubSignature; -static CRYPT_TRUST_REG_ENTRY SoftpubCertficate; +static CRYPT_TRUST_REG_ENTRY SoftpubCertificate; static CRYPT_TRUST_REG_ENTRY SoftpubCertCheck; static CRYPT_TRUST_REG_ENTRY SoftpubFinalPolicy; static CRYPT_TRUST_REG_ENTRY SoftpubCleanup; @@ -100,7 +100,7 @@ static void WINTRUST_InitRegStructs(void) WINTRUST_INITREGENTRY(SoftpubInitialization, SP_POLICY_PROVIDER_DLL_NAME, SP_INIT_FUNCTION) WINTRUST_INITREGENTRY(SoftpubMessage, SP_POLICY_PROVIDER_DLL_NAME, SP_OBJTRUST_FUNCTION) WINTRUST_INITREGENTRY(SoftpubSignature, SP_POLICY_PROVIDER_DLL_NAME, SP_SIGTRUST_FUNCTION) - WINTRUST_INITREGENTRY(SoftpubCertficate, SP_POLICY_PROVIDER_DLL_NAME, WT_PROVIDER_CERTTRUST_FUNCTION) + WINTRUST_INITREGENTRY(SoftpubCertificate, SP_POLICY_PROVIDER_DLL_NAME, WT_PROVIDER_CERTTRUST_FUNCTION) WINTRUST_INITREGENTRY(SoftpubCertCheck, SP_POLICY_PROVIDER_DLL_NAME, SP_CHKCERT_FUNCTION) WINTRUST_INITREGENTRY(SoftpubFinalPolicy, SP_POLICY_PROVIDER_DLL_NAME, SP_FINALPOLICY_FUNCTION) WINTRUST_INITREGENTRY(SoftpubCleanup, SP_POLICY_PROVIDER_DLL_NAME, SP_CLEANUPPOLICY_FUNCTION) @@ -134,7 +134,7 @@ static void WINTRUST_FreeRegStructs(void) WINTRUST_FREEREGENTRY(SoftpubInitialization); WINTRUST_FREEREGENTRY(SoftpubMessage); WINTRUST_FREEREGENTRY(SoftpubSignature); - WINTRUST_FREEREGENTRY(SoftpubCertficate); + WINTRUST_FREEREGENTRY(SoftpubCertificate); WINTRUST_FREEREGENTRY(SoftpubCertCheck); WINTRUST_FREEREGENTRY(SoftpubFinalPolicy); WINTRUST_FREEREGENTRY(SoftpubCleanup); @@ -432,7 +432,7 @@ static BOOL WINTRUST_RegisterGenVerifyV2(void) ProvInfo.sInitProvider = SoftpubInitialization; ProvInfo.sObjectProvider = SoftpubMessage; ProvInfo.sSignatureProvider = SoftpubSignature; - ProvInfo.sCertificateProvider = SoftpubCertficate; + ProvInfo.sCertificateProvider = SoftpubCertificate; ProvInfo.sCertificatePolicyProvider = SoftpubCertCheck; ProvInfo.sFinalPolicyProvider = SoftpubFinalPolicy; ProvInfo.sTestPolicyProvider = NullCTRE; /* No diagnostic policy */ @@ -465,7 +465,7 @@ static BOOL WINTRUST_RegisterPublishedSoftware(void) ProvInfo.sInitProvider = SoftpubInitialization; ProvInfo.sObjectProvider = SoftpubMessage; ProvInfo.sSignatureProvider = SoftpubSignature; - ProvInfo.sCertificateProvider = SoftpubCertficate; + ProvInfo.sCertificateProvider = SoftpubCertificate; ProvInfo.sCertificatePolicyProvider = SoftpubCertCheck; ProvInfo.sFinalPolicyProvider = SoftpubFinalPolicy; ProvInfo.sTestPolicyProvider = NullCTRE; /* No diagnostic policy */ @@ -497,7 +497,7 @@ static BOOL WINTRUST_RegisterPublishedSoftwareNoBadUi(void) ProvInfo.sInitProvider = SoftpubInitialization; ProvInfo.sObjectProvider = SoftpubMessage; ProvInfo.sSignatureProvider = SoftpubSignature; - ProvInfo.sCertificateProvider = SoftpubCertficate; + ProvInfo.sCertificateProvider = SoftpubCertificate; ProvInfo.sCertificatePolicyProvider = SoftpubCertCheck; ProvInfo.sFinalPolicyProvider = SoftpubFinalPolicy; ProvInfo.sTestPolicyProvider = NullCTRE; /* No diagnostic policy */ @@ -527,7 +527,7 @@ static BOOL WINTRUST_RegisterGenCertVerify(void) ProvInfo.sInitProvider = SoftpubDefCertInit; ProvInfo.sObjectProvider = SoftpubMessage; ProvInfo.sSignatureProvider = SoftpubSignature; - ProvInfo.sCertificateProvider = SoftpubCertficate; + ProvInfo.sCertificateProvider = SoftpubCertificate; ProvInfo.sCertificatePolicyProvider = SoftpubCertCheck; ProvInfo.sFinalPolicyProvider = SoftpubFinalPolicy; ProvInfo.sTestPolicyProvider = NullCTRE; /* No diagnostic policy */ @@ -557,7 +557,7 @@ static BOOL WINTRUST_RegisterTrustProviderTest(void) ProvInfo.sInitProvider = SoftpubInitialization; ProvInfo.sObjectProvider = SoftpubMessage; ProvInfo.sSignatureProvider = SoftpubSignature; - ProvInfo.sCertificateProvider = SoftpubCertficate; + ProvInfo.sCertificateProvider = SoftpubCertificate; ProvInfo.sCertificatePolicyProvider = SoftpubCertCheck; ProvInfo.sFinalPolicyProvider = SoftpubFinalPolicy; ProvInfo.sTestPolicyProvider = SoftpubDumpStructure; @@ -639,7 +639,7 @@ static BOOL WINTRUST_RegisterOfficeSignVerify(void) ProvInfo.sInitProvider = OfficeInitializePolicy; ProvInfo.sObjectProvider = SoftpubMessage; ProvInfo.sSignatureProvider = SoftpubSignature; - ProvInfo.sCertificateProvider = SoftpubCertficate; + ProvInfo.sCertificateProvider = SoftpubCertificate; ProvInfo.sCertificatePolicyProvider = SoftpubCertCheck; ProvInfo.sFinalPolicyProvider = SoftpubFinalPolicy; ProvInfo.sTestPolicyProvider = NullCTRE; /* No diagnostic policy */ @@ -670,7 +670,7 @@ static BOOL WINTRUST_RegisterDriverVerify(void) ProvInfo.sInitProvider = DriverInitializePolicy; ProvInfo.sObjectProvider = SoftpubMessage; ProvInfo.sSignatureProvider = SoftpubSignature; - ProvInfo.sCertificateProvider = SoftpubCertficate; + ProvInfo.sCertificateProvider = SoftpubCertificate; ProvInfo.sCertificatePolicyProvider = SoftpubCertCheck; ProvInfo.sFinalPolicyProvider = DriverFinalPolicy; ProvInfo.sTestPolicyProvider = NullCTRE; /* No diagnostic policy */

1 0

Francois Gouget : quartz: Fix spelling of a BaseOututPin method implementation name.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 4f916835803a1b83405fdbd5a9551c60400202c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f916835803a1b83405fdbd5a… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Apr 13 11:28:56 2016 +0200 quartz: Fix spelling of a BaseOututPin method implementation name. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/quartz/filesource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c index 33ac442..1a2af44 100644 --- a/dlls/quartz/filesource.c +++ b/dlls/quartz/filesource.c @@ -765,7 +765,7 @@ static inline FileAsyncReader *impl_from_BaseOutputPin(BaseOutputPin *iface) return CONTAINING_RECORD(iface, FileAsyncReader, pin); } -static inline BaseOutputPin *impl_BaseOututPin_from_BasePin(BasePin *iface) +static inline BaseOutputPin *impl_BaseOutputPin_from_BasePin(BasePin *iface) { return CONTAINING_RECORD(iface, BaseOutputPin, pin); } @@ -881,7 +881,7 @@ static const IPinVtbl FileAsyncReaderPin_Vtbl = * doesn't need the IMemInputPin interface on the receiving pin */ static HRESULT WINAPI FileAsyncReaderPin_AttemptConnection(BasePin * iface, IPin * pReceivePin, const AM_MEDIA_TYPE * pmt) { - BaseOutputPin *This = impl_BaseOututPin_from_BasePin(iface); + BaseOutputPin *This = impl_BaseOutputPin_from_BasePin(iface); HRESULT hr; TRACE("(%p, %p)\n", pReceivePin, pmt);

1 0

Francois Gouget : msctf: Fix spelling of a private struct's field name.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 0ebb3f2fcc4ffbd29606a55e2a074fdc05d19ed3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0ebb3f2fcc4ffbd29606a55e2… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Apr 13 11:30:37 2016 +0200 msctf: Fix spelling of a private struct's field name. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msctf/threadmgr.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index 3f0e7f6..1e0ec4d 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -99,8 +99,8 @@ typedef struct tagACLMulti { ITfDocumentMgr *focus; LONG activationCount; - ITfKeyEventSink *forgroundKeyEventSink; - CLSID forgroundTextService; + ITfKeyEventSink *foregroundKeyEventSink; + CLSID foregroundTextService; struct list CurrentPreservedKeys; struct list CreatedDocumentMgrs; @@ -767,15 +767,15 @@ static HRESULT WINAPI KeystrokeMgr_AdviseKeyEventSink(ITfKeystrokeMgr *iface, if (fForeground) { - if (This->forgroundKeyEventSink) + if (This->foregroundKeyEventSink) { - ITfKeyEventSink_OnSetFocus(This->forgroundKeyEventSink, FALSE); - ITfKeyEventSink_Release(This->forgroundKeyEventSink); + ITfKeyEventSink_OnSetFocus(This->foregroundKeyEventSink, FALSE); + ITfKeyEventSink_Release(This->foregroundKeyEventSink); } ITfKeyEventSink_AddRef(check); ITfKeyEventSink_OnSetFocus(check, TRUE); - This->forgroundKeyEventSink = check; - This->forgroundTextService = textservice; + This->foregroundKeyEventSink = check; + This->foregroundTextService = textservice; } return S_OK; } @@ -803,11 +803,11 @@ static HRESULT WINAPI KeystrokeMgr_UnadviseKeyEventSink(ITfKeystrokeMgr *iface, set_textservice_sink(tid, &IID_ITfKeyEventSink, NULL); ITfKeyEventSink_Release(check); - if (This->forgroundKeyEventSink == check) + if (This->foregroundKeyEventSink == check) { - ITfKeyEventSink_Release(This->forgroundKeyEventSink); - This->forgroundKeyEventSink = NULL; - This->forgroundTextService = GUID_NULL; + ITfKeyEventSink_Release(This->foregroundKeyEventSink); + This->foregroundKeyEventSink = NULL; + This->foregroundTextService = GUID_NULL; } return S_OK; } @@ -820,10 +820,10 @@ static HRESULT WINAPI KeystrokeMgr_GetForeground(ITfKeystrokeMgr *iface, if (!pclsid) return E_INVALIDARG; - if (IsEqualCLSID(&This->forgroundTextService,&GUID_NULL)) + if (IsEqualCLSID(&This->foregroundTextService,&GUID_NULL)) return S_FALSE; - *pclsid = This->forgroundTextService; + *pclsid = This->foregroundTextService; return S_OK; }

1 0

Francois Gouget : ole32/tests: Fix spelling of a few variable names.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 842bb8cb58a7a3c9353f6744d2fdceb20f08febc URL: http://source.winehq.org/git/wine.git/?a=commit;h=842bb8cb58a7a3c9353f6744d… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Apr 13 11:29:23 2016 +0200 ole32/tests: Fix spelling of a few variable names. Signed-off-by: Francois Gouget <fgouget(a)free.fr> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ole32/tests/moniker.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/ole32/tests/moniker.c b/dlls/ole32/tests/moniker.c index dca85ac..7b67dfd 100644 --- a/dlls/ole32/tests/moniker.c +++ b/dlls/ole32/tests/moniker.c @@ -1580,11 +1580,11 @@ static void test_item_moniker(void) IBindCtx *bindctx; IMoniker *inverse; IUnknown *unknown; - static const WCHAR wszDelimeter[] = {'!',0}; + static const WCHAR wszDelimiter[] = {'!',0}; static const WCHAR wszObjectName[] = {'T','e','s','t',0}; static const WCHAR expected_display_name[] = { '!','T','e','s','t',0 }; - hr = CreateItemMoniker(wszDelimeter, wszObjectName, &moniker); + hr = CreateItemMoniker(wszDelimiter, wszObjectName, &moniker); ok_ole_success(hr, CreateItemMoniker); test_moniker("item moniker", moniker, @@ -1709,15 +1709,15 @@ static void test_generic_composite_moniker(void) FILETIME filetime; IMoniker *inverse; IUnknown *unknown; - static const WCHAR wszDelimeter1[] = {'!',0}; + static const WCHAR wszDelimiter1[] = {'!',0}; static const WCHAR wszObjectName1[] = {'T','e','s','t',0}; - static const WCHAR wszDelimeter2[] = {'#',0}; + static const WCHAR wszDelimiter2[] = {'#',0}; static const WCHAR wszObjectName2[] = {'W','i','n','e',0}; static const WCHAR expected_display_name[] = { '!','T','e','s','t','#','W','i','n','e',0 }; - hr = CreateItemMoniker(wszDelimeter1, wszObjectName1, &moniker1); + hr = CreateItemMoniker(wszDelimiter1, wszObjectName1, &moniker1); ok_ole_success(hr, CreateItemMoniker); - hr = CreateItemMoniker(wszDelimeter2, wszObjectName2, &moniker2); + hr = CreateItemMoniker(wszDelimiter2, wszObjectName2, &moniker2); ok_ole_success(hr, CreateItemMoniker); hr = CreateGenericComposite(moniker1, moniker2, &moniker); ok_ole_success(hr, CreateGenericComposite);

1 0

Daniel Lehman : ucrtbase: Add __std_exception_destroy/copy.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 4f6f0f09fd7a67e20376772faf1e1c02c9112422 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f6f0f09fd7a67e20376772fa… Author: Daniel Lehman <dlehman(a)esri.com> Date: Mon Apr 11 14:19:00 2016 -0700 ucrtbase: Add __std_exception_destroy/copy. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- .../api-ms-win-crt-private-l1-1-0.spec | 4 +- dlls/msvcrt/except.c | 35 +++++++ dlls/ucrtbase/tests/Makefile.in | 1 + dlls/ucrtbase/tests/cpp.c | 103 +++++++++++++++++++++ dlls/ucrtbase/ucrtbase.spec | 4 +- dlls/vcruntime140/vcruntime140.spec | 4 +- 6 files changed, 145 insertions(+), 6 deletions(-) diff --git a/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec b/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec index b7b0eec..c85a998 100644 --- a/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec +++ b/dlls/api-ms-win-crt-private-l1-1-0/api-ms-win-crt-private-l1-1-0.spec @@ -42,8 +42,8 @@ @ stub __intrinsic_setjmpex @ stub __processing_throw @ stub __report_gsfailure -@ stub __std_exception_copy -@ stub __std_exception_destroy +@ cdecl __std_exception_copy(ptr ptr) ucrtbase.__std_exception_copy +@ cdecl __std_exception_destroy(ptr) ucrtbase.__std_exception_destroy @ cdecl __std_type_info_compare(ptr ptr) ucrtbase.__std_type_info_compare @ stub __std_type_info_destroy_list @ stub __std_type_info_hash diff --git a/dlls/msvcrt/except.c b/dlls/msvcrt/except.c index fc0e36e..18c2f15 100644 --- a/dlls/msvcrt/except.c +++ b/dlls/msvcrt/except.c @@ -462,3 +462,38 @@ void CDECL __CxxUnregisterExceptionObject(cxx_frame_info *frame_info, BOOL in_us __DestructExceptionObject(data->exc_record); data->exc_record = frame_info->rec; } + +struct __std_exception_data { + char *what; + MSVCRT_bool dofree; +}; + +/********************************************************************* + * __std_exception_copy (MSVCRT.@) + */ +void CDECL MSVCRT___std_exception_copy(const struct __std_exception_data *src, + struct __std_exception_data *dst) +{ + TRACE("(%p %p)\n", src, dst); + + if(src->dofree && src->what) { + dst->what = MSVCRT__strdup(src->what); + dst->dofree = 1; + } else { + dst->what = src->what; + dst->dofree = 0; + } +} + +/********************************************************************* + * __std_exception_destroy (MSVCRT.@) + */ +void CDECL MSVCRT___std_exception_destroy(struct __std_exception_data *data) +{ + TRACE("(%p)\n", data); + + if(data->dofree) + MSVCRT_free(data->what); + data->what = NULL; + data->dofree = 0; +} diff --git a/dlls/ucrtbase/tests/Makefile.in b/dlls/ucrtbase/tests/Makefile.in index c4fa7c8..10e4f0d 100644 --- a/dlls/ucrtbase/tests/Makefile.in +++ b/dlls/ucrtbase/tests/Makefile.in @@ -2,5 +2,6 @@ TESTDLL = ucrtbase.dll APPMODE = -mno-cygwin C_SRCS = \ + cpp.c \ printf.c \ string.c diff --git a/dlls/ucrtbase/tests/cpp.c b/dlls/ucrtbase/tests/cpp.c new file mode 100644 index 0000000..12b0422 --- /dev/null +++ b/dlls/ucrtbase/tests/cpp.c @@ -0,0 +1,103 @@ +/* + * Copyright 2016 Daniel Lehman (Esri) + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#include <errno.h> +#include <stdarg.h> +#include <stdlib.h> +#include <wchar.h> +#include <stdio.h> + +#include <windef.h> +#include <winbase.h> +#include "wine/test.h" + +typedef unsigned char MSVCRT_bool; + +typedef struct { + const char *what; + MSVCRT_bool dofree; +} __std_exception_data; + +static void (CDECL *p___std_exception_copy)(const __std_exception_data*, __std_exception_data*); +static void (CDECL *p___std_exception_destroy)(__std_exception_data*); + +static BOOL init(void) +{ + HMODULE module; + + module = LoadLibraryA("ucrtbase.dll"); + if (!module) + { + win_skip("ucrtbase.dll not installed\n"); + return FALSE; + } + + p___std_exception_copy = (void*)GetProcAddress(module, "__std_exception_copy"); + p___std_exception_destroy = (void*)GetProcAddress(module, "__std_exception_destroy"); + return TRUE; +} + +static void test___std_exception(void) +{ + __std_exception_data src; + __std_exception_data dst; + + if (0) /* crash on Windows */ + { + p___std_exception_copy(NULL, &src); + p___std_exception_copy(&dst, NULL); + + src.what = "invalid free"; + src.dofree = 1; + p___std_exception_destroy(&src); + p___std_exception_destroy(NULL); + } + + src.what = "what"; + src.dofree = 0; + p___std_exception_copy(&src, &dst); + ok(dst.what == src.what, "expected what to be same, got src %p dst %p\n", src.what, dst.what); + ok(!dst.dofree, "expected 0, got %d\n", dst.dofree); + + src.dofree = 0x42; + p___std_exception_copy(&src, &dst); + ok(dst.what != src.what, "expected what to be different, got src %p dst %p\n", src.what, dst.what); + ok(dst.dofree == 1, "expected 1, got %d\n", dst.dofree); + + p___std_exception_destroy(&dst); + ok(!dst.what, "expected NULL, got %p\n", dst.what); + ok(!dst.dofree, "expected 0, got %d\n", dst.dofree); + + src.what = NULL; + src.dofree = 0; + p___std_exception_copy(&src, &dst); + ok(!dst.what, "dst.what != NULL\n"); + ok(!dst.dofree, "dst.dofree != FALSE\n"); + + src.what = NULL; + src.dofree = 1; + p___std_exception_copy(&src, &dst); + ok(!dst.what, "dst.what != NULL\n"); + ok(!dst.dofree, "dst.dofree != FALSE\n"); +} + +START_TEST(cpp) +{ + if (!init()) return; + test___std_exception(); +} diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec index 20e8de1..a54a71a 100644 --- a/dlls/ucrtbase/ucrtbase.spec +++ b/dlls/ucrtbase/ucrtbase.spec @@ -140,8 +140,8 @@ @ cdecl __pxcptinfoptrs() MSVCRT___pxcptinfoptrs @ stub __report_gsfailure @ cdecl __setusermatherr(ptr) MSVCRT___setusermatherr -@ stub __std_exception_copy -@ stub __std_exception_destroy +@ cdecl __std_exception_copy(ptr ptr) MSVCRT___std_exception_copy +@ cdecl __std_exception_destroy(ptr) MSVCRT___std_exception_destroy @ cdecl __std_type_info_compare(ptr ptr) MSVCRT_type_info_compare @ stub __std_type_info_destroy_list @ stub __std_type_info_hash diff --git a/dlls/vcruntime140/vcruntime140.spec b/dlls/vcruntime140/vcruntime140.spec index d8c33c4..ea8c93b 100644 --- a/dlls/vcruntime140/vcruntime140.spec +++ b/dlls/vcruntime140/vcruntime140.spec @@ -36,8 +36,8 @@ @ stub __intrinsic_setjmpex @ stub __processing_throw @ stub __report_gsfailure -@ stub __std_exception_copy -@ stub __std_exception_destroy +@ cdecl __std_exception_copy(ptr ptr) ucrtbase.__std_exception_copy +@ cdecl __std_exception_destroy(ptr) ucrtbase.__std_exception_destroy @ stub __std_terminate @ cdecl __std_type_info_compare(ptr ptr) ucrtbase.__std_type_info_compare @ stub __std_type_info_destroy_list

1 0

Piotr Caban : ieframe: Improve setting different client site in OleObject_SetClientSite.
by Alexandre Julliard 13 Apr '16

13 Apr '16

Module: wine Branch: master Commit: 3fbd56b08ec1812f87a194670d5428ff4e566291 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3fbd56b08ec1812f87a194670… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 13 17:11:53 2016 +0200 ieframe: Improve setting different client site in OleObject_SetClientSite. Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ieframe/oleobject.c | 69 ++++++++++++++++++++++++++++++++---------------- 1 file changed, 46 insertions(+), 23 deletions(-) diff --git a/dlls/ieframe/oleobject.c b/dlls/ieframe/oleobject.c index 4dcc536..1ff9a92 100644 --- a/dlls/ieframe/oleobject.c +++ b/dlls/ieframe/oleobject.c @@ -283,7 +283,7 @@ static HRESULT on_silent_change(WebBrowser *This) return S_OK; } -static void release_client_site(WebBrowser *This) +static void release_client_site(WebBrowser *This, BOOL destroy_win) { release_dochost_client(&This->doc_host); @@ -297,7 +297,7 @@ static void release_client_site(WebBrowser *This) This->client_closed = NULL; } - if(This->shell_embedding_hwnd) { + if(destroy_win && This->shell_embedding_hwnd) { DestroyWindow(This->shell_embedding_hwnd); This->shell_embedding_hwnd = NULL; } @@ -459,6 +459,7 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, LPOLECLIENTSITE WebBrowser *This = impl_from_IOleObject(iface); IDocHostUIHandler *hostui; IOleCommandTarget *olecmd; + BOOL get_olecmd = TRUE; IOleContainer *container; IDispatch *disp; HRESULT hres; @@ -473,7 +474,14 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, LPOLECLIENTSITE if(This->client == pClientSite) return S_OK; - release_client_site(This); + if(This->client && pClientSite) { + get_olecmd = FALSE; + olecmd = This->doc_host.olecmd; + if(olecmd) + IOleCommandTarget_AddRef(olecmd); + } + + release_client_site(This, !pClientSite); if(!pClientSite) { on_commandstate_change(&This->doc_host, CSC_NAVIGATEBACK, FALSE); @@ -497,31 +505,46 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, LPOLECLIENTSITE if(SUCCEEDED(hres)) This->doc_host.hostui = hostui; - hres = IOleClientSite_GetContainer(This->client, &container); - if(SUCCEEDED(hres)) { - ITargetContainer *target_container; - - hres = IOleContainer_QueryInterface(container, &IID_ITargetContainer, - (void**)&target_container); + if(get_olecmd) { + hres = IOleClientSite_GetContainer(This->client, &container); if(SUCCEEDED(hres)) { - FIXME("Unsupported ITargetContainer\n"); - ITargetContainer_Release(target_container); + ITargetContainer *target_container; + + hres = IOleContainer_QueryInterface(container, &IID_ITargetContainer, + (void**)&target_container); + if(SUCCEEDED(hres)) { + FIXME("Unsupported ITargetContainer\n"); + ITargetContainer_Release(target_container); + } + + hres = IOleContainer_QueryInterface(container, &IID_IOleCommandTarget, (void**)&olecmd); + if(FAILED(hres)) + olecmd = NULL; + + IOleContainer_Release(container); + }else { + hres = IOleClientSite_QueryInterface(This->client, &IID_IOleCommandTarget, (void**)&olecmd); + if(FAILED(hres)) + olecmd = NULL; } - - hres = IOleContainer_QueryInterface(container, &IID_IOleCommandTarget, (void**)&olecmd); - if(FAILED(hres)) - olecmd = NULL; - - IOleContainer_Release(container); - }else { - hres = IOleClientSite_QueryInterface(This->client, &IID_IOleCommandTarget, (void**)&olecmd); - if(FAILED(hres)) - olecmd = NULL; } This->doc_host.olecmd = olecmd; - create_shell_embedding_hwnd(This); + if(This->shell_embedding_hwnd) { + IOleInPlaceSite *inplace; + HWND parent; + + hres = IOleClientSite_QueryInterface(This->client, &IID_IOleInPlaceSite, (void**)&inplace); + if(SUCCEEDED(hres)) { + hres = IOleInPlaceSite_GetWindow(inplace, &parent); + IOleInPlaceSite_Release(inplace); + if(SUCCEEDED(hres)) + SHSetParentHwnd(This->shell_embedding_hwnd, parent); + } + }else { + create_shell_embedding_hwnd(This); + } on_offlineconnected_change(This); on_silent_change(This); @@ -1198,5 +1221,5 @@ void WebBrowser_OleObject_Init(WebBrowser *This) void WebBrowser_OleObject_Destroy(WebBrowser *This) { - release_client_site(This); + release_client_site(This, TRUE); }

1 0